- 18 Apr, 2023 26 commits
-
-
Samuel Abada authored
Remove double.fromEnvironment from dart-define doc. Fixes #124665 The current dart-define docs reads: ``` Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and double.fromEnvironment constructors. ``` while dart-define-from-file reads: ``` The path of a json format file where flutter define a global constant pool. Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and double.fromEnvironment constructors; the key and field are json values ``` <img width="1440" alt="Screenshot 2023-04-03 at 19 31 34" src="https://user-images.githubusercontent.com/31275429/229720102-2020e1a9-c1fb-470b-89e6-ffb84096a51b.png"> However, there is no fromEnvironment constructor for double. The aim of this PR is to address this by removing double.fromEnvironment from help docs as stated in
-
Kim Jiun authored
Adding my name (Kim Jiun) to Authors. REF : https://github.com/flutter/flutter/pull/91496 Thanks!
-
Greg Spencer authored
## Description This adds an optional argument to the `SubmenuButton` that allows the creator to supply a `MenuController` for controlling the menu. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/124988 ## Tests - Added tests for new argument.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/879308a52228...6d263ea56a62 2023-04-18 gspencergoog@users.noreply.github.com Some minor doc typo and diagnostic fixes. (flutter/engine#40982) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Justin McCandless authored
Fixes a bug where the spell check menu could overflow.
-
Jenn Magder authored
Remove TESTOWNERS matching the removed impeller tests in https://github.com/flutter/flutter/pull/125044. Filed https://github.com/flutter/flutter/issues/125055 since I believe the mismatch should have been caught in that PR.
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/72b68622fffa...879308a52228 2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (flutter/engine#39801) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
These are currently unused and will not work in a multi-view environment where we will have multiple render trees. Work towards https://github.com/flutter/flutter/issues/121573.
-
Tae Hyung Kim authored
Currently, nullable-getter defaults to false when l10n.yaml is not present, which is not the same behavior as when an l10n.yaml file is present and nullable-getter is not set. Fixes #120457.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/55bb065c607b...72b68622fffa 2023-04-18 skia-flutter-autoroll@skia.org Manual roll Skia from d9e216e62223 to 5bd4bdc0d8e2 (12 revisions) (flutter/engine#41286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/125049 This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.
-
Greg Spencer authored
## Description This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`. Before: <img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png"> After: <img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png"> ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122246 ## Tests - No tests needed.
-
Justin McCandless authored
Tidying up the spell check API.
-
Justin McCandless authored
Fixes the cursor location after selecting a spell check result on iOS.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d2973619074e...55bb065c607b 2023-04-18 10456171+caroqliu@users.noreply.github.com [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Zachary Anderson authored
Impeller is now the default on iOS, so these are redundant. In a subsequent change, I'll clean up the source files for these.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/0277f2ad9d92...faf53fb3998c 2023-04-18 engine-flutter-autoroll@skia.org Manual roll Flutter from 50171bba to 15cb1f84 (9 revisions) (flutter/packages#3749) 2023-04-17 reidbaker@google.com [palette_generator] run agp update for example (flutter/packages#3747) 2023-04-17 47866232+chunhtai@users.noreply.github.com [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725) 2023-04-17 stuartmorgan@google.com [tool] Add initial gradle validation command (flutter/packages#3715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c4396f9f602f...d2973619074e 2023-04-18 leroux_bruno@yahoo.fr [macOS] Fix Ctrl+Tab is broken (flutter/engine#40706) 2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293) 2023-04-18 aam@google.com Roll buildroot to 059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288) 2023-04-18 bdero@google.com [Impeller] Remove glyph pixel rounding during text frame conversion (flutter/engine#41285) 2023-04-18 godofredoc@google.com Revert "Reland "Migrate mac_host_engine to engine v2 builds."" (flutter/engine#41284) 2023-04-17 flar@google.com focus SkiaGPUObject wrappers on only those objects that need the protection (flutter/engine#41237) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Tirth authored
Adds `acceptEmptyDate` property to `InputDatePickerFormField`. Fixes: #117511 | `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** | | --- | ---| |  |  |
-
Viren Khatri authored
during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView). Fixes #123497
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4a603aaff32e...c4396f9f602f 2023-04-17 zanderso@users.noreply.github.com Roll impeller-cmake-example to 58042bb24833a3cbd615ad082b1d17daef42d097 (flutter/engine#41280) 2023-04-17 jacksongardner@google.com Reland ui_web files in sky_engine (flutter/engine#41169) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/20034a8d62c4...4a603aaff32e 2023-04-17 magder@google.com Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226) 2023-04-17 chinmaygarde@google.com [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kate Lovett authored
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation) This is one of the last little PRs to prep for the 2D scrolling foundation. This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis. In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done. There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
-
- 17 Apr, 2023 14 commits
-
-
Bartek Pacia authored
Just found this while trying to run the integration test shard of `flutter_tools` locally :)
-
Harish Anbalagan authored
Adding my name (Harish Anbalagan) to Authors.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b2d07388ceb6...20034a8d62c4 2023-04-17 godofredoc@google.com Reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279) 2023-04-17 41930132+hellohuanlin@users.noreply.github.com [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730) 2023-04-17 akash.mercer@gmail.com null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082) 2023-04-17 5236035+fzyzcjy@users.noreply.github.com [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197) 2023-04-17 bdero@google.com [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256) 2023-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278) 2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
This PR is to: * Update API doc for `SearchBar`. * Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
-
chunhtai authored
When swapping out delegate of selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
-
Taha Tesser authored
-
chunhtai authored
deprecates the these strings since they are now moved into widgetslocalizations migration guide https://github.com/flutter/website/pull/8543/files
-
hangyu authored
issue #123378
-
Mubarak Bakarman authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/30e1c4308213...b2d07388ceb6 2023-04-17 30870216+gaaclarke@users.noreply.github.com Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979) 2023-04-17 yjbanov@google.com [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230) 2023-04-17 kjlubick@users.noreply.github.com Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270) 2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
godofredoc authored
The coverage build does not require write access to checks.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/e4ec15590935...0277f2ad9d92 2023-04-16 engine-flutter-autoroll@skia.org Roll Flutter from 00171b07 to 50171bba (7 revisions) (flutter/packages#3723) 2023-04-15 engine-flutter-autoroll@skia.org Roll Flutter from f7405446 to 00171b07 (17 revisions) (flutter/packages#3717) 2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.9 to 2.2.12 (flutter/packages#3711) 2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/packages#3710) 2023-04-14 stuartmorgan@google.com [path_provider] Fix Android lint warnings (flutter/packages#3706) 2023-04-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [camera_android_camerax] Updates internal Java InstanceManager to only stop finalization callbacks when stopped (flutter/packages#3571) 2023-04-14 stuartmorgan@google.com [shared_preferences] Fix Android Java version issue (flutter/packages#3712) 2023-04-14 48185017+andreisas06@users.noreply.github.com [image_picker][android] Non-bitmap images now return path instead of null (flutter/packages#3590) 2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter from be45eb24 to f7405446 (24 revisions) (flutter/packages#3713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/360ca05311c8...30e1c4308213 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/engine#41264) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from a64c248e62e0 to 5c4d2a518736 (1 revision) (flutter/engine#41262) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 03c8e529196d to a64c248e62e0 (1 revision) (flutter/engine#41261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4a998b73a2df...360ca05311c8 2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AAx6fLy6ykWVhXvNh... to xPacy_rLieLS05d_g... (flutter/engine#41260) 2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 46T4ZTAt48yPRDEn5... to atix5Ek_OOxH-uoPA... (flutter/engine#41258) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 46T4ZTAt48yP to atix5Ek_OOxH fuchsia/sdk/core/mac-amd64 from AAx6fLy6ykWV to xPacy_rLieLS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
