Commits · 807c55c6b322504fad16f34df050a8a085e698fa · abdullh.alsoleman / Front-End

29 Apr, 2023 10 commits

Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) (#125746) · 807c55c6

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0834c886f06a...c56ea398b0dc

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XeUTCh70VOPbIFXdz... to tz8A3SWVI56hqwnzp... (flutter/engine#41615)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XeUTCh70VOPb to tz8A3SWVI56h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

807c55c6

Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) (#125736) · 14981ffc

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/68f2ed0a1db5...0834c886f06a

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xfKYQ2vkoLvxhBHIf... to FUOS_QWwsi0RMumuZ... (flutter/engine#41611)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xfKYQ2vkoLvx to FUOS_QWwsi0R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14981ffc

Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (#125735) · b5a1d9c5

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0079bb4a20d0...68f2ed0a1db5

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from c7b3371bcd48 to 3a037528ab83 (2 revisions) (flutter/engine#41609)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5a1d9c5

Fix crasher in DragableScrollableSheet when controller is animating and switching widgets (#125721) · e1e8ad80

Dan Field authored Apr 29, 2023

We were failing to dispose of animation controllers created by `animateTo` when `didUpdateWidget` happens and we null out the `_attachedController`. This would cause the listener added here to fail on a null assertion:

https://github.com/flutter/flutter/blob/fef41cfce0e3582907f6846cf2385470bb17ecd1/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart#L135

Without the code change, the test ends up throwing exceptions related to that line. I don't have a great way to verify what this does visually though, hoping for help on that from internal customer.

b/279930163

See cl/527868355 as well.

Fixes https://github.com/flutter/flutter/issues/125709

e1e8ad80

Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (#125734) · 9417b2a4

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/8f04b29c1b98...0079bb4a20d0

2023-04-29 737941+loic-sharma@users.noreply.github.com Remove single view assumption from pointer events (flutter/engine#41602)
2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kNDuhglIFq_xEt5n3... to XeUTCh70VOPbIFXdz... (flutter/engine#41608)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kNDuhglIFq_x to XeUTCh70VOPb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9417b2a4

Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) (#125731) · bd85177d

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/788d0ed5ed06...8f04b29c1b98

2023-04-29 bdero@google.com [Impeller] Remove destructive blend mode check from Contents::ShouldRender (flutter/engine#41600)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd85177d

Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) (#125729) · 0ff36a1e

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/89a8affdced0...788d0ed5ed06

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 49412cbee072 to c7b3371bcd48 (7 revisions) (flutter/engine#41603)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ff36a1e

Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) (#125725) · 47f4d1a9

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/3835d975c8b0...89a8affdced0

2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (flutter/engine#41597)
2023-04-28 godofredoc@google.com Migrate desktop artifacts to engine v2. (flutter/engine#41599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47f4d1a9

Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) (#125722) · 6f85ff6b

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/1ae848ce6b55...3835d975c8b0

2023-04-28 jason-simmons@users.noreply.github.com [Impeller] Ensure that embedded blobs are placed at aligned addresses. (flutter/engine#41526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f85ff6b

fix package template create platform folders (#125292) · 512e2c3f

Anas authored Apr 29, 2023

`package` template should not create platform folders. This happen cause by default all platforms are supported and tools didn't distinguish between package and other template, which makes all platforms are true for below code,
https://github.com/flutter/flutter/blob/d186792c00f61149916f685e2975300342f64749/packages/flutter_tools/lib/src/project.dart#L374-L380

fixes: #119844 which make #116320 makes invalid. As for why tools created deprecated `Android Embedding`, `appManifestFile` does not exist for `package` template, which make below code to trigger,
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/project.dart#L768-L770

This does not happen with `module` and `plugin` as it have specific condition check for them. I try to reproduce it with `app` template but didn't succeed

512e2c3f

28 Apr, 2023 17 commits

Sliver Cross Axis Group (#123862) · 1a0b03cb

Tae Hyung Kim authored Apr 28, 2023

This widget implements the ability to place slivers side by side in a single ScrollView so that they scroll together. The design document for `SliverCrossAxisGroup` can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA).

Fixes #56756.

1a0b03cb

Roll Flutter Engine from 2a84ea55e4ef to 1ae848ce6b55 (1 revision) (#125718) · 2282eb36

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/2a84ea55e4ef...1ae848ce6b55

2023-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 8e9bf2bb9878 to e8b86b073413 (1 revision) (flutter/engine#41594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2282eb36

Remove bringup from new_gallery_skia_ios__transition_perf (#125715) · fef41cfc
Zachary Anderson authored Apr 28, 2023
```
Final step of https://github.com/flutter/flutter/pull/125663
```
fef41cfc

Roll Flutter Engine from 98b6fabc66bb to 2a84ea55e4ef (10 revisions) (#125714) · 63b7fa5d

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/98b6fabc66bb...2a84ea55e4ef

2023-04-28 zanderso@users.noreply.github.com Revert "Replace deprecated and internal Skia EncodedImage calls with public versions" (flutter/engine#41595)
2023-04-28 maruel@gmail.com Roll buildroot to c96c9d4641714301fab450a5f3b0f3c42712e1e3 (flutter/engine#41589)
2023-04-28 ychris@google.com [platform_view] Only dispose view when it is removed from the composition order (flutter/engine#41521)
2023-04-28 gspencergoog@users.noreply.github.com Determine lifecycle by looking at window focus also (flutter/engine#41094)
2023-04-28 zanderso@users.noreply.github.com Increase timeout for clang-tidy on mac (flutter/engine#41588)
2023-04-28 bdero@google.com [Impeller] Always enable validation for goldens (flutter/engine#41574)
2023-04-28 maruel@gmail.com fuchsia: do not read version_history.json (flutter/engine#41585)
2023-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from c7160d4ea0b7 to 8e9bf2bb9878 (5 revisions) (flutter/engine#41586)
2023-04-28 kjlubick@users.noreply.github.com Replace deprecated and internal Skia EncodedImage calls with public versions (flutter/engine#41368)
2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 05d09f28250a to 9867fa253064 (18 revisions) (flutter/engine#41584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

63b7fa5d

Opt into CMake policy CMP0135 (#125502) · 7d37f2a6

yaakovschectman authored Apr 28, 2023

~Update the windows app template and migration to use `CMP0135` when
cmake version is >= 3.24.~

Update app templates' and examples' CMakeLists.txt to use
`cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828
should obviate the need for a migration.

Addresses https://github.com/flutter/flutter/issues/116866

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7d37f2a6

Add a channel to query the engine keyboard state (#122885) · af050d95

Bruno Leroux authored Apr 28, 2023

## Description

This PR adds a new channel to query the engine keyboard state.
See https://github.com/flutter/flutter/issues/87391#issuecomment-1228975571 for motivation. 

## Related Issue

Framework side implementation for https://github.com/flutter/flutter/issues/87391.

Once approved the framework will try to query the initial keyboard state from the engine. PRs will be needed on the engine side to answer the framework query.

## Tests

Adds 1 test.

af050d95

Roll pub packages (#125698) · 73a343f1
Flutter GitHub Bot authored Apr 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
73a343f1
`Checkbox.fillColor` should be applied to checkbox's background color when it... · a433f88d
Qun Cheng authored Apr 28, 2023
```
`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. (#125643)
```
a433f88d
Add back one Skia test on iOS (#125663) · 50f83fc2
Zachary Anderson authored Apr 28, 2023
```
Fixes https://github.com/flutter/flutter/issues/125648
```
50f83fc2
Roll pub packages (#125447) · 888b208d
Flutter GitHub Bot authored Apr 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
888b208d

Nit: grammar in documentation (#125462) · 69af9343

Phlippie Bosman authored Apr 28, 2023

Fixes a [grocer's apostrophe](https://www.grammar-monster.com/lessons/apostrophe_error_with_plurals.htm). 

Apostrophes are not used to indicate plurals, and this incorrect usage in the documentation tripped me up, so I figured I could submit a quick correction :)

69af9343

Roll Flutter Engine from 1d25906b4cf0 to 98b6fabc66bb (4 revisions) (#125690) · a698da60

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/1d25906b4cf0...98b6fabc66bb

2023-04-28 godofredoc@google.com Migrate Linux Arm Host Engine to engine v2. (flutter/engine#41555)
2023-04-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Rk2iPE0_H1vjuGV4e... to kNDuhglIFq_xEt5n3... (flutter/engine#41582)
2023-04-28 bdero@google.com [Impeller] Manage the onscreen stencil in EntityPass (flutter/engine#41563)
2023-04-28 bdero@google.com Revert "Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. " (flutter/engine#41567)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Rk2iPE0_H1vj to kNDuhglIFq_x

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a698da60

Allow users to provide route settings to `showMenu` (#124935) · 00bbf543

fzyzcjy authored Apr 28, 2023

Background: I am adding logging to things like dialogs, bottom sheets and menus. Then I realized that, showMenu does not allow users to provide RouteSettings, while showDialog and showModalBottomSheet both allow. Therefore, IMHO a consistent API design may need to add this to showMenu.

I will add tests if this proposal looks OK :)

00bbf543

enhances OverlayEntry docs (#124478) · 5a1ef73d
Viren Khatri authored Apr 28, 2023
```
Fixes https://github.com/flutter/flutter/issues/123218
```
5a1ef73d

Smallest change required to support host apps using agp 8.0 (#125657) · 3a6c4eb1

Reid Baker authored Apr 28, 2023

Testing AGP 8.0 is not possible with the existing infra because of the java version on CI machines. See https://github.com/flutter/flutter/issues/125325 for more details.

https://github.com/flutter/flutter/issues/125181

3a6c4eb1

fix RangeSlider, with no overlayShape shifts to the left (#125483) · f87d2087
arvin authored Apr 28, 2023

f87d2087

Roll Flutter Engine from 3d61e293cb96 to 1d25906b4cf0 (1 revision) (#125658) · 55c988fb

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/3d61e293cb96...1d25906b4cf0

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from f7c8a58c2127 to 05d09f28250a (4 revisions) (flutter/engine#41557)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55c988fb

27 Apr, 2023 13 commits

Increase Xcode minimum version to 14 (#125639) · 6b73885e

Jenn Magder authored Apr 27, 2023

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to https://github.com/CocoaPods/CocoaPods/pull/11828 (see https://github.com/flutter/flutter/issues/123890 for context).

Bump the minimum Xcode version allowed by tooling to 14, released September 2022.

```
[!] Xcode - develop for iOS and macOS (Xcode 13.4)
    â Flutter requires Xcode 14 or higher.
      Download the latest version or update via the Mac App Store.
```

Fixes https://github.com/flutter/flutter/issues/125286.
Previous bump at #97746.

6b73885e

Add migrator to upgrade gradle version when conflict with Android Studio... · eba2a520

gmackall authored Apr 27, 2023

Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#124085)

This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376.

The PR also upgrades older gradle versions being used in integration testing to 7.4.

Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636

eba2a520

Update dartdoc to v6.2.2. (#125650) · fb36bba3

Janice Collins authored Apr 27, 2023

This PR updates the dartdoc version to v6.2.2.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2

The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers.  See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402.   This will also be a cherry-pick candidate for 3.1 if it can land in time.

- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].

fb36bba3

Add `slider_perf_android` task to `ci.yaml` (#125540) · 746cacc5

Taha Tesser authored Apr 27, 2023

This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296

746cacc5

Roll Flutter Engine from 883bb7d5cb28 to 3d61e293cb96 (1 revision) (#125645) · 215fa355

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/883bb7d5cb28...3d61e293cb96

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

215fa355

[flutter_tools] more debugging for timeouts in break_on_framework_exceptions test (#125584) · 4ff505c8

Christopher Fujino authored Apr 27, 2023

Better debugging to investigate: https://github.com/flutter/flutter/issues/125241

When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete.

From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception):

```
14:12 +26 -1: breaks when StatefulWidget.build throws [E]
  Timed out launching `flutter test`
  package:matcher                                                        fail
  test/integration.shard/break_on_framework_exceptions_test.dart 623:11  _timeoutAfter.<fn>

250s            Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ

251s <=stdout=  {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0}

<=stdout=  {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}

<=stdout=  {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}

258s <=stdout=  {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3  throwToolExit\npackage:flutter_tools/src/compile.dart 813:13    DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11           _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20       _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18       _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart...

<=stdout=  {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518}

<=stdout=  {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521}

<=stdout=  {"count":1,"time":7526,"type":"allSuites"}

<=stdout=  {"success":false,"type":"done","time":7529}

259s            Process exited (1)

371s            Expecting test.startedProcess event
[+    95] <=stdout=  {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
[+    95] <=stdout=  {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
[+  7600] <=stdout=  {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3  throwToolExit\npackage:flutter_tools/src/compile.dart 813:13    DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11           _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20       _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18       _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24...

Expecting test.startedProcess event is taking longer than usual...
```

4ff505c8

Roll Flutter Engine from 3d6d915cb74a to 883bb7d5cb28 (1 revision) (#125641) · 84e8d498

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/3d6d915cb74a...883bb7d5cb28

2023-04-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.11 to 2.3.1 (flutter/engine#41553)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84e8d498

Mark module_test_ios tests unflaky (#125498) · 28e17177

Jenn Magder authored Apr 27, 2023

[Dart workaround](https://dart-review.googlesource.com/c/sdk/+/297821 ) to prevent the flake has rolled into the framework.  Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands.

https://github.com/flutter/flutter/issues/125425#issuecomment-1522142360

Reverts https://github.com/flutter/flutter/pull/125426

28e17177

Roll Flutter Engine from 381f714972d8 to 3d6d915cb74a (1 revision) (#125637) · ea179fe0

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/381f714972d8...3d6d915cb74a

2023-04-27 103135467+sealesj@users.noreply.github.com Refactor vuln scan into separate yaml (flutter/engine#41528)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea179fe0

Bump the default minSdkVersion to 19 (#125515) · fc209836

Dan Field authored Apr 27, 2023

See https://docs.flutter.dev/reference/supported-platforms

I don't expect this to break anything, but if it does we can revert and figure out what else needs to happen first.

Without this change, engine changes upstream will get flagged in default flutter created apps.

fc209836

Fix `SnackBar` material clip (#125622) · 18e36dcb

Taha Tesser authored Apr 27, 2023

fixes https://github.com/flutter/flutter/issues/125619

### Before

![Screenshot 2023-04-27 at 14 08 05](https://user-images.githubusercontent.com/48603081/234853490-0a9c4e18-20aa-40f7-a6b0-efb278f515eb.png)

### After

![Screenshot 2023-04-27 at 14 00 44](https://user-images.githubusercontent.com/48603081/234853470-c69c20d3-124d-438a-9312-2d17492c5606.png)

18e36dcb

Roll Flutter Engine from 968413585768 to 381f714972d8 (1 revision) (#125634) · 4dbeb3fb

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/968413585768...381f714972d8

2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 497a81b1af4f to c7160d4ea0b7 (1 revision) (flutter/engine#41550)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dbeb3fb

fix: `moreOrLessEquals` does not allow `actual` to be integers (#125599) · 37c95a28
fzyzcjy authored Apr 27, 2023
```
Close https://github.com/flutter/flutter/issues/125600
```
37c95a28