Commits · 7ff5f81a2ea7190a48131c52e8a14dc65cf9f500 · abdullh.alsoleman / Front-End

26 Jan, 2024 3 commits

Fix `SegmentedButton` default size and default tappable size (#142243) · 7ff5f81a

Qun Cheng authored Jan 26, 2024

fix https://github.com/flutter/flutter/issues/121493

`SegmentedButton` uses `TextButton` for each segments. When we have `MaterialTapTargetSize.padded` for `TextButton`, we make sure the minimum tap target size is 48.0( this value can be adjusted by visual density), even tough the actual button size is smaller. When `SegmentedButton` paints segments by using `MultiChildRenderObjectWidget`, it also includes the tap target size so the button that it actually draws always has the same height as the height of the tap target size.

To fix it, this PR firstly calculate the actual height of a text button in `SegmentedButton` class, then we can get the height delta if there is. Then the the value of (Segmented button render box height - the delta) would be the actual button size that we should see.

For now, we are not able to customize the min, max, fixed size in [`SegmentedButton` style](https://api.flutter.dev/flutter/material/SegmentedButton/style.html). So the standard button height is always 40 and can only be customized by `style.visualDensity` and `style.tapTargetSize`; `SegmentedButton` only simulates the `TextButton` behavior when `TextButton`'s height is its default value.

![Screenshot 2024-01-25 at 11 45 42â¯AM](https://github.com/flutter/flutter/assets/36861262/7451fa96-6d45-4cd3-a894-ca71e776c8ef)

https://github.com/flutter/flutter/assets/36861262/15ca6034-e6e0-4cc6-8fe3-808b4bd6a920

7ff5f81a

Update name for android_defines_test. (#142273) · a6c3ad23

godofredoc authored Jan 26, 2024

This is to reuse the global emulator configurations and make it easier to identify this test is running on an emulator.

a6c3ad23

Enable native compilation for windows-arm64 (#141930) · 37c3978b

Pierrick Bouvier authored Jan 26, 2024

It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented.

Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows.

This is available only for master channel (on other channels, it fallbacks to windows-x64).

On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.

37c3978b

25 Jan, 2024 30 commits

Reverts "Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions)" (#142274) · d5bd2fe5

auto-submit[bot] authored Jan 25, 2024

Reverts flutter/flutter#142264
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/4b145d041560...44f26274bfbe

2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898)
2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424)
2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865)
2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883)
2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033)
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d5bd2fe5

Run a few mac tests only on arm. (#142188) · 8cc944d7
godofredoc authored Jan 25, 2024
```
Note: some benchmarks will require to be rebaselined.
```
8cc944d7
fix Ink not updating on TextField newline (#140700) · e3426679
derdilla authored Jan 25, 2024
```
Fixes a layout bug when using an EditableText and something containing an Ink widget.
```
e3426679

Bump codecov/codecov-action from 3.1.4 to 3.1.5 (#142259) · ab30122f

dependabot[bot] authored Jan 25, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.4 to 3.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>action.yml: Update to Node.js 20 by <a href="https://github.com/hallabro"><code>@âhallabro</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228">codecov/codecov-action#1228</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/hallabro"><code>@âhallabro</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228">codecov/codecov-action#1228</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5">https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0"><code>4fe8c5f</code></a> chore(release): bump to 3.1.5</li>
<li><a href="https://github.com/codecov/codecov-action/commit/9140fdcf549f069e1ad6cc2bf17ee0251b024bfb"><code>9140fdc</code></a> action.yml: Update to Node.js 20 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1228">#1228</a>)</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/eaaf4bedf32dbdc6b720b63067d99c4d77d6047d...4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.4&new-version=3.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

ab30122f

Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions) (#142264) · 56c499cc

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/4b145d041560...44f26274bfbe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

56c499cc

Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch... · db255409

auto-submit[bot] authored Jan 25, 2024

Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch anything else..."" (#142268)

Reverts flutter/flutter#142265
Initiated by: matanlurey
This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#142238
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/142178.

db255409

Reverts "Rename `integration_tests/external_ui` but do not touch anything else..." (#142265) · f8544df0

auto-submit[bot] authored Jan 25, 2024

Reverts flutter/flutter#142238
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/142178.

f8544df0

Roll Flutter Engine from b2167a93c1a0 to 4b145d041560 (3 revisions) (#142256) · 4589f4c4

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/b2167a93c1a0...4b145d041560

2024-01-25 jonahwilliams@google.com [Impeller] Fix mipmap generation for Vulkan render target textures. (flutter/engine#49848)
2024-01-25 jason-simmons@users.noreply.github.com [Impeller] Do not emit metadata for structs that are not part of the shader's interface (flutter/engine#50029)
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from de46a989e0ca to 29b545e4356b (1 revision) (flutter/engine#50047)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4589f4c4

Implementing `switch` expressions in the `cupertino/` directory (#141591) · 497f912d
Nate authored Jan 25, 2024
```
Refactors code to use the new `switch` expressions.
```
497f912d
Rename `integration_tests/external_ui` but do not touch anything else... (#142238) · f61d2f53
Matan Lurey authored Jan 25, 2024
```
Part of https://github.com/flutter/flutter/issues/142178.
```
f61d2f53

Roll Flutter Engine from 55eefd5bd255 to b2167a93c1a0 (2 revisions) (#142252) · f037b7ae

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/55eefd5bd255...b2167a93c1a0

2024-01-25 jonahwilliams@google.com [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741)
2024-01-25 jonahwilliams@google.com Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f037b7ae

Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) (#142245) · 2be86dbe

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/3b4779324b44...55eefd5bd255

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from bcc2e8b6105a to de46a989e0ca (1 revision) (flutter/engine#50046)
2024-01-25 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045)
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042)
2024-01-25 jonahwilliams@google.com [Impeller] call shutdown method in Android context. (flutter/engine#49992)
2024-01-25 maRci002@users.noreply.github.com [web] add support for AppLifecycleState changes (flutter/engine#44720)
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2be86dbe

Fix incorrect zh-cn translation for Look Up Label in selection controls (#142158) · caba667e

LouiseHsu authored Jan 25, 2024

Fixes https://github.com/flutter/flutter/issues/141764

Translation suggestion here:

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

caba667e

PopScope example improvements (#142163) · 204a8848
Justin McCandless authored Jan 25, 2024
```
Attempting to help users understand how to build a confirmation dialog when exiting a route.
```
204a8848

Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) (#142225) · e985c29f

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/1d3f16b0d62e...3b4779324b44

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 699ee2b7cf34 to 416d7b0e5ba1 (2 revisions) (flutter/engine#50039)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e985c29f

Roll Packages from 8fbdf65d0235 to 21b5abba7958 (6 revisions) (#142224) · ff010220

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/packages/compare/8fbdf65d0235...21b5abba7958

2024-01-24 pageli328@gmail.com Add rfw widgets (flutter/packages#5661)
2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586)
2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796)
2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659)
2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967)
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c28 to 19b06f4e (21 revisions) (flutter/packages#5968)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ff010220

Don't show legacy welcome message when analytics are disabled (#140956) · a0e43d30

Sigurd Meldgaard authored Jan 25, 2024

The legacy welcome message would be printed even if `CI=true` confusing
parsers of the output.

This fixes: https://github.com/flutter/flutter/issues/139737

---------
Co-authored-by: eliasyishak <42216813+eliasyishak@users.noreply.github.com>

a0e43d30

Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) (#142223) · 1e24c41c

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/7c4ed15cb271...1d3f16b0d62e

2024-01-25 skia-flutter-autoroll@skia.org Roll Dart SDK from beb003009a4d to 2fb950853f06 (1 revision) (flutter/engine#50037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e24c41c

Roll Flutter Engine from e2014f007f61 to 7c4ed15cb271 (1 revision) (#142221) · a8efa771

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/e2014f007f61...7c4ed15cb271

2024-01-25 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8efa771

Roll Flutter Engine from 5fa2e2920274 to e2014f007f61 (1 revision) (#142213) · bd5db0da

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/5fa2e2920274...e2014f007f61

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 21c53af2e9f5 to 699ee2b7cf34 (1 revision) (flutter/engine#50034)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd5db0da

provide command to `FakeCommand::onRun` (#142206) · 295a9a20

Andrew Kolos authored Jan 25, 2024

Part of work on [#101077](https://github.com/flutter/flutter/pull/141194). This is done as a separate PR to avoid a massive diff.

## Context
1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename.
2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question.

## Issue
In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched.

Example:
```dart
FakeCommand(
  command: <Pattern>[
    artifacts.getArtifactPath(Artifact.engineDartBinary),
    'run',
    'vector_graphics_compiler',
    RegExp(r'--input=/.*\.temp'),
    RegExp(r'--output=/.*\.temp'),
  ],
  onRun: (List<String> command) {
    final outputPath = (() { 
      // code to parse `--output` from `command`
    })();
    testFileSystem.file(outputPath).createSync(recursive: true);
  },
)
```

295a9a20

Roll Flutter Engine from c346fd3d9ca1 to 5fa2e2920274 (1 revision) (#142212) · 535ce79a

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/c346fd3d9ca1...5fa2e2920274

2024-01-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 6211fedca10c to beb003009a4d (1 revision) (flutter/engine#50032)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

535ce79a

Roll Flutter Engine from d4d8f668159b to c346fd3d9ca1 (1 revision) (#142209) · 20e8f5b9

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/d4d8f668159b...c346fd3d9ca1

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from c0544410fc8e to 21c53af2e9f5 (1 revision) (flutter/engine#50031)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20e8f5b9

Roll Flutter Engine from 499ed00bbda2 to d4d8f668159b (2 revisions) (#142205) · 1c3f3865

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/499ed00bbda2...d4d8f668159b

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 571873c31056 to c0544410fc8e (1 revision) (flutter/engine#50030)
2024-01-25 71952488+johnstiles-google@users.noreply.github.com Use top-level GN arg for Skottie instead of CanvasKit-specific arg. (flutter/engine#50019)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c3f3865

Roll Flutter Engine from 4880592ca5ba to 499ed00bbda2 (6 revisions) (#142202) · d2a2d838

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/4880592ca5ba...499ed00bbda2

2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 3b7accdf8ed8 to 571873c31056 (1 revision) (flutter/engine#50026)
2024-01-25 jonahwilliams@google.com [Impeller] round up subpass coverage when it is close to (and smaller) than root pass size. (flutter/engine#49925)
2024-01-25 mzhou620@gmail.com Adding DDC module system targets to web SDK artifacts. (flutter/engine#47783)
2024-01-25 hasan@hasali.dev [Windows] Set cursor immediately when framework requests update (flutter/engine#49784)
2024-01-25 737941+loic-sharma@users.noreply.github.com [Windows] Introduce `egl::Surface` and `egl::WindowSurface` (flutter/engine#49983)
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 588caf1ceddd to 3b7accdf8ed8 (1 revision) (flutter/engine#50025)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2a2d838

[ci] Adds test for web hot restart with const App. (#141824) · 703e12f5

David Iglesias authored Jan 25, 2024

This PR adds a test that reproduces the problem described in the linked issue: hot restart on the web seems to not update if the app being run is `const`.

The new test is expected to fail, until the `const` issue with hot restart in the web is resolved.

Expected failure mode is a 15s timeout in the following test:

```
02:31 +3 ~1 -1: Hot reload (index.html: Default) (with `const MyApp()`)): newly added code executes during hot restart [E]
  TimeoutException after 0:00:15.000000: Future not completed
  dart:async  _startMicrotaskLoop
  ...
```

(And then a bunch of output that I'm not 100% sure is intended :))

## Issues

* #141588

703e12f5

Migrate android_view to linux_android_emu platform. (#142184) · 3165fa30

godofredoc authored Jan 25, 2024

A new top level platform configuration was created for android emulator tests running on linux vms.

This is also a preparation step to remove adhoc recipes created to run emulator tests.

3165fa30

Refactor `external_ui` without making any name changes (I think) (#142192) · b3da19f8

Matan Lurey authored Jan 25, 2024

Work towards https://github.com/flutter/flutter/issues/142178.

---

This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:

1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)

b3da19f8

Fix text selection edge scrolling when inside a horizontal scrollable (#140250) · eba38c4b

Renzo Olivares authored Jan 25, 2024

Fixes #129590

* Consider `AxisDirection` when calculating scroll offset used in determining TextSelection during a drag/long press drag. Previously it seems that we were assuming the direction was always vertical https://github.com/flutter/flutter/blob/30cc83198544582b858e48c7bb9d761ecdb3d944/packages/flutter/lib/src/widgets/text_selection.dart#L2842-L2844 .
* SelectableText now considers RenderEditable offset changes and Scrollable offset changes when calculating the TextSelection during a long press drag.

eba38c4b

Roll Flutter Engine from d7bf5ec1dcdd to 4880592ca5ba (2 revisions) (#142186) · d83eff44

engine-flutter-autoroll authored Jan 25, 2024

https://github.com/flutter/engine/compare/d7bf5ec1dcdd...4880592ca5ba

2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from e0bf6a261895 to 6211fedca10c (1 revision) (flutter/engine#50021)
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 247a61a5496d to 588caf1ceddd (2 revisions) (flutter/engine#50020)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d83eff44

24 Jan, 2024 7 commits

Roll Flutter Engine from 6a7f963dc751 to d7bf5ec1dcdd (2 revisions) (#142185) · d12b36de

engine-flutter-autoroll authored Jan 24, 2024

https://github.com/flutter/engine/compare/6a7f963dc751...d7bf5ec1dcdd

2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 7d69d275afd8 to 247a61a5496d (1 revision) (flutter/engine#50018)
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 643160445720 to 7d69d275afd8 (3 revisions) (flutter/engine#50016)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d12b36de

Reland "Remove hack from PageView." (#142172) · 47d8252a

Polina Cherkasova authored Jan 24, 2024

Original PR: https://github.com/flutter/flutter/pull/141533
Failure: https://fusion2.corp.google.com/presubmit/601217743/OCL:601217743:BASE:601219708:1706132224874:9a4bcab3/targets
Fix: [b/321743868](https://b.corp.google.com/321743868), http://cl/601219001 (added as g3 fix.

47d8252a

Upgrade leak_tracker. (#142162) · a522b38e
Polina Cherkasova authored Jan 24, 2024

a522b38e
Migrate android views to devicelab. (#142081) · d51858c2
godofredoc authored Jan 24, 2024
```
Migrate android view out of recipes.
```
d51858c2

Roll Flutter Engine from ed498f111d53 to 6a7f963dc751 (4 revisions) (#142176) · 30cc8319

engine-flutter-autoroll authored Jan 24, 2024

https://github.com/flutter/engine/compare/ed498f111d53...6a7f963dc751

2024-01-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kYC2-fFgjbb36mukB... to Igt2rE-R6rgfmTRaF... (flutter/engine#50015)
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 9ea7cb490804 to 643160445720 (6 revisions) (flutter/engine#50014)
2024-01-24 robert.ancell@canonical.com Add custom FlValue types and support their en/decoding via FlStandardMessageCodec (flutter/engine#49162)
2024-01-24 matanlurey@users.noreply.github.com Do not double-increment `nextId` when using `createSurfaceProducer` with `SurfaceTexture`s (flutter/engine#50011)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kYC2-fFgjbb3 to Igt2rE-R6rgf

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30cc8319

Support wireless debugging for iOS 12 or earlier (#141439) · 23385468

Jo Jaeyong authored Jan 24, 2024

`idevicesyslog` requires the `--network` flag to obtain logs for iOS devices when wirelessly paired. 

When running Flutter on devices with iOS 12 or earlier versions, [the `idevicesyslog` command is used.](https://github.com/flutter/flutter/blob/5931b4f21da0c564b28794f40257b5f660596a3e/packages/flutter_tools/lib/src/ios/devices.dart#L1269-L1277).

Related Issue: #15072
Related PRs: #118104, #118895, #60623

23385468

Roll Flutter Engine from 4bc368ee5f74 to ed498f111d53 (5 revisions) (#142167) · 990e2a56

engine-flutter-autoroll authored Jan 24, 2024

https://github.com/flutter/engine/compare/4bc368ee5f74...ed498f111d53

2024-01-24 flar@google.com [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994)
2024-01-24 103135467+sealesj@users.noreply.github.com Fuchsia + ocmock mirror migration (flutter/engine#50003)
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009)
2024-01-24 dkwingsmt@users.noreply.github.com [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995)
2024-01-24 30870216+gaaclarke@users.noreply.github.com [Impeller] Share vulkan playground across goldens (flutter/engine#49981)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

990e2a56