1. 05 Feb, 2019 14 commits
    • Danny Tuppeny's avatar
    • xster's avatar
      Add more RenderEditable test coverage (#27003) · 32b9c2f0
      xster authored
      32b9c2f0
    • xster's avatar
    • liyuqian's avatar
      Add scroll performance test for flutter_gallery (#27513) · de321b9c
      liyuqian authored
      Previously, we had a scroll_perf drive test but we were not exercising
      it on our device lab. This helps us tracking issues like:
      https://github.com/flutter/flutter/issues/24782
      de321b9c
    • Ian Hickson's avatar
      Make NotchedShape more practical to use (#27487) · f4d5646b
      Ian Hickson authored
      This PR does two things:
      
      - It allows BottomAppBar to have a custom shape even when it doesn't
        have a notch.
      
      - It adds AutomaticNotchedShape, an adapter from ShapeBorder to
        NotchedShape.
      f4d5646b
    • engine-flutter-autoroll's avatar
      Roll engine 174b73c21af8..93aa035dd469 (2 commits) (#27524) · 51780b87
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/174b73c21af8...93aa035dd469
      
      git log 174b73c21af8b1f61865d0fa855a6b0ddc81c953..93aa035dd46999353d8f7fe4be61e6599c794b4b --no-merges --oneline
      93aa035dd Don't warn for Async texture uploads on Fuchsia (flutter/engine#7691)
      f38f03fc8 Replace hb_face_reference_table with hb_ot_color_has_png in isColorBitmapFont (flutter/engine#7686)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      51780b87
    • engine-flutter-autoroll's avatar
      Roll engine fde59006da24..174b73c21af8 (2 commits) (#27522) · 1b212975
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/fde59006da24...174b73c21af8
      
      git log fde59006da245dc90503919ea9091b9a56d74fb2..174b73c21af8b1f61865d0fa855a6b0ddc81c953 --no-merges --oneline
      174b73c21 Roll src/third_party/dart 3e5ed47777..b53dceadaa (5 commits) b53dceadaa Update pubspec for dev_compiler and sourcemap_testing eefc18dc82 Add a hook to AnalysisDriver on the current session to be discarded. cda43dabda Use findNode.simple in migration test bd51d6f120 [vm] Build scopes for implicit getters of static const fields b876d12f03 Revert "[vm/compiler] Continued graph checker development"
      2f18c3286 Lower the threshold to raster cache pictures (flutter/engine#7687)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      1b212975
    • Matt Carroll's avatar
    • engine-flutter-autoroll's avatar
      fde59006d Roll src/third_party/skia d7a5a1d27e1d..50ea3c06b80f (9 commits)... · 8d5e18e6
      engine-flutter-autoroll authored
      fde59006d Roll src/third_party/skia d7a5a1d27e1d..50ea3c06b80f (9 commits) (flutter/engine#7688) (#27521)
      
      
      https://github.com/flutter/engine/compare/4812a2af115c...fde59006da24
      
      git log 4812a2af115ce81c0ad1dec8680fdf9ea7dd4fc4..fde59006da245dc90503919ea9091b9a56d74fb2 --no-merges --oneline
      fde59006d Roll src/third_party/skia d7a5a1d27e1d..50ea3c06b80f (9 commits) (flutter/engine#7688)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      
      8d5e18e6
    • Michael Goderbauer's avatar
      Removed double the (#27509) · 9165afdd
      Michael Goderbauer authored
      9165afdd
    • engine-flutter-autoroll's avatar
      Roll engine 85492c3e804a..4812a2af115c (3 commits) (#27518) · b5e09735
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/85492c3e804a...4812a2af115c
      
      git log 85492c3e804a6f6bf06275ed49c103ac6548be87..4812a2af115ce81c0ad1dec8680fdf9ea7dd4fc4 --no-merges --oneline
      4812a2af1 DCHECK that clip layer's behavior isn't none (flutter/engine#7659)
      eaae8a67b Retained rendering in Fuchsia PhysicalShapeLayer (flutter/engine#6558)
      194608290 Move Brightness definition to dart:ui (#27479) (flutter/engine#7678)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      b5e09735
    • Hans Muller's avatar
      Updated focus handling for nested FocusScopes (#27365) · 05dc9444
      Hans Muller authored
      Updated focus handling in FocusManager et al and EditableText so that TextFields within nested FocusScopes can gain the focus and show the keybaord.
      05dc9444
    • Matt Carroll's avatar
    • engine-flutter-autoroll's avatar
      85492c3e8 Roll src/third_party/dart 71bee8f05e..3e5ed47777 (83 commits)... · 3ba97da9
      engine-flutter-autoroll authored
      85492c3e8 Roll src/third_party/dart 71bee8f05e..3e5ed47777 (83 commits) 3e5ed47777 Implement 'completion.getSuggestionDetails'. 38aadd71df Rework DecoratedType substitution. 087c6e3eb7 Add associatedErrorCodes API to AssistKind 8a45b5eb57 Move environment handling into the front-end constant evaluator. 8010fad320 [infra] Fix incorrect shell function syntax 1bfc3816d8 [infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit e4b809f0e6 Add unit testing of (some) invoke dynamic specializers 0fd1679620 Sort named parameters in native methods by declaration. 8c891ec25e Include type parameters into suggested code completions. 2efd22271e Use included suggestions only when free standing identifiers are allowed. 0d075031fa allow custom analysis options in lint driving f89acfa374 Issue 35621. Part files should use their own transitive signatures. 133d83eede Protect against override completion outside workspace. 849285276d Extract and migrate ElementLocator tests. d45a6ec893 Split Variables class into two interface classes and create DecoratedType.forElement constructor. b9c89c9fb5 More test cases for the migration prototype. a6e7361fa8 Add documentation comments to the migration prototype. 67ff7a6ef3 Remove unused import 53ba159aa4 Add assists to convert to list, map and set literals a9c84ab887 Verify nullability of dynamic in DecoratedType constructor. eaeffd2695 Rename ConstraintsTest to match the class it's testing af303a277c Add some assists for the code-as-ui features c4dcd85b3a Tests for control flow collections. fe585471e3 Add DartFileEditBuilder.importLibraryElement(). 460d69d08f Update 'Convert to StatefulWidget' to create private State classes. 509ac0648c Update non-nullability migration algorithm to handle missing types b01697ba5a [vm/compiler] Continued graph checker development 00c6f6b584 Document InheritanceManager deprecations. 3802a6d7eb Experimental prototype of a non-nullability migration algorithm. 931051814c Partial implementation of the 'available suggestion sets' protocol. 1c173c2ce7 Enhance dartfix to allow including and excluding specific fixes 971733a08b [kernel] Add a class to track variance of type parameters 967b5fbac3 Finish implementing IsFunctionSubtypeOf 0d7bdd734a Ensure that top types are equivalent. d44724d0af Compute default type arguments in Fasta types. d55f95e344 Add Types.isSameTypeKernel 7fa0376af7 Implement subtype rules for Null in Fasta types d9072d5272 Re-issue all problems in the incremental compiler b6dc18e21e Remove legacyMode parameter and delete obsolete version of test 33f167b039 Complete the implemention of IsInterfaceSubtypeOf. 534825020a Check intersection types in subtype tests ea0d98d98a Check FutureOr in subtype tests 014124e763 (Some) DiagnosticMessages can be serialized to/from json. eb956a2516 Add synthetic bit to Library flags e9597684fe Fix for incremental compiler swallowing certain errors 68d110ac2a Add test for codegen of optional parameters on native functions. 5737b452b8 [vm/gc] Update initial TLAB size calculation. 37a1f79360 [dart2js] Move letBindings to StackFrame ec343169e7 Skip the spread tests on platforms that aren't using the new test workflow. 598515f031 [vm/compiler] Fix another missing incremental DOM update d6f9d2da6f Add pkg/analysis_server/pubspec.yaml so that it is identified as a pub package. 9f8a9dc9f4 First stab at tests for "Spread Collections". 2c25cf016d [vm, gc] Use work stealing for the slices of the root set. 9308cac681 [vm] Simplify VirtualMemory::Truncate e717ecdc92 [vm] Maintain view-ness of bytecode instructions in snapshots. d4b8e0696d Add the capability in analysis server protocol for clients to express interest in receiving not yet imported code completions from specific packages and libraries. 7a95930bee Add a "summary-deps-output" option to build mode. aaf97448b0 Extract EnumListParameter values before checking for matches 20fc81470e Fix override_on_non_overriding_method hint ca4978e363 Add pkg:analysis_tool as an SDK-only set of utils e5164be27e Issue 35127. Fixes for mixin implements / overrides. fdd477721d [infra] Run co19_2 tests on DDC Linux and Windows builders c31627b778 Remove the unused TypeOverrideManager 485a41bb12 Include superclass constraints into mixin type suggestions. 8f12035f36 Clean up the diagnostic tests 14b2255584 Status update after c3c5250 c3c525079b Demonstrate bug for the VMs way of doing initializers in face of mixins d6608f19c0 Check function types in subtype tests a6a9d4854b Start checking type arguments in subtype tests dd70ecd5c0 Substitute type variables when computing class hierarchy 85c5082cf4 Support Kernel classes in ClassHierarchyBuilder 18ff842341 Start testing Fasta types implementation db44a727e5 Extend the edit.dartfix protocol 40fca03d07 [vm/compiler] fix assert failure on minint64 6c96d8fdaf Fix crashing analysis_server with some defensive null checks 3b5c1012e9 Update CodeChecker to handle the code-as-ui features b8fc017778 Replace convertAbsolutePathToUri() with toUriStr(). f903ee6dc0 Don't crash on formal parameters without name, exclude private SDK lbiraries. 118bdcc1f6 backlink to language docs for customized analysis bc2a5a6789 Generate some of the code-as-ui diagnostics; implement more resolution e8a0a209e3 Include into Declaration data that we will need for pre-cached suggestions. 0bb1aee3ff AstBuilder cleanup ec13e61df3 Move `question` getter from GenericFunctionType and NamedType to their common base class. (#27514)
      
      
      https://github.com/flutter/engine/compare/74839e207b48...85492c3e804a
      
      git log 74839e207b482e7a47eae8af73ffa1e23f8e8355..85492c3e804a6f6bf06275ed49c103ac6548be87 --no-merges --oneline
      85492c3e8 Roll src/third_party/dart 71bee8f05e..3e5ed47777 (83 commits) 3e5ed47777 Implement 'completion.getSuggestionDetails'. 38aadd71df Rework DecoratedType substitution. 087c6e3eb7 Add associatedErrorCodes API to AssistKind 8a45b5eb57 Move environment handling into the front-end constant evaluator. 8010fad320 [infra] Fix incorrect shell function syntax 1bfc3816d8 [infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit e4b809f0e6 Add unit testing of (some) invoke dynamic specializers 0fd1679620 Sort named parameters in native methods by declaration. 8c891ec25e Include type parameters into suggested code completions. 2efd22271e Use included suggestions only when free standing identifiers are allowed. 0d075031fa allow custom analysis options in lint driving f89acfa374 Issue 35621. Part files should use their own transitive signatures. 133d83eede Protect against override completion outside workspace. 849285276d Extract and migrate ElementLocator tests. d45a6ec893 Split Variables class into two interface classes and create DecoratedType.forElement constructor. b9c89c9fb5 More test cases for the migration prototype. a6e7361fa8 Add documentation comments to the migration prototype. 67ff7a6ef3 Remove unused import 53ba159aa4 Add assists to convert to list, map and set literals a9c84ab887 Verify nullability of dynamic in DecoratedType constructor. eaeffd2695 Rename ConstraintsTest to match the class it's testing af303a277c Add some assists for the code-as-ui features c4dcd85b3a Tests for control flow collections. fe585471e3 Add DartFileEditBuilder.importLibraryElement(). 460d69d08f Update 'Convert to StatefulWidget' to create private State classes. 509ac0648c Update non-nullability migration algorithm to handle missing types b01697ba5a [vm/compiler] Continued graph checker development 00c6f6b584 Document InheritanceManager deprecations. 3802a6d7eb Experimental prototype of a non-nullability migration algorithm. 931051814c Partial implementation of the 'available suggestion sets' protocol. 1c173c2ce7 Enhance dartfix to allow including and excluding specific fixes 971733a08b [kernel] Add a class to track variance of type parameters 967b5fbac3 Finish implementing IsFunctionSubtypeOf 0d7bdd734a Ensure that top types are equivalent. d44724d0af Compute default type arguments in Fasta types. d55f95e344 Add Types.isSameTypeKernel 7fa0376af7 Implement subtype rules for Null in Fasta types d9072d5272 Re-issue all problems in the incremental compiler b6dc18e21e Remove legacyMode parameter and delete obsolete version of test 33f167b039 Complete the implemention of IsInterfaceSubtypeOf. 534825020a Check intersection types in subtype tests ea0d98d98a Check FutureOr in subtype tests 014124e763 (Some) DiagnosticMessages can be serialized to/from json. eb956a2516 Add synthetic bit to Library flags e9597684fe Fix for incremental compiler swallowing certain errors 68d110ac2a Add test for codegen of optional parameters on native functions. 5737b452b8 [vm/gc] Update initial TLAB size calculation. 37a1f79360 [dart2js] Move letBindings to StackFrame ec343169e7 Skip the spread tests on platforms that aren't using the new test workflow. 598515f031 [vm/compiler] Fix another missing incremental DOM update d6f9d2da6f Add pkg/analysis_server/pubspec.yaml so that it is identified as a pub package. 9f8a9dc9f4 First stab at tests for "Spread Collections". 2c25cf016d [vm, gc] Use work stealing for the slices of the root set. 9308cac681 [vm] Simplify VirtualMemory::Truncate e717ecdc92 [vm] Maintain view-ness of bytecode instructions in snapshots. d4b8e0696d Add the capability in analysis server protocol for clients to express interest in receiving not yet imported code completions from specific packages and libraries. 7a95930bee Add a "summary-deps-output" option to build mode. aaf97448b0 Extract EnumListParameter values before checking for matches 20fc81470e Fix override_on_non_overriding_method hint ca4978e363 Add pkg:analysis_tool as an SDK-only set of utils e5164be27e Issue 35127. Fixes for mixin implements / overrides. fdd477721d [infra] Run co19_2 tests on DDC Linux and Windows builders c31627b778 Remove the unused TypeOverrideManager 485a41bb12 Include superclass constraints into mixin type suggestions. 8f12035f36 Clean up the diagnostic tests 14b2255584 Status update after c3c5250 c3c525079b Demonstrate bug for the VMs way of doing initializers in face of mixins d6608f19c0 Check function types in subtype tests a6a9d4854b Start checking type arguments in subtype tests dd70ecd5c0 Substitute type variables when computing class hierarchy 85c5082cf4 Support Kernel classes in ClassHierarchyBuilder 18ff842341 Start testing Fasta types implementation db44a727e5 Extend the edit.dartfix protocol 40fca03d07 [vm/compiler] fix assert failure on minint64 6c96d8fdaf Fix crashing analysis_server with some defensive null checks 3b5c1012e9 Update CodeChecker to handle the code-as-ui features b8fc017778 Replace convertAbsolutePathToUri() with toUriStr(). f903ee6dc0 Don't crash on formal parameters without name, exclude private SDK lbiraries. 118bdcc1f6 backlink to language docs for customized analysis bc2a5a6789 Generate some of the code-as-ui diagnostics; implement more resolution e8a0a209e3 Include into Declaration data that we will need for pre-cached suggestions. 0bb1aee3ff AstBuilder cleanup ec13e61df3 Move `question` getter from GenericFunctionType and NamedType to their common base class.
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      
      3ba97da9
  2. 04 Feb, 2019 10 commits
    • Ian Hickson's avatar
      [H] Tabs (#27477) · 7b618005
      Ian Hickson authored
      * Crash when a TabBar is put in a BottomAppBar.
      
      * Tabs bugs (e.g. crash on transparent material)
      
      - Tabs would crash when placed on transparent Materials
      - Tabs would fail to render the child if an icon was specified
      7b618005
    • Hans Muller's avatar
    • Hans Muller's avatar
      ad075dcd
    • Janice Collins's avatar
    • engine-flutter-autoroll's avatar
      Roll engine e7eb1c8bf655..74839e207b48 (33 commits) (#27507) · f026b193
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/e7eb1c8bf655...74839e207b48
      
      git log e7eb1c8bf65531195fc76ba96c8fc8478ac5f554..74839e207b482e7a47eae8af73ffa1e23f8e8355 --no-merges --oneline
      74839e207 Roll src/third_party/skia 8c14038e56c3..d7a5a1d27e1d (5 commits) (flutter/engine#7683)
      615ca598d Roll src/third_party/skia 69130631e23d..8c14038e56c3 (1 commits) (flutter/engine#7682)
      482e43faf Roll src/third_party/skia 21ca3702f8eb..69130631e23d (2 commits) (flutter/engine#7681)
      cc349a36e Roll src/third_party/skia b45f47dc3ef5..21ca3702f8eb (1 commits) (flutter/engine#7680)
      26b83393b Roll src/third_party/skia 9c7a006a8e2d..b45f47dc3ef5 (1 commits) (flutter/engine#7679)
      940b42030 Roll src/third_party/skia 32d8cce070dd..9c7a006a8e2d (1 commits) (flutter/engine#7677)
      0a9dadb04 Roll src/third_party/skia 71e434dc9dea..32d8cce070dd (1 commits) (flutter/engine#7675)
      6266da8e6 Roll src/third_party/skia d396dd0347d3..71e434dc9dea (1 commits) (flutter/engine#7674)
      94ec2c55c Roll src/third_party/skia 0d84e805c30c..d396dd0347d3 (1 commits) (flutter/engine#7673)
      48055b102 Roll src/third_party/skia 48913465db5f..0d84e805c30c (1 commits) (flutter/engine#7672)
      7f9d59cb0 Roll src/third_party/skia d6a45a8aee6e..48913465db5f (1 commits) (flutter/engine#7671)
      3f4ac2bac Roll src/third_party/skia 8ec9a60bdb6f..d6a45a8aee6e (2 commits) (flutter/engine#7670)
      b00c7c87f Roll src/third_party/skia 72c687807f5e..8ec9a60bdb6f (2 commits) (flutter/engine#7669)
      1b6f1397c Roll src/third_party/skia 8f5aeebdd8eb..72c687807f5e (3 commits) (flutter/engine#7668)
      637fadba7 Roll src/third_party/skia 3ed198faf93a..8f5aeebdd8eb (8 commits) (flutter/engine#7667)
      1b657855e Add kernel-worker and dart2js to BUILD.gn (flutter/engine#7660)
      1cf606148 Roll src/third_party/skia 5892553ad020..3ed198faf93a (3 commits) (flutter/engine#7666)
      377e665e4 Roll src/third_party/skia 569dda7216cd..5892553ad020 (5 commits) (flutter/engine#7665)
      44245c8e7 Roll src/third_party/skia 72a0e3347cdf..569dda7216cd (1 commits) (flutter/engine#7664)
      80db23fb7 Roll src/third_party/skia ae64f52786b3..72a0e3347cdf (2 commits) (flutter/engine#7663)
      4889c743c Roll src/third_party/skia 95b014790f93..ae64f52786b3 (3 commits) (flutter/engine#7662)
      fac24d938 Roll src/third_party/skia 88bfed46ab6e..95b014790f93 (3 commits) (flutter/engine#7661)
      5dcf3cfd2 Roll src/third_party/skia 5b257abb87d2..88bfed46ab6e (8 commits) (flutter/engine#7657)
      93452747f Initial import of FDE macOS framework (flutter/engine#7642)
      54f546715 Roll src/third_party/skia 1bd245b91801..5b257abb87d2 (5 commits) (flutter/engine#7656)
      e71daf6cf Roll src/third_party/skia ea2dc6a6bc11..1bd245b91801 (1 commits) (flutter/engine#7655)
      4f5e1709b Roll src/third_party/skia e9742a5a0db1..ea2dc6a6bc11 (1 commits) (flutter/engine#7654)
      ef1a7f8ce Roll src/third_party/skia 8a484d0203d9..e9742a5a0db1 (2 commits) (flutter/engine#7653)
      28339c864 Roll src/third_party/skia b7af275ebbf5..8a484d0203d9 (3 commits) (flutter/engine#7652)
      7fa77ef03 Fix two typos in embedder docs (flutter/engine#7649)
      e9419bf6d Roll src/third_party/skia 9c8ad0316147..b7af275ebbf5 (3 commits) (flutter/engine#7650)
      b94e759b2 Expose the Flutter engine, Dart and Skia versions to Dart. (flutter/engine#7634)
      64e17076c Document make_resource_current on FlutterOpenGLRendererConfig and warn if the callback is not set. (flutter/engine#7648)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (dnfield@google.com), and stop
      the roller if necessary.
      f026b193
    • Jason Simmons's avatar
      b5ca595d
    • Sander Kersten's avatar
      5b828764
    • Hans Muller's avatar
    • 木士羽's avatar
      Support using flutter with specific version (#26840) · 9f7ab4c4
      木士羽 authored
      * Support using flutter with specific version
      
      * Set min supported version to 1.2.1
      9f7ab4c4
    • Gary Qian's avatar
      Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui,... · c6cc3cde
      Gary Qian authored
      Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) (#26332)
      
      Includes a breaking change to dart:ui ParagraphStyle where lineHeight is renamed to height for consistency with TextStyle.
      c6cc3cde
  3. 03 Feb, 2019 1 commit
  4. 01 Feb, 2019 13 commits
  5. 31 Jan, 2019 2 commits