- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 07 Aug, 2023 1 commit
-
-
chunhtai authored
migration guide update https://github.com/flutter/website/pull/9124 fixes the concerns in https://github.com/flutter/flutter/pull/120619
-
- 24 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Reimplements what we reverted here: #125233.
-
- 20 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Going to make some changes to the implementation so I'll revert in the meantime. Reverts flutter/flutter#124337
-
- 10 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Sliver Constrained Cross Axis
-
- 07 Apr, 2023 1 commit
-
-
chunhtai authored
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 25 Apr, 2022 1 commit
-
-
wangying authored
-
- 14 Sep, 2021 1 commit
-
-
Dan Field authored
* Make sure Opacity widgets/layers do not drop the offset
-
- 13 Sep, 2021 2 commits
-
-
Dan Field authored
- 08 Jul, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 Jan, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 07 Jan, 2020 1 commit
-
-
Kate Lovett authored
-
- 19 Dec, 2019 3 commits
-
-
Alexandre Ardhuin authored
-
Lau Ching Jun authored
This reverts commit c235998a.
-
Alexandre Ardhuin authored
-
- 16 Dec, 2019 1 commit
-
-
Kate Lovett authored
-