- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 16 Dec, 2019 1 commit
-
-
Ian Hickson authored
-
- 05 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 19 Nov, 2019 1 commit
-
-
Greg Spencer authored
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors. Also, added a --verbose option to the sample analyzer.
-
- 17 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Jul, 2019 1 commit
-
-
Alexandre Ardhuin authored
* more ui-as-code * address review comments
-
- 01 Jul, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jun, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 Jun, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 May, 2019 1 commit
-
-
Michael Thomsen authored
-
- 02 Apr, 2019 1 commit
-
-
LongCatIsLooong authored
updates the regex the analyzer uses, so it should be able to recognize expressions such as const Foo a = Foo(); as "other code" rather than a constructor call.
-
- 15 Feb, 2019 1 commit
-
-
Greg Spencer authored
This converts all remaining "## Sample code" segments into snippets, and fixes the snippet generator to handle multiple snippets in the same dartdoc block properly. I also generated, compiled, and ran each of the existing application samples, and fixed them up to be more useful and/or just run without errors. This PR fixes these problems with examples: 1. Switching tabs in a snippet now works if there is more than one snippet in a single dartdoc block. 2. Generation of snippet code now works if there is more than one snippet. 3. Contrast of text and links in the code sample block has been improved to recommended levels. 4. Added five new snippet templates, including a "freeform" template to make it possible to show examples that need to change the app instantiation. 5. Fixed several examples to run properly, a couple by adding the "Scaffold" widget to the template, a couple by just fixing their code. 6. Fixed visual look of some of the samples when they run by placing many samples inside of a Scaffold. 7. In order to make it easier to run locally, changed the sample analyzer to remove the contents of the supplied temp directory before running, since having files that hang around is problematic (only a problem when running locally with the `--temp` argument). 8. Added a `SampleCheckerException` class, and handle sample checking exceptions more gracefully. 9. Deprecated the old "## Sample code" designation, and added enforcement for the deprecation. 10. Removed unnecessary `new` from templates (although they never appeared in the samples thanks to dartfmt, but still). Fixes #26398 Fixes #27411
-
- 08 Feb, 2019 1 commit
-
-
Greg Spencer authored
Now the sample analyzer can be run locally with: dart dev/bots/analyze-sample-code.dart --temp=/tmp/samples And it leaves /tmp/samples around so you can take a look at the code that was generated to see if it's the artificial environment that the samples are evaluated in that is the culprit for a failed analysis. Before, you had to specify the whole path to the dart executable, and had to modify the code to keep the tempdir around.
-
- 12 Dec, 2018 1 commit
-
-
Janice Collins authored
* Allow snippets tool to be run from arbitrary CWDs * Drop use of absolute when using Platform.executable (path is not relative, might require PATH resolution) * canonicalize paths * Use path.fromUri consistently to resolve file URIs * Force commit to try to kick Cirrus * Force commit to kick Cirrus, again
-
- 08 Nov, 2018 1 commit
-
-
Greg Spencer authored
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form. Also: 1. Fixed a minor bug in analyze-sample-code.dart 2. Made the snippet tool only insert descriptions if the description is non-empty. 3. Moved the Card diagram to before the code sample.
-
- 07 Nov, 2018 1 commit
-
-
Greg Spencer authored
When converting all of the samples to use the snippet tool, I encountered some bugs/shortcomings: 1. The document production took 90 minutes, since the snippet tool was being invoked from the command line each time. I fixed this by snapshotting the executable before running, so it's down to 7 minutes. 2. The sample code was not being properly escaped by the snippet tool, so generics were causing issues in the HTML output. It is now quoted. 3. Code examples that used languages other than Dart were not supported. Anything that highlight.js was compiled for dartdoc with is now supported. 4. The comment color for highlight.js was light grey on white, which was pretty unreadable. It's now dark green and bold.
-
- 05 Nov, 2018 1 commit
-
-
Greg Spencer authored
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well. It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions. I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error. For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
-
- 19 Oct, 2018 2 commits
-
-
Greg Spencer authored
Devon asked me to revert commit c4d1b31b. Merging on red to fix the build.
-
Devon Carew authored
* don't disable TODO issues in IDEs * minor change to start cirrus
-
- 17 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint prefer_void_to_null * replace last Null by void
-
- 11 Oct, 2018 1 commit
-
-
Greg Spencer authored
This attempts to re-land #22656. There are two changes from the original: I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text. I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences. As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor. * Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 06 Oct, 2018 2 commits
-
-
Greg Spencer authored
Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759) This reverts commit e4386321 because it breaks 160 benchmarks, and several devicelab tests, due to changing the format of the output.
-
Greg Spencer authored
Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 04 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 23 Sep, 2018 1 commit
-
-
Ian Hickson authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 2 commits
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
Alexandre Ardhuin authored
-
- 20 Aug, 2018 1 commit
-
-
Ian Hickson authored
* `flutter analyze` cleanup * Make `--dartdocs` work in all modes. * Make `analyze-sample-code.dart` more resilient. * Add a test for `analyze-sample-code.dart`. * Minor cleanup in related code and files. * Apply review comments * Fix tests
-
- 17 Aug, 2018 1 commit
-
-
Ian Hickson authored
All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`. I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests. While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others. Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
-
- 20 Jul, 2018 1 commit
-
-
Leaf Petersen authored
* Remove uses of deprecated constants * Change int.parse to int.tryParse where appropriate
-
- 20 Jun, 2018 1 commit
-
-
Ian Hickson authored
The new matcher package deprecates isInstanceOf which seems eggregious.
-
- 11 May, 2018 1 commit
-
-
Devon Carew authored
-
- 10 May, 2018 1 commit
-
-
Devon Carew authored
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
-
- 26 Apr, 2018 1 commit
-
-
Ian Hickson authored
-
- 13 Apr, 2018 1 commit
-
-
Hans Muller authored
-
- 12 Apr, 2018 1 commit
-
-
Alexander Aprelev authored
* Handle error count reported by frontend. Extend compilation result from single string to a structure(string filename and integer error count). * Use ?. * Include engine roll with dart sdk roll. * parse(onError) -> tryParse * Make '?? throw' more readable and avoid issue with analyzer * Fix test so it mocks compiler output including errors count
-
- 11 Apr, 2018 1 commit
-
-
Devon Carew authored
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)" (#16482) This reverts commit 2f41ea54.
-