1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  2. 23 Aug, 2023 1 commit
  3. 24 Jan, 2023 1 commit
  4. 22 Aug, 2022 1 commit
  5. 27 Apr, 2022 1 commit
  6. 14 Apr, 2022 1 commit
  7. 11 Apr, 2022 1 commit
  8. 06 Apr, 2022 1 commit
  9. 08 Mar, 2022 1 commit
  10. 03 Mar, 2022 1 commit
  11. 04 Feb, 2022 1 commit
  12. 13 May, 2021 1 commit
  13. 10 May, 2021 1 commit
  14. 02 Nov, 2020 2 commits
  15. 05 Oct, 2020 1 commit
  16. 03 Oct, 2020 1 commit
  17. 02 Oct, 2020 1 commit
  18. 24 Aug, 2020 1 commit
  19. 29 Jul, 2020 1 commit
  20. 11 Jun, 2020 1 commit
  21. 03 Jun, 2020 1 commit
  22. 28 May, 2020 1 commit
  23. 04 Dec, 2019 1 commit
  24. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  25. 01 Nov, 2019 1 commit
  26. 30 Oct, 2019 1 commit
  27. 10 Sep, 2019 1 commit
  28. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  29. 15 Aug, 2019 1 commit
  30. 17 Jul, 2019 1 commit
  31. 28 Jun, 2019 3 commits
  32. 13 Jun, 2019 1 commit
  33. 05 Jun, 2019 1 commit
  34. 15 May, 2019 1 commit
    • Greg Spencer's avatar
      Implements focus handling and hover for Material buttons. (#31438) · bb3c6605
      Greg Spencer authored
      This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets.
      
      Addresses #11344, #1608, and #13264.
      bb3c6605
  35. 05 Apr, 2019 1 commit
  36. 21 Mar, 2019 1 commit
  37. 12 Mar, 2019 1 commit