- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 23 Aug, 2023 1 commit
-
-
Kate Lovett authored
Part of https://github.com/flutter/flutter/issues/133171
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 27 Apr, 2022 1 commit
-
-
Pierre-Louis authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 06 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 08 Mar, 2022 1 commit
-
-
Kate Lovett authored
-
- 03 Mar, 2022 1 commit
-
-
Kate Lovett authored
-
- 04 Feb, 2022 1 commit
-
-
J-P Nurmi authored
-
- 13 May, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 May, 2021 1 commit
-
-
Hans Muller authored
-
- 02 Nov, 2020 2 commits
-
-
Greg Spencer authored
-
Michael Goderbauer authored
-
- 05 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 03 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
This reverts commit 81439922.
-
- 02 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate some material files to nullsafety * review
-
- 24 Aug, 2020 1 commit
-
-
Hans Muller authored
-
- 29 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 03 Jun, 2020 1 commit
-
-
Pedro Massango authored
* Pass disabledElevation from MaterialButton into RawMaterialButton
-
- 28 May, 2020 1 commit
-
-
Tong Mu authored
* Adds default cursor and/or mouseCursor property to a number of widgets. * Adds `MaterialStateMouseCurrsor`.
-
- 04 Dec, 2019 1 commit
-
-
Greg Spencer authored
* Add a density attribute to ThemeData * Simplify tests * Review changes (Hans)
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 01 Nov, 2019 1 commit
-
-
NikitaZhelonkin authored
* Wire enableFeedback parameter through MaterialButton, RawMaterialButton, and IconButton. Co-Authored-By:
Shi-Hao Hong <shihaohong@google.com>
-
- 30 Oct, 2019 1 commit
-
-
Bernardo Ferrari authored
* Add onLongPress to Buttons. * Button enabled status will now respond to onLongPress
-
- 10 Sep, 2019 1 commit
-
-
Greg Spencer authored
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget, and added a test for Focus and MaterialButton to test that it works properly.
-
- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary. This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
-
- 15 Aug, 2019 1 commit
-
-
Greg Spencer authored
Add an autofocus parameter to widgets which use Focus widget internally, and update related docs. This will allow developers to request that a particular widget be automatically focused when shown.
-
- 17 Jul, 2019 1 commit
-
-
Shi-Hao Hong authored
* Add clarifying docs on MaterialButton.colorBrightness
-
- 28 Jun, 2019 3 commits
-
-
MH Johnson authored
Re-land "[Material] Support for hovered, focused, and pressed border color on `OutlineButton`s" (#35278) * outline border implements material state property
-
Todd Volkert authored
Revert "[Material] Support for hovered, focused, and pressed border color on `OutlineButton`s (#34872)" (#35276) This reverts commit 3f941599.
-
MH Johnson authored
* outline border implements material state property
-
- 13 Jun, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 05 Jun, 2019 1 commit
-
-
MH Johnson authored
* Support for stateful text colors in buttons * Add color and a11y tests for buttons
-
- 15 May, 2019 1 commit
-
-
Greg Spencer authored
This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets. Addresses #11344, #1608, and #13264.
-
- 05 Apr, 2019 1 commit
-
-
Hans Muller authored
-
- 21 Mar, 2019 1 commit
-
-
Rubens de Melo authored
-
- 12 Mar, 2019 1 commit
-
-
Hans Muller authored
-