Commits · 7b47ba1ef92c7921fb28642488a20a6b73fc4164 · abdullh.alsoleman / Front-End

29 Jun, 2023 2 commits

Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) (#129730) · 7b47ba1e

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/241ca5c1d6be...4e49b9deb72d

2023-06-28 jonahwilliams@google.com [Impeller] remove redundant highp
modifiers in vertex shaders. (flutter/engine#43305)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b47ba1e

Skwasm benchmarks. (#129681) · 1b887c72

Jackson Gardner authored Jun 29, 2023

This enables benchmarks for the Skwasm renderer, compiled with
dart2wasm.

Platform views aren't supported in Skwasm yet, so we are skipping those
benchmarks for now.

1b887c72

28 Jun, 2023 18 commits

RTL InputDecoration fix (#129661) · c7511664

Justin McCandless authored Jun 28, 2023

Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.

c7511664

mark autoroller flaky (#129745) · c1b764a8
Christopher Fujino authored Jun 28, 2023
```
Unblock tree while I investigate: https://github.com/flutter/flutter/issues/129744
```
c1b764a8
Roll pub packages (#129380) · ba636881
Flutter GitHub Bot authored Jun 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
ba636881
Removes deprecated APIs from AnimationBuilder (#129657) · af09b57e
pdblasi-google authored Jun 28, 2023
```
Removes deprecated APIs from AnimationBuilder.

Resolves #129653
```
af09b57e

Roll Flutter Engine from e8a1c23d66ba to 241ca5c1d6be (1 revision) (#129725) · 51bef1b6

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/e8a1c23d66ba...241ca5c1d6be

2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) (flutter/engine#43304)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51bef1b6

Update analysis, linter, and repo links in analysis options (#129686) · c65e9084
Parker Lougheed authored Jun 28, 2023
```
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
```
c65e9084

Roll Flutter Engine from be1073aa352f to e8a1c23d66ba (1 revision) (#129723) · 73bb959a

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/be1073aa352f...e8a1c23d66ba

2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e164fdc1a3ad to 5a59cd06e49d (1 revision) (flutter/engine#43302)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

73bb959a

Dev, examples/api, etc updated for Material 3 by default (#129683) · 0d4b5ae1

Hans Muller authored Jun 28, 2023

Updated tests in dev, examples/api, and tests/widgets to ensure that
they continue to pass when the default for `ThemeData.useMaterial3` is
changed to true.

This is the final set of changes required for
https://github.com/flutter/flutter/issues/127064.

0d4b5ae1

Add `DatePickerTheme.inputDecorationTheme` for the DatePicker with input mode. (#128950) · 32fe4d7f
Taha Tesser authored Jun 28, 2023

32fe4d7f
[framework] ensure flexible space bar fades when scrolling. (#129527) · 9c963572
Jonah Williams authored Jun 28, 2023
```
This was missing the actual opacity rendering, oops
```
9c963572

Add InputDecorator.error to allow error message customization (#129275) · 8d837062

Bruno Leroux authored Jun 28, 2023

## Description

This PR is a fork of https://github.com/flutter/flutter/pull/118610 with some changes (mainly applying @justinmc comments).

~~This can be used by KishanBusa8 to update https://github.com/flutter/flutter/pull/118610 or can become a non WIP PR if KishanBusa8 does not respond or can not work on the update.~~

## Related Issue

fixes https://github.com/flutter/flutter/issues/11068

## Tests

Adds 3 tests.

8d837062

Roll Flutter Engine from b388e852be44 to be1073aa352f (1 revision) (#129712) · b6b417c2

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/b388e852be44...be1073aa352f

2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sBFKkha8HNLZpTNwv... to cytps4RRhs8-wbcVJ... (flutter/engine#43300)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sBFKkha8HNLZ to cytps4RRhs8-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6b417c2

Roll Flutter Engine from 17173994a8c2 to b388e852be44 (1 revision) (#129708) · 70b9dd70

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/17173994a8c2...b388e852be44

2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 3233ec5b6862 to e164fdc1a3ad (1 revision) (flutter/engine#43299)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70b9dd70

[flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply... · f3b0b172

Xilai Zhang authored Jun 28, 2023

[flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding" (#129645)

Reverts flutter/flutter#129556.

Context: b/288993600

quoting, "the failure (in internal tests) appears to be due to a
workaround for the issue fixed by this pr".

f3b0b172

Roll Flutter Engine from 2f4fc4872699 to 17173994a8c2 (1 revision) (#129694) · 43bda355

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/2f4fc4872699...17173994a8c2

2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bvv7TyHm_VHUkndFx... to 10hNrVMjnCypybnz2... (flutter/engine#43297)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Bvv7TyHm_VHU to 10hNrVMjnCyp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43bda355

Roll Flutter Engine from a6d9d12c440f to 2f4fc4872699 (1 revision) (#129691) · 0640f001

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/a6d9d12c440f...2f4fc4872699

2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from abfa59f66c42 to 3233ec5b6862 (2 revisions) (flutter/engine#43296)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0640f001

Roll Flutter Engine from 25a5850f8b5b to a6d9d12c440f (4 revisions) (#129687) · 14c04cd0

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/25a5850f8b5b...a6d9d12c440f

2023-06-28 jason-simmons@users.noreply.github.com Include the SkRTreeFactory headers in the skwasm picture recorder (flutter/engine#43292)
2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a233f843402 to abfa59f66c42 (3 revisions) (flutter/engine#43291)
2023-06-27 bdero@google.com [Impeller] Correct advanced blending behavior. (flutter/engine#43283)
2023-06-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 81cdbe69a16b to 7a233f843402 (4 revisions) (flutter/engine#43288)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14c04cd0

Roll Flutter Engine from 7c7c45d53bec to 25a5850f8b5b (1 revision) (#129682) · eead6a8e

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/7c7c45d53bec...25a5850f8b5b

2023-06-27 58529443+srujzs@users.noreply.github.com Revert "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43286)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eead6a8e

27 Jun, 2023 18 commits

Roll Flutter Engine from f320b8c36fee to 7c7c45d53bec (14 revisions) (#129678) · 7408a5ff

engine-flutter-autoroll authored Jun 27, 2023

https://github.com/flutter/engine/compare/f320b8c36fee...7c7c45d53bec

2023-06-27 flar@google.com Update skia includes to be more specific (flutter/engine#43284)
2023-06-27 yjbanov@google.com [web:a11y] introduce primary role responsible for ARIA roles (flutter/engine#43159)
2023-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ytzCCSvHY1lHWEDM9... to sBFKkha8HNLZpTNwv... (flutter/engine#43277)
2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from 9faf7059f9ef to 113f847be69f (2 revisions) (flutter/engine#43278)
2023-06-27 jacksongardner@google.com Initialize skwasm codecs before handing them back to the user. (flutter/engine#43274)
2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from 02292814a9d3 to 9faf7059f9ef (7 revisions) (flutter/engine#43272)
2023-06-27 15619084+vashworth@users.noreply.github.com Update Xcode to 14.3.1 (flutter/engine#42930)
2023-06-27 jonahwilliams@google.com [Impeller] Add Vulkan allocator traces. (flutter/engine#43215)
2023-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bj_X2Se1zObk_l_CC... to Bvv7TyHm_VHUkndFx... (flutter/engine#43270)
2023-06-27 chinmaygarde@google.com [Impeller] Report pipeline creation feedback to logs and traces. (flutter/engine#43227)
2023-06-27 jonahwilliams@google.com [Impeller] Give Impeller a dedicated raster priority level worker loop. (flutter/engine#43166)
2023-06-27 jason-simmons@users.noreply.github.com [Impeller] Fixes for GLES color mask setup (flutter/engine#43225)
2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from cba77bceb26c to 02292814a9d3 (1 revision) (flutter/engine#43224)
2023-06-27 skia-flutter-autoroll@skia.org Roll Skia from 370132bcadb1 to 5209dc7702d0 (1 revision) (flutter/engine#43223)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bj_X2Se1zObk to Bvv7TyHm_VHU
fuchsia/sdk/core/mac-amd64 from ytzCCSvHY1lH to sBFKkha8HNLZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7408a5ff

Update labeler yaml (#129676) · 7587eeaa

Ricardo Amador authored Jun 27, 2023

Update the labeler yaml to correct syntax and whitespace.

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7587eeaa

Revert "Fix the matcher condition where multiple matchers are found" (#129675) · 4ca398db
Ricardo Amador authored Jun 27, 2023
```
Reverts flutter/flutter#129670
```
4ca398db
Revert "Labeler format to remove extra single quote" (#129674) · 93b61eff
Ricardo Amador authored Jun 27, 2023
```
Reverts flutter/flutter#129672
```
93b61eff
Revert "Update labeler.yml to v5.0.0-beta.1" (#129673) · 264526db
Ricardo Amador authored Jun 27, 2023
```
Reverts flutter/flutter#129617
```
264526db

Labeler format to remove extra single quote (#129672) · 8ccb71da

Ricardo Amador authored Jun 27, 2023

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ccb71da

Fix the matcher condition where multiple matchers are found (#129670) · ea449c33

Ricardo Amador authored Jun 27, 2023

Something reformatted the labeler file and removed the any formatter
conditions on the label matchers.

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

ea449c33

Automatically migrate ClipboardData.text to non-null (#129567) · 5a5b58a9

Loïc Sharma authored Jun 27, 2023

https://github.com/flutter/flutter/pull/122446 was a breaking change in Flutter 3.10 that made the `ClipboardData` constructor's `text` argument a required non-nullable argument. This leverages `dart fix`'s new automatic migration to, well, automatically migrate affected users.

Manual migration docs: https://docs.flutter.dev/release/breaking-changes/clipboard-data-required

Follow-up to https://github.com/flutter/flutter/pull/122446
Part of https://github.com/flutter/flutter/issues/121976

5a5b58a9

Remove Editable.onCaretChanged callback (#109114) · ca6f23e8
Tomasz Gucio authored Jun 27, 2023

ca6f23e8

Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69

Ben Konyi authored Jun 27, 2023

Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)

**Original Description:**

> Service extensions are unable to handle requests when the isolate they
were registered on is paused. The DevTools launcher logic was waiting
for some service extension invocations to complete before advertising
the already active DevTools instance, but when --start-paused was
provided these requests would never complete, preventing users from
using DevTools to resume the paused isolate.
> 
> Fixes https://github.com/flutter/flutter/issues/126691

**Additional changes in this PR:**

The failures listed in https://github.com/flutter/flutter/pull/128117
appear to be related to a shutdown race. It's possible for the test to
complete while the tool is in the process of starting and advertising
DevTools, so we need to perform a check of `_shutdown` in
`FlutterResidentDevtoolsHandler` before advertising DevTools.

Before the original fix, this check was being performed immediately
after invoking the service extensions, which creates an asynchronous gap
in execution. With #126698, the callsite of the service extensions was
moved and the `_shutdown` check wasn't, allowing for the tool to attempt
to advertise DevTools after the DevTools server had been cleaned up.

---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

5ea2be69

Update Xcode to 14.3.1 (#129024) · 9531cd40
Victoria Ashworth authored Jun 27, 2023
```
Framework part of https://github.com/flutter/flutter/issues/129019
```
9531cd40

Adds `dart_fix` support to `integration_test` (#129579) · 321abcbe

pdblasi-google authored Jun 27, 2023

* Adds fix for `IntegrationTestWidgetsFlutterBinding.runTest(timeout)` to support first round of deprecations for `flutter_test`

Resolves #124346

321abcbe

Update labeler.yml to v5.0.0-beta.1 (#129617) · b359e907
Casey Hillers authored Jun 27, 2023
```
https://github.com/flutter/flutter/issues/128440
```
b359e907

iOS TextSelectionToolbar fidelity (#127757) · a90c33fd

Luccas Clezar authored Jun 27, 2023

CupertinoTextSelectionToolbar is different from the native one, with some UI and UX issues. More details on the linked issue.

https://github.com/flutter/flutter/issues/127756

Currently the only problem that I listed on the linked issue that I couldn't fix was the horizontal scrolling, but to workaround this I added a GestureDetector to change pages when swiping the toolbar. It's not exactly the same as native as there is no scroll animation, but it works.

I'm creating this PR a little early to have some feedback as these changes were more complex than the ones in my last PR. Probably best if @justinmc is involved ð

|Version|Video|
|-|-|
|Flutter Old|<video src="https://github.com/flutter/flutter/assets/12024080/7cf81075-46ec-4970-b118-cc27b60ddac0"></video>|
|Flutter New|<video src="https://github.com/flutter/flutter/assets/12024080/c9e27a53-f94c-4cb0-9b76-e47b73841dcb"></video>|
|Native|<video src="https://github.com/flutter/flutter/assets/12024080/468c7d5b-ba93-4bd4-8f6e-8ec2644b9866"></video>|

a90c33fd

Make a paragraph test involving Chinese characters work with inconsistent host... · 3e66c86a

Jason Simmons authored Jun 27, 2023

Make a paragraph test involving Chinese characters work with inconsistent host system fonts (#129628)

Text tests are run using the Ahem font, and test host environments such
as LUCI may not provide a fallback font for Chinese glyphs.

3e66c86a

Roll Packages from 6b70804799a9 to f89ce028d764 (7 revisions) (#129630) · 4b238d54

engine-flutter-autoroll authored Jun 27, 2023

https://github.com/flutter/packages/compare/6b70804799a9...f89ce028d764

2023-06-27 hansmuller@google.com Updated
rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316)
2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new
`clearWithParameters` and `getAllWithParameters` methods to platform
interface. (flutter/packages#4261)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from
042c0366 to 96a2c053 (60 revisions) (flutter/packages#4313)
2023-06-26 10687576+bparrishMines@users.noreply.github.com
[file_selector_android] Create initial Android implementation of the
file_selector package (flutter/packages#3814)
2023-06-26 49699333+dependabot[bot]@users.noreply.github.com
[in_app_pur]: Bump org.json:json from 20230227 to 20230618 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#4244)
2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the
`isInspectable` to `WebKitWebViewController`. (flutter/packages#3984)
2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy
project (flutter/packages#4306)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b238d54

Roll Flutter Engine from 715eff211a42 to f320b8c36fee (6 revisions) (#129599) · 7dbdacff

engine-flutter-autoroll authored Jun 27, 2023

https://github.com/flutter/engine/compare/715eff211a42...f320b8c36fee

2023-06-27 ditman@gmail.com [web] Removes patchCanvasKitModule. (flutter/engine#42941)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from cafbf6e2660f to cba77bceb26c (1 revision) (flutter/engine#43222)
2023-06-26 bdero@google.com [Impeller] Fix CPU Porter-Duff blends (flutter/engine#43217)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from c1effc01211e to 370132bcadb1 (2 revisions) (flutter/engine#43221)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 4a4b13cc6931 to cafbf6e2660f (2 revisions) (flutter/engine#43219)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 4ae209493390 to c1effc01211e (4 revisions) (flutter/engine#43218)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7dbdacff

Fix chinese text is not selected by long press (#129320) · 9459f1c5

hangyu authored Jun 27, 2023

issue:#126652

in Chinese text, word length is 1 and (position.offset == word.end) happens a lot.

Update if (position.offset >= word.end) to if (position.offset > word.end) to resolve the issue that Chinese characters are not selected.

9459f1c5

26 Jun, 2023 2 commits

Roll Flutter Engine from 0da06de991a9 to 715eff211a42 (4 revisions) (#129593) · 2e5a255b

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/0da06de991a9...715eff211a42

2023-06-26 58529443+srujzs@users.noreply.github.com Refactor JSNumber.toDart and Object.toJS (flutter/engine#43149)
2023-06-26 jonahwilliams@google.com [Impeller] Treat SubOptimalKHR as rotated. (flutter/engine#43214)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from f6c7dc891859 to 4a4b13cc6931 (12 revisions) (flutter/engine#43213)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 632fa401098d to 4ae209493390 (3 revisions) (flutter/engine#43212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e5a255b

Fix syntax error in no-response (#129588) · 9f1809b5

godofredoc authored Jun 26, 2023

The comma needs to be enclosed in the quotes.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

9f1809b5