Commits · 7b300f07574d42c1a24d79225da22a067af2e04b · abdullh.alsoleman / Front-End

02 Dec, 2023 1 commit

Reverts "Retry on transient Skia failure." (#139407) · 7b300f07

auto-submit[bot] authored Dec 02, 2023

Reverts flutter/flutter#139182
Initiated by: Hixie
This change reverts the following previous change:
Original Description:
This works around https://g-issues.skia.org/issues/40044713 using exponential backoff.

This is completely untested because I have no idea how to test it.

Also I only changed one of the code paths here. I figure if we get success here then we can start propagating the change to other places in this file that generate errors, maybe factoring out the retry and error reporting logic so it's not duplicated multiple times.

7b300f07

01 Dec, 2023 14 commits

Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (#139397) · e047f276

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/162ad29a576f...4d19fedb7617

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from d55911b49773 to 9277bdf97d06 (1 revision) (flutter/engine#48583)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e047f276

[l10n] Update Material shareButtonLabel (#138899) · b6fa0418

Bruno Leroux authored Dec 01, 2023

## Description

This PR updates the Material label for the share option, currently it is "**Share...**" (the expected label on iOS), on Android it should be "**Share**".

Native Android TextField screenshot:

![Capture dâÃ©cran du 2023-11-20 17-19-02](https://github.com/flutter/flutter/assets/840911/6004b900-0ba4-441e-a814-4afd0c0e2fe2)

## Related Issue

Step 2 for https://github.com/flutter/flutter/issues/138728

## Tests

Adds 1 test.

b6fa0418

Retry on transient Skia failure. (#139182) · b2d90eb6

Ian Hickson authored Dec 01, 2023

This works around https://g-issues.skia.org/issues/40044713 using exponential backoff.

This is completely untested because I have no idea how to test it.

b2d90eb6

Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (#139394) · d7d1572f

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/820cb686d17d...162ad29a576f

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 14dceac9d276 to d55911b49773 (1 revision) (flutter/engine#48580)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d7d1572f

Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (#139390) · f808aaa1

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/00316e4b7680...820cb686d17d

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 5849e2b1aa8f to 14dceac9d276 (2 revisions) (flutter/engine#48577)
2023-12-01 skia-flutter-autoroll@skia.org Roll Dart SDK from d306bc3634c0 to a419c7050dcb (4 revisions) (flutter/engine#48578)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f808aaa1

Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (#139389) · 23b74b5a

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/95995c48d591...00316e4b7680

2023-12-01 15619084+vashworth@users.noreply.github.com Renable macOS 13 tests (flutter/engine#48418)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23b74b5a

Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (#139388) · 62c38e71

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/69f0e5550702...95995c48d591

2023-12-01 yjbanov@google.com [web] Implement multi-view for semantics (flutter/engine#48251)
2023-12-01 flar@google.com [Impeller] Fix size of squares in DrawPoints(PointMode). (flutter/engine#48547)
2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from ecf10008c8bd to 5849e2b1aa8f (2 revisions) (flutter/engine#48569)
2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 0ed7f26b3adb to ecf10008c8bd (1 revision) (flutter/engine#48568)
2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from e69fbf086bb6 to 0ed7f26b3adb (1 revision) (flutter/engine#48565)
2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 57c6a5a97dc5 to e69fbf086bb6 (1 revision) (flutter/engine#48562)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62c38e71

Added vscode-insiders path installed via snap (#137117) · cf71a55f

Kristijan Žic authored Dec 01, 2023

Closes  #137116

<b>Before</b>
VS Code Insiders installed via Snap isn't detected.

<b>After</b>
```sh
[â] VS Code (version 1.84.0-insider)
    â¢ VS Code at /snap/code-insiders/current/usr/share/code-insiders
    â¢ Flutter extension version 3.75.20231002
```

cf71a55f

Typo fix in dartdoc in tool test (#139386) · 7d9010c3

Mouad Debbar authored Dec 01, 2023

The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in https://github.com/flutter/tests/pull/317 and an
issue was filed at https://github.com/macosui/macos_ui/issues/499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.

7d9010c3

Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (#139348) · e5762baf

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/51ef7642750f...69f0e5550702

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from b7b02ebaf770 to 57c6a5a97dc5 (1 revision) (flutter/engine#48561)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e5762baf

Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (#139346) · 8f518573

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/894360cca1ec...51ef7642750f

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 0a90c366ff87 to b7b02ebaf770 (3 revisions) (flutter/engine#48559)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f518573

Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (#139345) · fb6a88ad

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/c26e6ced11df...894360cca1ec

2023-12-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bb2k375udWIltCEAx... to oPdJSBgOI25vZ9Jby... (flutter/engine#48558)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Bb2k375udWIl to oPdJSBgOI25v

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb6a88ad

Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (#139342) · be268ebd

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/74d2df52514a...c26e6ced11df

2023-12-01 matanlurey@users.noreply.github.com Roll a new version of googletest (2021->2023). (flutter/engine#48285)
2023-12-01 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add ImageFilter.compose (flutter/engine#48546)
2023-12-01 dnfield@google.com Avoid reloading the kernel snapshot when spawning an isolate in the same group (flutter/engine#48478)
2023-12-01 43054281+camsim99@users.noreply.github.com [Android] Check for text to paste before trying to retrieve data from URI (flutter/engine#48166)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 88a1bcb9e43e to 0a90c366ff87 (3 revisions) (flutter/engine#48549)
2023-11-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK to 3.3.0-174.2.beta (4 revisions) (flutter/engine#48538)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from db3399a541f3 to 88a1bcb9e43e (1 revision) (flutter/engine#48545)
2023-11-30 737941+loic-sharma@users.noreply.github.com [Windows] Begin decoupling text input plugin from the view (flutter/engine#47833)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2d236de89898 to db3399a541f3 (3 revisions) (flutter/engine#48543)
2023-11-30 flar@google.com [Impeller] Add direct tesselation of circles for DrawCircle and Round end caps (flutter/engine#48103)
2023-11-30 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Revert to `drawImage` rendering on Chrome 110 or earlier (flutter/engine#48515)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 6b4bdebaab88 to 2d236de89898 (1 revision) (flutter/engine#48537)
2023-11-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Started expanding the blur clip region (flutter/engine#48535)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0e479728cc1f to 6b4bdebaab88 (1 revision) (flutter/engine#48536)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0968fe18ff75 to 0e479728cc1f (1 revision) (flutter/engine#48534)
2023-11-30 103135467+sealesj@users.noreply.github.com Use Chromium mirror for archive dependency (flutter/engine#48509)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2f01d500a352 to 0968fe18ff75 (2 revisions) (flutter/engine#48531)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 11a15444a3aa to 2f01d500a352 (1 revision) (flutter/engine#48524)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 84fdd36b1eea to 11a15444a3aa (1 revision) (flutter/engine#48523)
2023-11-30 leroux_bruno@yahoo.fr [Android] Add support for the PlatformChannel "Share.invoke" command (flutter/engine#48265)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5d64b1322879 to 84fdd36b1eea (1 revision) (flutter/engine#48521)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 23721750e433 to 5d64b1322879 (1 revision) (flutter/engine#48520)
2023-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8wu5EgBh1yJPNOd5W... to Bb2k375udWIltCEAx... (flutter/engine#48519)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5a635f2211ce to 23721750e433 (1 revision) (flutter/engine#48514)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 928e8950e8e3 to 5a635f2211ce (1 revision) (flutter/engine#48511)
2023-11-29 mdebbar@google.com [web] No implicit view in multi-view mode (flutter/engine#48505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8wu5EgBh1yJP to Bb2k375udWIl

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be268ebd

Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (#139264) · b24f2fbf

engine-flutter-autoroll authored Dec 01, 2023

https://github.com/flutter/engine/compare/35939ca8534f...74d2df52514a

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 010883e6572c to
928e8950e8e3 (1 revision) (flutter/engine#48507)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b24f2fbf

30 Nov, 2023 10 commits

Add `undoStackModifier` to `UndoHistory` (#138674) · 75011b25

Renzo Olivares authored Nov 30, 2023

This change adds a feature to `UndoHistory` that allows the user to modify the value being pushed onto the undo stack.

This is used by the framework to ignore the composing region when pushing history entries to the Undo stack on Android. This is so an undo does not trigger an input connection restart by the Android TextInputPlugin, which occurs when the framework changes the composing region. This is also the native platform behavior observed in Google Keep app on Android, where doing an undo during composing reverts to the previous state but with composing inactive and a subsequent redo does not bring back the composing region.

Fixes #130881
Partial fix for #134398

75011b25

Migrate docs_test to shard. (#139282) · 8412adb9

godofredoc authored Nov 30, 2023

This is part of the deprecation of adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153

8412adb9

Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`,... · c10787bc

Tirth authored Nov 30, 2023

Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (#139258)

Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0`

Note: test for `cupertino_text_field.0` was already there but it was named `cupertino_text_field.0.dart`. I renamed it to `cupertino_text_field.0_test.dart`.

Part of #130459

c10787bc

Refactor prepare_package.dart (#139277) · 88710972

Christopher Fujino authored Nov 30, 2023

I plan to extend the prepare_package.dart script to upload the flutter preview device ([design doc](https://docs.google.com/document/d/1AzI-_Uk2v1LA2kKKFJ7gVD4xcakXJ6yVZiS5Ek6RHtg/edit#heading=h.byp03plw7mg9)).

However, given that that script is one large >1k line file, I decided to organize it into smaller libraries in this PR. There should be no behavioral change in this PR, this is a cleanup only. I made the following changes:

1. Created a //dev/bots/prepare_package/ directory to contain helper libraries
2. Moved everything but the `main()` function in //dev/bots/prepare_package.dart into one of 4 helper libraries under the new directory from step 1:
a. archive_creator.dart which contains the code that creates archive directory locally on disk
b. archive_publisher.dart which contains the code that uploads the archive to cloud storage
c. common.dart for shared constants and definitions
d. process_runner.dart for an abstraction over running sub-processes
3. Changed all definitions to `File` and `Directory` from `dart:io` to use the testable versions from `package:file`. This allowed me to use the `MemoryFileSystem` in the unit tests, rather than creating real temp file system directories.

88710972

Roll Packages from e4aaba833261 to bc72d15c95a5 (4 revisions) (#139307) · 995a020e

engine-flutter-autoroll authored Nov 30, 2023

https://github.com/flutter/packages/compare/e4aaba833261...bc72d15c95a5

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd4 to 5e5b5292 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

995a020e

Move Impeller tests on Pixel 7 Pro from staging to prod (#139280) · 918e3360

Zachary Anderson authored Nov 30, 2023

These tests are now expected to be reasonably stable, and increases in
flakiness should be reported as part of the regular flaky test triage
process.

918e3360

Introduce multi-touch drag strategies for `DragGestureRecognizer` (#136708) · d49dcaa6

xubaolin authored Nov 30, 2023

Fixes #11884

As #38926 pointed out, the current Flutter implementation of multi-finger drag behavior is different from iOS and Android.
This change introduces the `MultitouchDragStrategy` attribute, which implements the Android behavior and can be controlled through `ScrollBehavior`, while retaining the ability to extend iOS behavior in the future.

d49dcaa6

Use the correct recipe on fuchsia_precache. (#139279) · cae47c46

godofredoc authored Nov 30, 2023

To run shard tests we need to use flutter_drone recipe.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

cae47c46

Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (#139278) · 6c4475e7

auto-submit[bot] authored Nov 30, 2023

Reverts flutter/flutter#138896
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.

6c4475e7

Migrate fuchsia_precache to shard tests. (#139202) · c8101b56

godofredoc authored Nov 30, 2023

Adhoc tests are being deprecated and existing tests are being migrated to shard tests.

Bug: https://github.com/flutter/flutter/issues/139153

c8101b56

29 Nov, 2023 15 commits

Fix chips `onDeleted` callback don't show the delete button when disabled (#137685) · 4648f544

Taha Tesser authored Nov 29, 2023

fixes [Chips with `onDeleted` callback should show the delete button in the `disabled` state](https://github.com/flutter/flutter/issues/136638)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onSelected: null,
              isEnabled: false,
              onDeleted: () {},
            ),
            InputChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: false,
              onPressed: null,
              onDeleted: () {},
            ),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: null,
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/8bd458de-cfd2-44f0-a0dd-a8298938c61f" /> | <img src="https://github.com/flutter/flutter/assets/48603081/afca0684-b061-416b-b029-5316588c6888" /> |

4648f544

Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (#139259) · 023e5add

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/9a7e49d75411...35939ca8534f

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503)
2023-11-29 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475)
2023-11-29 jonnywang@google.com [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

023e5add

Refactor to use Apple system fonts (#137275) · e84f1296

Mitchell Goodwin authored Nov 29, 2023

Addresses #63507, and is a follow up to the engine PR https://github.com/flutter/engine/pull/46857

Changes the font family string when attempting to use Apple system fonts to the new proxies added by the engine. For the "Text" font this will be more secure in the future against possible changes to Apple's API. For the "Display" font, this will now work correctly when it didn't before.

I checked the letter spacing values against a native app for all font sizes between 17-28. I made a few adjustments to better match native, but especially for the "Text" font we were either really close, or close enough to not make a large breaking change to default fonts worth it.

| Before  | After |
| ------------- | ------------- |
| <img width="466" alt="Screenshot 2023-11-02 at 11 45 12â¯AM" src="https://github.com/flutter/flutter/assets/58190796/627ed8ac-d848-4f71-aa62-a467b8aac62d"> | <img width="383" alt="Screenshot 2023-11-02 at 11 46 25â¯AM" src="https://github.com/flutter/flutter/assets/58190796/9a502021-7d2b-4e14-98f1-86971b3830a5"> |

The smaller text in both the before and after should be the same. The large system font that Flutter used before was incorrect, which caused it to look more spread out. Now we use the correct font.

e84f1296

Dynamic view sizing (#138648) · 4f8a9914

Michael Goderbauer authored Nov 29, 2023

Towards https://github.com/flutter/flutter/issues/134501.

This change is based on https://github.com/flutter/engine/pull/48090. It changes the `RenderView` to be dynamically sized based on its content if the `FlutterView` it is configured with allows it (i.e. the `FlutterView` has loose `FlutterView.physicalConstraints`). For that, it uses those `physicalConstraints` as input to the layout algorithm by passing them on to its child (after translating them to logical constraints via the device pixel ratio). The resulting `Size` that the `RenderView` would like to be is then communicated back to the engine by passing it to the `FlutterView.render` call.

Tests will fail until https://github.com/flutter/engine/pull/48090 has rolled into the framework.

4f8a9914

Roll dependencies (#139203) · b4178125
Ian Hickson authored Nov 29, 2023
```
Removes video_player and scoped_model pins, rolls everything else to latest.
```
b4178125

add sourceTimeStamp to ScaleUpdateDetails (#135936) · 443d8617

yakagami authored Nov 29, 2023

This PR adds the ability to get the `sourceTimeStamp` from `ScaleUpdateDetails` in a `GestureScaleUpdateCallback` like so:

```dart
onScaleUpdate: (ScaleUpdateDetails details){
print(details.sourceTimeStamp);
}
```

`sourceTimeStamp` is necessary when tracking velocity eg.

```dart
VelocityTracker tracker = VelocityTracker.withKind(PointerDeviceKind.touch);
///...
onScaleUpdate: (ScaleUpdateDetails details){
tracker.addPosition(details.sourceTimeStamp!, details.focalPoint);
}
```

The docs say:

>Having both a pan gesture recognizer and a scale gesture recognizer is redundant; scale is a superset of pan. Just use the scale gesture recognizer.

Currently this is not entirely accurate, and should be fixed, as noted in https://github.com/flutter/flutter/issues/43833#issuecomment-548133779. This PR does not add `sourceTimeStamp` to `ScaleStartDetails` because it is more involved. Specifically, `ScaleStartDetails` can be created in `acceptGesture` which does not have access to the `PointerEvent` to get the `event.timeStamp` (https://github.com/flutter/flutter/blob/54fa25543243e3bf31af6af0c1fef6adabc1d5c1/packages/flutter/lib/src/gestures/scale.dart#L730C5-L730C5).

fixes https://github.com/flutter/flutter/issues/135873. See also https://github.com/flutter/flutter/issues/43833 which added delta and https://github.com/flutter/flutter/issues/49025 which added `numPointers` to `ScaleUpdateDetails` for the reason given above. `sourceTimeStamp` should probably be added to `ScaleStartDetails` as well because it exists in `DragStartDetails` and therefore in `onPanStart`.

I am not sure how to add tests for this, any input about this PR would be appreciated.

- [] All existing and new tests are passing.

443d8617

Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (#139250) · c864a556

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/222beb28a8eb...9a7e49d75411

2023-11-29 jonahwilliams@google.com [Impeller] fix order of operations in SkSL generated texture lookup. (flutter/engine#48488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c864a556

Remove deprecated `PlatformMenuBar.body` (#138509) · 62952891

Greg Spencer authored Nov 29, 2023

Part of https://github.com/flutter/flutter/issues/139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations

62952891

Migration for the `sendTiming` events for `package:unified_analytics` (#138896) · 60d5c8ab

Elias Yishak authored Nov 29, 2023

Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.

60d5c8ab

Roll Flutter Engine from 60b963930202 to 222beb28a8eb (2 revisions) (#139242) · 5e5b5292

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/60b963930202...222beb28a8eb

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498)
2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e5b5292

Roll Flutter Engine from eebbe7e15c7d to 60b963930202 (2 revisions) (#139237) · f53e68a1

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/eebbe7e15c7d...60b963930202

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from ca84147b3e4e to b9e2514a6fb6 (1 revision) (flutter/engine#48497)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 19fbbf73fa33 to ca84147b3e4e (1 revision) (flutter/engine#48496)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f53e68a1

Roll Packages from 3c054661a3a6 to e4aaba833261 (5 revisions) (#139232) · 85d311d6

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/packages/compare/3c054661a3a6...e4aaba833261

2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471)
2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483)
2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326)
2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265)
2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85d311d6

Update VelocityTracker (4) (#139166) · 8ba459ce

Kate Lovett authored Nov 29, 2023

This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291
Fixes https://github.com/flutter/flutter/issues/97761

1. The original change was reverted due to flakiness it introduced in tests that use fling gestures.
  * Using a mocked clock through the test binding fixes this now
2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. 
  * These leaks are now fixed
3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit.
  * The benchmark is now fixed

8ba459ce

Analyze against using Stopwatches in the framework (#138507) · 133711ba
Kate Lovett authored Nov 29, 2023

133711ba

Roll Flutter Engine from ecc9c7b6be7d to eebbe7e15c7d (1 revision) (#139225) · 4d8ae570

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/ecc9c7b6be7d...eebbe7e15c7d

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 89e844f3fc87 to 19fbbf73fa33 (1 revision) (flutter/engine#48494)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d8ae570