- 13 Oct, 2023 1 commit
-
-
Todd Volkert authored
Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument. For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 25 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 19 May, 2021 1 commit
-
- 18 May, 2021 1 commit
-
-
YeungKC authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Oct, 2020 1 commit
-
-
Matej Knopp authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 25 Aug, 2020 1 commit
-
-
chunhtai authored
-
- 18 Aug, 2020 1 commit
-
-
Mehmet Fidanboylu authored
This reverts commit 72619b86.
-
- 12 Aug, 2020 1 commit
-
-
chunhtai authored
-
- 17 Jun, 2020 1 commit
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 31 May, 2020 1 commit
-
-
Mehmet Fidanboylu authored
This reverts commit cd593dae.
-
- 29 May, 2020 1 commit
-
-
liyuqian authored
* Add clipBehavior to RenderFlex * Add clipBehavior to FittedBox * Add clipBehavior to Flex and FittedBox * Add clipBehavior to UnconstrainedBox * Add clipBehavior to Stack and Wrap * Add clipBehavior to TextEditable * Add clipBehavior to ListWheelScrollView * Add clipBehavior to SingleChildScrollView * Add clipBehavior to RenderViewportBase's widgets Those widgets are NestedScrollView and ShrinkWrappingViewport. * Fix tests * Remove enum Overflow and fix typo * Remove clipToSize * Analyze fix * Remove Mixin and other small fixes * Fix tests and respect Stack's default clipBehavior * Add Overflow back to make it non-breaking * Restore clipBehavior to make it non-breaking * Small fixes * Fix rebase
-
- 06 May, 2020 1 commit
-
-
Mjk authored
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-
- 25 Feb, 2020 1 commit
-
-
Ferhat authored
-
- 04 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/rendering * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 16 Jan, 2019 1 commit
-
-
Kyrel Jerome authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Apr, 2018 1 commit
-
-
Jonah Williams authored
* do not add run spacing if there are no run metrics
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2018 1 commit
-
-
Jason Simmons authored
-
- 08 Mar, 2018 1 commit
-
-
Jason Simmons authored
The first child fits on the line if the line can accomodate its width. After the first child the line needs room for the child's width plus spacing.
-
- 07 Mar, 2018 1 commit
-
-
Jonah Williams authored
* RenderWrap.performLayout takes should take spacing into consideration when deciding to move to next row/axis * fix spacing in text * remove dart:developer import * remove extra line
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 30 Aug, 2017 1 commit
-
-
Adam Barth authored
Fixes #11389
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-