- 10 Jan, 2017 1 commit
-
-
Adam Barth authored
This patch improves test coverage for a number of files that had low coverage. This patch also fixes a few minor bugs found by these tests.
-
- 06 Jan, 2017 1 commit
-
-
Ian Hickson authored
- more dartdocs for the drag typedefs - more toStrings to aid debugging - require the position for DragUpdateDetails since we were omitting it in some places - add the primaryVelocity to DragEndDetails so that consumers don't have to themselves track the axis in question - fix the velocity tracker so that it doesn't walk the null data. Previously, near time t=0 (which pretty much only matters in tests, but it does matter there) we would walk the velocity data and then also walk missing data, treating it as Point.zero with t=0. - simplify some of the velocity tracker; e.g. instead of trying (and failing?) to clear the velocity tracker when the pointer stalls, just drop the data before a stall during the velocity estimation (where we redundantly had another bigger horizon anyway).
-
- 19 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 16 Nov, 2016 2 commits
-
-
Adam Barth authored
-
Ian Hickson authored
I used the wrong identifiers here.
-
- 15 Nov, 2016 1 commit
-
-
Ian Hickson authored
See https://github.com/flutter/flutter/pull/6861 This silences all but two of the warnings from https://travis-ci.org/flutter/flutter/builds/176055550 One of the silenced warnings was a genuine code error. Some of the others were correct but there was no way for the analyzer to know, and I worked around them. The remainder are problems with the analyzer, specifically https://github.com/dart-lang/sdk/issues/27827 and https://github.com/dart-lang/sdk/issues/27504.
-
- 01 Nov, 2016 1 commit
-
-
Chris Bracken authored
-
- 28 Oct, 2016 1 commit
-
-
Jason Simmons authored
If a recognizer is interrupted by an exception from a callback, it could be left in an inconsistent state and be unable to process future events
-
- 17 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes #1186
-
- 16 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously we would maroon the feedback in the overlay. Now we let the drag proceed and only tear down the gesture recognizer when all the drags it spawns have been resolved. Fixes #6151
-
- 15 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously we were relying on the gesture arena to call us back to cancel our timer. However, in the case where we've already been accepted, asking the gesture arena to reject us doesn't lead to a callback and we fail to stop the timer (and hence trigger an assert). Fixes #6156
-
- 04 Oct, 2016 1 commit
-
-
Hans Muller authored
-
- 03 Oct, 2016 1 commit
-
-
Hans Muller authored
-
- 30 Sep, 2016 1 commit
-
-
Adam Barth authored
Now dart:ui does the decoding of the pointer data itself, which means we don't need to do it in the framework.
-
- 21 Sep, 2016 1 commit
-
-
James Robinson authored
This rewrites imports of various mojom.dart files from the Flutter engine repo to instead import normal-looking dart files from the (new) flutter_services package. This package handles exporting the correct symbols from generated code wherever that may live. Includes an engine roll to 3551e7a48e2e336777b15c7637af92fd7605b6c5 which contains the new flutter_services package.
-
- 15 Sep, 2016 1 commit
-
-
Adam Barth authored
The engine now reports coordinates in physical pixels.
-
- 09 Sep, 2016 1 commit
-
-
Ian Hickson authored
I did a pass through some of the code cleaning minor things up.
-
- 02 Aug, 2016 1 commit
-
-
Hans Muller authored
-
- 07 Jul, 2016 1 commit
-
-
Adam Barth authored
Fixes #4761
-
- 01 Jul, 2016 1 commit
-
-
Adam Barth authored
This patch updates the framework to use the new SemanticAction in semantics.mojom.
-
- 27 Jun, 2016 2 commits
-
-
Adam Barth authored
This patch adds tests for some code paths we weren't hitting before and removes some dead code that couldn't be tested because it was unreachable.
-
Adam Barth authored
* Change how navigator prevents redundant operations Instead of requiring transactions, we now cancel all active pointers that are interacting with the navigator and absorb future pointers until we get a chance to build. This approach isn't perfect (e.g., events that trigger off the cancelled pointers could still interact with the navigator), but it should be better than the current transaction-based approach. Fixes #4716 * Remove openTransaction * test * fixup
-
- 20 Jun, 2016 1 commit
-
-
Adam Barth authored
In writing a test for #1927, I found a number of bugs in how Draggable shuts down. Previously it would leak its recongizer. Now it disposes its recognizer and the recognizer knows how to be disposed cleanly. Fixes #1927
-
- 09 Jun, 2016 1 commit
-
-
Adam Barth authored
Fixes #4428
-
- 07 Jun, 2016 2 commits
-
-
Adam Barth authored
We have these details objects for the same reason we now have drag details objects: future extensibility.
-
Adam Barth authored
We were trying to unregister the pointer route twice. Now we only unregister it once. Fixes #4341
-
- 03 Jun, 2016 3 commits
-
-
Adam Barth authored
I changed the behavior late in the code review but didn't update this dartdoc.
-
Adam Barth authored
This patch starts working through the missing dartdocs in widgets.dart.
-
Adam Barth authored
Previously we supplied individual parameters to the various drag and pan callbacks. However, that approach isn't extensible because each new parameter is a breaking change to the API. This patch makes a one-time breaking change to the API to provide a "details" object that we can extend over time as we need to expose more information. The first planned extension is adding enough information to accurately produce an overscroll glow on Android.
-
- 01 Jun, 2016 1 commit
-
-
Adam Barth authored
This patch starts using the mustCallSuper annotation for several of the key lifecycle callbacks in the framework. I haven't added it to didUpdateConfig because there are a large number of non-compliant overrides. We should discuss whether we want to use it there.
-
- 27 May, 2016 1 commit
-
-
Adam Barth authored
We'll use this functionality to implement some subtle behaviors for tooltips.
-
- 25 May, 2016 1 commit
-
-
Adam Barth authored
For consistency. Fixes #4142
-
- 18 May, 2016 1 commit
-
-
Adam Barth authored
Also, make some previously private classes public for better documentation.
-
- 17 May, 2016 2 commits
-
-
Adam Barth authored
-
Adam Barth authored
Also, add some missing docs to http.dart and widgets.dart.
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 26 Apr, 2016 1 commit
-
-
Adam Barth authored
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes #3183
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 21 Apr, 2016 1 commit
-
-
Ian Hickson authored
* Refactor the Gesturer's interfaces This makes them more coherent. It also makes it easier for the tests to override each specific part of hit-testing, should that be necessary. * Update binding.dart
-
- 15 Apr, 2016 1 commit
-
-
Ian Hickson authored
We're getting back to the point where we have a bunch of foundation APIs and it's getting confusing having them mixed with services/.
-