1. 20 Sep, 2017 1 commit
  2. 31 Aug, 2017 1 commit
  3. 24 Aug, 2017 1 commit
  4. 10 Aug, 2017 1 commit
  5. 27 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Increase the touch slop. (#11419) · 87445e59
      Ian Hickson authored
      It was 8.0. It's now arbitrarily 18.0.
      
      Changing this required adjusting some tests. Adjusting the tests
      required debugging the tests. Debugging the tests required some tools
      to help debugging gesture recognizers and gesture arenas, so I added
      some. It also required updating some toString() methods which resulted
      in some changes to the tree diagnostics logic.
      
      Also I cleaned up some docs while I was at it.
      87445e59
  6. 02 May, 2017 1 commit
    • Ian Hickson's avatar
      Tapping a ScrollView during overscroll got it stuck. (#9721) · f64bfba8
      Ian Hickson authored
      Fixes https://github.com/flutter/flutter/issues/8476
      
      More detailed list of changes in this patch:
      
      * Replaced the didTouch special logic with more generic logic that
        uses Activities instead. Now instead when you tap down the
        Scrollable calls `hold()` which begins a HoldScrollActivity which is
        a hybrid of DragStartDetails and IdleScrollActivity and can be
        canceled. When you let go, it gets canceled and that goes ballistic.
      
      * Make DragGestureRecognizer more aggressive about grabbing pointers,
        otherwise a second pointer in a situation with competing horizontal
        and vertical recognizers always gets taken by the other one.
      
      * Fixed the _GestureSemantics widget to call the "down" callbacks so
        that it follows the same pattern as "real" interactions.
      
      * Added tests for the above.
      
      * Added a hashCode to ScrollActivity.toString (and subclasses).
      
      * Added a toString to ScrollDragController, and include it in
        DragScrollActivity's toString.
      
      * s/coorindator/coordinator/
      
      * Add a comment in DragStartDetails to distinguish it from the
        otherwise identical DragDownDetails, so we're not tempted to merge
        them.
      f64bfba8
  7. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  8. 04 Mar, 2017 1 commit
  9. 06 Jan, 2017 1 commit
    • Ian Hickson's avatar
      Changes to the drag gesture detectors and the velocity tracker (#7363) · 11d1d54c
      Ian Hickson authored
      - more dartdocs for the drag typedefs
      
      - more toStrings to aid debugging
      
      - require the position for DragUpdateDetails since we were omitting it
        in some places
      
      - add the primaryVelocity to DragEndDetails so that consumers don't
        have to themselves track the axis in question
      
      - fix the velocity tracker so that it doesn't walk the null data.
        Previously, near time t=0 (which pretty much only matters in tests,
        but it does matter there) we would walk the velocity data and then
        also walk missing data, treating it as Point.zero with t=0.
      
      - simplify some of the velocity tracker; e.g. instead of trying (and
        failing?) to clear the velocity tracker when the pointer stalls,
        just drop the data before a stall during the velocity estimation
        (where we redundantly had another bigger horizon anyway).
      11d1d54c
  10. 27 Jun, 2016 1 commit
  11. 03 Jun, 2016 1 commit
    • Adam Barth's avatar
      Convert drag gestures to use details objects (#4343) · 2d4acb80
      Adam Barth authored
      Previously we supplied individual parameters to the various drag and pan
      callbacks. However, that approach isn't extensible because each new
      parameter is a breaking change to the API.
      
      This patch makes a one-time breaking change to the API to provide a
      "details" object that we can extend over time as we need to expose more
      information. The first planned extension is adding enough information to
      accurately produce an overscroll glow on Android.
      2d4acb80
  12. 16 May, 2016 1 commit
    • Ian Hickson's avatar
      Make it possible to run tests live on a device (#3936) · 32527017
      Ian Hickson authored
      This makes it possible to substitute 'flutter run' for 'flutter test'
      and actually watch a test run on a device.
      
      For any test that depends on flutter_test:
      
      1. Remove any import of 'package:test/test.dart'.
      
      2. Replace `testWidgets('...', (WidgetTester tester) {`
            with `testWidgets('...', (WidgetTester tester) async {`
      
      3. Add an "await" in front of calls to any of the following:
          * tap()
          * tapAt()
          * fling()
          * flingFrom()
          * scroll()
          * scrollAt()
          * pump()
          * pumpWidget()
      
      4. Replace any calls to `tester.flushMicrotasks()` with calls to
         `await tester.idle()`.
      
      There's a guarding API that you can use, if you have particularly
      complicated tests, to get better error messages. Search for
      TestAsyncUtils.
      32527017
  13. 26 Apr, 2016 1 commit
    • Adam Barth's avatar
      Delay win-by-default in gesture arena (#3552) · 51b1550d
      Adam Barth authored
      Wait until the end of the microtask to tell gesture recognizers that
      they've won in the gesture arena. This lets recognizers dispose reject
      themselves at arbitrary times without triggering gestures in awkward
      call stacks.
      
      Fixes #3183
      51b1550d
  14. 22 Apr, 2016 1 commit
  15. 12 Mar, 2016 1 commit
  16. 25 Feb, 2016 1 commit
    • Adam Barth's avatar
      Remove PointerRouter and GestureArena arguments · 4b1a9ff1
      Adam Barth authored
      There's no reason to make clients supply a PointerRounter and a
      GestureArena when constructing gesture recognizers. These objects are
      statics and the gesture recognizers can just grab them directly.
      
      Also, remove the callback constructor arguments. Almost no code used
      them. Instead, people seem to prefer using the `..` operator to set
      callbacks on the recognizers. Removing the arguments removes a bunch of
      boilerplate.
      4b1a9ff1
  17. 14 Feb, 2016 1 commit
    • Adam Barth's avatar
      Add a Velocity class to be explicit about units · 4fb47600
      Adam Barth authored
      We were using an Offset, which represented pixels/second, but it wasn't
      clear to clients whether that was pixels/ms. Now we use a Velocity class
      that is explict about the units.
      
      Fixes #1510
      Fixes #785
      4fb47600
  18. 16 Dec, 2015 1 commit
  19. 14 Dec, 2015 1 commit
  20. 05 Dec, 2015 1 commit
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556
  21. 23 Nov, 2015 1 commit
  22. 27 Oct, 2015 1 commit
  23. 14 Oct, 2015 1 commit
  24. 13 Oct, 2015 1 commit
  25. 10 Oct, 2015 3 commits
  26. 17 Sep, 2015 1 commit
    • Adam Barth's avatar
      Create gestures.dart · 41b8ffd6
      Adam Barth authored
      This patch is part of a sequence of patches towards fewer top-level libraries.
      In this patch, the gesture libraries are combined into one gestures.dart
      library.
      41b8ffd6
  27. 16 Sep, 2015 1 commit
    • Adam Barth's avatar
      Move Drawer to GestureDetector · 74f7d9ef
      Adam Barth authored
      This fixes an issue in the stocks app in horizontal mode where you could both
      scroll and drag the drawer at the same time.
      74f7d9ef
  28. 11 Sep, 2015 1 commit
  29. 10 Sep, 2015 1 commit
    • Adam Barth's avatar
      Fold fling gesture into onDragEnd · 63101e49
      Adam Barth authored
      That way the fling engages in the same direction as the scroll. For example, if
      you have a horizontal scroll nested inside a vertical scroll, the fling will
      take place in the same direction as the scroll.
      63101e49
  30. 08 Sep, 2015 1 commit
  31. 30 Aug, 2015 1 commit
    • Adam Barth's avatar
      Scrolls should start immediately when possible · bef55951
      Adam Barth authored
      If there are no other gestures in the arena, we should kick off the scroll
      gesture right away. This change pulled a refactoring of how we dispatch events
      to Widgets. Now we dispatch events to Widgets interleaved with their associated
      RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
      bef55951
  32. 29 Aug, 2015 1 commit
  33. 28 Aug, 2015 2 commits