- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 09 Nov, 2020 1 commit
-
-
Kate Lovett authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-
- 25 Feb, 2020 1 commit
-
-
Ferhat authored
-
- 22 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Jan, 2020 1 commit
-
-
Kate Lovett authored
-
- 27 Nov, 2019 2 commits
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
LongCatIsLooong authored
-
- 26 Nov, 2019 1 commit
-
-
Kate Lovett authored
-
- 15 Nov, 2019 1 commit
-
-
LongCatIsLooong authored
Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" (#44778) * Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" This reverts commit 9aea03f4.
-
- 21 Aug, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 19 Jul, 2019 1 commit
-
-
Kate Lovett authored
Fixes the hasScrollBody flag not accounting for child size. Adds the ability to specify over-scroll behavior.
-
- 14 Jun, 2019 1 commit
-
-
Kate Lovett authored
* WIP * Fixing nested scroll view tests * Fixing nested scroll view tests * Fixing nested scroll view tests * WIP * Added flag for SliverFillRemaining * Clean up * Review * Reverted nested scroll view tests * Updating tests * Updated for overscroll behavior
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Dec, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Apr, 2017 1 commit
-
-
Ian Hickson authored
-
- 05 Apr, 2017 1 commit
-
-
Ian Hickson authored
-