- 03 Nov, 2023 27 commits
-
-
Daco Harkes authored
Pin the dependencies from dart-lang/native to a specific version during testing (rather than having them auto-upgrade during pub resolution). This will prevent tests using the template to start failing if a bad version is published to pub. Closes: https://github.com/flutter/flutter/issues/137418 Also bumps dep in flutter_tools.
-
Chris Bracken authored
Background: In the framework, the position of the caret rect is updated on each cursor position change such that if the user initiates composing input, the current cursor position can be used for the first character until the composing rect can be sent. Previously, no update was sent on selection changes, on the assumption that the most recent cursor position will remain the correct position for the duration of the selection. While this is the case for forward selections, it is an incorrect assumption for reversed selections, where selection.base > selection.extent. We now update the cursor position during selection changes such that the cursor position sent to the embedder is always the position at which next text input would occur. This is the start position of the selection or min(selection.baseOffset, selection.extentOffset). Issue: https://github.com/flutter/flutter/issues/137677
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/677040f10f65...035740c1f90e 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666) 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from y-hqwYkPPVT6RwmAS... to 5GLArzquQ4eL56vdy... (flutter/engine#47667) 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663) 2023-11-03 flar@google.com [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ho9FqsUD0hxh to 8tJt8KJzTzbw fuchsia/sdk/core/mac-amd64 from y-hqwYkPPVT6 to 5GLArzquQ4eL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Chris Bobbe authored
As discussed at https://github.com/flutter/flutter/pull/133007#issuecomment-1743916183, this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f363a6e5e093...677040f10f65 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from ee6dbb4e2592 to c0ca9f2fd828 (1 revision) (flutter/engine#47660) 2023-11-03 zanderso@users.noreply.github.com Move //third_party/benchmark to //flutter/third_party/benchmark (flutter/engine#47652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#137191 Initiated by: camsim99 This change reverts the following previous change: Original Description: Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d5ccb5b1b706...f363a6e5e093 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 75507da748f9 to ee6dbb4e2592 (1 revision) (flutter/engine#47659) 2023-11-03 30870216+gaaclarke@users.noreply.github.com [Impeller] removed operator overload (c++ style violation) (flutter/engine#47658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/72262a238090...d5ccb5b1b706 2023-11-03 jonahwilliams@google.com [Impeller] add example of testing entity with "real" HAL instead of mocking. (flutter/engine#47631) 2023-11-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3c45f68cd7c2 to 529fcd5bdffc (3 revisions) (flutter/engine#47655) 2023-11-03 zanderso@users.noreply.github.com Reverts specialization constant PR and one change that used it (flutter/engine#47650) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hans Muller authored
Updated the NavigationBar API doc that describes examples/api/lib/material/navigation_bar/navigation_bar.2.dart and made some cosmetic changes to the example to improve its appearance in Material 3. Also did a little gratuitous reformatting. Fixes #136125
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0415a4f5e2a2...72262a238090 2023-11-03 godofredoc@google.com Upload debug symbols in engine v2 fuchsia build. (flutter/engine#47626) 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from b173066e6f15 to 75507da748f9 (2 revisions) (flutter/engine#47653) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8531c5935356...0415a4f5e2a2 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from e5a6f9e79b0a to b173066e6f15 (1 revision) (flutter/engine#47648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Adds some bottom sheet fixes and resizes oversized images.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/43653c5a3ec8...8531c5935356 2023-11-03 matej.knopp@gmail.com Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/33c2b4e53ad7...cccf5d24d703 2023-11-02 47866232+chunhtai@users.noreply.github.com [go_router] Fixes crashes when dynamically updates routing tables wit⦠(flutter/packages#5242) 2023-11-02 43054281+camsim99@users.noreply.github.com [camerax] Fix `_getResolutionSelectorFromPreset` NPE (flutter/packages#5287) 2023-11-02 ybz975218925@live.com [go_router]Fixes the problem what pathParameters is null in redirect when the Router is recreated. (flutter/packages#5258) 2023-11-02 stuartmorgan@google.com [google_sign_in] Fix Obj-C formatting bug (flutter/packages#5310) 2023-11-02 goderbauer@google.com Fix mounted checks (flutter/packages#5305) 2023-11-02 srawlins@google.com [flutter_image] [flutter_markdown] Do not use dynamic in an == operator override (flutter/packages#5298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Matej Knopp authored
https://github.com/flutter/engine/pull/46829 changed event handling sequence on web so that KeyboardBinding/RawKeyboard handles the text event first before it reaches IME. That means when dispatching synthetised events to IME every keydown event must have a corresponding keyup, otherwise consistency assertions in `KeyboardBindings` are triggered. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Binni Goel authored
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fc7c3f70c076...43653c5a3ec8 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 3db534b066e0 to e5a6f9e79b0a (1 revision) (flutter/engine#47642) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d1b29a1bea0b...fc7c3f70c076 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bhSlAQy4VM3Plrlh4... to y-hqwYkPPVT6RwmAS... (flutter/engine#47641) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from bhSlAQy4VM3P to y-hqwYkPPVT6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/78e8475ddbd7...d1b29a1bea0b 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 745825a18444 to 3db534b066e0 (1 revision) (flutter/engine#47640) 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from YS7vrarYI-cH to ho9FqsUD0hxh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e3f81ed27cc7...78e8475ddbd7 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 525a1487e501 to 745825a18444 (1 revision) (flutter/engine#47636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dff66925dcfa...e3f81ed27cc7 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 9f6022736b14 to 525a1487e501 (1 revision) (flutter/engine#47635) 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 5b6d295cc39b to 9f6022736b14 (1 revision) (flutter/engine#47633) 2023-11-03 jonahwilliams@google.com [Impeller] Use specialization constant for blur pipelines decal feature. (flutter/engine#47617) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/57768e18ed74...dff66925dcfa 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 3b8e2b391d03 to 5b6d295cc39b (1 revision) (flutter/engine#47630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dd620fcf9af7...57768e18ed74 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627) 2023-11-02 31859944+LongCatIsLooong@users.noreply.github.com Reland "Expose more methods on ui.Paragraph: lines" (#47584) (flutter/engine#47623) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
- 02 Nov, 2023 13 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d9b6245d3748...dd620fcf9af7 2023-11-02 flar@google.com [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592) 2023-11-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ef4ce9294299...d9b6245d3748 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 66e06117294e to 86d15e651ae0 (1 revision) (flutter/engine#47619) 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 94000281b7d6 to 66e06117294e (1 revision) (flutter/engine#47616) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Camille Simon authored
Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1e2eee05855f...ef4ce9294299 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614) 2023-11-02 godofredoc@google.com Remove mirroring workflow from engine. (flutter/engine#47603) 2023-11-02 athom@google.com Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Reid Baker authored
Fixes #137600 Protect flutter analyze --suggestions from null error when AGP value is missing Update template with a reference to new agp definition location Look for AGP version being set in settings.gradle (change to templates happened in https://github.com/flutter/flutter/commit/dbe0ccd8853dabdcb0f94ce2cdef892a1b10e48a#diff-20537fb84ee37894a3f3d9723a06bcf2674290ee25aa83332c2524a1f7546a6d
-
Gray Mackall authored
Fixes https://github.com/flutter/flutter/issues/130808. Short context is that the migration guide doesn't help when a user has a newer java version than 17, and this tells them how to fix the error in that situation. This is an alternative to https://github.com/flutter/flutter/pull/131354, because I think it is a bad idea to introduce branching in how we handle this error with some specialized regexp.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b11e318b3690...1e2eee05855f 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610) 2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606) 2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611) 2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Sam Rawlins authored
Also ignore one case where it is hard to fix. The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value. The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253. Fixes https://github.com/flutter/flutter/issues/137294 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Bartek Pacia authored
I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511. At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that. I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2ec0f74a1e8a...b11e318b3690 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608) 2023-11-02 jonahwilliams@google.com [Impeller] add support for specialization constants. (flutter/engine#47432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
godofredoc authored
This is the first of a series of changes to migrate to remove master-docs-flutter-dev GCP project. Bug: https://github.com/flutter/flutter/issues/133877
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/16d54bda1613...2ec0f74a1e8a 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561. The change referenced above tightens the `use_build_context_synchronously` to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up the flutter/flutter in preparation of this new enforcement.
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
