1. 16 Aug, 2019 1 commit
  2. 02 Jul, 2019 1 commit
  3. 27 Jun, 2019 1 commit
  4. 26 Jun, 2019 1 commit
  5. 20 Jun, 2019 1 commit
  6. 07 Jun, 2019 2 commits
  7. 06 Jun, 2019 1 commit
  8. 05 Jun, 2019 1 commit
  9. 04 Jun, 2019 1 commit
    • Gary Qian's avatar
      Text inline widgets, TextSpan rework (#33794) · 86862c1e
      Gary Qian authored
      * Merge in changes for inline widgets
      
      * Make analyzer happy, fix tests
      
      * Fix analyzer
      
      * Add missing doc
      
      * Docs on RichText
      
      * Fix analyzer some more
      
      * Remove whitespace at end of line
      
      * Update goldens
      
      * Text fixes
      
      * Analyzer
      86862c1e
  10. 31 May, 2019 1 commit
  11. 16 May, 2019 1 commit
  12. 09 May, 2019 1 commit
  13. 01 May, 2019 1 commit
  14. 05 Apr, 2019 1 commit
  15. 15 Mar, 2019 1 commit
    • Justin McCandless's avatar
      Text field height attempt 2 (#29250) · 6d8f5399
      Justin McCandless authored
      Adds the `minLines` and `expands` parameters for controlling text height.  The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
      6d8f5399
  16. 09 Mar, 2019 1 commit
  17. 08 Mar, 2019 1 commit
    • Justin McCandless's avatar
      Fix TextField height issues (#27205) · 9e9f48da
      Justin McCandless authored
      * Create new TextField attribute to control maxLength behaviour
      
      * Create test case for maxLinesIncrementalHeight
      
      * fix maxLinesIncrementalHeight set method
      
      * fix editable_test.dart
      
      * Just introducing some proposed API additions, renaming to expands
      
      * Pass minLines and expands through to child widgets and validate
      
      * minLines can't be null, and expands can't be true when maxLines is 1
      
      * Implement minLines and maxLines height sizing logic
      
      * Simplify minLines validation logic
      
      * expands parameter proof of concept
      
      * min/max mixup bug fix, and tests work with expands false
      
      * Test expands=true cases, and fix textPainter.height being out of date
      
      * Test all behavior matrix cases
      
      * min/max assertion more strict, can't be equal
      
      * Tests work that were missing expands serialization
      
      * Action sheet tests no longer fail due to rounding error
      
      * TextFieldFocus test no longer mysteriously fails
      
      * TODOs for making expands nullable. Will depend on how Expanded wrapping works
      
      * Expanded growth happens when expanded is true and maxLines is null
      
      * Test Expanded wrapper
      
      * No more overflow when wrapped in Expanded
      
      * Docs improvements
      
      * expands can be null
      
      * Simplify error cases to support existing behavior
      
      * Docs examples and other docs cleanup
      
      * Expansion up to perfectly meet the parent size
      
      * Fix analyze null error
      
      * Fix test after move to nullable expands
      
      * minLines defaults to null
      
      * expands is now exclusively for expanding to parent height and not growth between min and max
      
      * _layout rewritten to handle max height. Need to fix prefix tests and
      reenable expands
      
      * Tests for textfield overflowing parent
      
      * layoutLineBox is documented and private
      
      * expands works in new _layout
      
      * _layout return numbers seem to perfectly match original _layout
      
      * inputWidth comment after trying it out and failing tests
      
      * Fix analyze errors
      
      * WIP prefix/suffix do affect height
      
      * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original
      
      * Tall prefix test that verifies pixel perfect layout
      
      * Fix overflowing edge case and test it
      
      * Clean up comments, old code, and todos
      
      * Changing _expands causes relayout. Wasnt able to figure out how to test though...
      
      * Clean up code review comments
      
      * Fix misalignment when tall prefix and border, and clean up related test
      
      * Simple code review cleanup
      
      * Bring back inputWidth to _layout method
      
      * Fix rounding errors showing up in mac tests
      
      * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine.
      
      * Fix more rounding error mac tests
      9e9f48da
  18. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  19. 21 Feb, 2019 1 commit
  20. 15 Feb, 2019 1 commit
  21. 29 Jan, 2019 1 commit
  22. 23 Jan, 2019 1 commit
  23. 14 Nov, 2018 1 commit
  24. 08 Nov, 2018 1 commit
  25. 18 Oct, 2018 1 commit
  26. 17 Oct, 2018 1 commit
  27. 15 Oct, 2018 1 commit
    • Gary Qian's avatar
      Add support for text shadows and roll engine (26 commits) (#22449) · bdc3dda5
      Gary Qian authored
      * Add support for shadows in text.
      
      * Use dart:ui Shadow as base class for Shadows
      
      * Update lerp definition
      
      * Roll engine 3ffa3629523..84fe4a9f7e24e4 - Text Shadows and update goldens for skia roll.
      
      git log 50c2e69daff4e207c54e463d2304139985c7511c..32f417db0d566d354605305cb29c251276fa65ee --oneline --no-merges
      32f417db0 Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541)
      4ee77256c Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537)
      964acafeb Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536)
      d4bae4ca4 Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535)
      ff93ccf47 Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534)
      a4161c895 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532)
      116072e46 Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531)
      ef0b0f6e9 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530)
      f46b7b971 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529)
      9033c3902 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528)
      e6887a412 Add missing imports for unicode/utf16.h (#6524)
      1242f6dfe Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527)
      a1bbea77c Add a no-op platform view layer. (#6505)
      2bb3afad8 Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526)
      75e875240 Fix the Mac embedder build (#6525)
      436f9707b Add version check for dismissable (#6522)
      7767c785b Provide a default GL function resolver in the embedder (#6523)
      32841dd89 Case-insensitive matching of family names for custom fonts (#6519)
      a9076c7e6 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520)
      f2e7441b5 An API for loading fonts from a buffer provided by the application (#6508)
      05aac0f27 fix ResourceExtractor npe. (#6461)
      cf5a2a145 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517)
      84fe4a9f7 Re-revert invalid line height tests (#6516)
      5f529566c Add support for text shadows (#6385)
      e44c10c96 Reland "Share engine layers with the framework" (#6412) (#6468)
      ba0449971 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
      bdc3dda5
  28. 05 Oct, 2018 3 commits
  29. 04 Oct, 2018 1 commit
  30. 26 Sep, 2018 1 commit
  31. 12 Sep, 2018 1 commit
  32. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  33. 29 Jun, 2018 1 commit
  34. 21 Jun, 2018 1 commit
  35. 05 Jun, 2018 1 commit
  36. 31 May, 2018 1 commit
  37. 04 Apr, 2018 1 commit