Commits · 72080e60489f07ebb2dda2fa058e4617f30cedc1 · abdullh.alsoleman / Front-End

14 Nov, 2023 18 commits

Bump github/codeql-action from 2.22.5 to 2.22.6 (#138438) · 72080e60

dependabot[bot] authored Nov 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.5 to 2.22.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/689fdc5193eeb735ecb2e52e819e3382876f93f4"><code>689fdc5</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1990">#1990</a> from github/update-v2.22.6-8c8c7b4d8</li>
<li><a href="https://github.com/github/codeql-action/commit/33bfd1de925b3298f55b5df9d048a50f99ec63ec"><code>33bfd1d</code></a> Update changelog for v2.22.6</li>
<li><a href="https://github.com/github/codeql-action/commit/8c8c7b4d80b1c936356d9e6eafb7622e3d5c07bd"><code>8c8c7b4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1979">#1979</a> from github/aeisenberg/python-on-mac</li>
<li><a href="https://github.com/github/codeql-action/commit/64981bbb5a43eb8447be59c3b591d131e3d91f2d"><code>64981bb</code></a> Merge branch 'main' into aeisenberg/python-on-mac</li>
<li><a href="https://github.com/github/codeql-action/commit/e280207df7e8a23a01921824ff65d5e476d97df3"><code>e280207</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1978">#1978</a> from github/update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/e46740a99e0ff2eb0aac8fa7674cdbdd0cef0716"><code>e46740a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/6abf8569a19e2664b102b72b0ef9dd9f9a57a6ab"><code>6abf856</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1984">#1984</a> from github/aeisenberg/fix-debug-integration-tests</li>
<li><a href="https://github.com/github/codeql-action/commit/59252d9bfb0e66fde481d0102f2920f096385899"><code>59252d9</code></a> Update setup-swift deficiency compensation</li>
<li><a href="https://github.com/github/codeql-action/commit/dcf348a0d38952308a445163e94992084ed53799"><code>dcf348a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/82284f1b28654cb1dcfe26b6c02e0636ee633a07"><code>82284f1</code></a> Fix failing workflows</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/74483a38d39275f33fcff5f35b679b5ca4a26a99...689fdc5193eeb735ecb2e52e819e3382876f93f4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.5&new-version=2.22.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

72080e60

Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (#138429) · dfa694ec

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/eba757803a6f...f15b259fe98c

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 63037925e344 to 6feae2c274ce (1 revision) (flutter/engine#48033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dfa694ec

Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (#138425) · 3df477d0

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/603bdd48df8a...eba757803a6f

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 5fbacd5d68a5 to 63037925e344 (1 revision) (flutter/engine#48028)
2023-11-14 john@johnmccutchan.com Revert "Add an AndroidManifest.xml flag to disable ImageReader backend Platform Views (#46430)" (flutter/engine#48024)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ce88be2adf67 to 5fbacd5d68a5 (1 revision) (flutter/engine#48026)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df477d0

Unified analytics migration for `CodeSizeAnalysis` (#138351) · d5b67035

Elias Yishak authored Nov 14, 2023

Part of tracker issue:
- https://github.com/flutter/flutter/issues/128251

This migrates the event being sent when the "--analyze-size" is used in a flutter invocation

The only file that had this event being sent from is `packages/flutter_tools/lib/src/base/analyze_size.dart`

d5b67035

Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (#138421) · 44990867

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/777dcb99f6e0...603bdd48df8a

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from a811132be321 to ce88be2adf67 (1 revision) (flutter/engine#48022)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44990867

Run all tests in examples/ (#138374) · 0a0adf7c

Michael Goderbauer authored Nov 14, 2023

https://github.com/flutter/flutter/pull/138253 demonstrated that the tests for the textures example weren't actually running on CI. This changes the testing script to execute the tests for everything inside the `examples` directory.

0a0adf7c

Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (#138420) · 7f6842cd

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/1b3fd80812c3...777dcb99f6e0

2023-11-14 mdebbar@google.com [web] Explicit initialization of the implicit view (flutter/engine#47921)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from b7d581997f2b to a811132be321 (1 revision) (flutter/engine#48019)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f6842cd

Reland "Update `framework_test.dart` to remove `ButtonBar` usage and remove... · e8c2bb13

Taha Tesser authored Nov 14, 2023

Reland "Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases (#137550) (#137753)

This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to https://github.com/flutter/flutter/issues/127955

reland https://github.com/flutter/flutter/pull/137550

e8c2bb13

Consume flutter.js from the engine artifacts. (#137113) · 07d73630
Jackson Gardner authored Nov 14, 2023
```
Work in progress... currently testing against presubmit.
```
07d73630

Roll Flutter Engine from 995ebcefb0d4 to 1b3fd80812c3 (1 revision) (#138415) · 463c02da

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/995ebcefb0d4...1b3fd80812c3

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from f22c71596039 to b7d581997f2b (1 revision) (flutter/engine#48018)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

463c02da

Roll Packages from 17bd92e8a37d to 428ba3e24532 (2 revisions) (#138412) · ff728044

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/packages/compare/17bd92e8a37d...428ba3e24532

2023-11-13 stuartmorgan@google.com [pigeon] Remove semicolons from Kotlin generation (flutter/packages#5375)
2023-11-13 stuartmorgan@google.com [tool] Add Kotlin autoformatting (flutter/packages#5374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ff728044

Roll Flutter Engine from 712094481217 to 995ebcefb0d4 (1 revision) (#138409) · b356bb38

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/712094481217...995ebcefb0d4

2023-11-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UaodAPcg8HCGdDb-C... to AuDKY8ob6GrGwDlmk... (flutter/engine#48016)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UaodAPcg8HCG to AuDKY8ob6GrG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b356bb38

Roll Flutter Engine from 2c54b5f70c94 to 712094481217 (1 revision) (#138401) · e4bf14e3

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/2c54b5f70c94...712094481217

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ab1b506c68a2 to f22c71596039 (3 revisions) (flutter/engine#48009)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4bf14e3

Roll Flutter Engine from d100e8912eb0 to 2c54b5f70c94 (4 revisions) (#138399) · 9131d5de

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/d100e8912eb0...2c54b5f70c94

2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" (flutter/engine#48011)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 9a45d3d77b31 to ab1b506c68a2 (1 revision) (flutter/engine#48007)
2023-11-14 zanderso@users.noreply.github.com Move Skia to //flutter/third_party/skia (flutter/engine#47913)
2023-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) (flutter/engine#48006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9131d5de

Roll Flutter Engine from 74a9de45f128 to d100e8912eb0 (3 revisions) (#138383) · 6e9d4ccc

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/74a9de45f128...d100e8912eb0

2023-11-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 370145bbbd4f to 6219f11bf0fb (7 revisions) (flutter/engine#47998)
2023-11-14 matanlurey@users.noreply.github.com Make `display_list/...` compatible with `.clang_tidy`. (flutter/engine#47993)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from c5aef650e2b2 to 9a45d3d77b31 (1 revision) (flutter/engine#47997)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6e9d4ccc

Roll Flutter Engine from 77b952f3add4 to 74a9de45f128 (3 revisions) (#138382) · c34e637b

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/77b952f3add4...74a9de45f128

2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `fml/...` compatible with `.clang_tidy`." (flutter/engine#48004)
2023-11-13 matanlurey@users.noreply.github.com Make `fml/...` compatible with `.clang_tidy`. (flutter/engine#47992)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9ac5cad143ec to c5aef650e2b2 (3 revisions) (flutter/engine#47991)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c34e637b

Fixing typo (#138253) · 2189d4fd
Peter Abraham authored Nov 14, 2023

2189d4fd

Roll Flutter Engine from 046ec85dffc6 to 77b952f3add4 (1 revision) (#138377) · 924889c9

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/046ec85dffc6...77b952f3add4

2023-11-13 mdebbar@google.com [web] Cleanup touch and mouse event adapters (flutter/engine#43697)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

924889c9

13 Nov, 2023 12 commits

Roll Flutter Engine from db6da000a17e to 046ec85dffc6 (5 revisions) (#138375) · 87c32cee

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/db6da000a17e...046ec85dffc6

2023-11-13 godofredoc@google.com Fix fuchsia upload symbols. (flutter/engine#47938)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 1a39bd56cda2 to 9ac5cad143ec (3 revisions) (flutter/engine#47984)
2023-11-13 110993981+htoor3@users.noreply.github.com [web] - fix Safari textfield selection bug (flutter/engine#47917)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 17b6555a1551 to 1a39bd56cda2 (2 revisions) (flutter/engine#47980)
2023-11-13 jason-simmons@users.noreply.github.com Add a libcxxabi module that provides support for C++ thread-local storage (flutter/engine#47886)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

87c32cee

Finally remove analysis_options_user.yaml (#138261) · c4b706cd

Michael Goderbauer authored Nov 13, 2023

ð«¡

This was terribly outdated and has long been superseded by `package:flutter_lints`. Also, as of https://github.com/dart-lang/sdk/commit/c033718da0502ed92609f8c6cee2f6a59ccc058e support for this was removed from the analyzer and this file is now even more useless, if that's even possible.

Fixes https://github.com/flutter/flutter/issues/82948.

c4b706cd

Add a DevTools section to CONTRIBUTING.md (#137193) · 398590fe
Kenzie Davisson authored Nov 13, 2023
```
Mirrored change in the .github/ repo: https://github.com/flutter/.github/pull/34
```
398590fe

Update DraggableScrollableSheet docs to reflect API change (#136471) · 61c007a3

huycozy authored Nov 13, 2023

### Description

This PR intends to update `DraggableScrollableSheet` docs for Web and Desktop platforms. On these platforms, the vertical dragging gesture does not provide natural behavior similar to other desktop applications. 

By adding a note before the sample code so users are aware that the sample code will not work as expected on Desktop and Web. Also, refer to the instructions if they still want to implement it on these platforms.

### Related issue

Fixes https://github.com/flutter/flutter/issues/111372

61c007a3

Clean up synonyms, key code generation. (#138192) · 1b9cab71

Greg Spencer authored Nov 13, 2023

## Description

This cleans up how synonyms are calculated, and adds a reverse mapping from pseudo keys to the real keys they are synonyms of.

Updates the `layout_goals.json` to include the "Space" key, since that was added in the engine without updating the generation configuration.

1b9cab71

Roll Flutter Engine from 74ba6c17a488 to db6da000a17e (2 revisions) (#138364) · 5980342e

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/74ba6c17a488...db6da000a17e

2023-11-13 jonahwilliams@google.com [Impeller] Add convex tess benchmark. (flutter/engine#47956)
2023-11-13 jonahwilliams@google.com [engine] request frame rate once per frame. (flutter/engine#47954)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5980342e

Roll Flutter Engine from 5d62f1a2392a to 74ba6c17a488 (1 revision) (#138362) · a36821b5

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/5d62f1a2392a...74ba6c17a488

2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9c369abd687d to 17b6555a1551 (5 revisions) (flutter/engine#47975)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a36821b5

Roll Flutter Engine from 7de793d2bb68 to 5d62f1a2392a (1 revision) (#138358) · a681ff61

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/7de793d2bb68...5d62f1a2392a

2023-11-13 dacoharkes@google.com Revert "[deps] Stop moving NDK folder inside Android SDK (#47454)" (flutter/engine#47905)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a681ff61

Upgrade leak tracker. (#138283) · 793827d9
Polina Cherkasova authored Nov 13, 2023

793827d9

Roll Flutter Engine from fe11f3a46bac to 7de793d2bb68 (2 revisions) (#138353) · 749daa1a

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/fe11f3a46bac...7de793d2bb68

2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 7b730016006e to 9c369abd687d (3 revisions) (flutter/engine#47969)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 3a7a6d23ab4f to 7b730016006e (1 revision) (flutter/engine#47967)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

749daa1a

Roll Packages from a6821898bd5a to 17bd92e8a37d (2 revisions) (#138347) · f70a01c6

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/packages/compare/a6821898bd5a...17bd92e8a37d

2023-11-11 15619084+vashworth@users.noreply.github.com Only run tests on macOS 12 (flutter/packages#5369)
2023-11-10 tarrinneal@gmail.com [pigeon] Channel name in flutter error. (flutter/packages#5273)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f70a01c6

Roll Flutter Engine from a18ee3c7f57a to fe11f3a46bac (2 revisions) (#138344) · 4e77e7b1

engine-flutter-autoroll authored Nov 13, 2023

https://github.com/flutter/engine/compare/a18ee3c7f57a...fe11f3a46bac

2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 1e9711980c61 to 3a7a6d23ab4f (1 revision) (flutter/engine#47964)
2023-11-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from K3jvECt7y1_-zBVw3... to UaodAPcg8HCGdDb-C... (flutter/engine#47962)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from K3jvECt7y1_- to UaodAPcg8HCG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e77e7b1

12 Nov, 2023 1 commit

Roll Flutter Engine from 828e4dbf6693 to a18ee3c7f57a (7 revisions) (#138332) · 2e088178

engine-flutter-autoroll authored Nov 12, 2023

https://github.com/flutter/engine/compare/828e4dbf6693...a18ee3c7f57a

2023-11-12 zanderso@users.noreply.github.com Reverts Dart SDK to 3.3.0-120.0.dev (flutter/engine#47959)
2023-11-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ikCrJNCuuApNeuH-6... to K3jvECt7y1_-zBVw3... (flutter/engine#47958)
2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 6415489ae51b to 1a1b9cbc838a (1 revision) (flutter/engine#47952)
2023-11-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8sk2n2-NXJ-ceyc7T... to ikCrJNCuuApNeuH-6... (flutter/engine#47950)
2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from a03a7b62eb4e to 6415489ae51b (1 revision) (flutter/engine#47949)
2023-11-11 skia-flutter-autoroll@skia.org Roll Skia from 290962a9d913 to 1e9711980c61 (1 revision) (flutter/engine#47940)
2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 370145bbbd4f to a03a7b62eb4e (1 revision) (flutter/engine#47945)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8sk2n2-NXJ-c to K3jvECt7y1_-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e088178

11 Nov, 2023 5 commits

Roll Flutter Engine from e2e07eab35ec to 828e4dbf6693 (1 revision) (#138282) · e33d4b86

engine-flutter-autoroll authored Nov 11, 2023

https://github.com/flutter/engine/compare/e2e07eab35ec...828e4dbf6693

2023-11-11 skia-flutter-autoroll@skia.org Roll Skia from 7eaff63b1425 to 290962a9d913 (5 revisions) (flutter/engine#47937)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e33d4b86

Roll Flutter Engine from 1c29ce15c528 to e2e07eab35ec (1 revision) (#138280) · 453e20cd

engine-flutter-autoroll authored Nov 11, 2023

https://github.com/flutter/engine/compare/1c29ce15c528...e2e07eab35ec

2023-11-11 bdero@google.com [Flutter GPU] Add DeviceBuffer. (flutter/engine#47699)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

453e20cd

Roll Flutter Engine from aa6753fdbb51 to 1c29ce15c528 (1 revision) (#138277) · 89fde135

engine-flutter-autoroll authored Nov 11, 2023

https://github.com/flutter/engine/compare/aa6753fdbb51...1c29ce15c528

2023-11-11 15619084+vashworth@users.noreply.github.com Only run tests on macOS 12 (flutter/engine#47933)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

89fde135

Roll Flutter Engine from 00db306f6f7b to aa6753fdbb51 (1 revision) (#138269) · 9f08780e

engine-flutter-autoroll authored Nov 11, 2023

https://github.com/flutter/engine/compare/00db306f6f7b...aa6753fdbb51

2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 96ce4d6f433d to 7eaff63b1425 (1 revision) (flutter/engine#47932)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9f08780e

Roll Flutter Engine from 9d8a1125640d to 00db306f6f7b (7 revisions) (#138266) · 6f393ed3

engine-flutter-autoroll authored Nov 11, 2023

https://github.com/flutter/engine/compare/9d8a1125640d...00db306f6f7b

2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump minSdk to 19 for Android tests" (flutter/engine#47935)
2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 91c4a92a64ea to 370145bbbd4f (1 revision) (flutter/engine#47930)
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 2c43bf002b7f to 96ce4d6f433d (3 revisions) (flutter/engine#47931)
2023-11-10 flar@google.com [Impeller] implement Canvas::DrawLine to tesselate lines directly (flutter/engine#47846)
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from d06840545bff to 2c43bf002b7f (1 revision) (flutter/engine#47928)
2023-11-10 43091780+utzcoz@users.noreply.github.com Bump minSdk to 19 for Android tests (flutter/engine#47686)
2023-11-10 dnfield@google.com [Impeller] Reduce allocations for polyline generation (flutter/engine#47837)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f393ed3

10 Nov, 2023 4 commits

Only run tests on macOS 12 (#138260) · c0ca261e

Victoria Ashworth authored Nov 10, 2023

There's an https://github.com/flutter/flutter/issues/138238 with mac_toolchain that makes Xcode installs flakey and an https://github.com/flutter/flutter/issues/138246 that makes Xcode installs more frequent on macOS 13, which is causing presubmit tests to fall frequently. In the meantime, we'll only have tests run on macOS 12.

c0ca261e

Fixes vscode path installed via snap (#136997) · 0539c8bd

Kristijan Žic authored Nov 10, 2023

Fixes the #136996
Readresses the #54358

Before:
```sh
[✓] VS Code (version unknown)
    • VS Code at /snap/code/current
    • Flutter extension version 3.74.0
    ✗ Unable to determine VS Code version.
```

After:
```sh
[✓] VS Code (version 1.83.1)
    • VS Code at /snap/code/current/usr/share/code
    • Flutter extension version 3.74.0
```

*List which issues are fixed by this PR. You must list at least one
issue.*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0539c8bd

Docs typo: comprised -> composed (#137896) · 2c3c6b05
Ross Llewallyn authored Nov 10, 2023
```
This is a simple, common grammar issue. See here:
https://en.wikipedia.org/wiki/Comprised_of
```
2c3c6b05

Deprecates onWillAccept and onAccept callbacks in DragTarget. (#133691) · 0bde95dc

Chinmoy authored Nov 10, 2023

This PR deprecates `onWillAccept` and `onAccept` over `onWillAcceptWithDetails` and `onAcceptWithDetails`.

Fixes: #133347

0bde95dc