- 26 Oct, 2020 1 commit
-
-
Jonah Williams authored
Overhaul of flutter drive in order to deliver a better experience, namely: * flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. * Removes web-initialize-platform as this is no longer used * flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. * VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes * Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 23 Oct, 2020 1 commit
-
-
Jonah Williams authored
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845) This reverts commit 2e75f52a.
-
- 22 Oct, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451) Overhaul of flutter drive in order to deliver a better experience, namely: flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. Removes web-initialize-platform as this is no longer used flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 19 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 15 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Oct, 2020 1 commit
-
-
Jonah Williams authored
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
-
- 12 Oct, 2020 5 commits
-
-
Jonah Williams authored
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968) This reverts commit bd813879.
-
Jonah Williams authored
Reland of #67669 The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. So that we can adjust/modify this logic, fold it into flutter and add some additional logging. caches the resolved executable per target directory, to avoid repeated look ups. Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found Accept files or symlinks for the executable path. user where/which to resolve path instead of package:process logic.
-
Jonah Williams authored
This reverts commit 10c78c26.
-
Jonah Williams authored
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
-
Jonah Williams authored
HACKTOBERFEST
-
- 08 Oct, 2020 1 commit
-
-
Yegor authored
Work around the glibc bug that causes rare Chrome crashes
-
- 05 Oct, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] disable source maps by default for release builds, enable for run and with command line arg (#67331) Disables source map production by default for build web. For web builds performed as a part of flutter run --release, enable the source maps, or allow force enabling with --source-maps command line flag. fixes #67328
-
- 29 Sep, 2020 1 commit
-
-
Jonah Williams authored
Crash reporting shows at least one occurrence of this due to a windows file lock. That could happen if there is another running chrome instance, or perhaps a virus scanner is running. Print out the error and do not crash.
-
- 03 Sep, 2020 1 commit
-
-
Jonah Williams authored
Fix run release/profile modes generating a full service worker.
-
- 19 Aug, 2020 1 commit
-
-
Jonah Williams authored
Like Android/iOS, only enable --null-assertions if asked. Previously this was enabled by default for web, but in general this has proved to be too breaking to enable by default. #61042
-
- 20 Jul, 2020 1 commit
-
-
Helin Shiah authored
-
- 15 Jul, 2020 2 commits
-
-
Danny Tuppeny authored
-
Jonah Williams authored
Enable null safety asserts for web debug mode. This induces runtime asserts at the boundaries between null safe and non-null safe libraries. Adds integration test that validates assertion error is thrown. #61042
-
- 13 Jul, 2020 1 commit
-
-
Jonah Williams authored
Skip unnecessary parsing of chrome URI. Ensure stack traces are initialized in web server. Disclaimer on web server that it does not support debugging and remove help message. Fix generated entrypoint to check for main(List<String> args) - Fixes #59643 - Fixes #55084 - Fixes #60417
-
- 09 Jul, 2020 1 commit
-
-
Jonah Williams authored
run/attach --machine requires a different logger than daemon, which uses the NotifyingLogger. We have too many loggers! Fixes #59463
-
- 30 Jun, 2020 1 commit
-
-
Jonah Williams authored
In web debug mode, infer sound null safety by default. When sound null safety is enabled, provide a separate dill and precompiled Dart SDK. Release builds do not need this setting since we run dart2js from source. Fixes #59873
-
- 11 Jun, 2020 1 commit
-
-
Gary Roumanis authored
-
- 09 Jun, 2020 1 commit
-
-
Jonah Williams authored
Support Microsoft Edge as a device for flutter run when web is enabled. Currently this only works on Windows, and does not include a validator for edge. Fixes #55322
-
- 08 Jun, 2020 3 commits
-
-
Jenn Magder authored
-
Jonah Williams authored
instead of restricting profile/release mode based on whether the tool thinks the device is an emulator, restrict based on the device target architecture and the requested build mode. Notably, this enables release mode on x86_64 Android emulators, but not x86 emulators since we do not support that as an AOT target. This does not add release mode support for simulators, since this requires us to build and upload artifacts for simulator/x86_64
-
Jonah Williams authored
Instead of targets/dart.dart -> targets/common.dart
-
- 04 Jun, 2020 2 commits
-
-
Jonah Williams authored
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides. This allows removing a work around where web devices needed to look up directly from the context in non-test code. Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
-
Jonah Williams authored
Also combines experiments into extraGenSnapshot/ExtraFrontEndOptions. Allows providing --no-sound-null-safety to allow out of order migration and running.
-
- 27 May, 2020 1 commit
-
-
Jonah Williams authored
-
- 06 May, 2020 1 commit
-
-
Zachary Anderson authored
-
- 05 May, 2020 3 commits
-
-
Jonah Williams authored
Fixes #56194 Remove caching of FlutterView and poll forever if the list of flutter views is empty. Added test for missing release mode logic.
-
Jonah Williams authored
This reverts commit 209bdcb6.
-
Jonah Williams authored
Remove caching of FlutterView. Perhaps the FlutterView RPC might return an empty list if the VM is not quite up yet? We had some old logic to poll the flutter views RPC for up to 200ms. That doesn't seem like a great approach, so instead we could forgo it entirely and trust that either the views come up before the developer tries to interact, or we crash.
-
- 29 Apr, 2020 1 commit
-
-
Jonah Williams authored
Constructing the WebDevices with the global logger too early will lead to them grabbing the StdoutLogger when running in daemon mode. This prevents IDEs from seeing the correct debug message.
-
- 22 Apr, 2020 3 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
Jonah Williams authored
-
- 20 Apr, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-