- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 12 Apr, 2023 1 commit
-
-
xubaolin authored
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics
-
- 10 Apr, 2023 1 commit
-
-
Callum Moffat authored
Reduce macOS overscroll friction
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 10 Mar, 2023 1 commit
-
-
Greg Price authored
Document on ScrollPhysics the requirement to override applyTo
-
- 08 Mar, 2023 1 commit
-
-
Callum Moffat authored
No friction factor on macOS overscroll ease
-
- 16 Feb, 2023 1 commit
-
-
Greg Price authored
Fixes #120341. The scroll protocol makes an important assumption about the behavior of ScrollPhysics implementations, and this requirement hasn't been clearly documented. Add documentation for it. Parts of the text are modelled on similar language at StatelessWidget.build and StatefulWidget.build. It does feel a bit uncomfortable to juxtapose this description of a required invariant with three issues where the framework doesn't satisfy it. Fortunately two of them apply by default only in uncommon cases: #120340 macOS touchpad flinging, and #109675 never. The third is #120338, affecting default scrolling on Android and other non-Apple platforms. I'll send a PR to fix that shortly, and another for #109675. As discussed at #120338, it's quite possible we'll remove this invariant in the future. But that's been attempted before, and is complicated: the invariant is a useful one. Removing it would almost certainly involve a breaking change for ScrollPhysics subclasses. So I think even if we had an immediate plan to remove it, we'd need some kind of documentation for it, if only to explain the breaking change.
-
- 25 Jan, 2023 1 commit
-
-
Ahmed Ashour authored
* Remove superfluous words from comments. * Revert `win32_window.h` Which seems to come from `gallery`
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 03 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
This reverts commit c956121a.
-
- 27 Dec, 2022 1 commit
-
-
Xilai Zhang authored
This reverts commit 999356b7.
-
- 22 Dec, 2022 3 commits
-
-
Michael Goderbauer authored
* Revert "Revert "Remove single-view assumption from widgets library (#117480)" (#117545)" This reverts commit b8d5d9c4. * check for mounted
-
Michael Goderbauer authored
* Remove single-view assumption from ScrollPhysics * fix scrollable_dispose_test.dart * add deprecated method back
-
Michael Goderbauer authored
This reverts commit b8b35671.
-
- 21 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 22 Nov, 2022 1 commit
-
-
Callum Moffat authored
-
- 19 Sep, 2022 1 commit
-
-
Callum Moffat authored
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 17 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 24 Jan, 2022 1 commit
-
-
Kate Lovett authored
This reverts commit daef0825.
-
- 22 Jan, 2022 1 commit
-
-
nt4f04uNd authored
-
- 11 Nov, 2021 1 commit
-
-
nt4f04uNd authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 02 Jun, 2021 1 commit
-
-
Anis Alibegić authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Mar, 2021 1 commit
-
-
Hans Muller authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 16 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-