- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 24 Apr, 2023 1 commit
-
-
fzyzcjy authored
Just a one-word super tiny change, which I encounter today when playing with RawGestureDetector :) The original doc says: > For common gestures, use a [GestureRecognizer](https://api.flutter.dev/flutter/gestures/GestureRecognizer-class.html). [RawGestureDetector](https://api.flutter.dev/flutter/widgets/RawGestureDetector-class.html) is useful primarily when developing your own gesture recognizers. However, for "common gestures", IMHO the doc wants to say `GestureDetector` (because that one has easy-to-use onTap, onLongPress etc). On the other hand, GestureRecognizer should be used together with RawGestureDetector and is a quite low-level thing, and for common gestures people seldom use it. So I guess here it is a typo.
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 13 Feb, 2023 1 commit
-
-
xubaolin authored
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 06 Jan, 2023 1 commit
-
-
Callum Moffat authored
* trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 18 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 22 Jul, 2022 1 commit
-
-
Pedro Massango authored
-
- 21 Jul, 2022 1 commit
-
-
Callum Moffat authored
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 24 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 17 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Apr, 2022 1 commit
-
-
Callum Moffat authored
* Implement trackpad gestures in framework * Touch and Pan/Zoom pointers have separate IDs now * Handle trackpad pointer device type * Respect supportedDevices for pan/zoom events * Update after rebase * Fix check failures * Avoid error with very short drags * Address feedback * Refactor drag event handler * Address more feedback * Add some missing punctuation
-
- 25 Feb, 2022 2 commits
-
-
Craig Labenz authored
-
Jonah Williams authored
-
- 14 Jan, 2022 1 commit
-
-
Alberto authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 24 Jun, 2021 1 commit
-
-
Greg Spencer authored
This removes the broken video for GestureDetector, and replaces it with a Dartpad sample, for both samples in GestureDetector.
-
- 14 May, 2021 1 commit
-
-
xubaolin authored
-
- 04 May, 2021 1 commit
-
-
Todd Volkert authored
-
- 28 Apr, 2021 1 commit
-
-
Todd Volkert authored
This adds support for GestureDetector.onLongPressDown and GestureDetector.onLongPressCancel, allowing callers to register interest in the initial pointer contact that might turn into a long-press (and the associated cancel event if the gesture loses).
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 11 Mar, 2021 1 commit
-
-
Konstantin Scheglov authored
-
- 04 Feb, 2021 1 commit
-
-
Ian Hickson authored
-
- 24 Dec, 2020 1 commit
-
-
Darren Austin authored
-
- 22 Dec, 2020 1 commit
-
-
Justin McCandless authored
-
- 11 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 15 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* Reland "Nnbd widgets (#64672)" This reverts commit 127e6790. * remove non-nullable enforcement on AsyncSnapshot * make data param non-nullable for AsyncSnapshot.withData * make some Text params non-nullable
-
- 09 Sep, 2020 2 commits
-
-
Michael Goderbauer authored
This reverts commit e682ec71.
-
Alexandre Ardhuin authored
* migrate widget to nullsafety * remove double blank line after license * address review comments in actions.dart * nullable ObjectKey.value * use local variable oldElement * make State.build non-nullable * make State.context non-nullable * newline at eof * make ProxyWidget.child non-nullable * make _InactiveElements.debugContains non-nullable * make Element.depth non-nullable * make ProxyElement.build non-nullable * make StatefulElement.state non-nullable * remove 'Notice that' * avoid cast of list in RenderObjectElement.updateChildren * make IndexedSlot.value non-nullable * avoid cast of list in MultiChildRenderObjectElement.mount * make some WidgetsApp parameters non-nullable * hitTest take non-nullable position * make ScrollableState.position non-nullable * use _pixels instead of pixels * make ViewportOffset.pixels non-nullable * make param and return type of IndexedWidgetBuilder non-nullable * unused_import * make context param non-nullable for Builder in animated_list.dart * make ScrollMetrics.viewportDimension non-nullable * make ScrollMetrics.{min,max}ScrollExtent non-nullable * make _Location.file non-nullable * _WidgetForTypeTests.createElement throw UnimplementedError * update _NullWidget.build error message * make _ShortcutsState.manager non-nullable * Fix childCount issues for NNBD * fix childCount computation on web * increase max value on js side to compute childCount * make aspect parameter of dependOnInheritedWidgetOfExactType nullable * merge has{min,max}ScrollExtent into hasScrollExtents * update focus_manager.dart * address review comments in icon.dart * address review comments in image.dart * address review comments in routes.dart * address review comments in scroll_activity.dart * update doc comments * make UserScrollNotification.direction non-nullable and required * rename hasScrollExtents to hasContentDimensions * unnecessary late Co-authored-by:
Ian Hickson <ian@hixie.ch>
-
- 24 Aug, 2020 1 commit
-
-
Todd Volkert authored
* Add GestureDetector.onDoubleTapDown() * Review comments
-