- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 18 May, 2018 1 commit
-
-
Greg Spencer authored
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this. Only naming changes to private vars: no logic changes.
-
- 23 Apr, 2018 1 commit
-
-
Yegor authored
New a11y traversal: - sort direct sibling SemanticsNodes only - use new sorting algorithm - implement RTL - test semantics in traversal order by default - add AppBar traversal test - breaking: remove nextNodeId/previousNodeId from the framework - breaking: remove DebugSemanticsDumpOrder.geometricOrder
-
- 03 Apr, 2018 1 commit
-
-
Darshan Baid authored
-
- 22 Mar, 2018 2 commits
-
-
Ian Hickson authored
This is not a grand refactor yet, it's just cleaning up what we have already, so that people who keep using this API (e.g. dialogs) have something coherent to deal with. The major changes are that Navigator and NavigatorState have the same API now, that most of the examples use `<void>` instead of `<Null>`, that the navigator observer can see replaces, and that the `settings` is moved from ModalRoute to Route. I also cleaned up some of the API documentation.
-
Jonah Williams authored
* use HttpOverrides and dart:io HttpClient in flutter * add missing package:http dependency * update flutter packages and remove comment about createHttpClient from flutter_test * move byte loading logic to common class, move string parsing logic to base class * addAll doesn't work for a Uint8List * use bytes.setRange * undo addition to hello_world * add newline to end of binding.dart * and a newline for hello world * refactor to function and add tests * address comments on unknown length case * alignment * sort alaphabetically * rename convertResponse to consolidateClientHttpClientResponseBytes. Add header * fix alignment in test
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Mar, 2018 1 commit
-
-
Jason Simmons authored
-
- 14 Mar, 2018 1 commit
-
-
Jonah Williams authored
* replace child parameter with builder on showDialog * change builder parameter to WidgetBuilder * mark child as deprecated and expand documentation to cover this and how builder should be used * tidy comments and address some feedback * phrasing * move space to prev line and add //ignore comments for deprecated member use * address comments and fix it's its * update code samples * adds semicolon to code snippets
-
- 13 Mar, 2018 1 commit
-
-
Alexander Aprelev authored
This fixes https://github.com/flutter/flutter/issues/15458.
-
- 06 Feb, 2018 1 commit
-
-
Greg Spencer authored
This adds an API for defining the semantic node traversal order. It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined. It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key. The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
-
- 05 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Jan, 2018 1 commit
-
-
Vyacheslav Egorov authored
-
- 11 Jan, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Dec, 2017 1 commit
-
-
Leaf Petersen authored
Small code changes as part of moving the framework SDK forward to a 2.0 dev version.
-
- 22 Oct, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Oct, 2017 1 commit
-
-
Hans Muller authored
-
- 11 Oct, 2017 1 commit
-
-
Hans Muller authored
-
- 27 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Sep, 2017 1 commit
-
-
Hans Muller authored
* Make an app's supported locales configurable * Added an supportedLocales.isNotEmpty assert * WidgetsApp no longer const because supportedLocales.isNotEmpty * updated per review feedback * tweaked dartdoc to restart the build * updated per review feedback * Updated per review feedback
-
- 28 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* Semantic hit test order for Slivers * ++ * fix double space * refactoring * fix test * comment fix * tests * remove accidental debugDumpSemanticsTree * review comments * fix button
-
- 24 Aug, 2017 1 commit
-
-
Hans Muller authored
-
- 23 Jun, 2017 1 commit
-
-
Ian Hickson authored
The main purpose of this PR is to make it so that when you set the initial route and it's a hierarchical route (e.g. `/a/b/c`), it implies multiple pushes, one for each step of the route (so in that case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those routes don't exist, it falls back to '/'. As part of doing that, I: * Changed the default for MaterialApp.initialRoute to honor the actual initial route. * Added a MaterialApp.onUnknownRoute for handling bad routes. * Added a feature to flutter_driver that allows the host test script and the device test app to communicate. * Added a test to make sure `flutter drive --route` works. (Hopefully that will also prove `flutter run --route` works, though this isn't testing the `flutter` tool's side of that. My main concern is over whether the engine side works.) * Fixed `flutter drive` to output the right target file name. * Changed how the stocks app represents its data, so that we can show a page for a stock before we know if it exists. * Made it possible to show a stock page that doesn't exist. It shows a progress indicator if we're loading the data, or else shows a message saying it doesn't exist. * Changed the pathing structure of routes in stocks to work more sanely. * Made search in the stocks app actually work (before it only worked if we happened to accidentally trigger a rebuild). Added a test. * Replaced some custom code in the stocks app with a BackButton. * Added a "color" feature to BackButton to support the stocks use case. * Spaced out the ErrorWidget text a bit more. * Added `RouteSettings.copyWith`, which I ended up not using. * Improved the error messages around routing. While I was in some files I made a few formatting fixes, fixed some code health issues, and also removed `flaky: true` from some devicelab tests that have been stable for a while. Also added some documentation here and there.
-
- 07 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 May, 2017 1 commit
-
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/9342
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 21 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
- 20 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 08 Apr, 2017 1 commit
-
-
Dariusz Baciński authored
* generate_from_arb has been moved to intl_translantion library * fixed typo * added missing intl dependency * Regenerated language files with latest intl script * Added version to intl_translations * added isolate min version constraint
-
- 07 Apr, 2017 1 commit
-
-
Ian Hickson authored
Aggressively apply the const lint.
-
- 05 Apr, 2017 1 commit
-
-
Ian Hickson authored
This yak shave went as follows: Fix https://github.com/flutter/flutter/issues/8795 by adding stocks to the examples README. Notice the layers entry in that README isn't quite right either. Update that. Check the layers/README file is worth pointing at. Update the layers/README. Let's run some of the layer tests to see if they still work. Oops, need to update them to gradle. Ok let's try running them again. Oops, sector is broken. Add a test for sector. Fix sector. Find you need to add an assert to a const constructor. Notice we need to turn const asserts on for the analyzer. Notice the analysis_options files are out of sync with each other and with the full list of lints. Turn on the lints that should be on. Fix the bugs that finds.
-
- 02 Apr, 2017 1 commit
-
-
Adam Barth authored
After this patch, there are three major text input widgets: * EditableText. This widget is a low-level editing control that interacts with the IME and displays a blinking cursor. * TextField. This widget is a Material Design text field, with all the bells and whistles. It is highly configurable and can be reduced down to a fairly simple control by setting its `decoration` property to null. * TextFormField. This widget is a FormField that wraps a TextField. This patch also replaces the InputValue data model for these widgets with a Listenable TextEditingController, which is much more flexible. Fixes #7031
-
- 31 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
* add @required when there's an assert not null * address review comments
-