1. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  2. 15 Aug, 2019 1 commit
  3. 15 May, 2019 1 commit
    • Greg Spencer's avatar
      Implements focus handling and hover for Material buttons. (#31438) · bb3c6605
      Greg Spencer authored
      This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets.
      
      Addresses #11344, #1608, and #13264.
      bb3c6605
  4. 04 Apr, 2019 1 commit
  5. 02 Apr, 2019 1 commit
  6. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  7. 15 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  8. 08 Feb, 2019 1 commit
  9. 01 Feb, 2019 1 commit
  10. 23 Jan, 2019 1 commit
  11. 15 Jan, 2019 1 commit
    • Ian Hickson's avatar
      Support setting the elevation of disabled floating action buttons (#24728) · 29928a46
      Ian Hickson authored
      Previously, a disabled floating action button always had zero
      elevation, which looks dumb.
      
      This also fixes the issue whereby highlightElevation was not honoured
      on floating action buttons.
      
      This also fixes an issue I found during testing whereby setState was
      being called during build when onHighlightChanged fired due to
      onPressed becoming null while a gesture is ongoing (which triggers an
      onTapCancel synchronously during build).
      29928a46
  12. 18 Dec, 2018 1 commit
  13. 16 Oct, 2018 1 commit
  14. 12 Oct, 2018 2 commits
    • matthew-carroll's avatar
      Revert "Reversion for roll (#22984)" (#23029) · 04a26778
      matthew-carroll authored
      This reverts commit 80f80ab0.
      04a26778
    • matthew-carroll's avatar
      Reversion for roll (#22984) · 80f80ab0
      matthew-carroll authored
      For G3 Roll:
      
      * Revert "MaterialButton must honor its minWidth and height parameters (#22919)"
      
      This reverts commit a0233233.
      
      * Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"
      
      This reverts commit 655bf6a2.
      
      * Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"
      
      This reverts commit a590940e.
      
      * Revert "Bring TextTheme into alignment with the current Material spec (#22330)"
      
      This reverts commit 8bfb4b3e.
      
      * Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"
      
      This reverts commit eea3465a.
      
      * Manual adjustments to fix reversion issues.
      80f80ab0
  15. 08 Oct, 2018 1 commit
  16. 02 Oct, 2018 1 commit
  17. 12 Sep, 2018 1 commit
  18. 07 Sep, 2018 1 commit
  19. 24 Aug, 2018 1 commit
  20. 15 Aug, 2018 1 commit
  21. 09 Aug, 2018 1 commit
  22. 09 Jul, 2018 1 commit
  23. 03 Jul, 2018 2 commits
  24. 05 Jun, 2018 1 commit
  25. 20 Mar, 2018 1 commit
  26. 02 Mar, 2018 1 commit
  27. 05 Feb, 2018 1 commit
  28. 13 Oct, 2017 1 commit
    • Greg Spencer's avatar
      Modify the MaterialButton to expand when text is scaled. (#12431) · 25ac924e
      Greg Spencer authored
      This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.
      
      Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.
      
      Addresses #12311
      25ac924e
  29. 27 May, 2017 1 commit
    • Ian Hickson's avatar
      Much work on the documentation (#10331) · f50caddf
      Ian Hickson authored
      Minor fixes throughout, e.g. removing trailing commas from the end of sample code expressions, changing headings to "sample code" more consistently, removing stale todos, fix typos in a private method name, minor grammar fixes, added some clarifications to CircularProgressIndicator, LinearProgressIndicator, CrossAxisAlignment, added some cross-references to various members, made it slightly clearer that layout algorithms are implementation details.
      
      Clarified "elevation" throughout.
      
      Added docs to InkResponse and InkWell.
      
      Added sample code for: SliverAppBar, Card, ListTile, EdgeInsets, Row, Column, CustomScrollView, ListView, SliverFixedExtentList, and SliverGrid.
      
      Fixes #10317.
      Fixes #10316.
      Fixes #10267. (sort of, see comment therein)
      Fixes #9331. (sort of, see comment therein)
      Fixes #9407. (sort of, see comment therein)
      f50caddf
  30. 03 May, 2017 2 commits
  31. 21 Apr, 2017 1 commit
  32. 23 Mar, 2017 1 commit
    • Luke's avatar
      Adds highlight + splash color properties to material button (#8643) · 1adfbd4e
      Luke authored
      * adds highlight + splash color properties to material button
      
      * add states to raised button + flat button
      
      * fixes an issue where the custom highlight would not be properly set
      
      * Add preliminary tests for theme highlight + splash and via theme
      
      * documentation changes. tweaks per code review feedback
      
      * comment out unused variable
      
      * remove unused import
      
      * documentation updates. removed commented code
      1adfbd4e
  33. 21 Mar, 2017 1 commit
  34. 04 Mar, 2017 1 commit
  35. 31 Jan, 2017 1 commit
  36. 20 Jan, 2017 1 commit
  37. 14 Jan, 2017 1 commit
    • Adam Barth's avatar
      Add SimpleDialogOption (#7494) · ad27fcd3
      Adam Barth authored
      The demo of the SimpleDialog had some useful code that should really be part of
      the framework. This patch extracts it into a SimpleDialogOption widget.
      
      Remove debugCheckHasScaffold because it is unused.
      
      Also, add tests for InkWell, SimpleDialog, and other widgets.
      ad27fcd3