Commits · 6d18d31b5c6c3c3ff94722b56aee596434a5b0c2 · abdullh.alsoleman / Front-End

11 Oct, 2019 1 commit

Fix abstract_method_smoke_test flakiness (#42454) · 6d18d31b

Michael Klimushyn authored Oct 11, 2019

The flake appears to be coming from the Google Maps plugin. This test
just needs a platform view plugin without the interface method
implemented in general, not Maps specifically. Update it here to avoid
the issue in Maps until that's fixed.

Create a very simple platform view implementation that exercises this
potential bug in order to create a minimal test case with less risk of
causing second order issues like depending on any kind of full package
would cause.

6d18d31b

10 Oct, 2019 35 commits

Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478) · eede7929
Jonah Williams authored Oct 10, 2019

eede7929
Wrap dwds in async guard, only catch known error types (#42364) · 2b635816
Jonah Williams authored Oct 10, 2019

2b635816
Add support for Android x86_64 ABI to Flutter (#42401) · 03a45dc3
Jonah Williams authored Oct 10, 2019

03a45dc3
Rewrite MouseTracker's tracking and notifying algorithm (#42031) · 53636374
Tong Mu authored Oct 10, 2019
```
* Redesigns the algorithm with which MouseTracker keeps track of states and dispatches events. 
```
53636374
Fix semantics testing now that dropdown can take a11y focus again. (#42475) · ff2fdf40
Greg Spencer authored Oct 10, 2019
```
Fixes the android_semantics_testing integration test to have the right criteria now that ce150971 has landed.
```
ff2fdf40

Roll engine 5162413111b8..cef6751dba87 (3 commits) (#42469) · ffcd0cd1

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/5162413111b8...cef6751dba87

git log 5162413111b8..cef6751dba87 --no-merges --oneline
2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (#13048)" (flutter/engine#13067)
2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048)
2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

ffcd0cd1

Update docker_builder dependencies (#42462) · 6430b440
Emmanuel Garcia authored Oct 10, 2019

6430b440

Roll engine c8f665c3a7b0..5162413111b8 (2 commits) (#42459) · 89a4fe3a

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/c8f665c3a7b0...5162413111b8

git log c8f665c3a7b0..5162413111b8 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 69537d798994..b484e7ce24c9 (8 commits) (flutter/engine#13065)
2019-10-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from xd5Jj... to 3GwxH... (flutter/engine#13064)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

89a4fe3a

Re-land keyboard traversal PRs (#42278) · ce150971

Greg Spencer authored Oct 10, 2019

This attempts to reland #40186 and #41220, that were reverted in #41945.

The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.

I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)

Fixes #40101

ce150971

Revert removing DropdownMenuItem hint/disabledHint wrapper (#42456) · a95a84eb
Shi-Hao Hong authored Oct 10, 2019

a95a84eb
Add transitive dependencies back (#42441) · 53cc59f8
Emmanuel Garcia authored Oct 10, 2019

53cc59f8

Add opacity control to MouseRegion. Add findAnnotations to Layer. (#37896) · a71d69ba

Tong Mu authored Oct 10, 2019

* Adds a new parameter bool opaque to MouseRegion
* The same to RenderMouseRegion and AnnotatedRegionLayer
* Add findAnnotations to Layer

a71d69ba

PlatformView: recreate surface if the controller changes (#40280) · 6b4a10ae

tauu authored Oct 10, 2019

Currently the surface of a platform view is only created only one when the state of PlatformViewLink is created. When the PlatformViewLink widget changes, the PlatformViewController in the corresponding state is also updated. Just the surface is not updated even though it depends on the controller.

This PR changes this behavior to recreate the surface whenever the controller is updated.

6b4a10ae

Roll engine 0b6aa5e3201a..c8f665c3a7b0 (2 commits) (#42453) · 75f75463

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/0b6aa5e3201a...c8f665c3a7b0

git log 0b6aa5e3201a..c8f665c3a7b0 --no-merges --oneline
2019-10-10 jason-simmons@users.noreply.github.com Allow embedders to disable causal async stacks in the Dart VM (flutter/engine#13004)
2019-10-10 jason-simmons@users.noreply.github.com Integration with more of Skia's SkShaper/SkParagraph APIs (flutter/engine#13008)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

75f75463

Roll engine a05803a0d2ba..0b6aa5e3201a (2 commits) (#42443) · 6a63ef7d

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/a05803a0d2ba...0b6aa5e3201a

git log a05803a0d2ba..0b6aa5e3201a --no-merges --oneline
2019-10-10 yjbanov@google.com Add "felt clean" command (flutter/engine#13042)
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0fc9b3829b47..69537d798994 (1 commits) (flutter/engine#13061)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

6a63ef7d

Add font fallback clarification docs (#42365) · d62565a5
Gary Qian authored Oct 10, 2019

d62565a5
Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. (#42354) · 2a40c2dd
Ryan Macnak authored Oct 10, 2019
```
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
```
2a40c2dd
TextStyle.fontFamily should override fontFamily parameter in ThemeData constructor. (#42366) · 812e0387
Darren Austin authored Oct 10, 2019
```
Also updated the documentation for the ThemeData constructor to include
descriptions of parameters that don't map to specific fields directly.
```
812e0387

Partial deflaking of abstract_method_smoke_test (#42379) · 29bfb11c

Michael Klimushyn authored Oct 10, 2019

1. The platform code to show the keyboard wasn't working on certain
devices. From my testing it appears to be related to when the code was
firing. IMM won't show the soft input (or shows and then immediately
hides it, it's hard to tell) if it's called before the Flutter UI is
loaded. Change this to instead show the soft keyboard after a message
from Flutter that main() has been started.

2. A text field was visible in the UI, and the test was run under a
fuzzer that random tapped portions of the screen. Remove the text field
so that the fuzzer can't accidentally open the keyboard on its own at a
random time.

3. The keyboard was left open even after the app was closed. Also toggle
the input off when the app was closed, so that this test can be ran
multiple times in succession relatively hermetically.

29bfb11c

[BUG] Process all children of intent-filter instead of just the first one to... · ff15a39c
Sahil Soni authored Oct 10, 2019
```
[BUG] Process all children of intent-filter instead of just the first one to identify default activity (#40029)
```
ff15a39c

Roll engine d25a623d7f90..a05803a0d2ba (2 commits) (#42438) · 7e46192d

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/d25a623d7f90...a05803a0d2ba

git log d25a623d7f90..a05803a0d2ba --no-merges --oneline
2019-10-10 dnfield@google.com Android targets create final zip artifacts (flutter/engine#13059)
2019-10-10 sjindel@google.com Remove use of the blobs snapshot format from unittests (flutter/engine#12563)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

7e46192d

d25a623d7 Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw...... · 166fd597

engine-flutter-autoroll authored Oct 10, 2019

d25a623d7 Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw... (flutter/engine#13060) (#42425)

git@github.com:flutter/engine.git/compare/5a8605444187...d25a623d7f90

git log 5a8605444187..d25a623d7f90 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw... (flutter/engine#13060)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

166fd597

Shard web tests; enable semantics tests on the Web (#42203) · 9cd9680b
Yegor authored Oct 10, 2019
```
Shard web tests; enable semantics tests on the Web
```
9cd9680b

5a8605444 Roll src/third_party/skia fe23b1de9ed0..0fc9b3829b47 (1 commits)... · 991153ad

engine-flutter-autoroll authored Oct 10, 2019

5a8605444 Roll src/third_party/skia fe23b1de9ed0..0fc9b3829b47 (1 commits) (flutter/engine#13058) (#42412)

git@github.com:flutter/engine.git/compare/f237896bac7c...5a8605444187

git log f237896bac7c..5a8605444187 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia fe23b1de9ed0..0fc9b3829b47 (1 commits) (flutter/engine#13058)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

991153ad

Roll engine ed1557f82dd4..f237896bac7c (3 commits) (#42406) · ed0db167

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/ed1557f82dd4...f237896bac7c

git log ed1557f82dd4..f237896bac7c --no-merges --oneline
2019-10-10 bkonyi@google.com Roll src/third_party/dart cc3e22f724..48e93d3d3b (8 commits)
2019-10-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from pczjK... to xd5Jj... (flutter/engine#13055)
2019-10-10 dnfield@google.com Minimal test harness for iOS (flutter/engine#13029)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

ed0db167

Use processManager.run() instead of manually capturing streams in test_utils getPackages() (#41687) · e8c5d66b
Danny Tuppeny authored Oct 10, 2019
```
* Capture stdout in test helper

* Simplify running getPackages() in test utils

* Remove unused import
```
e8c5d66b

Roll engine 179fab9dcbac..ed1557f82dd4 (2 commits) (#42402) · f57774fe

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/179fab9dcbac...ed1557f82dd4

git log 179fab9dcbac..ed1557f82dd4 --no-merges --oneline
2019-10-10 chinmaygarde@google.com Don’t bump iOS deployment target for Metal builds. (flutter/engine#13051)
2019-10-10 duanweiwei1982@gmail.com Add texture support for macOS shell. (flutter/engine#8507)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

f57774fe

Add option to precache unsigned mac binaries. (#42376) · 5a41374a
Lau Ching Jun authored Oct 10, 2019

5a41374a

Roll engine 46b2e3d9a313..179fab9dcbac (2 commits) (#42392) · 02470fe2

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/46b2e3d9a313...179fab9dcbac

git log 46b2e3d9a313..179fab9dcbac --no-merges --oneline
2019-10-10 chinmaygarde@google.com Set the Cirrus badge to only display status of the master branch. (flutter/engine#13053)
2019-10-10 bkonyi@google.com Roll src/third_party/dart 2ffdc54d24..cc3e22f724 (6 commits)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

02470fe2

Add smoke test for the new Android embedding (#42360) · 9eaac9c4

Emmanuel Garcia authored Oct 10, 2019

* Add smoke test for the new Android embedding

* Update AndroidManifest.xml in app template

* Update test README.md

* Remove widget_test.dart

* Update pubspec.yaml

* Force GeneratedPluginRegistrant.java

9eaac9c4

Roll engine eb7abf28e439..46b2e3d9a313 (2 commits) (#42387) · df419d30

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/eb7abf28e439...46b2e3d9a313

git log eb7abf28e439..46b2e3d9a313 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76826fc91c0a..fe23b1de9ed0 (4 commits) (flutter/engine#13050)
2019-10-10 chinmaygarde@google.com Ignore thread leaks from Dart VM in tsan instrumented builds. (flutter/engine#13049)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

df419d30

Roll engine e69319216729..eb7abf28e439 (5 commits) (#42381) · 7de0e1cb

engine-flutter-autoroll authored Oct 10, 2019

git@github.com:flutter/engine.git/compare/e69319216729...eb7abf28e439

git log e69319216729..eb7abf28e439 --no-merges --oneline
2019-10-09 bkonyi@google.com Roll src/third_party/dart 41d13f0ffe..2ffdc54d24 (10 commits)
2019-10-09 ferhat@gmail.com [web] Implement basic radial gradient (TileMode.clamp, no transform) (flutter/engine#12811)
2019-10-09 dnfield@google.com dart analysis of tests, cleanup (flutter/engine#13033)
2019-10-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from cknsi... to QIjex... (flutter/engine#13041)
2019-10-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia e27a503a0a21..76826fc91c0a (9 commits) (flutter/engine#13040)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

7de0e1cb

Switch desktop build commands to use process utils (#42373) · 48034289
Jonah Williams authored Oct 10, 2019

48034289
Make MouseTracker.sendMouseNotifications private (#41879) · 94515ba5
Tong Mu authored Oct 10, 2019
```
* Make sendMouseNotifications private
```
94515ba5
remove println (#42378) · 10ddb7db
Jonah Williams authored Oct 10, 2019

10ddb7db

09 Oct, 2019 4 commits

Expose wait conditions in the public flutter_driver API (#42162) · 2adda80c
Dwayne Slater authored Oct 09, 2019

2adda80c
Fix DropdownButton crash when hint and selectedItemBuilder are simultaneously defined (#42342) · 8fcc1d41
Shi-Hao Hong authored Oct 09, 2019
```
* Fix DropdownButton crash when hint and selectedItemBuilder are simultaneously defined
```
8fcc1d41

Roll engine 0d749933bcc6..e69319216729 (11 commits) (#42363) · 609de088

engine-flutter-autoroll authored Oct 09, 2019

git@github.com:flutter/engine.git/compare/0d749933bcc6...e69319216729

git log 0d749933bcc6..e69319216729 --no-merges --oneline
2019-10-09 hterkelsen@users.noreply.github.com [web_ui] Check if a pointer is already down for the specific device (flutter/engine#12470)
2019-10-09 bkonyi@google.com Roll src/third_party/dart bb04f145b2..41d13f0ffe (24 commits)
2019-10-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from u0JpE... to pczjK... (flutter/engine#13025)
2019-10-09 gspencergoog@users.noreply.github.com Add missing focusable testing info (flutter/engine#13013)
2019-10-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024)
2019-10-09 30870216+gaaclarke@users.noreply.github.com Refactor: FlutterDartProject (flutter/engine#13006)
2019-10-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023)
2019-10-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021)
2019-10-09 bkonyi@google.com Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits)
2019-10-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019)
2019-10-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

609de088

Fix documentation for the required argument (#41675) · 9b29e830
tery lim authored Oct 09, 2019

9b29e830