1. 05 Oct, 2015 1 commit
    • Hixie's avatar
      Fix Focus · fbf8174c
      Hixie authored
      Focus.at() and company should be on Focus, not FocusState.
      
      _notifyDescendants() was using the wrong runtimeType.
      
      Let InheritedWidget update the descendants during build.
      
      When you setState() during build, assert that you're not
      markNeedsBuild()ing someone who isn't a descendant.
      
      Typo in Widget.toString().
      fbf8174c
  2. 03 Oct, 2015 1 commit
  3. 01 Oct, 2015 3 commits
  4. 29 Sep, 2015 1 commit
  5. 28 Sep, 2015 1 commit
    • Adam Barth's avatar
      Actually notify GlobalKey listeners in fn3 · 64dfb849
      Adam Barth authored
      This patch makes a number of changes:
      
      1) buildDirtyComponents now prevents all calls to setState, not just those
         higher in the tree. This change is necessary for consistency with
         MixedViewport and HomogeneousViewport because those widgets already build
         subwidgets with that restriction. If the "normal" build didn't enforce that
         rule, then some widgets would break when put inside a mixed or homogeneous
         viewport.
      
      2) We now notify global key listeners in a microtask after beginFrame. That
         means setState is legal in these callbacks and that we'll produce another
         frame if someone calls setState in such a callback.
      64dfb849
  6. 26 Sep, 2015 1 commit
  7. 23 Sep, 2015 3 commits
    • Adam Barth's avatar
      Add tests for ParentData · fa119c38
      Adam Barth authored
      fa119c38
    • Hixie's avatar
      fn3: Minor cleanup · 2a5fad93
      Hixie authored
      - Remove the unique objects used as slots since we decided 'null' was
        fine after all
      - Rename 'slot' to 'newSlot' when it's used as an argument to change the
        _slot field, to clarify which variable has the newer value
      - Remove the RenderObject registry since we'll do listeners a different
        way. This also removes handleEvent for the same reason.
      - Remove the TODOs for mount/unmount becoming didMount/didUnmount since
        the methods do in fact do the mounting/unmounting.
      2a5fad93
    • Hixie's avatar
      fn3: Binding to RenderView · 555138e6
      Hixie authored
      In the old world, we had two ways to bind a Widget tree to a
      RenderObject node, one way for RenderView and one mostly untested way
      for other cases (it's only tested by the spinning_mixed.dart demo). For
      fn3, I made these the same code path.
      
      This patch also introduces GlobalKey, though the GlobalKey logic isn't
      hooked in yet.
      
      This is Hello World in the new world:
      
      ```dart
      import 'package:sky/src/fn3.dart';
      
      void main() {
        runApp(new Text('Hello World!'));
      }
      ```
      555138e6
  8. 22 Sep, 2015 2 commits
    • Hixie's avatar
      Fix warnings and build errors · 5fb2cb32
      Hixie authored
      Fixes errors from #1285 and #1281.
      5fb2cb32
    • Hixie's avatar
      fn3: Add a binding for fn3 and sky. · b73b06e4
      Hixie authored
      - I extracted the BuildScheduler into a separate binding.dart file.
      - Various changes to expose private members that are needed by
        binding.dart.
      - Registering the render objects for event dispatch.
      - Convert the tests to use the new binding mechanism.
      
      This doesn't yet have a RenderView or event handling.
      b73b06e4