- 03 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 26 Oct, 2020 1 commit
-
-
Jonah Williams authored
Overhaul of flutter drive in order to deliver a better experience, namely: * flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. * Removes web-initialize-platform as this is no longer used * flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. * VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes * Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 23 Oct, 2020 1 commit
-
-
Jonah Williams authored
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845) This reverts commit 2e75f52a.
-
- 22 Oct, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451) Overhaul of flutter drive in order to deliver a better experience, namely: flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. Removes web-initialize-platform as this is no longer used flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 13 Oct, 2020 1 commit
-
-
Jonah Williams authored
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
-
- 09 Oct, 2020 1 commit
-
-
James D. Lin authored
[flutter tools] Add a DelegatingLogger class Move most of `DelegateLogger` `from test/src/testbed.dart` to `lib/src/base/logger.dart` to better formalize the common practice of chaining `Logger`s together. I renamed the class since it isn't itself the delegate and to better match the `Delegating...` classes from `package:collection`. Additionally, add a freestanding `asLogger<T>` function to "cast" a `Logger` into a matching delegate if possible. This will allow `Logger` chains to be ordered a *bit* more freely (e.g. `NotifyingLogger` and `AppRunLogger` will no longer required to be at the end of the chain, an unwritten rule that has led to breakage in google3). Chain order still matters since lack of virtual dispatch means that parent `Logger`s can never invoke child methods, however. I made `asLogger<T>` a freestanding function because I didn't want to make it part of the `Logger` interface (and I thought that making it an extension method might be weird). Bonus cleanup: There no longer appears to be a way to construct an `AppRunLogger` with a null parent, so remove all of code paths for that case and make the `parent` construction parameter required.
-
- 05 Oct, 2020 1 commit
-
-
Jonah Williams authored
This functionality ultimately became the single widget reload optimization, which did not require a separate service protocol.
-
- 03 Oct, 2020 1 commit
-
-
Jonah Williams authored
Flutter logs should not attempt to filter the device list based on the current project, because it does not require a current project. Also fix disabled polling test Fixes #47996 Fixes #63550
-
- 23 Sep, 2020 2 commits
-
-
Jonah Williams authored
If a file scheme and one or more roots is provided, fall back to this mapping before the direct file path if the file path cannot be turned into a package URI. Use URI representation so that the transformation is resilient to the org-dartlang-app scheme used by the web builds. Fixes #66095 Fixes #66404
-
Jenn Magder authored
This reverts commit af6ba867.
-
- 22 Sep, 2020 1 commit
-
-
Jonah Williams authored
If a file scheme and one or more roots is provided, fall back to this mapping before the direct file path if the file path cannot be turned into a package URI. Fixes #66095
-
- 19 Sep, 2020 1 commit
-
-
Jonah Williams authored
-
- 15 Sep, 2020 1 commit
-
-
Devon Carew authored
fix an issues where raw json output was written to IDE clients
-
- 11 Sep, 2020 1 commit
-
-
Danny Tuppeny authored
-
- 17 Aug, 2020 1 commit
-
-
Helin Shiah authored
-
- 10 Aug, 2020 1 commit
-
-
Michael Klimushyn authored
-
- 03 Aug, 2020 1 commit
-
-
Helin Shiah authored
-
- 31 Jul, 2020 1 commit
-
-
Helin Shiah authored
-
- 20 Jul, 2020 2 commits
-
-
Jonah Williams authored
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble. To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86 Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method. Cleanups: Remove modules, as this is unused now.
-
Helin Shiah authored
-
- 17 Jul, 2020 1 commit
-
-
Jenn Magder authored
-
- 15 Jul, 2020 1 commit
-
-
Danny Tuppeny authored
-
- 09 Jul, 2020 1 commit
-
-
Jonah Williams authored
run/attach --machine requires a different logger than daemon, which uses the NotifyingLogger. We have too many loggers! Fixes #59463
-
- 25 Jun, 2020 1 commit
-
-
Jonah Williams authored
The global packages path could cause tests to fail when it would be overriden to unexpected (in test setup) values. Remove most usage and make it a configuration on buildInfo, along with most other build information. Cleanup the asset builder to require the .packages path and the resident runners to no longer require it, since they already have the information in build_info. It needs to stick around for the fuchsia deps we do not control. Filled #60232 for remaining work.
-
- 18 Jun, 2020 3 commits
-
-
Jenn Magder authored
-
Jonah Williams authored
The addition of the non-optional parent logger broke the google3 roll. Make it optional so we can roll
-
Jonah Williams authored
Refactors KernelCompiler and ResidentCompiler to no longer use globals (except as a fallback for g3 migration). Improves the compilation error when running flutter test on a package without a flutter_test dependency. Updates machine mode to output trace text to stderr
-
- 09 Jun, 2020 1 commit
-
-
Jenn Magder authored
-
- 08 Jun, 2020 1 commit
-
-
Jonah Williams authored
instead of restricting profile/release mode based on whether the tool thinks the device is an emulator, restrict based on the device target architecture and the requested build mode. Notably, this enables release mode on x86_64 Android emulators, but not x86 emulators since we do not support that as an AOT target. This does not add release mode support for simulators, since this requires us to build and upload artifacts for simulator/x86_64
-
- 04 Jun, 2020 1 commit
-
-
Jonah Williams authored
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides. This allows removing a work around where web devices needed to look up directly from the context in non-test code. Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
-
- 01 Jun, 2020 1 commit
-
-
Jenn Magder authored
-
- 27 May, 2020 1 commit
-
-
Jonah Williams authored
-
- 30 Mar, 2020 1 commit
-
-
Jonah Williams authored
-
- 24 Mar, 2020 1 commit
-
-
Jonah Williams authored
-
- 11 Mar, 2020 1 commit
-
-
Jonah Williams authored
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
-
- 06 Mar, 2020 2 commits
-
-
Jonah Williams authored
-
Zachary Anderson authored
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception * Add armv7f to getIOSArchForName
-
- 05 Mar, 2020 2 commits
-
-
Jonah Williams authored
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041) This reverts commit ee60eeea.
-
Jonah Williams authored
-
- 04 Mar, 2020 1 commit
-
-
Jenn Magder authored
This reverts commit 57c6721c.
-