- 26 Oct, 2020 2 commits
-
-
Jonah Williams authored
* [flutter_tools] simplication of application store logic * maybe return null * fix install tests * Clean up imports * revert windows test * remove unused import
-
Jonah Williams authored
Overhaul of flutter drive in order to deliver a better experience, namely: * flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. * Removes web-initialize-platform as this is no longer used * flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. * VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes * Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 23 Oct, 2020 1 commit
-
-
Jonah Williams authored
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845) This reverts commit 2e75f52a.
-
- 22 Oct, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451) Overhaul of flutter drive in order to deliver a better experience, namely: flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive. Removes web-initialize-platform as this is no longer used flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service. VM service connection now provides access to memory info without launching devtools (only for debug/profile mode) Web changes Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible Additional NNBD related bug fixes: No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
-
- 19 Oct, 2020 3 commits
-
-
Jonah Williams authored
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone. Example: flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
-
Jonah Williams authored
This reverts commit ddab72e7.
-
Jonah Williams authored
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone. Example: flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
-
- 15 Oct, 2020 2 commits
-
-
Jonah Williams authored
This reverts commit d962c8f2.
-
Jonah Williams authored
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
-
- 14 Oct, 2020 2 commits
-
-
Jonah Williams authored
-
Jenn Magder authored
-
- 13 Oct, 2020 2 commits
-
-
Jonah Williams authored
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
-
Jonah Williams authored
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE. fixes #67986
-
- 12 Oct, 2020 2 commits
-
-
Jonah Williams authored
Work towards #39925 Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp. This should reduce the occurrence of the error in the devicelab.
-
Jonah Williams authored
HACKTOBERFEST
-
- 05 Oct, 2020 2 commits
-
-
Jonah Williams authored
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
-
Danny Tuppeny authored
-
- 03 Oct, 2020 1 commit
-
-
Jonah Williams authored
Refactors the desktop devices and workflow to remove unnecessary usage of global variables. This should make it easier to test and continue enhancing the desktop functionality of the tooling #47161
-
- 30 Sep, 2020 1 commit
-
-
Jenn Magder authored
-
- 29 Sep, 2020 1 commit
-
-
Jonah Williams authored
In cases where the Intellij/AS plugins are not located, display links to where they can be downloaded but do not surface an error. This should generally reduce confusion about whether the plugins are required for every installed IDE. For example, frequently users may only install AS so that they can install the Android SDK - or they may have multiple copies of Intellij installed. For example: #66762
-
- 25 Sep, 2020 1 commit
-
-
knaeckeKami authored
Teach the flutter tool how to find android output files if the flavor contains uppercase letters (#66687) This changes the name of the generated output files on android in case a flavor with uppercase letters is used. Previously, the lowercased flavor name would be used for the apk/aab file. Now, the flavor name is used as-is.
-
- 17 Sep, 2020 1 commit
-
-
Daniel Edrisian authored
-
- 16 Sep, 2020 1 commit
-
-
Michael R Fairhurst authored
-
- 03 Sep, 2020 2 commits
-
-
Jonah Williams authored
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit. While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
-
Jonah Williams authored
More work to prevent current #2 crash issue on stable. If adb is not located do not list/create android devices.
-
- 31 Aug, 2020 2 commits
-
-
Mehmet Fidanboylu authored
This reverts commit c8f234d3.
-
- 29 Aug, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit eef0050d.
-
- 28 Aug, 2020 2 commits
-
- 27 Aug, 2020 3 commits
-
-
Ben Konyi authored
This change re-enables DDS and outputs the DDS URI in place of the VM service URI on the console. If --disable-dds is not provided, --host-vmservice-port will be used to determine the port for DDS rather than the host port for the VM service, which will instead be randomly chosen.
-
Jonah Williams authored
* [flutter_tools] add analytics to code size, add more testing * add gradle case * Update build_macos_test.dart * move analytics to code size tooling * Update analyze_size.dart * fix analysis
-
Jonah Williams authored
Avoid creating AndroidDevice discovery if the SDK cannot be located. Previously the tool would use which/where adb, however this required us to handle the AndroidSdk class being potentially null - which required an additional layer of indirection around all access. Sometimes these were forgotten leading to NPEs. In general, not much can be done with an Android Device if the actual SDK is not installed. Reland with fixed code + tests for null SDK + adb in AndroidDeviceDiscovery
-
- 26 Aug, 2020 2 commits
-
-
Kenzie Schmoll authored
-
Jenn Magder authored
Revert "[flutter_tools] avoid creating Android Devices if AndroidSDK cannot be found (#64524)" (#64602) This reverts commit 47596c62.
-
- 25 Aug, 2020 2 commits
-
-
Jonah Williams authored
Avoid creating AndroidDevice discovery if the SDK cannot be located. Previously the tool would use which/where adb, however this required us to handle the AndroidSdk class being potentially null - which required an additional layer of indirection around all access. Sometimes these were forgotten leading to NPEs. In general, not much can be done with an Android Device if the actual SDK is not installed.
-
Jonah Williams authored
[flutter_tools] support code size tooling on iOS, linux, windows, macOS, and Android on Windows (#63610) Adds support for size analysis on iOS, macOS, linux, and Windows - using an uncompressed directory based approach. The output format is not currently specified. Adds support for size analysis on android on windows, switching to package:archive Updates the console format to display as a tree, allowing longer paths. Increases the number of dart libraries shown (to avoid only ever printing the flutter/dart:ui libraries, which dominate the size)
-
- 20 Aug, 2020 1 commit
-
-
xster authored
-
- 19 Aug, 2020 1 commit
-
-
Jonah Williams authored
Attempt to simplify the Android SDK interface ahead of refactoring it. The locateAndroidSdk static method is called at startup to locate the android SDK, returning null if it cannot be found. These helper methods attempted to first look up the AndroidSDK if it was already null - which could only cover the case where someone installed the Android SDK while flutter was running (possibly through an IDE)
-
- 11 Aug, 2020 1 commit
-
-
Jonah Williams authored
-