Commits · 6b91fcb20f58b8c1cfc9f59b281fb02362899975 · abdullh.alsoleman / Front-End

12 Jan, 2024 25 commits

Bump actions/upload-artifact from 4.0.0 to 4.1.0 (#141480) · 6b91fcb2

dependabot[bot] authored Jan 12, 2024

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.0.0 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add migrations docs by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/482">actions/upload-artifact#482</a></li>
<li>Update README.md by <a href="https://github.com/samuelwine"><code>@âsamuelwine</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/492">actions/upload-artifact#492</a></li>
<li>Support artifact-url output by <a href="https://github.com/konradpabjan"><code>@âkonradpabjan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/496">actions/upload-artifact#496</a></li>
<li>Update readme to reflect new 500 artifact per job limit by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/497">actions/upload-artifact#497</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/samuelwine"><code>@âsamuelwine</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/492">actions/upload-artifact#492</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.1.0">https://github.com/actions/upload-artifact/compare/v4...v4.1.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/1eb3cb2b3e0f29609092a73eb033bb759a334595"><code>1eb3cb2</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/497">#497</a> from actions/robherley/update-readme-limit</li>
<li><a href="https://github.com/actions/upload-artifact/commit/8688a86492f53c8d67423223a877bc9e3768fe95"><code>8688a86</code></a> Update readme to reflect new artifact/job limit</li>
<li><a href="https://github.com/actions/upload-artifact/commit/73d8b66ede50d06e26f1d69f28e1652c702c56d8"><code>73d8b66</code></a> Support artifact-url output (<a href="https://redirect.github.com/actions/upload-artifact/issues/496">#496</a>)</li>
<li><a href="https://github.com/actions/upload-artifact/commit/c320f57948d137eb8c7f8e781ddcc0f61b04e834"><code>c320f57</code></a> Update README.md (<a href="https://redirect.github.com/actions/upload-artifact/issues/492">#492</a>)</li>
<li><a href="https://github.com/actions/upload-artifact/commit/cf8714cfeaba5687a442b9bcb85b29e23f468dfa"><code>cf8714c</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/482">#482</a> from actions/robherley/add-migration-docs</li>
<li><a href="https://github.com/actions/upload-artifact/commit/7f16e37e88af9d50a1db3c1e84660985ee8dd1ab"><code>7f16e37</code></a> add migrations docs</li>
<li><a href="https://github.com/actions/upload-artifact/commit/353073034f1f3c6d1a65ede161c5a2ca79650a49"><code>3530730</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/468">#468</a> from actions/robherley/misc-updates</li>
<li><a href="https://github.com/actions/upload-artifact/commit/6c139afa6f18a1359e5a9185f9415433473e3793"><code>6c139af</code></a> update imports and old v4-beta references</li>
<li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/c7d193f32edcb7bfad88892161225aeda64e9392...1eb3cb2b3e0f29609092a73eb033bb759a334595">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.0.0&new-version=4.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

6b91fcb2

Fixed a lot of typos (#141431) · 81d80c58

Anis Alibegić authored Jan 12, 2024

Fair amount of typos spotted and fixed. Some of them are in comments, some of them are in code and some of them are in nondart files.

There is no need for issues since it's a typo fix.

I have doubts about [packages/flutter_tools/lib/src/ios/core_devices.dart](https://github.com/flutter/flutter/compare/master...anisalibegic:flutter:master#diff-fdbc1496b4bbe7e2b445a567fd385677af861c0093774e3d8cc460fdd5b794fa), I have a feeling it might broke some things on the other end, even though it's a typo.

81d80c58

Reverts "Remove hack from PageView." (#141479) · 8f797fc3

auto-submit[bot] authored Jan 12, 2024

Reverts flutter/flutter#141138
Initiated by: itsjustkevin
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/141119

The change is breaking, because now controller is nullable.

Migration path: https://github.com/flutter/website/pull/10033

Packages to fix:

8f797fc3

Roll Flutter Engine from 01e353544dd7 to 418c9e918a22 (2 revisions) (#141474) · 8bab8a40

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/01e353544dd7...418c9e918a22

2024-01-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Use chromium test-scripts to download images and execute tests" (flutter/engine#49772)
2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from 2bc5d2ee9896 to 31309ff09537 (1 revision) (flutter/engine#49764)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8bab8a40

Roll Flutter Engine from 0ac8215c70ae to 01e353544dd7 (1 revision) (#141470) · e85e56c4

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/0ac8215c70ae...01e353544dd7

2024-01-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 042dbc146a37 to d6c08fa9bb54 (2 revisions) (flutter/engine#49763)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e85e56c4

Roll Flutter Engine from ef2cf86c35a5 to 0ac8215c70ae (2 revisions) (#141464) · ed0f48a4

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/ef2cf86c35a5...0ac8215c70ae

2024-01-12 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Use chromium test-scripts to download images and execute tests (flutter/engine#49650)
2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from e04ca400c5d8 to 2bc5d2ee9896 (1 revision) (flutter/engine#49761)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ed0f48a4

unpin web_socket_channel and roll pub packages (#141424) · 9e9af67b

Christopher Fujino authored Jan 12, 2024

Fixes https://github.com/flutter/flutter/issues/141032

We pinned to web_socket_channel v2.4.1 because v2.4.2 was retracted, however v2.4.3 is now available.

9e9af67b

FlutterExtension: make fields non-static (#141463) · dbf5f04b

Bartek Pacia authored Jan 12, 2024

There's no issue for this PR. I can create one if requested.

## Summary

This PR makes public fields of `FlutterExtension` non-static. The aim is to make migrating from Gradle Groovy DSL to Gradle Kotlin DSL easier for Flutter developers, because...

### Without this PR

**android/app/build.gradle.kts**

```kotlin
plugins {
    id "com.android.application"
    id "dev.flutter.flutter-gradle-plugin"
}

android {
    namespace = "io.flutter.examples.hello_world"
    compileSdk = FlutterExtension.compileSdkVersion

    defaultConfig {
        applicationId = "io.flutter.examples.hello_world"
        minSdk = FlutterExtension.minSdkVersion
        targetSdk = FlutterExtension.targetSdkVersion
        // ...
    }
}
// ...
```

Groovy and Java allow accessing static fields of a class through its instance, but Kotlin is being more "correct" and disallows that.

### With this PR

Thanks to this PR, the user won't have to replace `flutter` with FlutterExtension in some places, thus decreasing possible confusion.

```kotlin
plugins {
    id "com.android.application"
    id "dev.flutter.flutter-gradle-plugin"
}

android {
    namespace = "io.flutter.examples.hello_world"
    compileSdk = flutter.compileSdkVersion

    defaultConfig {
        applicationId = "io.flutter.examples.hello_world"
        minSdk = flutter.minSdkVersion
        targetSdk = flutter.targetSdkVersion
        // ...
    }
}
// ...
```

dbf5f04b

[deep link] Update a gradle task to add flag check and intent filter check to... · 4b914bd1

hangyu authored Jan 12, 2024

[deep link]  Update a gradle task to add flag check and intent filter check to the AppLinkSettings (#141231)

These check result is used in devtool deep link validation
issue: https://github.com/flutter/flutter/issues/120408

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

4b914bd1

Expose versionCode and versionName from local.properties in FlutterExtension (#141417) · fd827e3a

Bartek Pacia authored Jan 12, 2024

This PR has no issue. I got this cool idea and decided to quickly try it out, and it works.

### Summary

This will allow Flutter Developers to have less code in their Android Gradle buildscripts.

```diff
 plugins {
     id "com.android.application"
     id "dev.flutter.flutter-gradle-plugin"
     id "kotlin-android"
 }

-def localProperties = new Properties()
-def localPropertiesFile = rootProject.file("local.properties")
-if (localPropertiesFile.exists()) {
-    localPropertiesFile.withReader("UTF-8") { reader ->
-        localProperties.load(reader)
-    }
-}
-
-def flutterVersionCode = localProperties.getProperty("flutter.versionCode")
-if (flutterVersionCode == null) {
-    flutterVersionCode = "1"
-}
-
-def flutterVersionName = localProperties.getProperty("flutter.versionName")
-if (flutterVersionName == null) {
-    flutterVersionName = "1.0"
-}
-
-def keystorePropertiesFile = rootProject.file("keystore.properties")
-def keystoreProperties = new Properties()
-
 keystoreProperties.load(new FileInputStream(keystorePropertiesFile))

 android {
         applicationId "pl.baftek.discoverrudy"
         minSdk 21
         targetSdk 34
-        versionCode flutterVersionCode.toInteger()
-        versionName flutterVersionName
+        versionCode flutter.versionCode()
+        versionName flutter.versionName()
     }
```

The boilerplate that loads 'local.properties' can live in Flutter Gradle Plugin.

### Concerns

I was worried about lifecycle/ordering issues, so I tested it.

To Flutter Gradle Plugin, I added:

```diff
 class FlutterPlugin implements Plugin<Project> {
     //...

     @Override
     void apply(Project project) {
+        project.logger.quiet("Start applying FGP")
         // ...
     }
 }
```

and to my `android/app/build.gradle` I added:

```diff
 android {
+    logger.quiet("Start evaluating android block")
     namespace "pl.bartekpacia.awesomeapp"
     compileSdk 34
 
     defaultConfig {
         applicationId "pl.baftek.discoverrudy"
         minSdk 21
         targetSdk 34
         versionCode flutter.versionCode()
         versionName flutter.versionName()
     }
```

Gradle first applies the plugins (which sets versionCode and versionName on FlutterExtension), and then it executes the `android {}` extension block:

```
$ ./gradlew :app:assembleDebug

> Configure project :app
Start applying FGP
Start evaluating android block

BUILD SUCCESSFUL in 2s
383 actionable tasks: 10 executed, 373 up-to-date
```

So ordering is fine.

fd827e3a

Roll Flutter Engine from a56f346dbbf9 to ef2cf86c35a5 (1 revision) (#141456) · d35ee11e

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/a56f346dbbf9...ef2cf86c35a5

2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from 7484d4a2514e to e04ca400c5d8 (2 revisions) (flutter/engine#49759)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d35ee11e

When Impeller is enabled for flutter tester choose correct shader target. (#141391) · f2745e97
Jonah Williams authored Jan 12, 2024
```
When compiling shaders for flutter tester, include Vulkan shaders when targeting Impeller.
```
f2745e97
Remove hack from PageView. (#141138) · 2da87e61
Polina Cherkasova authored Jan 12, 2024

2da87e61

Roll Flutter Engine from d0f9329c5ce4 to a56f346dbbf9 (6 revisions) (#141451) · 9186aeab

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/d0f9329c5ce4...a56f346dbbf9

2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from 22fa87f32944 to 7484d4a2514e (1 revision) (flutter/engine#49757)
2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from 1871595fecb3 to 22fa87f32944 (1 revision) (flutter/engine#49755)
2024-01-12 skia-flutter-autoroll@skia.org Roll Dart SDK from f61f7d2f57c5 to 042dbc146a37 (1 revision) (flutter/engine#49752)
2024-01-12 skia-flutter-autoroll@skia.org Roll Dart SDK from bff80f6c56de to f61f7d2f57c5 (1 revision) (flutter/engine#49748)
2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from 2bef4f0f8058 to 1871595fecb3 (1 revision) (flutter/engine#49747)
2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from e9de42588e54 to 2bef4f0f8058 (2 revisions) (flutter/engine#49745)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9186aeab

Adds support for StepStyle visual property bundle to the Step widget (#140825) · f40a99ce

Mairramer authored Jan 12, 2024

Fixes  #140770 and #103124

Adds the possibility of passing a height and width to icons. And also a margin for the distance of the lines between the icons.

f40a99ce

Roll Flutter Engine from 44a0a6ee4d39 to d0f9329c5ce4 (1 revision) (#141435) · ec97b6d0

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/44a0a6ee4d39...d0f9329c5ce4

2024-01-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
3245b92a5930 to bff80f6c56de (4 revisions) (flutter/engine#49744)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ec97b6d0

Revert "Reverts "Run iOS staging tests with Xcode 15.2"" (#141420) · 7dc856ab
Qun Cheng authored Jan 12, 2024
```
Relands "Run iOS staging tests with Xcode 15.2""

Reverts flutter/flutter#141412
```
7dc856ab

Roll Packages from 0744fe6fdb31 to d74d687dc0aa (5 revisions) (#141449) · 52d2c121

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/packages/compare/0744fe6fdb31...d74d687dc0aa

2024-01-12 stuartmorgan@google.com [ci] Check repo-level package metadata (flutter/packages#5811)
2024-01-12 stuartmorgan@google.com [various] Add iOS privacy manifests (flutter/packages#5846)
2024-01-11 stuartmorgan@google.com [video_player] Skip flaky tests in certain circumstances on Android (flutter/packages#5872)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 78666c8dc57e to 46787ee49c1f (5 revisions) (flutter/packages#5870)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter from b840a60d to 9f2e681e (24 revisions) (flutter/packages#5871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52d2c121

Fix `FlexibleSpaceBar` centered title position and title color (#140883) · e20d34c3

Taha Tesser authored Jan 12, 2024

fixes [Invisible SliverAppBar title in Material 3 light theme](https://github.com/flutter/flutter/issues/138296) 
fixes [`FlexibleSpaceBar` title is misaligned without the leading widget](https://github.com/flutter/flutter/issues/138608)

Previous attempt https://github.com/flutter/flutter/pull/138611

--- 

### Description

 - fixes the `FlexibleSpaceBar` centered title position when there is a leading widget.
 - fixes the `FlexibleSpaceBar` title color for Material 3.
 - Added documentation when using a long `FlexibleSpaceBar` title and update its test.
 - Improved documentation of default title padding.

### Code sample

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: SafeArea(
          child: CustomScrollView(
        slivers: <Widget>[
          SliverAppBar(
            leading: Icon(Icons.favorite_rounded),
            flexibleSpace: FlexibleSpaceBar(
              title: ColoredBox(
                color: Color(0xffff0000),
                child: Text('SliverAppBar'),
              ),
            ),
          ),
        ],
      )),
    );
  }
}
```

</details>

###  Before

![Screenshot 2024-01-03 at 18 02 25](https://github.com/flutter/flutter/assets/48603081/92ae1062-c78f-4005-8e28-85af617acd60)

### After

![Screenshot 2024-01-03 at 18 02 16](https://github.com/flutter/flutter/assets/48603081/2ef97108-9b50-44f7-a303-018ff1b28db6)

e20d34c3

Do not reset framework checkout before running customer tests (#141013) · 62da6525

William Hesse authored Jan 12, 2024

The migration of customer tests to sharded tests adds a step that checks out the current tip-of-tree of the framework repo, removing local changes. This does not work with monorepo testing, which modifies engine.version, and does not work with local testing of a branch.

The sharded tests should already be running with the correct checkout of the framework repo. If the REVISION environment variable is set, the framework checkout will still be reset to check out that revision.

These commands were migrated from the existing shell script to the sharded tester in
https://github.com/flutter/flutter/pull/138659

Bug: https://github.com/dart-lang/sdk/issues/51042

62da6525

Increase delay for checking integration_ui_keyboard_resize test success (#141301) · 5931b4f2

Camille Simon authored Jan 12, 2024

Increases delay for checking keyboard resizing to potentially accommodate the occasional longer delay of the Pixel 7 Pro.

Intended to address https://github.com/flutter/flutter/issues/140645.

5931b4f2

Add osx_sdk context for mac builds. (#141422) · e20e9510

godofredoc authored Jan 12, 2024

This is to give ci.yaml the flexibility to select the contexts to execute and remove complexity from recipes.

e20e9510

Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (#141432) · 6cc8b619

engine-flutter-autoroll authored Jan 12, 2024

https://github.com/flutter/engine/compare/ecdaed76f284...44a0a6ee4d39

2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from d65d18ac1e8d to e9de42588e54 (1 revision) (flutter/engine#49738)
2024-01-11 matanlurey@users.noreply.github.com Add `SurfaceTextureSurfaceProducer` (flutter/engine#49653)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) (flutter/engine#49735)
2024-01-11 jonahwilliams@google.com [Impeller] Begin migrating to RenderPass command recording API. (flutter/engine#49480)
2024-01-11 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 only (flutter/engine#49722)
2024-01-11 jonahwilliams@google.com [Impeller] dont accidentally copy shared ptr. (flutter/engine#49731)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) (flutter/engine#49733)
2024-01-11 jason-simmons@users.noreply.github.com Revert Dart SDK to 3245b92a5930 (flutter/engine#49727)
2024-01-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9... (flutter/engine#49730)
2024-01-11 103135467+sealesj@users.noreply.github.com Google GitHub mirrors - reland (flutter/engine#49716)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) (flutter/engine#49723)
2024-01-11 103135467+sealesj@users.noreply.github.com Osv-scanner integration (flutter/engine#49470)
2024-01-11 jason-simmons@users.noreply.github.com [Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas recorder (flutter/engine#49697)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) (flutter/engine#49720)
2024-01-11 dnfield@google.com Try to get GLES tests running... (flutter/engine#49701)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 2a5710618fc3 to 440f5f849008 (1 revision) (flutter/engine#49715)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from c46008e5a839 to 2a5710618fc3 (1 revision) (flutter/engine#49712)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 3245b92a5930 to 7f3ea1c3bc27 (1 revision) (flutter/engine#49710)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gJuGKaWsKazI to Klxww53tA4-T

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cc8b619

Add support for Gradle Kotlin DSL (#140744) · 0a1af8a1
Bartek Pacia authored Jan 12, 2024
```
This PR resolves #140548. It's based on my work in #118067.
```
0a1af8a1
Fix typo (#141426) · 5887d6c7
Qun Cheng authored Jan 12, 2024

5887d6c7

11 Jan, 2024 15 commits

Reverts "Run iOS staging tests with Xcode 15.2" (#141412) · 66759d75

auto-submit[bot] authored Jan 11, 2024

Reverts flutter/flutter#141392
Initiated by: QuncCccccc
This change reverts the following previous change:
Original Description:
Potential fix for https://github.com/flutter/flutter/issues/141383.

66759d75

Run iOS staging tests with Xcode 15.2 (#141392) · ef3de359
Victoria Ashworth authored Jan 11, 2024
```
Potential fix for https://github.com/flutter/flutter/issues/141383.
```
ef3de359

Fix `ListWheelScrollView` in an `AnimatedContainer` with zero height throw an error (#141372) · 8dcae5ac

Taha Tesser authored Jan 11, 2024

fixes [`ListWheelScrollView` Throws Unexpected Error Inside `AnimatedContainer`](https://github.com/flutter/flutter/issues/140780)
fixes [`CupertinoDatePicker` throw exception when parent height is 0](https://github.com/flutter/flutter/issues/55630)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: AnimatedContainer(
          height: 0,
          duration: Duration.zero,
          child: ListWheelScrollView(
            itemExtent: 20.0,
            children: <Widget>[
              for (int i = 0; i < 20; i++) Container(),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

8dcae5ac

make asset_test.dart tests not dependent on context (#141331) · c3552191

Andrew Kolos authored Jan 11, 2024

Part of work on https://github.com/flutter/flutter/issues/141330, which is a part of work on https://github.com/flutter/flutter/issues/140092

This is a refactoring; there should be no behavioral changes in these tests.

c3552191

Expose 'enable' property to allow the user to disable the SearchBar (#137388) · e281c391

Gianluca Bettega authored Jan 11, 2024

This exposes the `enabled` property of the `TextField` widget to the `Searchbar` widget.

## Related Issues

https://github.com/flutter/flutter/issues/136943

Still missing tests

e281c391

Add impeller key to skia gold client, Turn on a framework test shard that will... · 35903620

Jonah Williams authored Jan 11, 2024

Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (#141341)

Redo of https://github.com/flutter/flutter/pull/140985 due to CLA issues.

35903620

[Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (#140976) · 9f2e681e

Dan Field authored Jan 11, 2024

This should wait for some upstream work, just don't want to lose it locally for now. I'll switch this from draft and update the description when it's ready.

9f2e681e

Roll Packages from 378e70006863 to 0744fe6fdb31 (6 revisions) (#141378) · f5fb61b9

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/packages/compare/378e70006863...0744fe6fdb31

2024-01-11 10687576+bparrishMines@users.noreply.github.com [quick_actions_android] Close system dialogs for integration test (flutter/packages#5853)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter/packages#5712)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#5713)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#5708)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#5703)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter from 126302df to b840a60d (29 revisions) (flutter/packages#5855)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5fb61b9

Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (#141359) · 2216a780

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/engine/compare/efd0eb62f4aa...ecdaed76f284

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 5d4f12f3f12d to c46008e5a839 (1 revision) (flutter/engine#49708)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2216a780

Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (#141356) · 60f503db

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/engine/compare/ade9f18fa008...efd0eb62f4aa

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from e80a6830eb4d to 5d4f12f3f12d (1 revision) (flutter/engine#49706)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from ae45496c55e2 to e80a6830eb4d (2 revisions) (flutter/engine#49705)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

60f503db

Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (#141337) · 3e5cad03

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/engine/compare/42e3e0236112...ade9f18fa008

2024-01-11 dnfield@google.com [Impeller] Vulkan runtime effects/fragment program API (flutter/engine#49543)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5a6a2ccace to 3245b92a5930 (1 revision) (flutter/engine#49700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e5cad03

Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (#141327) · 085aaa5d

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/engine/compare/f39f5ca18328...42e3e0236112

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 596053dde5f0 to ae45496c55e2 (1 revision) (flutter/engine#49695)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from d1fbb9177115 to 596053dde5f0 (1 revision) (flutter/engine#49694)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

085aaa5d

Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (#141322) · d1f3ae73

engine-flutter-autoroll authored Jan 11, 2024

https://github.com/flutter/engine/compare/431d64dbb4b8...f39f5ca18328

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2f254f5d41f2 to d1fbb9177115 (1 revision) (flutter/engine#49692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1f3ae73

Add dart fix support to flutter_driver (#141300) · 97857180

Kate Lovett authored Jan 11, 2024

Part of https://github.com/flutter/flutter/issues/139249

This adds dart fix support plus fixes for APIs that are currently deprecated in the flutter_driver package.

97857180

Fix a leak. (#141312) · 13684ca4
Polina Cherkasova authored Jan 11, 2024

13684ca4