- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 11 May, 2023 1 commit
-
-
Michael Goderbauer authored
Sync lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml and enable `implicit_reopen` and `type_literal_in_constant_pattern` (which have no violations). Also contains some clean-up work towards enabling `matching_super_parameters`, which is not quite ready yet due to its handling of "private" arguments.
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by: Michael Goderbauer <goderbauer@google.com>
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 28 Jul, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Jul, 2022 1 commit
-
-
Tong Mu authored
-
- 30 Jun, 2022 1 commit
-
-
Tong Mu authored
-
- 21 Jun, 2022 1 commit
-
-
Tong Mu authored
* Impl * Fix build * Add test
-
- 16 Jun, 2022 1 commit
-
-
Tong Mu authored
* Impl * Test
-
- 20 May, 2022 1 commit
-
-
Tong Mu authored
-
- 12 May, 2022 1 commit
-
-
Tong Mu authored
-
- 14 Apr, 2022 1 commit
-
-
Tong Mu authored
-
- 29 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 07 Sep, 2021 1 commit
-
-
Anis Alibegić authored
-
- 29 Jul, 2021 2 commits
- 28 Jul, 2021 1 commit
-
- 27 Jul, 2021 1 commit
-
-
Tong Mu authored
-
- 26 Jul, 2021 1 commit
-
-
Tong Mu authored
-
- 20 Jul, 2021 1 commit
-
-
Greg Spencer authored
The (new, not yet used) code gen for iOS was setting up a std::map from key codes to logical and physical key codes, but it was using uint32_t, which isn't big enough to hold the Flutter key codes. Also, iOS needs to be able to filter out function keys, so I added a function key set.
-
- 14 Jul, 2021 1 commit
-
-
Tong Mu authored
This PR updates the ID used by logical keyboard keys. The logical key ID is still composed of 2 parts: 32 bits of value, and 8 bits of plane. But the assignment of planes has been drastically changed. HID plane is removed, and unprintable plane and Flutter plane are added. This is to reflect the new generation method for logical key IDs. Now keys that are defined by Flutter but not by dom_key_data are placed into the Flutter plane, including numpad keys, sided modifier keys, and gamepad keys. The values for platform planes have also been adjusted. The generation script and README have been updated accordingly as well. A new file, test_utils/key_codes.h is now generated to assist engine unit testing. All lists generated by the script are now sorted by the key.
-
- 01 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 17 Jun, 2021 1 commit
-
-
Tong Mu authored
-
- 14 Jun, 2021 1 commit
-
-
Greg Spencer authored
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated. Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
-
- 02 Jun, 2021 1 commit
-
-
Tong Mu authored
Adds tests to the following behaviors, which have existed without tests: - When tapping during live testing, a message is printed with widgets that contain the tap location. - When tapping during live testing, a mark is displayed on screen on the tap location.
-
- 26 May, 2021 1 commit
-
-
Greg Spencer authored
This adds iOS key map generation that uses std::maps. It uses std::maps because on iOS if we use NSDictionaries, then when XCode loads the dylib, the initialization of those status NSDictionaries hasn't yet occurred, and it crashes the app. std::maps have a well-defined static behavior, and are correctly initialized. I also made the naming of variables, fields, etc. consistent for macOS. We variously had macosFoo, macOSFoo, and macOsFoo. I eliminated macOsFoo and macosFoo, since the rest of the repo uses macOSFoo for lowerCamelCase names (with only a few exceptions). I used iOSFoo for iOS.
-
- 21 May, 2021 1 commit
-
-
nt4f04uNd authored
-
- 11 May, 2021 1 commit
-
-
Greg Spencer authored
I noticed that tab traversal stopped working on iOS when #73440 was landed. It seems to be that the control characters were excluded from the list of logical keys, and so they ended up being generated values. This PR just adds "Enter" and "Tab" to the list for both macOS and iOS.
-
- 10 May, 2021 1 commit
-
-
Tong Mu authored
Removes webValues from logical_key_data.json. Web's logical mapping should map webNames to logical key values, i.e. entry.value.
-
- 02 May, 2021 1 commit
-
-
Phil Quitslund authored
-
- 01 May, 2021 1 commit
-
-
Tong Mu authored
Rewrites tools/gen_keycodes, the script that generates key mappings across the framework and the engine.
-
- 21 Apr, 2021 1 commit
-
-
Phil Quitslund authored
-
- 01 Apr, 2021 1 commit
-
-
Tong Mu authored
-
- 28 Mar, 2021 1 commit
-
-
Tong Mu authored
-