- 19 Jan, 2024 15 commits
-
-
Reid Baker authored
packages Roller breakage https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/5504/overview Fixes flutter/flutter/issues/141897 ``` FAILURE: Build failed with an exception. * Where: Script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 168 * What went wrong: Could not compile script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy'. > startup failed: script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy': 168: primitive type parameters not allowed here; solution: use the corresponding wrapper type, such as Integer for int @ line 168, column 41. e static final Map<String, int> ABI_VERS ``` Covered by tests in packages.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c953c83112ba...f2b441a26416 2024-01-19 jonahwilliams@google.com Reland: Encode directly to command buffer. (flutter/engine#49821) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 2536dc6fef1d to c09908c48f14 (6 revisions) (flutter/engine#49899) 2024-01-19 dnfield@google.com [Impeller] Documentation for SurfaceContextVK (flutter/engine#49882) 2024-01-19 32242716+ricardoamador@users.noreply.github.com Adding ignore paths to cache test (flutter/engine#49874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Daco Harkes authored
Packages the native assets for iOS and MacOS in frameworks. Issue: * https://github.com/flutter/flutter/issues/140544 * https://github.com/flutter/flutter/issues/129757 ## Details * [x] This packages dylibs from the native assets feature in frameworks. It packages every dylib in a separate framework. * [x] The dylib name is updated to use `@rpath` instead of `@executable_path`. * [x] The dylibs for flutter-tester are no longer modified to change the install name. (Previously it was wrongly updating the install name to the location the dylib would have once deployed in an app.) * [x] Use symlinking on MacOS.
-
Ian Hickson authored
Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (#141814) Reverts https://github.com/flutter/flutter/pull/140101 That PR somehow made non-matching gold tests not fail at HEAD. Fixes https://github.com/flutter/flutter/issues/141880 - Blocked by https://github.com/flutter/flutter/issues/140169 - https://github.com/flutter/flutter/pull/141427
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/538975f2511b...c953c83112ba 2024-01-19 flar@google.com [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816) 2024-01-19 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9a6c64de8a46...538975f2511b 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890) 2024-01-19 103135467+sealesj@users.noreply.github.com Re-enable osv-scanner on pushes to main (flutter/engine#49729) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889) 2024-01-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887) 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886) 2024-01-19 leroux_bruno@yahoo.fr [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dTy8CK4YxnUs to geXIwPzzJiSX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Much nicer calling API and simplifies evolving this API in the future. I wish we could write a dart fix for this, but that's blocked on https://github.com/dart-lang/sdk/issues/54668.
-
fzyzcjy authored
The old doc says that, AutomatedTestWidgetsFlutterBinding for `flutter test` and LiveTestWidgetsFlutterBinding for `flutter run`. However, suppose we `flutter test integration_test/simple_test.dart` with the following code: ``` void main() { testWidgets('hi', (WidgetTester tester) async { print('hi ${TestWidgetsFlutterBinding.instance} ${Platform.operatingSystem}'); }); } ``` We will see: `hi <IntegrationTestWidgetsFlutterBinding> ios`. Therefore, we see `IntegrationTestWidgetsFlutterBinding` is used in a `flutter test` command, which is contrary to the documentation. -
Zachary Anderson authored
Includes the Engine roll from https://github.com/flutter/flutter/pull/141841 A new version of Dart is having trouble with the tool integration test test `passing one file with errors are detected`: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/31851/overview. However the analysis server emits the expected errors when we give it both the file without issues and the file with issues. My guess is that the analysis server has changed it's behavior slightly when supplied with a single malformed file. Since the Dart roll is >20 dev versions behind, and this is the only failing presubmit test, and it's testing something a bit weird, I suggest we investigate the right way to test the thing that test was attempting to cover as a follow-up.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/83c2c4da97c5...129e08c1dff1 2024-01-19 magder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934) 2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935) 2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933) 2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931) 2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930) 2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795) 2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921) 2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922) 2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925) 2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905) 2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0b to f77f8243 (25 revisions) (flutter/packages#5924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
godofredoc authored
This is in preparation to allow tests to run on x64 and arm64 if they rely only on the ios phone.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/90be25d8aac3...d1afda52d254 2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from c71519e854d1 to dd24bd11d79e (1 revision) (flutter/engine#49878) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
Turns out all implementations of this method made this call, so it seems like it should belong in the superclass.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dde3ebf6551a...90be25d8aac3 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from da3bfb25fb84 to c71519e854d1 (1 revision) (flutter/engine#49875) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 18 Jan, 2024 25 commits
-
-
Yegor authored
- Unskip `text_style_test` for CanvasKit. - Remove no longer necessary `kIsWeb` checks in a few tests. This PR depends on https://github.com/flutter/engine/pull/49786, which rolled into the framework. If the engine PR needs to be reverted, this PR will need to be reverted too.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9dded186bcff...dde3ebf6551a 2024-01-18 737941+loic-sharma@users.noreply.github.com [Windows] Refactor logic when window resize completes (flutter/engine#49872) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 40200ceca00e to da3bfb25fb84 (1 revision) (flutter/engine#49873) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
David Martos authored
This PR improves the distance between the label and the icon in the Tab widget. I updated the margin to 2 pixels, taken from the Figma design page for Material 3. On Material 2 I left the default value of 10 pixels. Related to #128696 (In particular, the distance between label and icon) Here are some screenshots for comparison. I looked a bit into the other mentioned issue of the tab height not following the M3 spec. Flutter uses 72 and the spec uses 64. But because Tab is a PreferredSizeWidget, I don't think there is an easy way to provide a different size depending on `ThemeData.useMaterial3`, because there is no `BuildContext` available. I provide a sample image for the 64 height as well for context on the linked issue, even though it's not part of the PR changes. The screenshots are taken side by side with the image at: https://m3.material.io/components/tabs/guidelines ## Original  ## New (tab height = 72, Flutter default for 8 years)  ## New (tab height = 64, M3 spec) 
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3106e08e1219...9dded186bcff 2024-01-18 fmil@google.com [fuchsia] Wire through the tzdata-icu capability (flutter/engine#48907) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 31fae9f0cdd1 to 40200ceca00e (1 revision) (flutter/engine#49871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#137618 Initiated by: Jasguerrero This change reverts the following previous change: Original Description: It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented. Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows. This is available only for master channel (on other channels, it fallbacks to windows-x64). On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
-
godofredoc authored
This is to ensure coverage in both platforms.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f4a4f046b173...3106e08e1219 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 1064eeedac09 to 31fae9f0cdd1 (1 revision) (flutter/engine#49869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
dependabot[bot] authored
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v4.2.0</h2> <h2>What's Changed</h2> <ul> <li>Ability to overwrite an Artifact by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/501">actions/upload-artifact#501</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.2.0">https://github.com/actions/upload-artifact/compare/v4...v4.2.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/694cdabd8bdb0f10b2cea11669e1bf5453eed0a6"><code>694cdab</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/501">#501</a> from actions/robherley/overwrite-artifact</li> <li><a href="https://github.com/actions/upload-artifact/commit/05d4fe67025ed6d5b746e3502573715a2c37e318"><code>05d4fe6</code></a> run licensed against version that matches ci</li> <li><a href="https://github.com/actions/upload-artifact/commit/40b305282182ab3d3265c0c45fd82dee1e605ace"><code>40b3052</code></a> update readme</li> <li><a href="https://github.com/actions/upload-artifact/commit/49552fcb82fc92c668b492a7d36fc7860a20c81d"><code>49552fc</code></a> add overwrite tests to workflow</li> <li><a href="https://github.com/actions/upload-artifact/commit/79615904cc1dfafb77b85c0d3a21f89dba2a38c2"><code>7961590</code></a> licensed cache</li> <li><a href="https://github.com/actions/upload-artifact/commit/11ff42c7b1b52130283d8a02bc960d1e1de95000"><code>11ff42c</code></a> add new overwrite input & docs</li> <li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/1eb3cb2b3e0f29609092a73eb033bb759a334595...694cdabd8bdb0f10b2cea11669e1bf5453eed0a6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Michael Goderbauer authored
* `flutter_web_plugins` didn't have a label that would make PRs show up for team triage, now they are assigned to the web team so they don't fall through the cracks * `flutter_goldens_client` doesn't exist anymore, deleted * `integration_test` PRs should be treated like `flutter_test` or `flutter_driver` PRs and get the `a: tests` label.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/75400c49fa0b...f4a4f046b173 2024-01-18 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fall back to multi-context rendering on Firefox and Safari (flutter/engine#49572) 2024-01-18 godofredoc@google.com Use any mac machine available for orchestrator run. (flutter/engine#49845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
Fixes https://github.com/flutter/flutter/issues/141119 Original PR: https://github.com/flutter/flutter/pull/141138 Revert: https://github.com/flutter/flutter/pull/141479 Reason for revert: https://fusion2.corp.google.com/presubmit/597877179/OCL:597877179:BASE:597883748:1705084754455:88d992fc/targets Fix: cl/599347719
-
Callum Moffat authored
Now trackpad gestures will count as pointerCount=2 instead of 1. It makes it easier for people who want to have different behaviour for single-finger drag vs two-finger pan/zoom. Also fixed up `scale_test.dart` to verify `pointerCount` in more places. Related: https://github.com/flutter/flutter/issues/13102 Fixes https://github.com/flutter/flutter/issues/140730
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/de68e7612948...75400c49fa0b 2024-01-18 103135467+sealesj@users.noreply.github.com Simplify osv-scanner workflow (flutter/engine#49807) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from b1611add5939 to 1064eeedac09 (6 revisions) (flutter/engine#49867) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Attempting to debug https://github.com/flutter/flutter/issues/141383.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d80fe1cb5854...de68e7612948 2024-01-18 dnfield@google.com [Impeller] Eliminate some shared_ptr copying from EntityPass::Render (flutter/engine#49855) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Pierrick Bouvier authored
It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented. Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows. This is available only for master channel (on other channels, it fallbacks to windows-x64). On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
-
Xilai Zhang authored
revision 01/17: instead of removing actions/checkout, keep actions/checkout but remove the `token` field and add `persist-credentials` field. tested with a [mirror script](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml) and creates [expected pull request](https://github.com/flutter/flutter/pull/141730) Issue: when running github actions, the [tokens not found error](https://github.com/actions/checkout/issues/298) still happens( `Input required and not supplied: token`). We are not using fork PR or dependabot, and it's flaky when the well defined token isn't find in the inputs. We hit this error when invoking [market place actions/checkout](https://github.com/actions/checkout): [example failed run 1](https://github.com/flutter/flutter/actions/runs/7546108771/job/20543199801), [example failed run 2](https://github.com/flutter/flutter/actions/runs/7546141972/job/20543265842) In this PR, Remove the dependency on marketplace actions to make our workflow more reliable and less flaky. other changes to remove actions/checkout dependency: 1. embedded token url for git push Tried a number of ways and this is the only / best workaround I found to resolve [the notorious problem of pushing without ssh key](https://stackoverflow.com/questions/22147574/github-fatal-could-not-read-username-for-https-github-com-no-such-file-o). 2. added back `--head` `--head` is now needed to avoid [abort](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548409479/job/20550397014) Test: a [replicate of the actions file](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml) is [tested](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548448024/job/20550521341) on my personal repo, and it creates the [expected PR](https://github.com/flutter/flutter/pull/141647)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b75d6d80d813...d80fe1cb5854 2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jesús S Guerrero authored
b/320767653 Reverts flutter/flutter#141684
-
Pierre-Louis authored
These have 1:1 replacements with a new name, introduced in https://github.com/flutter/flutter/pull/129942 Land after https://github.com/flutter/packages/pull/4898 Part of https://github.com/flutter/flutter/issues/116525 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Renzo Olivares authored
Previously `TextField`s error `cursorColor` was being derived without taking into account any `InputDecorationTheme` defaults. This change respects `InputDecorationTheme` defaults when deriving the error `cursorColor`. Fixes #140607
-
yaakovschectman authored
Add a warning to Flutter Doctor if Topaz OFD is found as a process on the system. The protection module used by the Bank of Brazil has been identified as causing build failures when using VS with CMake for Windows (see https://github.com/flutter/flutter/issues/121366#issuecomment-1845703728). Disabling the software allows the build to succeed again. If a running process is found by `flutter doctor` whose path contains `Topaz OFD\Warsaw\core.exe`, a warning message is generated to convey this. Addresses https://github.com/flutter/flutter/issues/121366 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Elias Yishak <42216813+eliasyishak@users.noreply.github.com> Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
-
Reid Baker authored
Move static methods together. Fix property uses of duplicate strings. Add types wherever obvious Fix format depth Add whitespace to top and bottom of classes Ignore line length for file Ignore prefer single quote for file Ignore correction for getFoo used instead of foo Loosely related to flutter/flutter/issues/123934
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/1a2b780c9108...83c2c4da97c5 2024-01-18 stuartmorgan@google.com [google_maps_flutter] Restore the arm64 workaround (flutter/packages#5915) 2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the KotlinGenerator (flutter/packages#5891) 2024-01-17 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkebview] Verify JavaScriptChannels have a unique name (flutter/packages#5904) 2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the `DartGenerator` (flutter/packages#5859) 2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter from 8e94423e to def6af0b (23 revisions) (flutter/packages#5911) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/49fa2cb9024f...b75d6d80d813 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 1b2909f1eac7 to 7b3d788ba978 (1 revision) (flutter/engine#49861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
![dependabot[bot]'s avatar](https://secure.gravatar.com/avatar/48ea49be76d0c68403a7f3df87e3487d?s=80&d=identicon "dependabot[bot]")
