1. 07 Feb, 2024 1 commit
    • Chris Bracken's avatar
      [Windows] Fix signed/unsigned int comparison (#142341) · 9f8fe3f0
      Chris Bracken authored
      Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
      
      ```
      windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
      ```
      
      WideCharToMultiByte returns:
      * 0 on error
      * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
      
      As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
      
      No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
      
      Fixes: https://github.com/flutter/flutter/issues/134227
      9f8fe3f0
  2. 13 Feb, 2023 1 commit
  3. 30 Jun, 2022 1 commit
  4. 08 Mar, 2022 1 commit
    • Chris Bracken's avatar
      Check string size before Win32 MultiByte <-> WideChar conversions (#99729) · b5d3c432
      Chris Bracken authored
      This patch adds an additional check to ensure the target length of a string is within the supported maximum string length prior to calling WideCharToMultiByte/MultiByteToWideChar in the Windows runner template.
      
      This is to prevent resize() from failing if called with a count > std::string::max_size().
      
      According to Win32 API docs (WideCharToMultiByte, MultiByteToWideChar) it's the caller responsibility to make sure the buffers are correctly allocated.
      
      Authored by: Tomasz Gucio <tgucio@gmail.com>
      b5d3c432
  5. 07 Jun, 2021 1 commit
  6. 28 Sep, 2020 1 commit
  7. 03 May, 2020 1 commit