- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 28 Jul, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 29 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 02 Jun, 2021 2 commits
-
-
Dan Field authored
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 28 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 22 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 21 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 22 Nov, 2019 1 commit
-
-
Greg Spencer authored
No code changes, just comments: I spell-checked all the comments in the repo.
-
- 28 Jun, 2019 1 commit
-
-
Dan Field authored
Default `semanticsEnabled` to true for `testWidgets` and fix associated bugs
-
- 25 May, 2019 1 commit
-
-
Chris Bracken authored
Updates documentation and non-public API to use American spellings for consistency with the rest of the codebase. No changes to behaviour... other than how it's spelt.
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 22 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* some space formattings * always use blocks in if-else if a block is used * format spaces in for and while * allow multiline if conditions * fix missing space
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2018 1 commit
-
-
Jason Simmons authored
-
- 06 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Oct, 2017 1 commit
-
-
Greg Spencer authored
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint. Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols. Addresses #12311
-
- 27 Apr, 2017 1 commit
-
-
Ian Hickson authored
backgroundColor -> color backgroundImage -> image BackgroundImage -> DecorationImage
-
- 20 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* comprehensive list of lints * add comments to commented out lint * fix unnecessary_this lints * exclude prefer_final_fields
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 05 Apr, 2017 1 commit
-
-
Ian Hickson authored
This yak shave went as follows: Fix https://github.com/flutter/flutter/issues/8795 by adding stocks to the examples README. Notice the layers entry in that README isn't quite right either. Update that. Check the layers/README file is worth pointing at. Update the layers/README. Let's run some of the layer tests to see if they still work. Oops, need to update them to gradle. Ok let's try running them again. Oops, sector is broken. Add a test for sector. Fix sector. Find you need to add an assert to a const constructor. Notice we need to turn const asserts on for the analyzer. Notice the analysis_options files are out of sync with each other and with the full list of lints. Turn on the lints that should be on. Fix the bugs that finds.
-
- 15 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
-
- 21 Feb, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jun, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that the parent is notified when they change. Fixes #2298
-