* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests

* Revert "iOS Dialog blur, brightness, and layout (#18381)"

This reverts commit 21bc9f1b.

* Revert "Flutter tool support for dynamic code. (#20543)"

This reverts commit 25ba90aa.

This removes the final traces of Travis and Appveyor from the Flutter tree.

I've updated the documentation and fixed a couple of places where scripts look for Travis, and eliminated the dart tools runningOnTravis function (which was unused anyhow).

There are places in the flutter script that used to look for the environment variable TRAVIS. We actually do want to continue to detect that we're running on Travis there, since in the plugins repo we still use Travis (for the moment). In any case, it's OK, because the CI environment variable is set on all of the CI bots (Cirrus, Travis, and Appveyor).

FastLane doesn't have a setup_cirrus equivalent to setup_travis, but it actually doesn't matter there either, since it doesn't do Travis-specific things, and it also looks for the CI environment variable.

It was causing problems rolling Flutter into Fuchsia

* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)

This reverts commit cc1cf13e.

* adjust declared types to work with dart 2 typing at runtime

* review comments

* update packages/flutter_tools/lib/src/ios/simulators.dart

(second attempt)

fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb24. (#18362)
This reverts commit 3daebd05. (#18316)

Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.

This reverts commit 4f1b6604.

Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)

This reverts commit 32586020.

Fixes #18028

Just changes typedef declarations, no logic changes.

This updates AppContext per the recommendations in #15352

Fixes #15352

It was failing in the case of an AppContext being in scope
but not having a `BotDetector` seeded in it.

* Fix packages tests when run off bots

* Tweak dependencies to make bots happy

* Review comment

* First version

* Prevent modification of .flutter during analytics test

* Pass in directory and override analyzer warning due to conditional import

* Review comments

I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.

This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.

* enable lint prefer_foreach

* fix tests

* round 2

* deal with null futures

* review

* review

* review

* review

* perform the initial poll for devices quicker

* add a Poller class

* test the new Poller class

Eagerly generate local.properties, and always update the flutter.sdk
setting in it, in case FLUTTER_ROOT has changed.

Fixes #8365.
Fixes #9716 - at least the specific issue reported. My Android Studio
still complains about Gradle versions - it ships with v3.2, but requires
v3.3...

Add a 'generate dependencies' task to the Gradle build, which checks if
the snapshot dependencies file exists, and runs an extra build before
the actual FlutterTask if it doesn't. This makes the first build slower,
but sub-sequent builds (without source changes) much faster.

Fixes #9717.

* Populate PUB_ENVIRONMENT for initial pub get

* review comments

* change order

FlutterCommand.runCommand subclasses can optionally return a FlutterCommandResult which is used to append additional analytics. 

Fix flutter run timing report and add a bunch of dimensional data