1. 31 Aug, 2018 1 commit
  2. 30 Aug, 2018 2 commits
  3. 28 Aug, 2018 4 commits
  4. 24 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Ignore pub-cache when analyzing (#20925) · 977da4fb
      Greg Spencer authored
      This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.
      
      Also, I centralized the ANSI "red line" so that they would all use the same final string.
      977da4fb
  5. 23 Aug, 2018 2 commits
    • Danny Tuppeny's avatar
      Start logger in startProgress to avoid assertion failure (#20814) · dc5a5c18
      Danny Tuppeny authored
      * Start logger in startProgress to avoid assertion failure
      
      There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).
      
      Fixes #20812.
      
      * Enable asserts for tools tests
      
      * Fix lint
      
      * Rename enableAsserts -> enableFlutterToolAsserts
      
      To make it clearer that it only enables asserts for flutter_tools when set.
      dc5a5c18
    • Jonah Williams's avatar
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo... · 99b38295
      Jonah Williams authored
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700)
      
      99b38295
  6. 20 Aug, 2018 1 commit
    • Ian Hickson's avatar
      `flutter analyze` cleanup (#20490) · ad1eaff4
      Ian Hickson authored
      * `flutter analyze` cleanup
      
      * Make `--dartdocs` work in all modes.
      * Make `analyze-sample-code.dart` more resilient.
      * Add a test for `analyze-sample-code.dart`.
      * Minor cleanup in related code and files.
      
      * Apply review comments
      
      * Fix tests
      ad1eaff4
  7. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  8. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  9. 15 Aug, 2018 4 commits
    • Martin Kustermann's avatar
      Reland "Roll engine to version e3687f70c7ece72000b32ee1b3c02755ba5361ac (#20427)" (#20633) · 9299c02c
      Martin Kustermann authored
      * Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)"
      
      This is a re-land with downgraded `package:flutter_gallery_assets`
      version.
      
      * Downgrade package:flutter_gallery_assets to 0.1.4
      
      * Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix)
      
      * Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
      9299c02c
    • Martin Kustermann's avatar
      Revert "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)" (#20631) · 515909ec
      Martin Kustermann authored
      Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
      515909ec
    • Martin Kustermann's avatar
      Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427) · c7c493ea
      Martin Kustermann authored
      This CL
      
        * rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev)
        * rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine)
        * changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b
        * adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted) 
        * upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
      c7c493ea
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  10. 12 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Switch from infinite retries on upgrade to 10 retries. (#20450) · 01d64444
      Greg Spencer authored
      This changes the flutter tool to just try 10 times before giving up when running "flutter upgrade". Infinite retries can hang bots, and really don't provide a lot of help: if we've failed to upgrade for for nearly a minute, trying every five seconds, then something is just not responding.
      
      Also, changed the bot default warning level to "normal" from "all", because the solver messages are VERY verbose: several megs of output for doing packages get on Flutter. "normal" will give warnings, user messages and errors, which should be sufficient to diagnose problems on the bots without spamming the log.
      
      I removed the retrying for building the snapshot on flutter.bat because we don't do that on the other platforms, and because I can't imagine how running it again would give a different answer.
      
      I also fixed a problem in the whitespace detection when no files matched the type of file that it is looking for, and removed the code that waits until failure to print the logs on setup, since reducing the log output made a huge difference.
      01d64444
  11. 08 Aug, 2018 1 commit
  12. 07 Aug, 2018 3 commits
    • Greg Spencer's avatar
      Remove Travis configuration from flutter/flutter (#20288) · e60087a1
      Greg Spencer authored
      This removes the final traces of Travis and Appveyor from the Flutter tree.
      
      I've updated the documentation and fixed a couple of places where scripts look for Travis, and eliminated the dart tools runningOnTravis function (which was unused anyhow).
      
      There are places in the flutter script that used to look for the environment variable TRAVIS. We actually do want to continue to detect that we're running on Travis there, since in the plugins repo we still use Travis (for the moment). In any case, it's OK, because the CI environment variable is set on all of the CI bots (Cirrus, Travis, and Appveyor).
      
      FastLane doesn't have a setup_cirrus equivalent to setup_travis, but it actually doesn't matter there either, since it doesn't do Travis-specific things, and it also looks for the CI environment variable.
      e60087a1
    • liyuqian's avatar
      Update build bot update instructions (#20301) · 0630518b
      liyuqian authored
      `run_recipe.py` has been removed and waterfall is deprecated...
      0630518b
    • Greg Spencer's avatar
      Try again to switch docs and gallery deployment to Cirrus (#20276) · 77645df7
      Greg Spencer authored
      This switches docs and gallery build and deployment to use Cirrus CI instead of Travis, reapplying the changes from #19925, but updating the Firebase tokens for upload, and refining docs.sh some to limit retries to five times (instead of indefinitely).
      77645df7
  13. 06 Aug, 2018 1 commit
  14. 04 Aug, 2018 2 commits
  15. 02 Aug, 2018 3 commits
  16. 01 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Fix the whitespace check. (#20059) · 2a66fd34
      Greg Spencer authored
      I switched to just checking for spaces and tabs, since otherwise it expresses a preference for line endings that I think should be taken care of at the git level (and I think they are).
      
      I also fixed a bug where I was looking for ".yml" instead of "*.yml" files, and clarified an output message.
      2a66fd34
  17. 30 Jul, 2018 3 commits
  18. 27 Jul, 2018 1 commit
  19. 26 Jul, 2018 1 commit
  20. 25 Jul, 2018 1 commit
  21. 24 Jul, 2018 1 commit
  22. 23 Jul, 2018 3 commits
  23. 20 Jul, 2018 1 commit