1. 08 Dec, 2023 1 commit
    • Bruno Leroux's avatar
      Add 'Share' button to the selection toolbar on Android (#139479) · e070417a
      Bruno Leroux authored
      ## Description
      
      This PR adds the 'Share' button to the text selection toolbar on Android.
      
      ## Related Issue
      
      Fixes https://github.com/flutter/flutter/issues/138728
      
      ## Tests
      
      Refactor a lot of existing tests in order to:
      - make them more readable (avoid duplication by introducing helper functions, specify explictly check which buttons are expected).
      - make them more accurate (check that expected buttons are visible instead of just checking the number of buttons).
      
      For instance, previous tests contained sections such as:
      
      ```dart
      
            // Collapsed toolbar shows 3 buttons.
            expect(
              find.byType(CupertinoButton),
              isContextMenuProvidedByPlatform ? findsNothing : isTargetPlatformIOS ? findsNWidgets(6) : findsNWidgets(3)
            );
      
      ```
      
      Where the comment is obsolete, the two cases (6 widgets and 3 widgets) are not explicit (which buttons are expected?), and not accurate (will pass if the number of buttons is right but the buttons are the wrong ones).
      e070417a
  2. 17 Aug, 2023 1 commit
  3. 08 Aug, 2023 1 commit
  4. 02 Aug, 2023 1 commit
  5. 06 Jul, 2023 1 commit
  6. 21 Apr, 2023 1 commit
  7. 25 Jan, 2023 1 commit
  8. 20 Dec, 2022 1 commit
    • Camille Simon's avatar
      [Android] Add spell check suggestions toolbar (#114460) · e0742ebb
      Camille Simon authored
      * Add spell check suggestions toolbar
      
      * Fix test and move menu
      
      * Cleanup
      
      * Cleanup and fix bug
      
      * More cleanup
      
      * Make height dynamic and use localized delete
      
      * Begin adding tests
      
      * Create var checking for results
      
      * Add tests
      
      * Fix analyze (sorta)
      
      * Add back hideToolbar call for testing
      
      * Add back hidetoolbar in ts and delete one in et
      
      * Remove unecessary calls to hidToolbar
      
      * Fix analyze and docs
      
      * Test fix
      
      * Fix container issue
      
      * Clean up
      
      * Fix analyze
      
      * Move delegate
      
      * Fix typos
      
      * Start addressing review
      
      * Continue addressing review
      
      * Add assert
      
      * Some refactoring
      
      * Add test for button behavior
      
      * Undo test change
      
      * Make spell check results public
      
      * Rearrange test
      
      * Add comment
      
      * Address review
      
      * Finish addressing review
      
      * remove unused imports
      
      * Address nits
      
      * Address review
      
      * Fix formatting
      
      * Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints
      
      * Fix analyze:
      e0742ebb
  9. 28 Oct, 2022 1 commit
    • Justin McCandless's avatar
      Context Menus (#107193) · 0b451b6d
      Justin McCandless authored
      * Can show context menus anywhere in the app, not just on text.
      * Unifies all desktop/mobile context menus to go through one class (ContextMenuController).
      * All context menus are now just plain widgets that can be fully customized.
      * Existing default context menus can be customized and reused.
      0b451b6d