Commits · 664915f38b1f6c1f033be89abc47d7ab0cf1f090 · abdullh.alsoleman / Front-End

24 Oct, 2023 12 commits

Roll Flutter Engine from 7224835bb65f to ca7ef01c99c6 (1 revision) (#137153) · 664915f3

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/7224835bb65f...ca7ef01c99c6

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from fb6e09449f71 to 86df55671e1d (1 revision) (flutter/engine#47261)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

664915f3

fix some typos (#137144) · c5e71b3e

cui fliter authored Oct 24, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

fix some typos

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c5e71b3e

Roll Flutter Engine from 8f7488e0b4b5 to 7224835bb65f (1 revision) (#137150) · 4dd48905

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/8f7488e0b4b5...7224835bb65f

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 70978e42479c to fb6e09449f71 (1 revision) (flutter/engine#47260)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dd48905

Roll Flutter Engine from d58895093d0a to 8f7488e0b4b5 (3 revisions) (#137135) · 5effaf34

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/d58895093d0a...8f7488e0b4b5

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from b3923b715c50 to 70978e42479c (1 revision) (flutter/engine#47257)
2023-10-24 chinmaygarde@google.com Update fml::ThreadPriority enum to match style guide. (flutter/engine#47255)
2023-10-24 jonahwilliams@google.com [Impeller] Adjustments to SubmitKHR and queries. (flutter/engine#47249)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5effaf34

Roll Flutter Engine from 2a8471f188cd to d58895093d0a (4 revisions) (#137130) · e6bf3ffc

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/2a8471f188cd...d58895093d0a

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 82f665328e96 to b3923b715c50 (1 revision) (flutter/engine#47256)
2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from a3CcHQHJIAEr-O2R0... to OUWiWfUxyMyDOlEfA... (flutter/engine#47254)
2023-10-24 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/engine#47252)
2023-10-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (flutter/engine#47253)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from a3CcHQHJIAEr to OUWiWfUxyMyD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e6bf3ffc

Roll Flutter Engine from 71600d89aa3f to 2a8471f188cd (2 revisions) (#137129) · dc78bf66

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/71600d89aa3f...2a8471f188cd

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 8632561c828a to 82f665328e96 (1 revision) (flutter/engine#47251)
2023-10-24 chinmaygarde@google.com [Impeller] Update shader pipeline image with a chart. (flutter/engine#47250)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dc78bf66

Roll Flutter Engine from 3dd197dcf9e5 to 71600d89aa3f (1 revision) (#137127) · 6e02e40a

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/3dd197dcf9e5...71600d89aa3f

2023-10-24 chinmaygarde@google.com [Impeller] Rename blobcat to shader_archive(r). (flutter/engine#47247)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6e02e40a

Roll Flutter Engine from bdbd1058858b to 3dd197dcf9e5 (2 revisions) (#137125) · 62b6414c

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/bdbd1058858b...3dd197dcf9e5

2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uW96BsI9g7PF2on-4... to 7Cq6zmNZ_1UTJoQUE... (flutter/engine#47245)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 6711d27055e8 to 8632561c828a (1 revision) (flutter/engine#47246)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uW96BsI9g7PF to 7Cq6zmNZ_1UT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62b6414c

Roll Flutter Engine from 0ef5caa91c40 to bdbd1058858b (1 revision) (#137119) · e4eecba7

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/0ef5caa91c40...bdbd1058858b

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from fd557c42e44c to 6711d27055e8 (1 revision) (flutter/engine#47244)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4eecba7

Reverts "Use `coverage.collect`'s `coverableLineCache` param to speed up coverage" (#137121) · 8df62188

auto-submit[bot] authored Oct 24, 2023

Reverts flutter/flutter#136851
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
One of the reasons gathering coverage information is expensive is that we have to force compile every function in the libraries we're interested in. Without this, functions that haven't been invoked (so haven't been compiled) won't have any line number information, so the coverage tool doesn't know which lines to add to the list of misses. In flutter's case, the test infra spawns many VMs, and each of these needs to recompile all those libraries.

To fix this, we need a way of skipping force compilation for libraries we've already seen in previous tests, without losing the information about which lines in each library are coverable. So I [added](https://github.com/dart-lang/coverage/pull/466) the `coverableLineCache` to `coverage.collect` in package:coverage v1.7.0. This cache starts out empty, but fills up with lists of all the lines that are coverable for every library as coverage is gathered. package:coverage can then tell the VM not to force compile any libraries in this cache (using `getSourceReport`'s `librariesAlreadyCompiled` param). So the first test suite will still have to compile everything, but subsequent test suites will be much faster.

This speeds up coverage collection significantly, for large test suites:

| Running flutter/packages/flutter tests... | Time | Overhead |
| --- | --- | --- |
| without coverage | 8:53 | - |
| with coverage | 20:25 | 130% |
| with `coverableLineCache` | 12:21 | 40% |

Bug: https://github.com/flutter/flutter/issues/100751

8df62188

Roll Flutter Engine from dd6a6531e816 to 0ef5caa91c40 (1 revision) (#137114) · d1884e7b

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/dd6a6531e816...0ef5caa91c40

2023-10-23 dkwingsmt@users.noreply.github.com Reland 2: Multiview Pipeline (flutter/engine#47239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1884e7b

Roll Flutter Engine from 0bd703132cc1 to dd6a6531e816 (2 revisions) (#137111) · 54e88a0b

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/0bd703132cc1...dd6a6531e816

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from fcad7b2b0027 to fd557c42e44c (2 revisions) (flutter/engine#47238)
2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 73e9879f06e7 to fcad7b2b0027 (1 revision) (flutter/engine#47236)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54e88a0b

23 Oct, 2023 28 commits

Roll Flutter Engine from abeab897a29c to 0bd703132cc1 (3 revisions) (#137107) · 27bc1cf6

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/abeab897a29c...0bd703132cc1

2023-10-23 zanderso@users.noreply.github.com Revert "Reland: Multiview pipeline " (flutter/engine#47237)
2023-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 53fee35b299f to 901e92d10627 (5 revisions) (flutter/engine#47235)
2023-10-23 dkwingsmt@users.noreply.github.com Reland: Multiview pipeline (flutter/engine#47234)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27bc1cf6

Upgrade packages in flutter and flutter_test. (#137106) · 5d43869c
Polina Cherkasova authored Oct 23, 2023

5d43869c

Bump ossf/scorecard-action from 2.2.0 to 2.3.1 (#137103) · 88ebc26a

dependabot[bot] authored Oct 23, 2023

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1282">ossf/scorecard-action#1282</a>
<ul>
<li>Adds additional Fuzzing detection and fixes a SAST bug related to detecting CodeQL. For a full changelist of what this includes, see the  <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.1">v4.13.1</a> release notes</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1">https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1</a></p>
<h2>v2.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.11.0 to v4.13.0 by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1270">ossf/scorecard-action#1270</a>
<ul>
<li>For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.12.0">v4.12.0</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.0">v4.13.0</a> release notes</li>
</ul>
</li>
<li>✨ Send rekor tlog index to webapp when publishing results by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1169">ossf/scorecard-action#1169</a></li>
<li>🐛 Prevent url clipping for GHES instances by <a href="https://github.com/rajbos"><code>@ârajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1225">ossf/scorecard-action#1225</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>📖 Update access rights needed to see the results in code scanning by <a href="https://github.com/rajbos"><code>@ârajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1229">ossf/scorecard-action#1229</a></li>
<li>📖 Add package comments. by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1221">ossf/scorecard-action#1221</a></li>
<li>📖 Add SECURITY.md file by <a href="https://github.com/david-a-wheeler"><code>@âdavid-a-wheeler</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250">ossf/scorecard-action#1250</a></li>
<li>📖 Fix typo in token input docs by <a href="https://github.com/aabouzaid"><code>@âaabouzaid</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258">ossf/scorecard-action#1258</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/david-a-wheeler"><code>@âdavid-a-wheeler</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250">ossf/scorecard-action#1250</a></li>
<li><a href="https://github.com/aabouzaid"><code>@âaabouzaid</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258">ossf/scorecard-action#1258</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0">https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/ossf/scorecard-action/commit/0864cf19026789058feabb7e87baa5f140aac736"><code>0864cf1</code></a> 🌱 Bump docker tag to for v2.3.1 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1284">#1284</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/72df3bff668d052aaec251accaffec0b280410fb"><code>72df3bf</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1282">#1282</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/0ea411f94ac145b6fd793458b7f75ebbe7ae0a8f"><code>0ea411f</code></a> 🌱 Bump the docker-images group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1281">#1281</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/dbfd042453ccc43ade96943685dbece2dd86bbae"><code>dbfd042</code></a> 🌱 Bump the github-actions group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1280">#1280</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/2fa1e2fa153141e2950c7e1299ed05e2081ead0c"><code>2fa1e2f</code></a> 🌱 Bump golang.org/x/net from 0.16.0 to 0.17.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1278">#1278</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/652ddd06c802ac1ba4021a9f02978dc5150b223e"><code>652ddd0</code></a> 🌱 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1277">#1277</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/28d0c92b8bb9dd266a8cf4dde7bae71c06a0c62f"><code>28d0c92</code></a> 🌱 Group Dependabot updates for GitHub Actions and Dockerfiles (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1276">#1276</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/cb50491a46a858cb57669a16a720b7a00e1f9d29"><code>cb50491</code></a> 🌱 Bump distroless/base from <code>a35b652</code> to <code>b31a6e0</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1275">#1275</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/87157ac77d7ec18a631049bc92fdac7ee63a471a"><code>87157ac</code></a> 🌱 Bump github/codeql-action from 2.21.9 to 2.22.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1274">#1274</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/7c1648b23e27a96acf7c3842fd1921d16bd8d4d2"><code>7c1648b</code></a> 🌱 Bump step-security/harden-runner from 2.5.1 to 2.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1273">#1273</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/08b4669551908b1024bb425080c797723083c031...0864cf19026789058feabb7e87baa5f140aac736">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.2.0&new-version=2.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

88ebc26a

Dartdoc warnings (#137077) · 58b64781
Michael Goderbauer authored Oct 23, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/136975.
```
58b64781

Roll Flutter Engine from e89f0421bcab to abeab897a29c (5 revisions) (#137100) · 92fd0634

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/e89f0421bcab...abeab897a29c

2023-10-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Added tests to assert empty saveLayer behaviors. (flutter/engine#47138)
2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from d534571c4bc3 to 73e9879f06e7 (1 revision) (flutter/engine#47233)
2023-10-23 chinmaygarde@google.com Add missing headers to the fml source_set. (flutter/engine#47232)
2023-10-23 jonahwilliams@google.com [Impeller] Vk query cleanups. (flutter/engine#47208)
2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 4976279e4441 to d534571c4bc3 (1 revision) (flutter/engine#47231)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92fd0634

Cover last test/material tests with leak tracking. (#137004) · 38f318b4
Kostia Sokolovskyi authored Oct 23, 2023

38f318b4

Roll Flutter Engine from 1ac30863a0b6 to e89f0421bcab (2 revisions) (#137088) · abf20877

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/1ac30863a0b6...e89f0421bcab

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 8a0324990bf5 to 4976279e4441 (1 revision) (flutter/engine#47230)
2023-10-23 nbosch1@gmail.com Update to the latest package:test (flutter/engine#46592)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

abf20877

Roll pub packages (#137087) · 042e1051
flutter-pub-roller-bot authored Oct 23, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
042e1051
CustomPainterSemantics doc typo (#137081) · 57a20ef2
Ross Llewallyn authored Oct 23, 2023
```
Just a documentation typo, I think.

#137080
```
57a20ef2

Roll Flutter Engine from ef568c309df5 to 1ac30863a0b6 (3 revisions) (#137085) · 2beb8d83

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/ef568c309df5...1ac30863a0b6

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from d27ff651a99b to 8a0324990bf5 (1 revision) (flutter/engine#47229)
2023-10-23 jonahwilliams@google.com [Impeller] remove image upload workarounds. (flutter/engine#47209)
2023-10-23 jonahwilliams@google.com [Impeller] Disable raster stats service protocol. (flutter/engine#47206)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2beb8d83

[ci_yaml] Remove back_fill=false on roller (#137076) · 347ae937

Casey Hillers authored Oct 23, 2023

Follow up from https://flutter-review.googlesource.com/c/50200 which removed the issue with inconsistencies

https://github.com/flutter/flutter/issues/112127

347ae937

Use `coverage.collect`'s `coverableLineCache` param to speed up coverage (#136851) · fb297e1d

Liam Appelbe authored Oct 23, 2023

One of the reasons gathering coverage information is expensive is that we have to force compile every function in the libraries we're interested in. Without this, functions that haven't been invoked (so haven't been compiled) won't have any line number information, so the coverage tool doesn't know which lines to add to the list of misses. In flutter's case, the test infra spawns many VMs, and each of these needs to recompile all those libraries.

To fix this, we need a way of skipping force compilation for libraries we've already seen in previous tests, without losing the information about which lines in each library are coverable. So I [added](https://github.com/dart-lang/coverage/pull/466) the `coverableLineCache` to `coverage.collect` in package:coverage v1.7.0. This cache starts out empty, but fills up with lists of all the lines that are coverable for every library as coverage is gathered. package:coverage can then tell the VM not to force compile any libraries in this cache (using `getSourceReport`'s `librariesAlreadyCompiled` param). So the first test suite will still have to compile everything, but subsequent test suites will be much faster.

This speeds up coverage collection significantly, for large test suites:

| Running flutter/packages/flutter tests... | Time | Overhead |
| --- | --- | --- |
| without coverage | 8:53 | - |
| with coverage | 20:25 | 130% |
| with `coverableLineCache` | 12:21 | 40% |

Bug: https://github.com/flutter/flutter/issues/100751

fb297e1d

Roll Flutter Engine from eaed54aa67e7 to ef568c309df5 (1 revision) (#137078) · 30efa60c

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/eaed54aa67e7...ef568c309df5

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 49fa29c8b153 to d27ff651a99b (1 revision) (flutter/engine#47227)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30efa60c

Roll Flutter Engine from 79c32970b20e to eaed54aa67e7 (2 revisions) (#137074) · 5ceb7284

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/79c32970b20e...eaed54aa67e7

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from acbc278f7600 to 49fa29c8b153 (1 revision) (flutter/engine#47226)
2023-10-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from nGgFMB0Tjnpr-pvTY... to a3CcHQHJIAEr-O2R0... (flutter/engine#47225)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from nGgFMB0Tjnpr to a3CcHQHJIAEr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5ceb7284

Roll Flutter Engine from 1dc66e8f2fba to 79c32970b20e (4 revisions) (#137068) · 3ad1d5a8

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/1dc66e8f2fba...79c32970b20e

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 47c408712efd to acbc278f7600 (3 revisions) (flutter/engine#47223)
2023-10-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qCxi4ThERe1MpDT9C... to uW96BsI9g7PF2on-4... (flutter/engine#47222)
2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 90658830b8ce to 47c408712efd (1 revision) (flutter/engine#47221)
2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from bce627e38d25 to 90658830b8ce (3 revisions) (flutter/engine#47220)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from qCxi4ThERe1M to uW96BsI9g7PF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ad1d5a8

Fix TextStyle terminology (#137000) · 117c7097
LongCatIsLooong authored Oct 23, 2023
```
cascading -> inheritance
```
117c7097
Add `InputDatePickerFormField.focusNode` prop (#136673) · 2de1af40
Tirth authored Oct 23, 2023
```
Adds `focusNode` prop to `InputDatePickerFormField` widget.

Fixes #105881
```
2de1af40
Roll pub packages (#137067) · aea56211
flutter-pub-roller-bot authored Oct 23, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
aea56211

Add delete button support to `FilterChip` (#136645) · 6c3010e7

Taha Tesser authored Oct 23, 2023

fixes [`FilterChip` should have `DeletableChipAttributes`/`trailing` to match Material 3 spec.](https://github.com/flutter/flutter/issues/135595)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return  MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text('FilterChip'),
            const SizedBox(height: 8),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              selected: true,
              showCheckmark: false,
              onSelected: (bool value) {},
              onDeleted: () {},
              deleteButtonTooltipMessage: 'Delete Me!',
            ),
            const SizedBox(height: 16),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: (bool value) {},
              onDeleted: () {},
            ),
            const SizedBox(height: 48),
            const Text('FilterChip.elevated'),
            const SizedBox(height: 8),
            FilterChip.elevated(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              selected: true,
              showCheckmark: false,
              onSelected: (bool value) {},
              onDeleted: () {},
            ),
            const SizedBox(height: 16),
            FilterChip.elevated(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: (bool value) {},
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

### Before

Not possible to add delete button

### After 
![Screenshot 2023-10-16 at 17 56 51](https://github.com/flutter/flutter/assets/48603081/ad751ef9-c2bc-4184-ae5f-4d1017eff664)

6c3010e7

Update `ColorScheme.fromSwatch` docs for Material 3 (#136816) · 5e8b5f4e
Taha Tesser authored Oct 23, 2023
```
part of [Clarify ColorScheme fromSwatch/fromSeed usage](https://github.com/flutter/flutter/issues/132584)
```
5e8b5f4e

Reland "Fixes ability to call nextFocus() on a node to focus its desc… (#136898) · e8691444

chunhtai authored Oct 23, 2023

â¦endant" (#136894)"

This reverts commit c2bd2c11.

fixes https://github.com/flutter/flutter/issues/134854

This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981

e8691444

`OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead... · af129b61

LongCatIsLooong authored Oct 23, 2023

`OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (#134921)

Fixes https://github.com/flutter/flutter/issues/134456

af129b61

Roll Packages from be915be92708 to 4bf51144c295 (12 revisions) (#137062) · 6dc5d2fd

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/packages/compare/be915be92708...4bf51144c295

2023-10-23 PROGrand@users.noreply.github.com [camera] CameraPlatform.createCameraWithSettings (flutter/packages#3615)
2023-10-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/packages#5201)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 6f4850d7 to 823e0835 (3 revisions) (flutter/packages#5198)
2023-10-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (flutter/packages#5167)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter from 0883cb2e to 6f4850d7 (24 revisions) (flutter/packages#5196)
2023-10-21 50643541+Mairramer@users.noreply.github.com [ios_platform_images] migrate objC to swift (flutter/packages#4847)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#5149)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#5150)
2023-10-20 tarrinneal@gmail.com [quick_actions] convert to pigeon (flutter/packages#5159)
2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Add build-only Windows Arm64 tests (flutter/packages#5142)
2023-10-20 43759233+kenzieschmoll@users.noreply.github.com Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter/packages#5186)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter from c2bd2c11 to 0883cb2e (24 revisions) (flutter/packages#5192)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6dc5d2fd

Roll Flutter Engine from 8820a419c800 to 1dc66e8f2fba (1 revision) (#137055) · 0f5bf521

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/8820a419c800...1dc66e8f2fba

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 3f7302e44c94 to bce627e38d25 (1 revision) (flutter/engine#47215)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f5bf521

Roll Flutter Engine from e2abdeb650f8 to 8820a419c800 (1 revision) (#137051) · 4d6df1d4

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/e2abdeb650f8...8820a419c800

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from a0515f94dfee to 3f7302e44c94 (3 revisions) (flutter/engine#47214)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d6df1d4

Roll Flutter Engine from 39f78ce1884d to e2abdeb650f8 (1 revision) (#137050) · 4aee432c

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/39f78ce1884d...e2abdeb650f8

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 2476ef80672f to a0515f94dfee (1 revision) (flutter/engine#47213)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4aee432c

Roll Flutter Engine from 4899344c34d9 to 39f78ce1884d (1 revision) (#137048) · f459e4ac

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/4899344c34d9...39f78ce1884d

2023-10-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kUMDo17HHiZKJNlp4... to nGgFMB0Tjnpr-pvTY... (flutter/engine#47212)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kUMDo17HHiZK to nGgFMB0Tjnpr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f459e4ac

Roll Flutter Engine from 9d05b061e245 to 4899344c34d9 (1 revision) (#137046) · ade09942

engine-flutter-autoroll authored Oct 23, 2023

https://github.com/flutter/engine/compare/9d05b061e245...4899344c34d9

2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from fbc238393b47 to 2476ef80672f (1 revision) (flutter/engine#47210)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ade09942