- 10 Jun, 2023 1 commit
-
-
ZhulanovAA authored
Fix unnecessary parentheses introduced in #128501 @chunhtai @HansMuller
-
- 09 Jun, 2023 27 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/488876ed26c6...3e90345cdca7 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 3e4f4caebcb0 to 72df42832ee4 (2 revisions) (flutter/engine#42703) 2023-06-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from bbce07ad3944 to d5b39a8385f9 (2 revisions) (flutter/engine#42702) 2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Reland: Added a switch to turn on vulkan (flutter/engine#42669) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (#128529) Closes https://github.com/flutter/flutter/issues/128456, which is now linked to in a code comment in this change. Reopens https://github.com/flutter/flutter/issues/124883. This effectively reverts https://github.com/flutter/flutter/pull/126077 and is intended to be cherry-picked into stable.
-
hangyu authored
fixes: #127145 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/071e1fb21c7a...488876ed26c6 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (flutter/engine#42701) 2023-06-09 bdero@google.com [Impeller] Add CPU implementations for all color filters (flutter/engine#42692) 2023-06-09 jonahwilliams@google.com [Impeller] add explicit VMA flush to device memory writes. (flutter/engine#42685) 2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Makes validation layers flag work for android (flutter/engine#42625) 2023-06-09 jmccandless@google.com Platform channel for predictive back (flutter/engine#39208) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/35112
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bc6e047570f6...071e1fb21c7a 2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from romfKfKwgjzAXQSxt... to EInl_eQkJekqc-gfW... (flutter/engine#42698) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from romfKfKwgjzA to EInl_eQkJekq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hans Muller authored
Reverts flutter/flutter#128507 This PR caused some internal failures (Google internal link b/286503764). Will need to investigate before we can re-land these changes.
-
ZhulanovAA authored
-
Jason Simmons authored
Ignore app.stop events received before the app.detach response in attach integration tests (#128593) The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach. See https://github.com/flutter/flutter/issues/128546
-
Devin authored
Fixes https://github.com/flutter/flutter/issues/74114 This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened. I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen. Pre-launch Checklist [ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs. [ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities. [ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement). [ X] I signed the [CLA](https://cla.developers.google.com/). [ X] I listed at least one issue that this PR fixes in the description above. I updated/added relevant documentation (doc comments with ///). [ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests). [ X] All existing and new tests are passing.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/93afba901b3b...bc6e047570f6 2023-06-09 jonahwilliams@google.com [Impeller] disable buffer to texture blit for Vulkan. (flutter/engine#42686) 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 980896406d12 to a185cb8c8924 (1 revision) (flutter/engine#42697) 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from e9493542672c to 980896406d12 (1 revision) (flutter/engine#42696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hans Muller authored
Updated the localization tests so that they'll DTRT when useMaterial3:true becomes the default for ThemeData. In a few cases there are M2 and M3 tests now, to check features that are significantly different in Material3, notably the double ring for the 24 hour input dial. | Material 2 | Material 3| |---------|---------| | <img width="250" alt="Screenshot 2023-06-08 at 10 47 37 AM" src="https://github.com/flutter/flutter/assets/1377460/6ca95e22-b3f1-4f6b-9e39-79c888ba58f1"> | <img width="257" alt="Screenshot 2023-06-08 at 10 47 13 AM" src="https://github.com/flutter/flutter/assets/1377460/19b685bf-c812-4c87-baed-70fa56efaad8"> | In M3, most aspects of the ideographic text styles are the same as for alphabetic styles, so there are some tweaks here to account for that.
-
hangyu authored
fixes: #104703
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/e13b8c43386a...afe2f05c1adb 2023-06-08 stuartmorgan@google.com [image_picker] Add desktop support - platform interface (flutter/packages#4161) 2023-06-08 nils@reichardt.io [go_router] Update link to example for query and path parameters (flutter/packages#3994) 2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839) 2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768) 2023-06-08 stuartmorgan@google.com [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166) 2023-06-08 engine-flutter-autoroll@skia.org Roll Flutter from 8a5c22e2 to 6e254a3f (12 revisions) (flutter/packages#4165) 2023-06-08 banasco@gmail.com Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hans Muller authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cb93477008d6...93afba901b3b 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 8a62b4c44fc9 to e9493542672c (1 revision) (flutter/engine#42695) 2023-06-09 leroux_bruno@yahoo.fr [Linux] Return keyboard pressed state (flutter/engine#42346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
William Hesse authored
Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location. This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL. Bug: #127683 - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X ] I signed the [CLA]. - [X ] I listed at least one issue that this PR fixes in the description above. - [X ] I updated/added relevant documentation (doc comments with `///`).
-
Danny Tuppeny authored
The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error: Failed to Hot Reload: app 'null' not found  This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8f9e608d39ab...cb93477008d6 2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... (flutter/engine#42694) 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from d8339e78db54 to 8a62b4c44fc9 (1 revision) (flutter/engine#42691) 2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ukXXOXtI7uRIukzF5... to romfKfKwgjzAXQSxt... (flutter/engine#42689) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lPCv1NshK-tv to xqQPG9jnWgD1 fuchsia/sdk/core/mac-amd64 from ukXXOXtI7uRI to romfKfKwgjzA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/128465
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/128367 <details> <summary>code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: Scaffold( floatingActionButton: Builder( builder: (BuildContext context) => FloatingActionButton( child: const Icon(Icons.add), onPressed: () { Scaffold.of(context).showBottomSheet<void>( (_) { return DraggableScrollableSheet( expand: false, builder: (_, ScrollController scrollController) => ListView.builder( controller: scrollController, itemCount: 25, itemBuilder: (BuildContext context, int index) { return ListTile( title: Text('Item $index - tap to close'), onTap: () { Navigator.of(context).pop(); }, ); }, ), ); }, ); }, ), ), ), ); } } ``` </details> ### Before https://github.com/flutter/flutter/assets/48603081/fa87feb9-54f2-4e50-bf71-c81d9e54ff61 ### After https://github.com/flutter/flutter/assets/48603081/7d192059-7600-4d65-ae84-6321f3598133
-
engine-flutter-autoroll authored
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) Manual roll requested by zra@google.com https://github.com/flutter/engine/compare/a5f7d5d75ff2...8f9e608d39ab 2023-06-09 zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688) 2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667) 2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687) 2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682) 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684) 2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680) 2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679) 2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677) 2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678) 2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673) 2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648) 2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409) 2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675) 2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668) 2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662) 2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659) 2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658) 2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651) 2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622) 2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646) 2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638) 2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose ...
-
Chris Yang authored
Reverts flutter/flutter#127391 I'm back from OOO so change the test owners back.
-
Camille Simon authored
Bumps integration tests (that are not run manually only) using `compileSdkVersion` 31 to 33.
-
Tong Mu authored
This is a refactor to make `MouseTracker` use the same callback for both kinds of device update. Instead of using two different callbacks for the two device updating methods, `MouseTracker` now receives a hit testing callback at construction, which is the same hit testing method as the one used for other gestures. This PR not only makes the code cleaner, but also removes the single view assumption from `MouseTracker`, whose code no longer refers to `RendererBinding.renderView`. In the future, we only need to modify `hitTest` (which we will have to do to support gestures for multi-view anyway) to make mouse tracker support multi-view.
-
-
- 08 Jun, 2023 12 commits
-
-
Leigha Jarett authored
Fixes: https://github.com/flutter/flutter/issues/127228
-
Greg Spencer authored
## Description This adds `AppLifecycleListener`, a class for listening to changes in the application lifecycle, and responding to requests to exit the application. It depends on changes in the Engine that add new lifecycle states: https://github.com/flutter/engine/pull/42418 Here's a diagram for the lifecycle states. I'll add a similar diagram to the documentation for these classes.  ## Related Issues - https://github.com/flutter/flutter/issues/30735 ## Tests - Added tests for new lifecycle value, as well as for the `AppLifecycleListener` itself.
-
Tae Hyung Kim authored
This widget implements the ability to place slivers one after another in a single ScrollView in a way that all child slivers are drawn within the bounds of the group itself (i.e. SliverPersistentHeaders aren't drawn outside of the scroll extent provided by all of the child slivers). The design document for SliverMainAxisGroup can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA). Fixes https://github.com/flutter/flutter/issues/33137. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Kate Lovett <katelovett@google.com>
-
LongCatIsLooong authored
I'm getting a few false positives in https://github.com/flutter/flutter/pull/128522/checks from the `num.clamp` checker since I introduced a class with a `clamp` method.
-
Leigha Jarett authored
Fixes https://github.com/flutter/flutter/issues/128430
-
Jackson Gardner authored
This attempts to reland https://github.com/flutter/flutter/pull/126848 This was reverted because it made some unexpected changes to our perf measurements. After landing https://github.com/flutter/flutter/pull/127900, we have much less noise in our benchmarks, so I'd like to reland this and see if there is still a significant measurement difference.
-
Mahdi Bagheri authored
*The order of calling Navigator.pop and PopupMenuItem.onTap has been changed so before calling PopupMenuItem onTap method, PopupMenuBotton onSelect method is going to be called.* *Solves #127443* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Bruno Leroux authored
-
Taha Tesser authored
-
Janice Collins authored
This updates dartdoc to 6.3.0. Release notes are available, here: https://github.com/dart-lang/dartdoc/releases/tag/v6.3.0 Most important for Flutter are the reduction in the size of generated HTML files (dart-lang/dartdoc#3384) and a new dartdoc directive to hide constant implementations from indicated classes (dart-lang/dartdoc#3398), which fixes the longstanding issue (dart-lang/dartdoc#2657). I've also added the api documentation zip to `.gitignore` and the `{@hideConstantImplementations}` dartdoc directive to the motivating example. A screenshot:  I assert that this change to icons.dart should be test-exempt as existing tests cover whether or not dartdoc directives are recognized or are leaking into HTML, and the impact of adding the directive was tested in dart-lang/dartdoc#3398.
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/108187
-
hellohuanlin authored
Many parts of the floating cursor selection feature is pretty tricky. Some took me a while to figure out. So I added some comments to explain a bit for future readers. *List which issues are fixed by this PR. You must list at least one issue.* https://github.com/flutter/flutter/issues/30476 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
