- 18 Oct, 2023 1 commit
-
-
pdblasi-google authored
* Added `performAction` to `SemanticsController` as well as specific methods for specific actions * Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)` * Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>` Closes #112413
-
- 17 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 25 Sep, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/135144
-
- 22 Sep, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Michael Goderbauer authored
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
-
- 12 Sep, 2023 1 commit
-
-
Michael Goderbauer authored
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2. Part of https://github.com/flutter/flutter/issues/134476.
-
- 08 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 01 Sep, 2023 2 commits
-
-
Renzo Olivares authored
Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue (#133178) Part of: https://github.com/flutter/flutter/issues/133171
-
Renzo Olivares authored
Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue (#133176) Part of: https://github.com/flutter/flutter/issues/133171
-
- 23 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Part of https://github.com/flutter/flutter/issues/133171. Removes from `TestWindow`: * `localeTestValue` * `clearLocaleTestValue` * `localesTestValue` * `clearLocalesTestValue` * `initialLifecycleStateTestValue` * `alwaysUse24HourFormatTestValue` * `clearAlwaysUse24HourTestValue` * `brieflyShowPasswordTestValue` * `defaultRouteNameTestValue` * `clearDefaultRouteNameTestValue` * `semanticsEnabledTestValue` * `clearSemanticsEnabledTestValue` * `accessibilityFeaturesTestValue` * `clearAccessibilityFeaturesTestValue` These properties have reached the end of their deprecation period.
-
- 22 Aug, 2023 1 commit
-
-
Ivan Inozemtsev authored
Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode. Fixes https://github.com/flutter/flutter/issues/132964
-
- 21 Aug, 2023 1 commit
-
-
Angelo Silvestre authored
In `MacOSTestTextInputKeyHandler`, there are some mappings from shortcuts to generate macOS selectors. However, `ctrl + backspace` isn't mapped to `deleteBackwardByDecomposingPreviousCharacter:`. This PR adds the mapping for `deleteBackwardByDecomposingPreviousCharacter:`. Fixes: https://github.com/flutter/flutter/issues/132917
-
- 15 Aug, 2023 1 commit
-
-
Ian Hickson authored
- slightly improved assert message when row cell counts don't match column count. - more breadcrumbs in API documentation. more documentation in general. - added more documentation for the direction of the "ascending" arrow. - two samples for PaginatedDataTable. - make PaginatedDataTable support hot reloading across changes to the number of columns. - introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.
-
- 14 Aug, 2023 1 commit
-
-
pdblasi-google authored
* Updated `AutomatedTestWidgetsFlutterBinding.pump` to use microseconds instead of milliseconds * Added a test to prevent regression of the microsecond precision * Fixed a test that incorrectly assumed millisecond precision Closes #112610
-
- 10 Aug, 2023 1 commit
-
-
pdblasi-google authored
* Pulled `FinderBase` out of `Finder` * `FinderBase` can be used for any object, not just elements * Terminology was updated to be more "find" related * Re-implemented `Finder` using `FinderBase<Element>` * Backwards compatibility maintained with `_LegacyFinderMixin` * Introduced base classes for SemanticsNode finders * Introduced basic SemanticsNode finders through `find.semantics` * Updated some relevant matchers to make use of the more generic `FinderBase` Closes #123634 Closes #115874
-
- 07 Aug, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/59413 This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`. The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :) mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
-
- 31 Jul, 2023 1 commit
-
-
Qun Cheng authored
-
- 17 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
This change enables Flutter to generate multiple Scenes to be rendered into separate FlutterViews from a single widget tree. Each Scene is described by a separate render tree, which are all associated with the single widget tree. This PR implements the framework-side mechanisms to describe the content to be rendered into multiple views. Separate engine-side changes are necessary to provide these views to the framework and to draw the framework-generated Scene into them. ## Summary of changes The details of this change are described in [flutter.dev/go/multiple-views](https://flutter.dev/go/multiple-views). Below is a high-level summary organized by layers. ### Rendering layer changes * The `RendererBinding` no longer owns a single `renderView`. In fact, it doesn't OWN any `RenderView`s at all anymore. Instead, it offers an API (`addRenderView`/`removeRenderView`) to add and remove `RenderView`s that then will be MANAGED by the binding. The `RenderView` itself is now owned by a higher-level abstraction (e.g. the `RawView` Element of the widgets layer, see below), who is also in charge of adding it to the binding. When added, the binding will interact with the `RenderView` to produce a frame (e.g. by calling `compositeFrame` on it) and to perform hit tests for incoming pointer events. Multiple `RenderView`s can be added to the binding (typically one per `FlutterView`) to produce multiple Scenes. * Instead of owning a single `pipelineOwner`, the `RendererBinding` now owns the root of the `PipelineOwner` tree (exposed as `rootPipelineOwner` on the binding). Each `PipelineOwner` in that tree (except for the root) typically manages its own render tree typically rooted in one of the `RenderView`s mentioned in the previous bullet. During frame production, the binding will instruct each `PipelineOwner` of that tree to flush layout, paint, semantics etc. A higher-level abstraction (e.g. the widgets layer, see below) is in charge of adding `PipelineOwner`s to this tree. * Backwards compatibility: The old `renderView` and `pipelineOwner` properties of the `RendererBinding` are retained, but marked as deprecated. Care has been taken to keep their original behavior for the deprecation period, i.e. if you just call `runApp`, the render tree bootstrapped by this call is rooted in the deprecated `RendererBinding.renderView` and managed by the deprecated `RendererBinding.pipelineOwner`. ### Widgets layer changes * The `WidgetsBinding` no longer attaches the widget tree to an existing render tree. Instead, it bootstraps a stand-alone widget tree that is not backed by a render tree. For this, `RenderObjectToWidgetAdapter` has been replaced by `RootWidget`. * Multiple render trees can be bootstrapped and attached to the widget tree with the help of the `View` widget, which internally is backed by a `RawView` widget. Configured with a `FlutterView` to render into, the `RawView` creates a new `PipelineOwner` and a new `RenderView` for the new render tree. It adds the new `RenderView` to the `RendererBinding` and its `PipelineOwner` to the pipeline owner tree. * The `View` widget can only appear in certain well-defined locations in the widget tree since it bootstraps a new render tree and does not insert a `RenderObject` into an ancestor. However, almost all Elements expect that their children insert `RenderObject`s, otherwise they will not function properly. To produce a good error message when the `View` widget is used in an illegal location, the `debugMustInsertRenderObjectIntoSlot` method has been added to Element, where a child can ask whether a given slot must insert a RenderObject into its ancestor or not. In practice, the `View` widget can be used as a child of the `RootWidget`, inside the `view` slot of the `ViewAnchor` (see below) and inside a `ViewCollection` (see below). In those locations, the `View` widget may be wrapped in other non-RenderObjectWidgets (e.g. InheritedWidgets). * The new `ViewAnchor` can be used to create a side-view inside a parent `View`. The `child` of the `ViewAnchor` widget renders into the parent `View` as usual, but the `view` slot can take on another `View` widget, which has access to all inherited widgets above the `ViewAnchor`. Metaphorically speaking, the view is anchored to the location of the `ViewAnchor` in the widget tree. * The new `ViewCollection` widget allows for multiple sibling views as it takes a list of `View`s as children. It can be used in all the places that accept a `View` widget. ## Google3 As of July 5, 2023 this change passed a TAP global presubmit (TGP) in google3: tap/OCL:544707016:BASE:545809771:1688597935864:e43dd651 ## Note to reviewers This change is big (sorry). I suggest focusing the initial review on the changes inside of `packages/flutter` first. The majority of the changes describe above are implemented in (listed in suggested review order): * `rendering/binding.dart` * `widgets/binding.dart` * `widgets/view.dart` * `widgets/framework.dart` All other changes included in the PR are basically the fallout of what's implemented in those files. Also note that a lot of the lines added in this PR are documentation and tests. I am also very happy to walk reviewers through the code in person or via video call, if that is helpful. I appreciate any feedback. ## Feedback to address before submitting ("TODO")
-
- 06 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
PLUS: clean-up of all the unreachable stuff.
-
- 13 Jun, 2023 1 commit
-
-
Hans Muller authored
-
- 07 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 03 Jun, 2023 1 commit
-
-
- 02 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
In the multi view world, `RenderViews` are created by the `View` widget and no longer owned by the binding. Prior to this change, the `LiveTestWidgetsFlutterBinding` owned and managed a special subclass of `RenderView`, the `_LiveTestRenderView`. In the new world, where `RenderView`s can be created anywhere in the widget tree where a `View` widget is used, this setup is no longer feasible. This change removes this special `_LiveTestRenderView` and instead adds debug hocks to `RenderView` to allow the `LiveTestWidgetsFlutterBinding` to draw a debug overlay on top of the content of any `RenderView`.
-
- 01 Jun, 2023 1 commit
-
-
fzyzcjy authored
Closes https://github.com/flutter/flutter/issues/125920 I will add tests, polish code, etc, if this change looks generally OK!
-
- 26 May, 2023 1 commit
-
-
pdblasi-google authored
* Adds `TestDisplay` * Updates `TestPlatformDispatcher` to wrap all `Display`s and relate them to their appropriate `TestFlutterView` * Updates `TestFlutterView` to tie `devicePixelRatio` to its display as per the documentation on `Display` Closes #127225
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 27 Apr, 2023 1 commit
-
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125600
-
- 20 Apr, 2023 2 commits
-
-
Nate Bosch authored
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files. Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`. Leave uses of `test_api` from `flutter_test` library code.
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/107615 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 12 Apr, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` cleanup (part 4)
-
- 10 Apr, 2023 1 commit
-
-
Rexios authored
[flutter_test] Adds method to mock EventChannels
-
- 07 Apr, 2023 2 commits
-
-
Zachary Anderson authored
Reverts flutter/flutter#123726 Analysis failures on CI https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/12890/overview
-
Rexios authored
[flutter_test] Adds method to mock EventChannels
-
- 06 Apr, 2023 1 commit
-
-
Greg Price authored
Make tester.startGesture less async, for better stack traces
-
- 31 Mar, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` enum migration (part 2)
-
- 29 Mar, 2023 1 commit
-
-
Simon Binder authored
Treat hidden `IndexedStack` children as offstage for test finder
-
- 21 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
Deprecate BindingBase.window
-
Michael Goderbauer authored
Bump lower Dart SDK constraints to 3.0 & add class modifiers
-
- 16 Mar, 2023 2 commits
-
-
Ian Hickson authored
Assert that runApp is called in the same zone as binding.ensureInitialized
-
yaakovschectman authored
Revert "Assert that runApp is called in the same zone as binding.ensureInitialized (#117113)" (#122830) Revert "Assert that runApp is called in the same zone as binding.ensureInitialized"
-