- 31 Oct, 2023 4 commits
-
-
Binni Goel authored
## Description This PR fixes typos in - `checkbox.dart` - `chip_test.dart` - `color_scheme.dart` - `color_scheme_test.dart` - `curves.dart`
-
Todd Volkert authored
Add docs to NetworkImage constructor
-
Taha Tesser authored
Update `ColorScheme.light`, `ColorScheme.dark`, `ColorScheme.highContrastLight`, & `ColorScheme.highContrastDark` constructors docs for Material 3 (#137149) fixes [Clarify ColorScheme fromSwatch/fromSeed usage](https://github.com/flutter/flutter/issues/132584) "This explains how to use `ColorScheme.fromSeed` as a substitute for each `ColorScheme` constructor." | `ColorScheme.light` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![light](https://github.com/flutter/flutter/assets/48603081/e056e723-5640-4b05-8feb-ca6b517c8682) | | `ColorScheme.dark` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![dark](https://github.com/flutter/flutter/assets/48603081/5ff32611-bfb6-49ee-a34e-f935f580e84e) | | `ColorScheme.highContrastLight` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![highContrastLight](https://github.com/flutter/flutter/assets/48603081/4b47f2e3-ea8e-4148-85cc-69690e9082c7) | | `ColorScheme.highContrastDark` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![highContrastDark](https://github.com/flutter/flutter/assets/48603081/3dbd7ec4-c78e-4228-a8ed-673832681563) |
-
Binni Goel authored
## Description This PR fixes typos in - `date_picker.dart` - `date_picker_theme.dart` - `dropdown.dart`
-
- 28 Oct, 2023 4 commits
-
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-
Polina Cherkasova authored
-
Kostia Sokolovskyi authored
-
- 27 Oct, 2023 4 commits
-
-
Greg Spencer authored
## Description Adds some convenience methods to `KeyEvent` that allow testing to see if a logical or physical key is pressed from the event object. These are similar to the ones already on `RawKeyEvent`, and will make migration the to `KeyEvent` easier (so it could more easily be a `flutter fix` migration). Added: - `bool isLogicalKeyPressed(LogicalKeyboardKey key)` - `bool isPhysicalKeyPressed(PhysicalKeyboardKey key)` - `bool get isControlPressed` - `bool get isShiftPressed` - `bool get isAltPressed` - `bool get isMetaPressed` ## Related Issues - https://github.com/flutter/flutter/issues/136419 ## Tests - Added tests for the new methods.
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/54665
-
Todd Volkert authored
This method controls whether the builder needs to be called again again even if the layout constraints are the same. By default, the builder will always be called when the widget is updated because the logic in the callback might have changed. However, there are cases where subclasses of ConstrainedLayoutBuilder know that certain property updates only affect paint and not build. In these cases, we lack a way of expressing that the builder callback is not needed -- and we end up doing superfluous work. This PR gives subclasses the ability to know exactly when the callback needs to be called and when it can be skipped.
-
Binni Goel authored
## Description This PR fixes typos in - `actions.dart` - `app_bar.dart` - `basic.dart` - `button_bar_theme.dart`
-
- 26 Oct, 2023 4 commits
-
-
Kostia Sokolovskyi authored
-
Greg Price authored
This comment on _localizedThemeDataCacheSize was a bit garbled from getting split up, and the doc on _localizedThemeDataCache was missing from having been moved elsewhere. It looks like the dislocation happened in 8b86d238 (#116088), which was otherwise making unrelated changes, including a couple of lines near these. Likely it was due to an error in resolving merge or rebase conflicts at some point while revising that PR.
-
Bruno Leroux authored
## Description This PR adds `ProcessTextService` on the framework side to communicate with the engine to query and run text processing actions (on the engine side, only Android is supported currently, see https://github.com/flutter/engine/pull/44579). ## Related Issue Non-UI framework side for https://github.com/flutter/flutter/issues/107603 ## Tests Adds 3 tests.
-
Mairramer authored
Adds new feat and fix to https://github.com/flutter/flutter/issues/134341
-
- 25 Oct, 2023 2 commits
-
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/129094 I have demonstrated how this PR fixes the problem using tests in #129094. I will further add tests in this PR if the PR looks roughly acceptable :)
-
yim authored
This PR fixes the issue of items being created at the wrong position during dragging. Fixes #135819
-
- 24 Oct, 2023 2 commits
-
-
lirantzairi authored
The color of the TextField's cursor in error state is the same as the error text color by default. However we should be allowed to customize it Fixes #135580
-
cui fliter authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* fix some typos *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 23 Oct, 2023 7 commits
-
-
Ross Llewallyn authored
Just a documentation typo, I think. #137080
-
LongCatIsLooong authored
cascading -> inheritance
-
Tirth authored
Adds `focusNode` prop to `InputDatePickerFormField` widget. Fixes #105881
-
Taha Tesser authored
fixes [`FilterChip` should have `DeletableChipAttributes`/`trailing` to match Material 3 spec.](https://github.com/flutter/flutter/issues/135595) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return Scaffold( body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ const Text('FilterChip'), const SizedBox(height: 8), FilterChip( avatar: const Icon(Icons.favorite_rounded), label: const Text('FilterChip'), selected: true, showCheckmark: false, onSelected: (bool value) {}, onDeleted: () {}, deleteButtonTooltipMessage: 'Delete Me!', ), const SizedBox(height: 16), FilterChip( avatar: const Icon(Icons.favorite_rounded), label: const Text('FilterChip'), onSelected: (bool value) {}, onDeleted: () {}, ), const SizedBox(height: 48), const Text('FilterChip.elevated'), const SizedBox(height: 8), FilterChip.elevated( avatar: const Icon(Icons.favorite_rounded), label: const Text('FilterChip'), selected: true, showCheckmark: false, onSelected: (bool value) {}, onDeleted: () {}, ), const SizedBox(height: 16), FilterChip.elevated( avatar: const Icon(Icons.favorite_rounded), label: const Text('FilterChip'), onSelected: (bool value) {}, onDeleted: () {}, ), ], ), ), ); } } ``` </details> ### Before Not possible to add delete button ### After ![Screenshot 2023-10-16 at 17 56 51](https://github.com/flutter/flutter/assets/48603081/ad751ef9-c2bc-4184-ae5f-4d1017eff664)
-
Taha Tesser authored
part of [Clarify ColorScheme fromSwatch/fromSeed usage](https://github.com/flutter/flutter/issues/132584)
-
chunhtai authored
â¦endant" (#136894)" This reverts commit c2bd2c11. fixes https://github.com/flutter/flutter/issues/134854 This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
-
LongCatIsLooong authored
`OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (#134921) Fixes https://github.com/flutter/flutter/issues/134456
-
- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 20 Oct, 2023 1 commit
-
-
LongCatIsLooong authored
Update the `RenderEditable` implementation to match `RenderParagraph`. Fixes https://github.com/flutter/flutter/issues/136596
-
- 19 Oct, 2023 6 commits
-
-
Kate Lovett authored
Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (#136905) Reverts flutter/flutter#132291 We have found this introduced flakiness in many of our tests. Fixes https://github.com/flutter/flutter/issues/135728
-
Qun Cheng authored
Fixes #136735 This PR is to add a searchCallback to allow users to customize the search algorithm. This feature is used to fix b/305662376 which needs an exact match algorithm.
-
Kostia Sokolovskyi authored
-
Greg Spencer authored
-
auto-submit[bot] authored
Reverts flutter/flutter#136773 Initiated by: itsjustkevin This change reverts the following previous change: Original Description: fixes https://github.com/flutter/flutter/issues/134854
-
auto-submit[bot] authored
Reverts flutter/flutter#136771 Initiated by: gspencergoog This change reverts the following previous change: Original Description: ## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
- 18 Oct, 2023 5 commits
-
-
Greg Spencer authored
## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
Greg Spencer authored
## Description This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/124830 ## Tests - No tests yet (hence it is a draft)
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/134854
-
Taha Tesser authored
Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (#136720) fixes [Slider will call onChanged before onChangeStart when sliding.](https://github.com/flutter/flutter/issues/136707) This fixes a regression from https://github.com/flutter/flutter/pull/121483 ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatefulWidget { const Example({super.key}); @override State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { double _sliderValue = 0.5; @override Widget build(BuildContext context) { return Scaffold( body: Center( child: Slider( // allowedInteraction: SliderInteraction.tapAndSlide, // allowedInteraction: SliderInteraction.tapOnly, // allowedInteraction: SliderInteraction.slideOnly // allowedInteraction: SliderInteraction.slideThumb, value: _sliderValue, onChangeStart: (newValue) { print("onChangeStart ......"); }, onChanged: (newValue) { print("onChanged ......"); setState(() { _sliderValue = newValue; }); }, onChangeEnd: (newValue) { print("onChangeEnd ......"); }, ), ), ); } } ``` </details>
-
Arash authored
Consider a scenario where the background color and indicator's background color are the same. Adding a stroke color to the value indicator would be a valuable for the following reasons: - **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice. - **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps. - **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs. *List which issues are fixed by this PR. You must list at least one issue.* Fixes #135984
-