- 09 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
- 23 Nov, 2017 1 commit
-
-
Ian Hickson authored
-
- 27 Sep, 2017 1 commit
-
-
Michael Goderbauer authored
* Send scroll progress with ScrollCompletedSemanticsEvent This requires engine change https://github.com/flutter/engine/pull/4144 * fix analyze warning * review comment * Roll engine to 45b11f742d38ebf564a5a832b1af00661d1a31fa * fix test
-
- 12 Sep, 2017 1 commit
-
-
Michael Goderbauer authored
* Show accessibility frame while scrolling * ++ * fix test
-
- 08 Sep, 2017 1 commit
-
-
Michael Goderbauer authored
* ++ * ++ * ++ * ++ * ++ * dart docs * test fix * undo unintended change * fix test * fix test * review feedback
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
-
- 25 Jul, 2017 1 commit
-
-
Jacob Richman authored
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
-
- 21 Jul, 2017 1 commit
-
-
Ian Hickson authored
Mainly, this adds documentation to members that were previously lacking documentation. It also adds a big block of documentation about improving performance of widgets. This also removes some references to package:collection and adds global setEquals and listEquals methods in foundation that we can use. (setEquals in particular should be much faster than the package:collection equivalent, though both should be faster as they avoid allocating new objects.) All remaining references now qualify the import so we know what our remaining dependencies are. Also lots of code reordering in Flutter driver to make the code consistent and apply the style guide more thoroughly.
-
- 19 Jul, 2017 1 commit
-
-
Michael Goderbauer authored
* Expose the currently available semantic scroll actions * review comments * add test * refactor to set
-
- 08 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 05 May, 2017 2 commits
-
-
Hans Muller authored
-
Ian Hickson authored
-
- 03 May, 2017 1 commit
-
-
Ian Hickson authored
-
- 02 May, 2017 3 commits
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/8476 More detailed list of changes in this patch: * Replaced the didTouch special logic with more generic logic that uses Activities instead. Now instead when you tap down the Scrollable calls `hold()` which begins a HoldScrollActivity which is a hybrid of DragStartDetails and IdleScrollActivity and can be canceled. When you let go, it gets canceled and that goes ballistic. * Make DragGestureRecognizer more aggressive about grabbing pointers, otherwise a second pointer in a situation with competing horizontal and vertical recognizers always gets taken by the other one. * Fixed the _GestureSemantics widget to call the "down" callbacks so that it follows the same pattern as "real" interactions. * Added tests for the above. * Added a hashCode to ScrollActivity.toString (and subclasses). * Added a toString to ScrollDragController, and include it in DragScrollActivity's toString. * s/coorindator/coordinator/ * Add a comment in DragStartDetails to distinguish it from the otherwise identical DragDownDetails, so we're not tempted to merge them.
-
Adam Barth authored
-
Adam Barth authored
-
- 25 Apr, 2017 1 commit
-
-
Adam Barth authored
This patch reworks some of the guts of scrolling to make it easier to implement nested scrolling effects. The actually nested scrolling effect will be included in a later patch.
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 12 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 21 Mar, 2017 1 commit
-
-
Hans Muller authored
-
- 14 Mar, 2017 1 commit
-
-
Adam Barth authored
The new name matches the style guide. (The old name was just old and predated the style guide.) Fixes #8000
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 17 Feb, 2017 2 commits
-
-
Adam Barth authored
Rename all the "2" classes related to scrolling to remove the "2". Now that the old scrolling code is gone, we don't need to use the suffix.
-
Adam Barth authored
All the clients have migrated to Scrollable2.
-
- 15 Feb, 2017 2 commits
-
-
Adam Barth authored
The replacements are ListView and SingleChildScrollView, respectively.
-
Adam Barth authored
We can't read our size in the offset setter because we might be in the middle of layout. This issue also occured with the sliver-based viewport.
-
- 09 Feb, 2017 2 commits
-
-
Adam Barth authored
All the clients have migrated to GridView. Also, remove RenderGrid, which isn't needed by GridView.
-
Ian Hickson authored
Move the back button and drawer opening logic into the app bar. Move the tap-status-bar-to-scroll-to-top logic to using ScrollControllers. Provide a PrimaryScrollController and a `primary` flag on scroll views. Make it possible to track when a route becomes or stops being poppable.
-
- 08 Feb, 2017 2 commits
-
-
Adam Barth authored
All clients have moved to PageView.
-
Adam Barth authored
Tabs are now fully driven by slivers.
-
- 07 Feb, 2017 2 commits
-
-
Adam Barth authored
Also, move the creation of the ScrollPosition to ScrollController. Finally, remove TestScrollable in favor of CustomScrollView, which is the production version of this widget.
-
Adam Barth authored
If you pass a ScrollController to a Scrollable2, you can use the controller to read and write the scroll offset without having to find the Scrollable2State object.
-
- 04 Feb, 2017 1 commit
-
-
Adam Barth authored
This patch makes Scrollable2.ensureVisible with SingleChildScrollView. A future patch will extend the implementation to work with slivers. (Although the patch does include some of the infrastructure for that part of the implementation as well.)
-
- 03 Feb, 2017 3 commits
-
-
Adam Barth authored
This patch makes a number of changes to how you can configure a Scrollable2: - The ScrollPhysics is now responsible for creating the ScrollPosition. You can override the ScrollPhysics by supplying a `physics` argument to `Scrollable`, and the new physics you supply will be applied to the default physics inherited from the ScrollBehavior. - This patch removes the ScrollPosition/AbsoluteScrollPosition split as all clients were operating in pixels anyway and the split made the code very difficult to follow. - ScrollPosition no longer depends directly on Scrollable2State. Instead, it depends on an abstract interface that Scrollable2State implements. This change has two benefits: a) It removes the circular dependency between ScrollPosition and Scrollable2State, which lets us split the code for these classes (and several other classes that got wrapped up in that cycle) into separate libraries for easier maintenance. b) ScrollPosition is no longer bound to Scrollable2, which means you could use the behavior machinery to drive other sorts of widgets. For example, we could use it to drive Scrollabe1 if we wanted.
-
Adam Barth authored
This property is wired up to anything and it isn't used. We'll need to find a better way for clients to control the scroll offset.
-
Adam Barth authored
This widget is a start towards replacing PageableList. There are still a number of features that we'll need to add before this widget can replace PageableList.
-
- 02 Feb, 2017 2 commits
-
-
Ian Hickson authored
Also, tweak Banner a bit so you can set the color and text style. Also, cache the text painter between paints.
-
Ian Hickson authored
-