1. 03 Oct, 2020 1 commit
  2. 11 Jun, 2020 1 commit
  3. 02 Jan, 2020 2 commits
  4. 31 Dec, 2019 1 commit
    • Ian Hickson's avatar
      Add many more global analyses. (#47875) · e768c92f
      Ian Hickson authored
      * Update packages.
      
      * Add many more global analyses.
      
      * Catch trailing spaces and trailing newlines in all text files.
        Before we were only checking newly added files, but that means we
        missed some.
      
      * Port the trailing spaces logic to work on Windows too.
      
      * Correct all the files with trailing spaces and newlines.
      
      * Refactor some of the dev/bots logic into a utils.dart library.
        Notably, the "exit" and "print" shims for testing are now usable
        from test.dart, analyze.dart, and run_command.dart.
      
      * Add an "exitWithError" function that prints the red lines and
        then exits. This is the preferred way to exit from test.dart,
        analyze.dart, and run_command.dart.
      
      * More consistency in the output of analyze.dart.
      
      * Refactor analyze.dart to use the _allFiles file enumerating logic
        more widely.
      
      * Add some double-checking logic to the _allFiles logic to catch
        cases where changes to that logic end up catching fewer files
        than expected (helps prevent future false positives).
      
      * Add a check to prevent new binary files from being added to
        the repository. Grandfather in the binaries that we've already
        added.
      
      * Update all the dependencies (needed because we now import crypto in
        dev/bots/analyze.dart).
      e768c92f
  5. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  6. 27 Feb, 2019 1 commit
    • liyuqian's avatar
      Add LICENSE test to presubmit checks (#28369) · dd5559a5
      liyuqian authored
      ## Description
      
      Also update the existing dart files with missing licenses.
      
      Without the fix, we'll emit the following error message
      ```
      License headers cannot be found at the beginning of the following files.
      
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
      ```
      
      ## Related Issues
      
      Fixes https://github.com/flutter/flutter/issues/28368
      
      ## Checklist
      
      Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
      
      - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
      - [x] All existing and new tests are passing.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
      - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I am willing to follow-up on review comments in a timely manner.
      
      ## Breaking Change
      
      Does your PR require Flutter developers to manually update their apps to accommodate your change?
      
      - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
      - [x] No, this is *not* a breaking change.
      
      <!-- Links -->
      [issue database]: https://github.com/flutter/flutter/issues
      [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
      [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
      [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
      [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
      [CLA]: https://cla.developers.google.com/
      [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
      dd5559a5
  7. 08 Jan, 2019 1 commit