- 09 Nov, 2023 1 commit
-
-
Camille Simon authored
Re-lands https://github.com/flutter/flutter/pull/137191. The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in https://github.com/flutter/flutter/pull/138093.
-
- 03 Nov, 2023 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#137191 Initiated by: camsim99 This change reverts the following previous change: Original Description: Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
- 02 Nov, 2023 2 commits
-
-
Camille Simon authored
Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
Bartek Pacia authored
I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511. At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that. I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.
-
- 27 Oct, 2023 2 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#136880 Initiated by: camsim99 This change reverts the following previous change: Original Description: Since the original PR that supposedly enabled proguard, it was using the android proguard rules that disable optimizations. See initial PR in [0] This PR changes the flutter gradle plugin to use the `proguard-android-optimize.txt` (instead of `proguard-android.txt`) which will enable optimizations/shrinking of platform code (i.e. java/kotlin). For a simple flutter hello world this results in a 25% reduction in the resulting DEX file (`classes.dex` of the APK). [0] f098de1f Fixes https://github.com/flutter/flutter/issues/136879
-
Martin Kustermann authored
Since the original PR that supposedly enabled proguard, it was using the android proguard rules that disable optimizations. See initial PR in [0] This PR changes the flutter gradle plugin to use the `proguard-android-optimize.txt` (instead of `proguard-android.txt`) which will enable optimizations/shrinking of platform code (i.e. java/kotlin). For a simple flutter hello world this results in a 25% reduction in the resulting DEX file (`classes.dex` of the APK). Note for users: For some users this may result in issues because their java/kotlin code is now better optimized & tree shaken and thereby symbols may be no longer available or being obfuscated. To fix those issues it's best to craft precise proguard rules describing the extra symbols that are needed by the app (see [1]). But it's also possible to opt out entirely of optimizations by using the unoptimized proguard rules. To add custom proguard rules or use the unoptimized android rules, one can update `android/app/build.gradle`: ``` android { ... buildTypes { release { ... + proguardFiles( + // Not ideal: Disables optimizations by using unoptimized android rules. + getDefaultProguardFile("proguard-android.txt"), + + // Better: Have precise keep rules to only keep things that are needed. + "custom-rules.pro", + ) } } } ``` [0] f098de1f [1] https://developer.android.com/build/shrink-code Fixes https://github.com/flutter/flutter/issues/136879
-
- 26 Oct, 2023 1 commit
-
-
Gray Mackall authored
Fixes https://github.com/flutter/flutter/issues/129471. Does so by doing a very similar thing that is done by https://github.com/flutter/flutter/pull/121958, but for a task that is specific to the add to app build process.
-
- 22 Sep, 2023 1 commit
-
-
Bartek Pacia authored
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative `plugins {}` block (#127897) This PR fixes #125009.
-
- 21 Sep, 2023 1 commit
-
-
Derek Xu authored
-
- 18 Aug, 2023 1 commit
-
-
chunhtai authored
1. Remove vm service registration 2. combine print<variant>ApplicationId and print<variant>AppLinkDomain into one task dump<variant>AppLinkSettings, which dump all the data in a json file The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR https://github.com/flutter/flutter/pull/131009. The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.
-
- 16 Aug, 2023 1 commit
-
-
William Hesse authored
PR #132346 added the use of --local-engine-host to flutter_tools internals, and had an error on one line. Fix that error, to use the correct field name. The error occurs when building plugins with the changed tools.
-
- 15 Aug, 2023 1 commit
-
-
Matan Lurey authored
Partial work towards https://github.com/flutter/flutter/issues/132245. I made a minor refactor to test-only code because it was too confusing to have 2 optional parameters that are technically required together, but otherwise all other changes *should* be pass throughs. That being said, I can't say I totally understand the Gradle stuff so I could use a hand double checking that.
-
- 09 Aug, 2023 1 commit
-
-
Zachary Anderson authored
Context: https://github.com/flutter/flutter/issues/131862 This PR injects a "realm" component to the storage base URL when the contents of the file `bin/internal/engine.realm` is non-empty. As documented in the PR, when the realm is `flutter_archives_v2`, and `bin/internal/engine.version` contains the commit hash for a commit in a `flutter/engine` PR, then the artifacts pulled by the tool will be the artifacts built by the presubmit checks for the PR. This works for everything but the following two cases: 1. Fuchsia artifacts are not uploaded to CIPD by the Fuchsia presubmit builds. 2. Web artifacts are not uploaded to gstatic by the web engine presubmit builds. For (1), the flutter/flutter presubmit `fuchsia_precache` is driven by a shell script outside of the repo. It will fail when the `engine.version` and `engine.realm` don't point to a post-submit engine commit. For (2), the flutter/flutter web presubmit tests that refer to artifacts in gstatic hang when the artifacts aren't found, so this PR skips them.
-
- 02 Aug, 2023 1 commit
-
-
Gray Mackall authored
Add documentation in flutter.groovy noting that we always use the latest available android version (#131705) Last piece of/ Fixes https://github.com/flutter/flutter/issues/131425 Also added a period to a comment line that was missing one.
-
- 07 Jun, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/120408 Added two gradle tasks, one for grabing the application id, one for grabbing app link domains. Added a new vmservices to call these two gradle tasks and return the result. The expected work flow is that the devtool will first call a vmservices to grab all avaliable build variants. It will then choose one of the build variant and call this new services to get application id and app link domains.
-
- 05 May, 2023 1 commit
-
-
ChenRenJie authored
When I include flutter in my exist android project by `include_flutter.groovy`, it hint me: ``` Project :app doesn't exist. To custom the host app project name, set `org.gradle.project.flutter.hostAppProjectName=<project-name>` in gradle.properties. ``` But set `org.gradle.project.flutter.hostAppProjectName` has no effect, acutally need to set `flutter.hostAppProjectName`. This pr is to fix this incorrect hint. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 27 Apr, 2023 1 commit
-
-
Dan Field authored
See https://docs.flutter.dev/reference/supported-platforms I don't expect this to break anything, but if it does we can revert and figure out what else needs to happen first. Without this change, engine changes upstream will get flagged in default flutter created apps.
-
- 19 Apr, 2023 1 commit
-
-
Bartek Pacia authored
Refactor Flutter Gradle Plugin so it can be applied using the declarative `plugins {}` block (#123511) This PR aims to resolve #121552. Resources used: - [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html) - [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block) - [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html) This PR also paves way for #121541, because apps will no longer have: ```groovy apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" ``` hardcoded. Instead, they'll use: ```groovy plugins { // ... id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative } ```
-
- 18 Apr, 2023 1 commit
-
-
- 13 Apr, 2023 1 commit
-
-
Reid Baker authored
#123643 - Add task to projects evaluated by flutter.gradle that will print the java version. - Add integration test for the existence of javaVersion and the expected format. - Add gradle util to get the gradlew version for a specific platform (gradlew everywhere but windows). Why does this code need to exist? Figuring out what version of java is used by flutter/gradle is done in a few different ways that are not always aligned. See this issue https://github.com/flutter/flutter/issues/122609 , this issue https://github.com/flutter/flutter/issues/121501 this feature request https://github.com/flutter/flutter/issues/106416 As examples of why assuming the java version is dangerous. This task is code flutter can build upon and is the version gradle is using to build no matter how it is configured. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. --------- Co-authored-by: Mitchell Goodwin <58190796+MitchellGoodwin@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Victoria Ashworth <vashworth@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Jackson Gardner <jacksongardner@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: hellohuanlin <41930132+hellohuanlin@users.noreply.github.com> Co-authored-by: Danny Tuppeny <danny@tuppeny.com> Co-authored-by: Chris Bracken <chris@bracken.jp> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Elias Yishak <42216813+eliasyishak@users.noreply.github.com> Co-authored-by: Christopher Fujino <fujino@google.com>
-
- 10 Mar, 2023 1 commit
-
-
André Sousa authored
Fix Gradle 7 warnings that are now errors in Gradle 8
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 04 Jan, 2023 1 commit
-
-
Vyacheslav Egorov authored
* Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports
-
- 20 Dec, 2022 1 commit
-
-
Camille Simon authored
* Bump versions * Fix gradle errors test
-
- 01 Dec, 2022 1 commit
-
-
Gary Qian authored
-
- 09 Nov, 2022 1 commit
-
-
Gary Qian authored
* Apply multidex login in kotlin dsl gradle file * Cleanup * Remove plugin parameter passing * Cleanup * Restore dependencies block * Analyzer * Compiles * Cleanup * Cleanup
-
- 27 Oct, 2022 1 commit
-
-
Adel Khial authored
-
- 25 Oct, 2022 1 commit
-
-
Gary Qian authored
-
- 21 Oct, 2022 1 commit
-
-
Gary Qian authored
-
- 10 Oct, 2022 1 commit
-
-
Gary Qian authored
-
- 08 Oct, 2022 1 commit
-
-
Brett Morgan authored
-
- 06 Oct, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit f80411d8.
-
Gary Qian authored
-
- 04 Oct, 2022 1 commit
-
-
林军华 authored
-
- 14 Sep, 2022 1 commit
-
-
姚春锋 authored
let the plugin's output generated in flutter/.android/plugins_build_output/${androidPlugin.name} (#94645)
-
- 02 Sep, 2022 2 commits
-
-
Zachary Anderson authored
-
Gary Qian authored
-
- 15 Aug, 2022 1 commit
-
-
Gary Qian authored
-
- 07 Aug, 2022 1 commit
-
-
Daco Harkes authored
-
- 31 May, 2022 1 commit
-
-
Gary Qian authored
-