1. 29 Apr, 2019 1 commit
    • Shi-Hao Hong's avatar
      Fix ExpansionPanelList Duplicate Global Keys Exception (#31228) · 39712854
      Shi-Hao Hong authored
      - Move `setState` to only be invoked when guarded by `widget._allowMultiplePanelsOpen`, fixing the case for `ExpansionPanelList`
      
      - Remove setting `_currentOpenPanel` to `widget.initialOpenPanelValue` in `didUpdateWidget`, since this should only occur on `initState` and not every time the widget is updated. This fixes the problem for `ExpansionPanelList.radio`
      
      - Added a `didUpdateWidget` condition for when `ExpansionPanelList` changes into `ExpansionPanelList.radio` to open the panel at `widget.initialOpenPanelValue`
      
      - Added test cases for regression, expansionCallback cases, and `didUpdateWidget` transitions between `ExpansionPanelList` and `ExpansionPanelList.radio`
      39712854
  2. 18 Apr, 2019 1 commit
  3. 09 Apr, 2019 1 commit
  4. 04 Apr, 2019 1 commit
  5. 20 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      some spaces formatting (#29452) · a6af4228
      Alexandre Ardhuin authored
      * some space formattings
      
      * always use blocks in if-else if a block is used
      
      * format spaces in for and while
      
      * allow multiline if conditions
      
      * fix missing space
      a6af4228
  6. 09 Mar, 2019 1 commit
  7. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  8. 01 Feb, 2019 1 commit
  9. 30 Jan, 2019 1 commit
  10. 02 Oct, 2018 1 commit
  11. 14 Sep, 2018 1 commit
  12. 12 Sep, 2018 1 commit
  13. 22 Aug, 2018 1 commit
  14. 21 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Cleanup (#20754) · 94f9604a
      Ian Hickson authored
      - remove an //ignore that is no longer needed
      - fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
      - add some asserts to help track down bugs quicker
      - update a TODO to point to the currently relevant bug
      - fix some indenting
      - improve the naming of some privates to improve readability
      94f9604a
  15. 02 Aug, 2018 1 commit
  16. 27 Jul, 2018 1 commit
  17. 25 Jul, 2018 1 commit
    • jslavitz's avatar
      Added single open panel functionality (#19624) · 28dc0074
      jslavitz authored
      * Just commiting two files now
      
      * Fixed one tab
      
      * Fixed latest changes
      
      * Changed the data structure from a map to a single radio panel object
      
      * A few more changes
      
      * Fixed change from expansion radio to regular list
      
      * Fixed change from expansion radio to regular list2
      
      * Changed the radio constructor
      
      * Last fixes
      
      * Final commit
      
      * Actual final commit
      
      * Last change
      28dc0074
  18. 23 Jul, 2018 1 commit
  19. 16 Jul, 2018 2 commits
  20. 20 Jun, 2018 1 commit
  21. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  22. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  23. 05 Jun, 2018 1 commit
  24. 30 May, 2018 2 commits
  25. 03 May, 2018 1 commit
  26. 16 Nov, 2017 1 commit
    • Ian Hickson's avatar
      ExpansionPanel animation fixes (#13032) · c97fc206
      Ian Hickson authored
      Previously, ExpansionPanel would do weird things if interacted with
      when it was already animating. This is fixed and there's now a test.
      
      Also:
      
       * Minor fixes to make the gallery work in RTL, not that there's
         any way to see that without hard-coding the framework to RTL.
         But at least I'll be less annoyed when doing that.
      
       * Some trivial code and documentation cleanup.
      c97fc206
  27. 26 Sep, 2017 1 commit
  28. 11 Sep, 2017 1 commit
  29. 05 Sep, 2017 1 commit
  30. 03 Jun, 2017 1 commit
  31. 23 Apr, 2017 1 commit
  32. 08 Apr, 2017 1 commit
  33. 17 Mar, 2017 1 commit
  34. 04 Mar, 2017 1 commit
  35. 01 Dec, 2016 1 commit
  36. 22 Nov, 2016 1 commit
    • Adam Barth's avatar
      Rename Flexible to Expanded and improve docs (#6978) · 8ca4caa4
      Adam Barth authored
      This patch replaces uses of Flexible with Expanded where we're using
      FlexFit.tight. We still need to think of a better name for the
      FlexFit.loose variant.
      
      Also, improve the docs for Row, Column, Flex, and RenderFlex to be more
      problem-oriented and to give a complete account of the layout algorithn.
      
      Fixes #6960
      Fixes #5169
      8ca4caa4
  37. 19 Nov, 2016 1 commit
  38. 16 Sep, 2016 1 commit