Commits · 613a0ac59c06ce38979db8eaf18b7348021972db · abdullh.alsoleman / Front-End

07 Dec, 2023 1 commit

Implement `SubmenuButton.onFocusChange` (#139678) · 613a0ac5

Qun Cheng authored Dec 07, 2023

Fixes #139409

`SubmenuButton.onFocusChange` is not implemented. This PR is just add one line fix to assign this property to `TextButton.onFocusChange` which is used in `SubmenuButton`:)

613a0ac5

06 Dec, 2023 20 commits

have Java.version return null if `java --version` fails or cannot be run (#139614) · c22c19b6

Andrew Kolos authored Dec 06, 2023

## Summary
Fixes https://github.com/flutter/flutter/issues/139180, where `flutter create` could crash if the `java` binary the tool found cannot be run.

## Context

At startup, the tool searches for a Java installation[^1]. Unless the located installation is from [an Android Studio installation](https://github.com/flutter/flutter/blob/e1967ecabf014bf93d1731fde6a6547b06ca9c33/packages/flutter_tools/lib/src/android/android_studio.dart#L163), the tool does not verify that the binary is runnable. For more, see https://github.com/flutter/flutter/issues/139613, which tracks this inconsistency in behavior. 

This means that in the scenario where

1) the user does not have Android Studio installed or the java binary found within cannot be run **and**
2) the user has a) `flutter config --jdk-dir` set, b) `JAVA_HOME` set in their environment, **or** c) `java` on their system path **and**
3) the java binary we think we found during cannot be run (or `java --version` fails), **then**

the user running `flutter create` with Android enabled will hit a tool crash.

## Change

`Java.version` should return null if version checking fails for any reason. [This is documented behavior](https://github.com/flutter/flutter/blob/48f57621ade657b0c20ba53d513de4c3cd563abd/packages/flutter_tools/lib/src/android/java.dart#L136). Therefore, we'll update the implementation to first verify that the binary is runnable. If it isn't, it will return `null`.

[^1]: We find java by calling the static `Java.find`, see: https://github.com/flutter/flutter/blob/48187028c11ca8ca10e0179705d25553e1fe2c14/packages/flutter_tools/lib/src/context_runner.dart#L271
[^2]: This PR doesn't change this, as this would be too dangerous to cherry-pick into stable.

c22c19b6

Remove deprecated parameters from `ElevatedButton.styleFrom()`,... · 2230c091

Qun Cheng authored Dec 06, 2023

Remove deprecated parameters from `ElevatedButton.styleFrom()`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (#139267)

2230c091

[ci.yaml] Add runif filters and stricter timeout to packaging_test (#139694) · 9ef1c2b0

Casey Hillers authored Dec 06, 2023

https://github.com/flutter/flutter/issues/139597

* Remove beta and stable filters as the Cocoon scheduler doesn't run on these branches

9ef1c2b0

re-enable windows build_tests (#139599) · e5c5e15a

Christopher Fujino authored Dec 06, 2023

These have all passed since being introduced >20 commits ago:

![Screenshot from 2023-12-05 14-37-41](https://github.com/flutter/flutter/assets/7856010/997f39a1-377c-4e85-a7a1-02bb7e687506)

e5c5e15a

Roll dependencies (#139606) · fca7bc9e
Ian Hickson authored Dec 06, 2023
```
test-exempt: rolling dependencies
```
fca7bc9e

Roll Flutter Engine from fa632d995c47 to 347f506a341f (1 revision) (#139674) · 8a53be5f

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/fa632d995c47...347f506a341f

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 12dffa893c2a to 23e1cb20a6b5 (1 revision) (flutter/engine#48737)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a53be5f

Marks Linux_pixel_7pro new_gallery_impeller__transition_perf to be flaky (#139644) · 32bddf2f

Flutter GitHub Bot authored Dec 06, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro new_gallery_impeller__transition_perf"
}
-->
Issue link: https://github.com/flutter/flutter/issues/139643

32bddf2f

Roll Flutter Engine from 59d2ec70a391 to fa632d995c47 (1 revision) (#139669) · 46ad6dce

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/59d2ec70a391...fa632d995c47

2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 691e4650ce91 to 6eb13603c212 (1 revision) (flutter/engine#48736)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46ad6dce

Roll Flutter Engine from 273a604d0854 to 59d2ec70a391 (1 revision) (#139665) · d6a4e4b4

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/273a604d0854...59d2ec70a391

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from afa75c6cf697 to 12dffa893c2a (1 revision) (flutter/engine#48732)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d6a4e4b4

Add `AnimationStyle` to `ExpansionTile` (#139664) · f794cf9d

Taha Tesser authored Dec 06, 2023

fixes [Expose animation parameters for the [ExpansionTile] widget](https://github.com/flutter/flutter/issues/138047)

### Description
Add `AnimationStyle` to the `ExpansionTile` widget to override the default expand and close animation.

Syntax:
```dart
        child: ExpansionTile(
          title: const Text('Tap to expand'),
          expansionAnimationStyle: AnimationStyle(
            duration: Durations.extralong1,
            curve: Easing.emphasizedAccelerate,
          ),
          children: const <Widget>[FlutterLogo(size: 200)],
        ),
```

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';

/// Flutter code sample for [ExpansionTile] and [AnimationStyle].

void main() {
  runApp(const ExpansionTileAnimationStyleApp());
}

enum AnimationStyles { defaultStyle, custom, none }
const List<(AnimationStyles, String)> animationStyleSegments = <(AnimationStyles, String)>[
  (AnimationStyles.defaultStyle, 'Default'),
  (AnimationStyles.custom, 'Custom'),
  (AnimationStyles.none, 'None'),
];

class ExpansionTileAnimationStyleApp extends StatefulWidget {
  const ExpansionTileAnimationStyleApp({super.key});

  @override
  State<ExpansionTileAnimationStyleApp> createState() => _ExpansionTileAnimationStyleAppState();
}

class _ExpansionTileAnimationStyleAppState extends State<ExpansionTileAnimationStyleApp> {
  Set<AnimationStyles> _animationStyleSelection = <AnimationStyles>{AnimationStyles.defaultStyle};
  AnimationStyle? _animationStyle;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: SafeArea(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              SegmentedButton<AnimationStyles>(
                selected: _animationStyleSelection,
                onSelectionChanged: (Set<AnimationStyles> styles) {
                  setState(() {
                    _animationStyleSelection = styles;
                    switch (styles.first) {
                      case AnimationStyles.defaultStyle:
                        _animationStyle = null;
                      case AnimationStyles.custom:
                        _animationStyle = AnimationStyle(
                          curve: Easing.emphasizedAccelerate,
                          duration: Durations.extralong1,
                        );
                      case AnimationStyles.none:
                        _animationStyle = AnimationStyle.noAnimation;
                    }
                  });
                },
                segments: animationStyleSegments
                  .map<ButtonSegment<AnimationStyles>>(((AnimationStyles, String) shirt) {
                    return ButtonSegment<AnimationStyles>(value: shirt.$1, label: Text(shirt.$2));
                  })
                  .toList(),
              ),
              const SizedBox(height: 20),
              ExpansionTile(
                expansionAnimationStyle: _animationStyle,
                title: const Text('ExpansionTile'),
                children: const <Widget>[
                  ListTile(title: Text('Expanded Item 1')),
                  ListTile(title: Text('Expanded Item 2')),
                ],
              )
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

Related to https://github.com/flutter/flutter/pull/138721.

f794cf9d

Roll Packages from 4e7f160127ed to ca16173e67e4 (3 revisions) (#139661) · 1f07909c

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/packages/compare/4e7f160127ed...ca16173e67e4

2023-12-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (flutter/packages#5579)
2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/packages#5568)
2023-12-05 36861262+QuncCccccc@users.noreply.github.com [file_selector] Remove deprecated `primary` and `onPrimary` references from `ElevatedButton.styleFrom` (flutter/packages#5566)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f07909c

Update `Tooltip` tests for Material 3 (#139145) · 3c8700c2
Taha Tesser authored Dec 06, 2023
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
3c8700c2

Fix `DatePicker` Dialog content not visible on lower text scale (#139236) · 2f95a5a3

Taha Tesser authored Dec 06, 2023

fixes [`DatePicker` dialog contents are hidden when using smaller text size](https://github.com/flutter/flutter/issues/139120)

### Description
- Fixed `DatePicker` dialog contents are hidden when using smaller text size.
- Add golden tests

### Golden Test (Before)

| `TextScale - 0.88` | `TextScale - 1.0` | `TextScale - 2.0` | 
| --------------- |  --------------- |  --------------- | 
|   <img src="https://github.com/flutter/flutter/assets/48603081/9f301c5d-3acd-4a9f-8fb7-aa7b2e9553a2"> |  <img src="https://github.com/flutter/flutter/assets/48603081/0496cf1a-5086-4cb1-ad3f-256f34346920"> | <img src="https://github.com/flutter/flutter/assets/48603081/2d1e1892-435a-4938-a7fc-2ffa4684828b"> | 

### Golden Test (After)

| `TextScale - 0.88` | `TextScale - 1.0` | `TextScale - 2.0` | 
| --------------- |  --------------- |  --------------- | 
|   <img src="https://github.com/flutter/flutter/assets/48603081/8fb922b7-0f2c-4f08-a091-b359a01e3600"> |  <img src="https://github.com/flutter/flutter/assets/48603081/59933cbf-49ef-46fb-98b5-217db2cc0ee7"> | <img src="https://github.com/flutter/flutter/assets/48603081/fd2501cb-511c-4b57-a4eb-f583af60aed7"> |

2f95a5a3

Roll Flutter Engine from 6e0ad1b16698 to 273a604d0854 (1 revision) (#139647) · 92c2cadc

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/6e0ad1b16698...273a604d0854

2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e54241e915a to 691e4650ce91 (1 revision) (flutter/engine#48725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92c2cadc

Roll Flutter Engine from 695851108953 to 6e0ad1b16698 (2 revisions) (#139638) · b6e04d58

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/695851108953...6e0ad1b16698

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 3043b8051f15 to afa75c6cf697 (1 revision) (flutter/engine#48722)
2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from cd23ebc87188 to 3043b8051f15 (1 revision) (flutter/engine#48716)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6e04d58

Roll Flutter Engine from 899b88afc5f9 to 695851108953 (2 revisions) (#139625) · 42eeee8b

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/899b88afc5f9...695851108953

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 5f54e9f84cff to cd23ebc87188 (1 revision) (flutter/engine#48714)
2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from c3bd23e62ece to 9e54241e915a (1 revision) (flutter/engine#48715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42eeee8b

Roll Flutter Engine from fe96317750ff to 899b88afc5f9 (1 revision) (#139621) · bea04f63

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/fe96317750ff...899b88afc5f9

2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from d8efef525ce1 to c3bd23e62ece (1 revision) (flutter/engine#48710)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bea04f63

Roll Flutter Engine from 3e661e0a58cc to fe96317750ff (2 revisions) (#139612) · a0f42655

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/3e661e0a58cc...fe96317750ff

2023-12-06 jonahwilliams@google.com [Impeller] Vulkan framebuffer fetch via VK_ARM_RASTERIZATION_ORDER_ATTACHMENT_ACCESS (flutter/engine#48458)
2023-12-06 godofredoc@google.com Remove fuchsia v1 builder. (flutter/engine#48703)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a0f42655

Roll Flutter Engine from 647cf405f3dc to 3e661e0a58cc (3 revisions) (#139609) · 36444bcd

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/647cf405f3dc...3e661e0a58cc

2023-12-05 jason-simmons@users.noreply.github.com [Impeller] Declare specialization constants as floats. (flutter/engine#48644)
2023-12-05 102626803+drewroengoogle@users.noreply.github.com Fix labeler not actually doing any labeling (flutter/engine#48701)
2023-12-05 dnfield@google.com Roll abseil to d07bb1bc8e59b37204d457ee365b52b0d11feec0 (flutter/engine#48700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

36444bcd

Add linked dart doc for Display on media query. (#139587) · e15cb7f8

Reid Baker authored Dec 06, 2023

FlutterView.display.size tells you the resolution of the display on supported platforms. FlutterView.physicalSize tells you the view size, which may be different from the display. This can help you tell if you are being letterboxed on android.

https://medium.com/flutter/developing-flutter-apps-for-large-screens-53b7b0e17f10

Related to [flutter/website/9896](https://github.com/flutter/website/issues/9896)

e15cb7f8

05 Dec, 2023 19 commits

Roll Flutter Engine from c49b861832d3 to 647cf405f3dc (1 revision) (#139598) · 4a4801de

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/c49b861832d3...647cf405f3dc

2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 8bfec2c7ed43 to d8efef525ce1 (1 revision) (flutter/engine#48697)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4a4801de

Fix labeler not actually doing any labeling (#139596) · e69024d6

Drew Roen authored Dec 05, 2023

https://github.com/flutter/flutter/issues/139511

The initial formatting that landed just prevented it from failing, but it turns out the new format is completely overhauled.

e69024d6

Roll Flutter Engine from 96604392231a to c49b861832d3 (3 revisions) (#139595) · 5bce16de

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/96604392231a...c49b861832d3

2023-12-05 chinmaygarde@google.com Avoid non-const sizes in VLAs. (flutter/engine#48693)
2023-12-05 jonahwilliams@google.com [Impeller] Prefer moving vertex buffer, place on command instead of binding object. (flutter/engine#48630)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from c759bbf16310 to 5f54e9f84cff (3 revisions) (flutter/engine#48692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5bce16de

Roll Flutter Engine from cfdaecc2d2b7 to 96604392231a (1 revision) (#139586) · 4ea7a980

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/cfdaecc2d2b7...96604392231a

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from c0ad3e9bdec0 to c759bbf16310 (1 revision) (flutter/engine#48689)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ea7a980

Roll pub packages (#139510) · 935c8e8e
flutter-pub-roller-bot authored Dec 05, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
935c8e8e

Roll Flutter Engine from 7133378566d1 to cfdaecc2d2b7 (7 revisions) (#139583) · 1c1b2bff

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/7133378566d1...cfdaecc2d2b7

2023-12-05 jonnywang@google.com A11y enabled state (flutter/engine#48653)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from bf1db1c75704 to c0ad3e9bdec0 (1 revision) (flutter/engine#48685)
2023-12-05 30870216+gaaclarke@users.noreply.github.com [Impeller] started taking into account integer gaps in blur sigma, turned on linear filter (flutter/engine#48651)
2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 21574eae3a69 to 8bfec2c7ed43 (2 revisions) (flutter/engine#48683)
2023-12-05 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yaml format for labeler 5.0.0 (flutter/engine#48682)
2023-12-05 jonahwilliams@google.com [Impeller] Make Entity move only, simplify construction of geometry/filter contents. (flutter/engine#48596)
2023-12-05 jonahwilliams@google.com [Impeller] Delete tessellation control/eval shader support. (flutter/engine#48649)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c1b2bff

Support for dismissDirection property in SnackBarTheme (#139068) · af61c6c7

Shanmugam authored Dec 05, 2023

This PR introduces a new feature that allows users to configure the 'dismissDirection' in SnackBarTheme. This enhancement provides users with the flexibility to set the 'dismissDirection' property in the ThemeData, rather than having to apply it each time when initializing a snack bar. This streamlines the process and makes it more convenient for users to manage and customize the behavior of snack bars within their applications.

Fixes #139012

af61c6c7

Roll Flutter Engine from e6b872b01fde to 7133378566d1 (2 revisions) (#139575) · 88d65375

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/e6b872b01fde...7133378566d1

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from 7901100ba2d9 to bf1db1c75704 (2 revisions) (flutter/engine#48680)
2023-12-05 103135467+sealesj@users.noreply.github.com Use flutter mirrors for non-Google github origin deps (flutter/engine#48642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88d65375

Update generate_gradle_lockfiles script to represent newer templates, and run it on dev/ (#135175) · 4ce5421c

Gray Mackall authored Dec 05, 2023

Upgrades agp versions and lockfiles for `dev/`. Also changes the lockfile generation script to represent the newer form of the `settings.gradle` template, and therefore also propagates these changes.

~~Potentially related to https://github.com/flutter/flutter/issues/134419~~, but worth doing anyways. (not actually related)

4ce5421c

Roll Flutter Engine from 39ae00bf5328 to e6b872b01fde (2 revisions) (#139573) · 6099aef1

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/39ae00bf5328...e6b872b01fde

2023-12-05 jonahwilliams@google.com [Impeller] Render emoji shadows with correct colors. (flutter/engine#48593)
2023-12-05 jonahwilliams@google.com [Impeller] Document what some of this shader metadata is. (flutter/engine#48647)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6099aef1

Move docs to use their own recipe. (#139521) · ff881bad

godofredoc authored Dec 05, 2023

This is part of the deprecation of adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153

ff881bad

Removed deprecated NavigatorState.focusScopeNode (#139260) · 40405706

Kate Lovett authored Dec 05, 2023

Part of https://github.com/flutter/flutter/issues/139243

Deprecated in https://github.com/flutter/flutter/pull/109702

The replacement for focusScopeNode is focusNode.enclosingScope

40405706

Remove stray print (#139550) · 12aa1987
Ian Hickson authored Dec 05, 2023
```
It's making the tests have a lot of logspam.
```
12aa1987

Roll Flutter Engine from 78584fec8e52 to 39ae00bf5328 (2 revisions) (#139570) · 66da20a4

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/78584fec8e52...39ae00bf5328

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from 3040f78eeb71 to 7901100ba2d9 (3 revisions) (flutter/engine#48677)
2023-12-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (flutter/engine#48676)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

66da20a4

Update labeler version, fix yaml to work with v5 (#139564) · a82ae232

Drew Roen authored Dec 05, 2023

This fixes https://github.com/flutter/flutter/issues/139511

* A bug has been fixed with `sync-labels`, meaning this needs to be a boolean now. Setting to `true` to match v4 logic.
* in `labeler.yml`, all labels must be a list of globs, so updated them all to be a list of `any`.
* Update the version to v5

This is a little annoying to test, since the way github actions works means that changes to workflows aren't run until after they are merged. A workaround is I forked these labeler changes to a new branch in my own repo and created a PR to merge to that branch, seen here: https://github.com/drewroengoogle/flutter/actions/runs/7102118110/job/19331743809?pr=2. Note the step `Run actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9` which ensures we are running on the latest labeler version in that check.

a82ae232

Roll Packages from 5d9874f69bce to 4e7f160127ed (4 revisions) (#139565) · ea97fc48

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/packages/compare/5d9874f69bce...4e7f160127ed

2023-12-04 737941+loic-sharma@users.noreply.github.com [ci] Add Windows Arm64 stable build-only test (flutter/packages#5533)
2023-12-04 stuartmorgan@google.com [various] Update mockito to 5.4.3 (flutter/packages#5530)
2023-12-04 43759233+kenzieschmoll@users.noreply.github.com Add an optional parameter `initialPage` to `serveWebBenchmark` (flutter/packages#5538)
2023-12-04 engine-flutter-autoroll@skia.org Roll Flutter from d861ce49 to f35d049e (7 revisions) (flutter/packages#5564)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea97fc48

Roll Flutter Engine from 72d6a42f74b1 to 78584fec8e52 (1 revision) (#139548) · 315a8f4c

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/72d6a42f74b1...78584fec8e52

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from a998afefb1b0 to 3040f78eeb71 (1 revision) (flutter/engine#48663)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

315a8f4c

Send an event when proxied DDS creates a connection. (#139530) · 7a9adfd1
Lau Ching Jun authored Dec 05, 2023
```
The event allows tools to listen and connect to the original DDS port.
```
7a9adfd1

Roll Flutter Engine from 2923201bc337 to 72d6a42f74b1 (3 revisions) (#139547) · c396011e

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/2923201bc337...72d6a42f74b1

2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/engine#48662)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from de49aeaa8224 to a998afefb1b0 (1 revision) (flutter/engine#48660)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from d37625f80ac0 to de49aeaa8224 (1 revision) (flutter/engine#48658)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c396011e