* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas

* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint

* Unit test for build.dart::GenSnapshot

* Fix analysis errors

* Switch to testLogger

This reverts commit 202c1b42.

On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.

This reverts commit 5501a1c1.

## Description

Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.

This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.

## Tests

This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.

I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.

## Breaking Change

I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").

Move tools tests into a general.shard directory in preparation to changing how we shard tools tests (#36108)