https://github.com/flutter/engine/compare/78c1ad249b57...7a9409e12fab

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164)
2023-09-21 john@johnmccutchan.com Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071)
2023-09-21 jonahwilliams@google.com [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023)
2023-09-21 matanlurey@users.noreply.github.com More Clang Tidy --fix[es] to header files (flutter/engine#46151)
2023-09-21 dkwingsmt@users.noreply.github.com Reland: Enforce the rule of calling FlutterView.Render (#45300) (flutter/engine#45555)
2023-09-21 yjbanov@google.com Revert "[web] fix clicks on merged semantic nodes (#43620)" (flutter/engine#46067)
2023-09-21 matanlurey@users.noreply.github.com Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (flutter/engine#46017)
2023-09-21 godofredoc@google.com Remove linux fuchsia from recipes cq. (flutter/engine#46153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).

fix #111370

According to 

https://github.com/flutter/flutter/blob/5b47fef613e2d74ae44e1e22c2a3495294db180e/packages/flutter/lib/src/rendering/box.dart#L1259
: A [RenderBox] that uses methods on [PaintingContext] that introduce
new
/// layers should override the [alwaysNeedsCompositing] getter and set
it to
/// true.

set [alwaysNeedsCompositing] to true when RenderParagraph introduces
LeaderLayer for selection handles.



## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.

Mostly tweaks for better focus management, namely:

* Use `autofocus` throughout so the a11y focus is transferred to a logical place when overlaid content pops up (screen transitions, dialogs).
* Consolidate "enabled" and "disabled" widgets into the same screen. Otherwise, when only a disabled widget is shown, there's nothing to focus on and the screen reader is lost.

This analytics event only records the value of the plist entry on
`build` commands. This will give an idea of the proportion of users who
are disabling Impeller when shipping apps.

https://github.com/flutter/engine/compare/fa032d52a118...78c1ad249b57

2023-09-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3DKf4d8UFviYKRI28... to PXDDhlPyd9sgrWWun... (flutter/engine#46148)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 3DKf4d8UFviY to PXDDhlPyd9sg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR fixes yet another case in the windows startup test that violates the render rule, which caused https://github.com/flutter/engine/pull/45300 to be reverted.

Although the `FlutterView.render` call is within `onBeginFrame`, there is an `await` before the call, causing the call to fall out of the synchronous scope.

I've added this problem to the documentation of `FlutterView.render` in https://github.com/flutter/engine/pull/45555.

## Description

This PR adds a parameter to configure the input decorator hint fade transition duration.

This animation is not part of the Material specification.
Removing it was considered but it breaks internal tests (see https://github.com/flutter/flutter/pull/107406).
I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible.

To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/20283.

## Tests

Adds 3 tests, updates 3 tests.

https://github.com/flutter/engine/compare/6c1e58c86e8c...fa032d52a118

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 322abacca561 to 0cf83a86c56d (1 revision) (flutter/engine#46143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/packages/compare/51e74b97508a...d0411e450a8d

2023-09-20 stuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/584861202198...6c1e58c86e8c

2023-09-21 sigurdm@google.com Add package:tar to DEPS (flutter/engine#46140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/a4b1ef79596a...584861202198

2023-09-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from c20aeee90da9 to 322abacca561 (1 revision) (flutter/engine#46137)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/3e66ffa6aae6...a4b1ef79596a

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description

This PR fixes form fields in order to call the `onChange` callback when the form is reset.

This change is based on the work done in https://github.com/flutter/flutter/pull/123108.

I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`. 

## Related Issue

Fixes https://github.com/flutter/flutter/issues/123009.

## Tests

Adds 3 tests.

https://github.com/flutter/engine/compare/88aad1056781...3e66ffa6aae6

2023-09-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (flutter/engine#46133)
2023-09-21 jonahwilliams@google.com [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from zuOP7YCHHocX to 3DKf4d8UFviY

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/76e5e35ab395...88aad1056781

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (flutter/engine#46129)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/89d864552acd...76e5e35ab395

2023-09-21 matanlurey@users.noreply.github.com Tidy up `DlPaint` and friends. (flutter/engine#46120)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (flutter/engine#46128)
2023-09-21 30870216+gaaclarke@users.noreply.github.com [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127)
2023-09-20 jonahwilliams@google.com [Impeller] Remove removal of save layer from clip. (flutter/engine#46113)
2023-09-20 jason-simmons@users.noreply.github.com [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106)
2023-09-20 matanlurey@users.noreply.github.com Clang tidy-ify `DlColor` and friends. (flutter/engine#46122)
2023-09-20 godofredoc@google.com Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (flutter/engine#46121)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_color_(filter|source)` tidy. (flutter/engine#46111)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_(image|mask|path)_(filter|effect).h` tidy! (flutter/engine#46110)
2023-09-20 matanlurey@users.noreply.github.com Migrate from `LOG_X` to `kLogX`. (flutter/engine#46107)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116)
2023-09-20 ychris@google.com [ios] fix asset url not found when loading app extension (flutter/engine#46073)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (flutter/engine#46112)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108)
2023-09-20 mdebbar@google.com [web] Move context menu handling to its own class (flutter/engine#46042)
2023-09-20 matanlurey@users.noreply.github.com Delete `ci/lint.sh`, which is no longer used. (flutter/engine#46049)
2023-09-20 mdebbar@google.com [web] Make `PlatformViewManager` a clear singleton (flutter/engine#46044)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

When it comes to startup profiling, it is very helpful to look at platform channels. `debugProfilePlatformChannels` today only works in debug and profile mode. Unfortunately, using profile mode is less accurate for startup profiling, because of the service isolate introducing additional overhead.

This PR allows this toggle to work in release mode. Note that there are two parts to `debugProfilePlatformChannels`:

- Adding timeline events
- Logging statistics about platform channels

I also considered adding a separate toggle to limit the scope of this change to the former, but that seems like complexity that we might not need at this time.

Towards #102189

https://github.com/flutter/engine/compare/39c0f2ea1f53...89d864552acd

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 565d95f72f2e to f4238844089f (3 revisions) (flutter/engine#46105)
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (flutter/engine#46104)
2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (flutter/engine#46102)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 9bc5eeb93a1e to 565d95f72f2e (1 revision) (flutter/engine#46100)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from aHtib4LBcLwx to QcxgV9KlY7j3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR is the result of running:

```console
$ flutter upgrade-packages --force-upgrade
```

### Issues

* Fixes https://github.com/flutter/flutter/issues/135075
* Supersedes #135081

Log the details of how Chromium is about to be launched prior to running
the Chromium command, as well as the path to the Chromium executable.

This should improve our understanding of what's happening here:
https://github.com/flutter/flutter/issues/132654#issuecomment-1726630123

Related to https://github.com/flutter/flutter/issues/134419

Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks

Update the conductor to code sign extension safe iOS frameworks
The new frameworks are added in
https://github.com/flutter/engine/pull/45781/files

part of https://github.com/flutter/flutter/issues/124291

Also includes an Engine roll includes:

https://github.com/flutter/engine/commit/9232e76c30455ee1c0c1584001bdbb01000f8212

https://github.com/flutter/engine/commit/39c0f2ea1f536eb7dc057d9147f23e3fec4a56c9

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

https://github.com/flutter/engine/compare/6f256257b79f...55314d08d792

2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kGkqpvcPI1TGmR4Sc... to zuOP7YCHHocXuZJcD... (flutter/engine#46097)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (flutter/engine#46098)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kGkqpvcPI1TG to zuOP7YCHHocX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description

This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.

This PR removes them from the widgets library.

This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.

In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.

This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).

## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994

## Tests
 - Documentation only change.