1. 10 Aug, 2023 2 commits
    • pdblasi-google's avatar
      Adds SemanticsNode Finders for searching the semantics tree (#127137) · 5df1c996
      pdblasi-google authored
      * Pulled `FinderBase` out of `Finder`
        * `FinderBase` can be used for any object, not just elements
        * Terminology was updated to be more "find" related
      * Re-implemented `Finder` using `FinderBase<Element>`
        * Backwards compatibility maintained with `_LegacyFinderMixin`
      * Introduced base classes for SemanticsNode finders
      * Introduced basic SemanticsNode finders through `find.semantics`
      * Updated some relevant matchers to make use of the more generic `FinderBase`
      
      Closes #123634
      Closes #115874
      5df1c996
    • LongCatIsLooong's avatar
      Making TextPainter rounding hack disabled by default (#132094) · 3f831b69
      LongCatIsLooong authored
      Migrate tests in flutter/flutter. Once the tests here and in `*_customer_testing` are migrated, the default value of the migration flag will be changed from false to true, making the rounding hack disabled by default.
      3f831b69
  2. 17 Jul, 2023 1 commit
    • Michael Goderbauer's avatar
      Stand-alone widget tree with multiple render trees to enable multi-view rendering (#125003) · 6f09064e
      Michael Goderbauer authored
      This change enables Flutter to generate multiple Scenes to be rendered into separate FlutterViews from a single widget tree. Each Scene is described by a separate render tree, which are all associated with the single widget tree.
      
      This PR implements the framework-side mechanisms to describe the content to be rendered into multiple views. Separate engine-side changes are necessary to provide these views to the framework and to draw the framework-generated Scene into them.
      
      ## Summary of changes
      
      The details of this change are described in [flutter.dev/go/multiple-views](https://flutter.dev/go/multiple-views). Below is a high-level summary organized by layers.
      
      ### Rendering layer changes
      
      * The `RendererBinding` no longer owns a single `renderView`. In fact, it doesn't OWN any `RenderView`s at all anymore. Instead, it offers an API (`addRenderView`/`removeRenderView`) to add and remove `RenderView`s that then will be MANAGED by the binding. The `RenderView` itself is now owned by a higher-level abstraction (e.g. the `RawView` Element of the widgets layer, see below), who is also in charge of adding it to the binding. When added, the binding will interact with the `RenderView` to produce a frame (e.g. by calling `compositeFrame` on it) and to perform hit tests for incoming pointer events. Multiple `RenderView`s can be added to the binding (typically one per `FlutterView`) to produce multiple Scenes.
      * Instead of owning a single `pipelineOwner`, the `RendererBinding` now owns the root of the `PipelineOwner` tree (exposed as `rootPipelineOwner` on the binding). Each `PipelineOwner` in that tree (except for the root) typically manages its own render tree typically rooted in one of the `RenderView`s mentioned in the previous bullet. During frame production, the binding will instruct each `PipelineOwner` of that tree to flush layout, paint, semantics etc. A higher-level abstraction (e.g. the widgets layer, see below) is in charge of adding `PipelineOwner`s to this tree.
      * Backwards compatibility: The old `renderView` and `pipelineOwner` properties of the `RendererBinding` are retained, but marked as deprecated. Care has been taken to keep their original behavior for the deprecation period, i.e. if you just call `runApp`, the render tree bootstrapped by this call is rooted in the deprecated `RendererBinding.renderView` and managed by the deprecated `RendererBinding.pipelineOwner`.
      
      ### Widgets layer changes
      
      * The `WidgetsBinding` no longer attaches the widget tree to an existing render tree. Instead, it bootstraps a stand-alone widget tree that is not backed by a render tree. For this, `RenderObjectToWidgetAdapter` has been replaced by `RootWidget`.
      * Multiple render trees can be bootstrapped and attached to the widget tree with the help of the `View` widget, which internally is backed by a `RawView` widget. Configured with a `FlutterView` to render into, the `RawView` creates a new `PipelineOwner` and a new `RenderView` for the new render tree. It adds the new `RenderView` to the `RendererBinding` and its `PipelineOwner` to the pipeline owner tree.
      * The `View` widget can only appear in certain well-defined locations in the widget tree since it bootstraps a new render tree and does not insert a `RenderObject` into an ancestor. However, almost all Elements expect that their children insert `RenderObject`s, otherwise they will not function properly. To produce a good error message when the `View` widget is used in an illegal location, the `debugMustInsertRenderObjectIntoSlot` method has been added to Element, where a child can ask whether a given slot must insert a RenderObject into its ancestor or not. In practice, the `View` widget can be used as a child of the `RootWidget`, inside the `view` slot of the `ViewAnchor` (see below) and inside a `ViewCollection` (see below). In those locations, the `View` widget may be wrapped in other non-RenderObjectWidgets (e.g. InheritedWidgets).
      * The new `ViewAnchor` can be used to create a side-view inside a parent `View`. The `child` of the `ViewAnchor` widget renders into the parent `View` as usual, but the `view` slot can take on another `View` widget, which has access to all inherited widgets above the `ViewAnchor`. Metaphorically speaking, the view is anchored to the location of the `ViewAnchor` in the widget tree.
      * The new `ViewCollection` widget allows for multiple sibling views as it takes a list of `View`s as children. It can be used in all the places that accept a `View` widget.
      
      ## Google3
      
      As of July 5, 2023 this change passed a TAP global presubmit (TGP) in google3: tap/OCL:544707016:BASE:545809771:1688597935864:e43dd651
      
      ## Note to reviewers
      
      This change is big (sorry). I suggest focusing the initial review on the changes inside of `packages/flutter` first. The majority of the changes describe above are implemented in (listed in suggested review order):
      
      * `rendering/binding.dart`
      * `widgets/binding.dart`
      * `widgets/view.dart`
      * `widgets/framework.dart`
      
      All other changes included in the PR are basically the fallout of what's implemented in those files. Also note that a lot of the lines added in this PR are documentation and tests.
      
      I am also very happy to walk reviewers through the code in person or via video call, if that is helpful.
      
      I appreciate any feedback.
      
      ## Feedback to address before submitting ("TODO")
      6f09064e
  3. 28 Jun, 2023 1 commit
  4. 20 Apr, 2023 1 commit
    • Nate Bosch's avatar
      Remove uses of deprecated test_api imports (#124732) · dcfd35f8
      Nate Bosch authored
      Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files.
      Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.
      
      Leave uses of `test_api` from `flutter_test` library code.
      dcfd35f8
  5. 30 Mar, 2023 1 commit
  6. 28 Mar, 2023 1 commit
  7. 27 Mar, 2023 1 commit
  8. 24 Feb, 2023 1 commit
  9. 07 Dec, 2022 1 commit
  10. 05 Dec, 2022 1 commit
  11. 28 Jul, 2022 1 commit
  12. 28 Jun, 2022 1 commit
  13. 28 Mar, 2022 1 commit
  14. 03 Feb, 2022 1 commit
  15. 10 Dec, 2021 1 commit
  16. 08 Oct, 2021 3 commits
  17. 18 Sep, 2021 1 commit
  18. 15 Sep, 2021 1 commit
  19. 03 Aug, 2021 1 commit
  20. 15 Jul, 2021 1 commit
  21. 14 Jul, 2021 3 commits
  22. 13 Jul, 2021 2 commits
  23. 28 Jun, 2021 1 commit
  24. 21 Jun, 2021 1 commit
  25. 21 Apr, 2021 1 commit
  26. 25 Mar, 2021 1 commit
  27. 04 Mar, 2021 1 commit
  28. 02 Mar, 2021 1 commit
  29. 04 Feb, 2021 1 commit
  30. 27 Jan, 2021 1 commit
  31. 26 Jan, 2021 1 commit
  32. 05 Jan, 2021 1 commit
  33. 16 Dec, 2020 2 commits