1. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  2. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  3. 15 Jan, 2019 1 commit
    • Danny Tuppeny's avatar
      Fix+unskip `flutter test` expression eval tests (#26579) · fda193aa
      Danny Tuppeny authored
      * Fix `flutter test`e xpression eval tests
      
      We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.
      
      * Ensure we wait for breakpoints before trying to evaluate
      fda193aa
  4. 10 Jan, 2019 1 commit
  5. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  6. 12 Dec, 2018 1 commit
  7. 19 Nov, 2018 1 commit
  8. 30 Oct, 2018 1 commit
  9. 24 Oct, 2018 1 commit
  10. 19 Oct, 2018 1 commit
    • Danny Tuppeny's avatar
      Switch to URIs for breakpoints and unskip tests on Windows (#22510) · f87a2a32
      Danny Tuppeny authored
      * Switch to URIs for breakpoints and unskip tests on Windows
      
      addBreakpointWithScriptUri expects Uris. By coincidence, FS paths work on Mac/Linux but they fail on Windows. One of the issues in the skip comment is fixed, the other one seems not relevant here.
      
      * Apply symlink resolution to all integration tests
      
      The default temp folders we get include symlinks which breaks breakpoints.
      
      * Save :rolling_eyes:
      
      * Fix typo
      f87a2a32
  11. 13 Sep, 2018 1 commit
  12. 12 Sep, 2018 1 commit
  13. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  14. 15 Aug, 2018 3 commits
    • Martin Kustermann's avatar
      Reland "Roll engine to version e3687f70c7ece72000b32ee1b3c02755ba5361ac (#20427)" (#20633) · 9299c02c
      Martin Kustermann authored
      * Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)"
      
      This is a re-land with downgraded `package:flutter_gallery_assets`
      version.
      
      * Downgrade package:flutter_gallery_assets to 0.1.4
      
      * Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix)
      
      * Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
      9299c02c
    • Martin Kustermann's avatar
      Revert "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)" (#20631) · 515909ec
      Martin Kustermann authored
      Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
      515909ec
    • Martin Kustermann's avatar
      Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427) · c7c493ea
      Martin Kustermann authored
      This CL
      
        * rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev)
        * rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine)
        * changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b
        * adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted) 
        * upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
      c7c493ea
  15. 25 Jul, 2018 1 commit
  16. 20 Jul, 2018 1 commit
  17. 10 Jul, 2018 1 commit
    • Danny Tuppeny's avatar
      Improve flutter tools integration tests (#18865) · b931640c
      Danny Tuppeny authored
      * Rename util -> test_utils
      
      * Rename flutter_test_driver -> test_driver
      
      * Switch testWithContext -> test
      
      * Remove unused import
      
      * Move test project into a class to make it easier to have multiple of these
      
      Each "TestProject" class can contain its files and things like named breakpoint locations.
      
      * Split expression evaluation tests into own file
      
      * Include last response in error messages
      
      * Update expectations based on current bugs
      
      * Fix async-ness in tests
      
      * Fix incorrect expectation in test
      
      * Fix incorrect evaluations
      
      * Remove skips for tests that are now passing on master
      
      * Expect pass on Linux
      
      :shrug:‍♂️
      
      * Call the code
      
      * Skip expression evaluation tests on Windows
      
      * Skip whole group, not just one test
      
      * Remove duplicated method from merge
      
      * Fix misplaced close of group
      
      * Remove code that was duplicated from test we copied
      
      Not sure how this ended up in here?
      
      * Re-fix typo
      b931640c