1. 23 Jan, 2024 14 commits
  2. 22 Jan, 2024 23 commits
  3. 21 Jan, 2024 3 commits
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (#141945) · 5dea6b99
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/2b31ad2fb819...a7b207d5a1fe
      
      2024-01-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kOnlSGX_aTAK7vvLc... to p0njgljtokVLYfzqK... (flutter/engine#49924)
      
      Also rolling transitive DEPS:
        fuchsia/sdk/core/linux-amd64 from kOnlSGX_aTAK to p0njgljtokVL
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      5dea6b99
    • Christopher Fujino's avatar
    • 林洵锋's avatar
      Adjust the position of require File.expand_path (#141521) · f340d207
      林洵锋 authored
      On `Podfile`:
      
      ```ruby
      flutter_application_path = '../flutter_module'
      load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')
      
      target 'OCProject' do
        # Comment the next line if you don't want to use dynamic frameworks
        use_frameworks!
      
        # Pods for OCProject
        # install_all_flutter_pods(flutter_application_path)
        # install_flutter_engine_pod(flutter_application_path)
        # install_flutter_application_pod(flutter_application_path)
        install_flutter_plugin_pods(flutter_application_path)
      
      end
      
      post_install do |installer|
        flutter_post_install(installer)
      end
      ```
      Encountering the following error after executing `pod install`:
      
      ```shell
      pod install
      
      [!] Invalid `Podfile` file: undefined method `flutter_relative_path_from_podfile' for #<Pod::Podfile:0x000000010e74c520 @defined_in_file=#<Pathname:/Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile>, @internal_hash={}, @root_target_definitions=[#<Pod::Podfile::TargetDefinition label=Pods>], @current_target_definition=#<Pod::Podfile::TargetDefinition label=Pods>>
      
        relative = flutter_relative_path_from_podfile(export_script_directory)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^.
      
       #  from /Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile:17
       #  -------------------------------------------
       #    # install_flutter_plugin_pods(flutter_application_path)
       >    install_flutter_application_pod(flutter_application_path)
       #
       #  -------------------------------------------
      ```
      
      The `flutter_relative_path_from_podfile` method is in `flutter_tools/bin/podhelper.rb`, but now `flutter_tools/bin/podhelper.rb` is only required in `install_all_flutter_pods` in `podhelper.rb.tmpl`.
      
      Sometimes we only need to use the `install_flutter_plugin_pods` method in podhelper.rb. For example, using `Shorebird` in an iOS hybird app scenario, we need to build `Flutter.xcframework` and `App.xcframework` and embed them into the iOS native project. In order to avoid unnecessary conflicts, use `install_flutter_plugin_pods` method to install Flutter plugin pods.
      
      [Shorebird - Code Push In Hybrid Apps](https://docs.shorebird.dev/guides/hybrid-app/ios)
      
      So I adjust the position of `require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)`.
      f340d207