- 19 Jan, 2024 1 commit
-
-
Michael Goderbauer authored
Much nicer calling API and simplifies evolving this API in the future. I wish we could write a dart fix for this, but that's blocked on https://github.com/dart-lang/sdk/issues/54668.
-
- 10 Jan, 2024 1 commit
-
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/devtools/issues/6909.
-
- 15 Dec, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 13 Dec, 2023 1 commit
-
-
Mitchell Goodwin authored
Fixes #128555. Changes the back icon for the Material app bar when running on Apple devices from `arrow_back_ios` to `arrow_back_ios_new_rounded`, as the old version of the icon wasn't centered (https://github.com/google/material-design-icons/issues/824) and the native back icon, as well as the one in Cupertino, are rounded. | Before | After | | ------------- | ------------- | | <img width="295" alt="Screenshot 2023-09-14 at 11 24 10 AM" src="https://github.com/flutter/flutter/assets/58190796/242e5fae-1107-4e1d-9749-a988462e7767"> | <img width="285" alt="Screenshot 2023-09-14 at 11 23 50 AM" src="https://github.com/flutter/flutter/assets/58190796/4df1ecaa-4313-4eb3-9cf3-335a777e133f"> | New icon works as expected with RTL: <img width="283" alt="Screenshot 2023-09-14 at 10 57 34 AM" src="https://github.com/flutter/flutter/assets/58190796/ae92fb35-40fd-4ee0-be60-cd452f16b2e3">
-
- 03 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/137424. The generic type argument was unused.
-
- 30 Sep, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 11 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 05 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 22 Jun, 2023 1 commit
-
-
Masatoshi Tsushima authored
Fixes #128562
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 09 Jun, 2023 1 commit
-
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/128367 <details> <summary>code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: Scaffold( floatingActionButton: Builder( builder: (BuildContext context) => FloatingActionButton( child: const Icon(Icons.add), onPressed: () { Scaffold.of(context).showBottomSheet<void>( (_) { return DraggableScrollableSheet( expand: false, builder: (_, ScrollController scrollController) => ListView.builder( controller: scrollController, itemCount: 25, itemBuilder: (BuildContext context, int index) { return ListTile( title: Text('Item $index - tap to close'), onTap: () { Navigator.of(context).pop(); }, ); }, ), ); }, ); }, ), ), ), ); } } ``` </details> ### Before https://github.com/flutter/flutter/assets/48603081/fa87feb9-54f2-4e50-bf71-c81d9e54ff61 ### After https://github.com/flutter/flutter/assets/48603081/7d192059-7600-4d65-ae84-6321f3598133
-
- 07 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
To make them a little more resilient to changes in the tree shape as the tree will be changing a little bit for multi view.
-
- 19 May, 2023 1 commit
-
-
Phil Quitslund authored
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases. See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
-
- 05 May, 2023 1 commit
-
-
Viren Khatri authored
while debugging https://github.com/flutter/flutter/issues/123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain. https://github.com/flutter/flutter/blob/e0045d04f7057d91b1701a444f75f2f0458c1d1a/packages/flutter/lib/src/material/scaffold.dart#L3169-L3180
-
- 05 Apr, 2023 1 commit
-
-
Kate Lovett authored
Revert "Fix scrolling in the `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation" (#124226) Revert "Fix scrolling in the `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation"
-
- 29 Mar, 2023 1 commit
-
-
Taha Tesser authored
Fix scrolling in the `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation (#122600) Fix scrolling in the `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation
-
- 13 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland (3): Removes single window assumptions from `flutter_test`
-
- 10 Mar, 2023 1 commit
-
-
Casey Hillers authored
* Revert "Remove references to BindingBase.window (#122119)" This reverts commit c7681f00. * Revert "Remove another reference to BindingBase.window (#122341)" This reverts commit 6ec44450. * Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)" This reverts commit eb3d317e. * Revert "Remove single view assumption from TestViewConfiguration (#122352)" This reverts commit 927289fb. * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)" This reverts commit 67e17e45. * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)" This reverts commit c2a5111c. * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)" This reverts commit 28b65e08. * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)" This reverts commit 01367d52.
-
- 09 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland (2): Removes single window assumptions from `flutter_test`
-
- 08 Mar, 2023 1 commit
-
-
Casey Hillers authored
Revert "Reland: Removes single window assumptions from `flutter_test`"
-
- 07 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland: Removes single window assumptions from `flutter_test`
-
- 06 Mar, 2023 2 commits
-
-
pdblasi-google authored
This reverts commit f2dd19d5.
-
pdblasi-google authored
Removes single window assumptions from `flutter_test`
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 22 Feb, 2023 1 commit
-
-
Mushaheed Syed authored
* Add ActionButtonIconsData for overriding action icons * Fix formatting issues * Add missing exports in material library and add copyWith method in ActionButtonIconsData * Move all action buttons, and icons to action_buttons.dart * Rename actionButtonIcons to actionIconTheme * Refactor buttons in action_buttons.dart to extend a private class for common implementation * Refactor icons in action_buttons * Fix docs in action_buttons_theme * Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web * Update documentation for action buttons and add style parameter to every action button * Fix analyzer warnings * Add missing style argument in IconButton of _ActionButton * Add tests for action buttons, action icon theme, drawer buttons, and back buttons * Add example (+test) for action icon button's action icon theme in examples/api * Fix analysis errors * Add missing license header in action_icon_theme.0.dart * Fix deprecation notice in theme_data.dart * Update theme data tests for actionIconTheme * Remove iconSize parameter from ActionButtons and update docs * Fix failing tests * Update button color during backbutton tests to red * Fix analytics issues * Fix format
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 25 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* Add MediaQuery to View * unify API * fix test * add test * comment * better doc * Apply suggestions from code review Co-authored-by:
Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by:
Greg Spencer <gspencergoog@users.noreply.github.com>
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 17 Jan, 2023 1 commit
-
-
Greg Spencer authored
* Rename _*Marker classes to be _*Scope, for consistency * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Fix remaining tests Co-authored-by:
Drew Roen <102626803+drewroengoogle@users.noreply.github.com>
-
- 21 Dec, 2022 1 commit
-
-
Justin McCandless authored
* Prevent possibility of null exceptions on widget.bottomSheet * New approach that fixes bug in updating the bottomSheet * Real-world test for bottomSheet error * Allow bottomSheet to animate out after being killed, even if it was rebuilt * Go back to the simple solution of SizedBox.shrink
-
- 17 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
Reland "Inject current FlutterView into tree and make available via `View.of(context)` (#116924)" (#117244) * Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" This reverts commit 9102f2fe. * remove window placeholder
-
- 16 Dec, 2022 2 commits
-
-
Casey Hillers authored
Revert "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" (#117214) This reverts commit a34e4194.
-
Michael Goderbauer authored
* enable View.of * tests * ++ * greg review * rewording * hide view from public
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 17 Oct, 2022 1 commit
-
-
luckysmg authored
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 12 Jul, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 30 Jun, 2022 2 commits
-
-
Bruno Leroux authored
-
xubaolin authored
-
- 29 Jun, 2022 1 commit
-
-
Taha Tesser authored
-