Commits · 5a5b58a99326e2ba4c4e754430dd4e47f638221a · abdullh.alsoleman / Front-End

27 Jun, 2023 11 commits

Automatically migrate ClipboardData.text to non-null (#129567) · 5a5b58a9

Loïc Sharma authored Jun 27, 2023

https://github.com/flutter/flutter/pull/122446 was a breaking change in Flutter 3.10 that made the `ClipboardData` constructor's `text` argument a required non-nullable argument. This leverages `dart fix`'s new automatic migration to, well, automatically migrate affected users.

Manual migration docs: https://docs.flutter.dev/release/breaking-changes/clipboard-data-required

Follow-up to https://github.com/flutter/flutter/pull/122446
Part of https://github.com/flutter/flutter/issues/121976

5a5b58a9

Remove Editable.onCaretChanged callback (#109114) · ca6f23e8
Tomasz Gucio authored Jun 27, 2023

ca6f23e8

Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69

Ben Konyi authored Jun 27, 2023

Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)

**Original Description:**

> Service extensions are unable to handle requests when the isolate they
were registered on is paused. The DevTools launcher logic was waiting
for some service extension invocations to complete before advertising
the already active DevTools instance, but when --start-paused was
provided these requests would never complete, preventing users from
using DevTools to resume the paused isolate.
> 
> Fixes https://github.com/flutter/flutter/issues/126691

**Additional changes in this PR:**

The failures listed in https://github.com/flutter/flutter/pull/128117
appear to be related to a shutdown race. It's possible for the test to
complete while the tool is in the process of starting and advertising
DevTools, so we need to perform a check of `_shutdown` in
`FlutterResidentDevtoolsHandler` before advertising DevTools.

Before the original fix, this check was being performed immediately
after invoking the service extensions, which creates an asynchronous gap
in execution. With #126698, the callsite of the service extensions was
moved and the `_shutdown` check wasn't, allowing for the tool to attempt
to advertise DevTools after the DevTools server had been cleaned up.

---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

5ea2be69

Update Xcode to 14.3.1 (#129024) · 9531cd40
Victoria Ashworth authored Jun 27, 2023
```
Framework part of https://github.com/flutter/flutter/issues/129019
```
9531cd40

Adds `dart_fix` support to `integration_test` (#129579) · 321abcbe

pdblasi-google authored Jun 27, 2023

* Adds fix for `IntegrationTestWidgetsFlutterBinding.runTest(timeout)` to support first round of deprecations for `flutter_test`

Resolves #124346

321abcbe

Update labeler.yml to v5.0.0-beta.1 (#129617) · b359e907
Casey Hillers authored Jun 27, 2023
```
https://github.com/flutter/flutter/issues/128440
```
b359e907

iOS TextSelectionToolbar fidelity (#127757) · a90c33fd

Luccas Clezar authored Jun 27, 2023

CupertinoTextSelectionToolbar is different from the native one, with some UI and UX issues. More details on the linked issue.

https://github.com/flutter/flutter/issues/127756

Currently the only problem that I listed on the linked issue that I couldn't fix was the horizontal scrolling, but to workaround this I added a GestureDetector to change pages when swiping the toolbar. It's not exactly the same as native as there is no scroll animation, but it works.

I'm creating this PR a little early to have some feedback as these changes were more complex than the ones in my last PR. Probably best if @justinmc is involved ð

|Version|Video|
|-|-|
|Flutter Old|<video src="https://github.com/flutter/flutter/assets/12024080/7cf81075-46ec-4970-b118-cc27b60ddac0"></video>|
|Flutter New|<video src="https://github.com/flutter/flutter/assets/12024080/c9e27a53-f94c-4cb0-9b76-e47b73841dcb"></video>|
|Native|<video src="https://github.com/flutter/flutter/assets/12024080/468c7d5b-ba93-4bd4-8f6e-8ec2644b9866"></video>|

a90c33fd

Make a paragraph test involving Chinese characters work with inconsistent host... · 3e66c86a

Jason Simmons authored Jun 27, 2023

Make a paragraph test involving Chinese characters work with inconsistent host system fonts (#129628)

Text tests are run using the Ahem font, and test host environments such
as LUCI may not provide a fallback font for Chinese glyphs.

3e66c86a

Roll Packages from 6b70804799a9 to f89ce028d764 (7 revisions) (#129630) · 4b238d54

engine-flutter-autoroll authored Jun 27, 2023

https://github.com/flutter/packages/compare/6b70804799a9...f89ce028d764

2023-06-27 hansmuller@google.com Updated
rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316)
2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new
`clearWithParameters` and `getAllWithParameters` methods to platform
interface. (flutter/packages#4261)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from
042c0366 to 96a2c053 (60 revisions) (flutter/packages#4313)
2023-06-26 10687576+bparrishMines@users.noreply.github.com
[file_selector_android] Create initial Android implementation of the
file_selector package (flutter/packages#3814)
2023-06-26 49699333+dependabot[bot]@users.noreply.github.com
[in_app_pur]: Bump org.json:json from 20230227 to 20230618 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#4244)
2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the
`isInspectable` to `WebKitWebViewController`. (flutter/packages#3984)
2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy
project (flutter/packages#4306)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b238d54

Roll Flutter Engine from 715eff211a42 to f320b8c36fee (6 revisions) (#129599) · 7dbdacff

engine-flutter-autoroll authored Jun 27, 2023

https://github.com/flutter/engine/compare/715eff211a42...f320b8c36fee

2023-06-27 ditman@gmail.com [web] Removes patchCanvasKitModule. (flutter/engine#42941)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from cafbf6e2660f to cba77bceb26c (1 revision) (flutter/engine#43222)
2023-06-26 bdero@google.com [Impeller] Fix CPU Porter-Duff blends (flutter/engine#43217)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from c1effc01211e to 370132bcadb1 (2 revisions) (flutter/engine#43221)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 4a4b13cc6931 to cafbf6e2660f (2 revisions) (flutter/engine#43219)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 4ae209493390 to c1effc01211e (4 revisions) (flutter/engine#43218)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7dbdacff

Fix chinese text is not selected by long press (#129320) · 9459f1c5

hangyu authored Jun 27, 2023

issue:#126652

in Chinese text, word length is 1 and (position.offset == word.end) happens a lot.

Update if (position.offset >= word.end) to if (position.offset > word.end) to resolve the issue that Chinese characters are not selected.

9459f1c5

26 Jun, 2023 17 commits

Roll Flutter Engine from 0da06de991a9 to 715eff211a42 (4 revisions) (#129593) · 2e5a255b

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/0da06de991a9...715eff211a42

2023-06-26 58529443+srujzs@users.noreply.github.com Refactor JSNumber.toDart and Object.toJS (flutter/engine#43149)
2023-06-26 jonahwilliams@google.com [Impeller] Treat SubOptimalKHR as rotated. (flutter/engine#43214)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from f6c7dc891859 to 4a4b13cc6931 (12 revisions) (flutter/engine#43213)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 632fa401098d to 4ae209493390 (3 revisions) (flutter/engine#43212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e5a255b

Fix syntax error in no-response (#129588) · 9f1809b5

godofredoc authored Jun 26, 2023

The comma needs to be enclosed in the quotes.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

9f1809b5

Roll Flutter Engine from f2d70cc809cd to 0da06de991a9 (3 revisions) (#129582) · c56362c6

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/f2d70cc809cd...0da06de991a9

2023-06-26 tamird@google.com Avoid channel clone (flutter/engine#43181)
2023-06-26 5236035+fzyzcjy@users.noreply.github.com ParagraphStyle uses the wrong bit mask (flutter/engine#43070)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3Y8TbEFhQUKOJBLQ4... to bj_X2Se1zObk_l_CC... (flutter/engine#43205)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3Y8TbEFhQUKO to bj_X2Se1zObk

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c56362c6

Updated chip_test.dart tests for M3 (#129570) · b703f75f

Hans Muller authored Jun 26, 2023

Updated the chip tests per the changes from https://github.com/flutter/flutter/pull/128584 so that Chip tests that depend on Material2 will continue to pass when Material3 becomes the default. 

Part of: https://github.com/flutter/flutter/issues/127064

b703f75f

Roll Flutter Engine from 4032a9bc964e to f2d70cc809cd (4 revisions) (#129574) · 02c0abbb

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/4032a9bc964e...f2d70cc809cd

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 46dcf29e5dfe to 632fa401098d (5 revisions) (flutter/engine#43204)
2023-06-26 godofredoc@google.com Revert "Remove master mirroring workflow." (flutter/engine#43206)
2023-06-26 jonahwilliams@google.com [Impeller] opt srgb to linear into f16 (flutter/engine#43182)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 764f31be3228 to f6c7dc891859 (1 revision) (flutter/engine#43203)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02c0abbb

Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#129453) · 96a2c053

dependabot[bot] authored Jun 26, 2023

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192">ossf/scorecard-action#1192</a></li>
</ul>
<h2>Scorecard Result Viewer</h2>
<p>Thanks to contributions from <a href="https://github.com/cynthia-sg"><code>@âcynthia-sg</code></a> and <a href="https://github.com/tegioz"><code>@âtegioz</code></a> at <a href="https://github.com/cncf/clomonitor">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=&lt;project-url&gt;</code>.</p>
<ul>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406">ossf/scorecard-webapp#406</a></li>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422">ossf/scorecard-webapp#422</a></li>
</ul>
<p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard">here</a>
Checkout our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#scorecard-badge">README</a> to learn how to link your README badge to the new visualization page.</p>
<h2>Publishing Results</h2>
<p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p>
<ul>
<li>Runs that fail our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#workflow-restrictions">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150">ossf/scorecard-action#1150</a>)</li>
<li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191">ossf/scorecard-action#1191</a>)</li>
</ul>
<h2>Docs</h2>
<ul>
<li>ð Update README to accept fine-grained tokens by <a href="https://github.com/pnacht"><code>@âpnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
<li>ð Update installation instructions to match current GitHub UI  by <a href="https://github.com/joycebrum"><code>@âjoycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153">ossf/scorecard-action#1153</a></li>
<li>ð Document the GitHub action workflow restrictions when publishing results. by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bobcallaway"><code>@âbobcallaway</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1140">ossf/scorecard-action#1140</a></li>
<li><a href="https://github.com/pnacht"><code>@âpnacht</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0">https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/ossf/scorecard-action/commit/08b4669551908b1024bb425080c797723083c031"><code>08b4669</code></a> 🌱 Bump docker tag to for v2.2.0 release. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1194">#1194</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/3c7470f58c4371d8ac58beaeeacf771227d63ce8"><code>3c7470f</code></a> 📖 Update README badge link to use new uri param. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1185">#1185</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/a164dbc12a66d9fae8ec379fff6ba200da366366"><code>a164dbc</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1192">#1192</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/597960e1d95e5c741af238a819f03655e2fa43b8"><code>597960e</code></a> 📖 Update README to accept fine-grained tokens (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1175">#1175</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/8808ed28c3b8ba5a7d8059bd0360d8374ff6adb3"><code>8808ed2</code></a> 🌱 Retry external network calls when publishing results (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1191">#1191</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/0eed6cb5da014387b234df059cd4a2db5dbe9e1f"><code>0eed6cb</code></a> 🌱 Bump golang.org/x/net from 0.10.0 to 0.11.0</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/6c6335c126308fd03da1c3bb267c1ebc3a34db0c"><code>6c6335c</code></a> 🌱 Bump github/codeql-action from 2.3.6 to 2.20.0</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/7f1baf380a4f4418b4864d5a57bee1beba03e2eb"><code>7f1baf3</code></a> 📖 Switch recommended badge link to the new viewer. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1176">#1176</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/df98bbc13d1c3001cc90b8a2791ffde7ba29f061"><code>df98bbc</code></a> 🌱 Bump actions/checkout from 3.5.2 to 3.5.3</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/75886d414a5cd048874360697f1e8edb5b1e55ca"><code>75886d4</code></a> 🌱 Bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1172">#1172</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/80e868c13c90f172d68d1f4501dee99e2479f7af...08b4669551908b1024bb425080c797723083c031">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.3&new-version=2.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

96a2c053

Roll Flutter Engine from 63582320d20e to 4032a9bc964e (2 revisions) (#129569) · 7dd5c76d

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/63582320d20e...4032a9bc964e

2023-06-26 jonahwilliams@google.com [Impeller] use default precision specifiers. (flutter/engine#43183)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GkEyRw1Q2qLZWxitD... to ytzCCSvHY1lHWEDM9... (flutter/engine#43200)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from GkEyRw1Q2qLZ to ytzCCSvHY1lH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7dd5c76d

Updated TextMagnifierExampleApp to M3 (#129381) · 548fe147
Hans Muller authored Jun 26, 2023

548fe147

Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (#129563) · cef9a8c5

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/debee7cece49...63582320d20e

2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 7169dc5fe003 to 764f31be3228 (1 revision) (flutter/engine#43199)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 6d89bc1acb7e to 46dcf29e5dfe (2 revisions) (flutter/engine#43197)
2023-06-26 matej.knopp@gmail.com Implement union and intersection for DlRegion (flutter/engine#42620)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cef9a8c5

Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding (#129556) · c8e42b47

Taha Tesser authored Jun 26, 2023

fixes [AnimatedList does not take SafeArea into account when building the list ](https://github.com/flutter/flutter/issues/129539)

### Description
This PR fixes an issue for `AnimatedList` & `AnimatedGrid` where `MediaQuery` padding isn't applied. See the [source](https://github.com/flutter/flutter/blob/a20db068dd9f72e2e4a35a3ce64f22d47b3d20f7/packages/flutter/lib/src/widgets/scroll_view.dart#L803-L833).

While the  `ListView` or `GridView` applies `MediaQuery` padding to its inner `SliverPadding`.  This is missing from `AnimatedList` & `AnimatedGrid`.

![Digram of ListView applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/01917900-cd26-4ca1-8e51-b7dcd1241471)

The fix applies  `MediaQuery` padding to the inner `SliverPadding` in `AnimatedList` & `AnimatedGrid`.

![Digram of AnimatedList & AnimatedGrid applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/75d0a0ad-539c-485e-b3c1-770ee187086b)

### Code sample
<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Row(
        children: <Widget>[
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('ListView'),
                Expanded(
                  child: ListView.builder(
                    itemCount: 50,
                    itemBuilder: (_, int index) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('AnimatedList'),
                Expanded(
                  child: AnimatedList(
                    initialItemCount: 50,
                    itemBuilder: (_, int index, __) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
              child: Column(
            children: <Widget>[
              const Text('AnimatedGrid'),
              Expanded(
                child: AnimatedGrid(
                  initialItemCount: 50,
                  gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 2,
                  ),
                  itemBuilder: (_, int index, __) {
                    return ColoredBox(
                      color: Theme.of(context).colorScheme.primaryContainer,
                      child: Center(
                        child: Text('$index', textAlign: TextAlign.center),
                      ),
                    );
                  },
                ),
              ),
            ],
          ))
        ],
      ),
    );
  }
}

``` 
	
</details>

### Before
![Before preview image](https://github.com/flutter/flutter/assets/48603081/73954a8a-9d1d-4b9e-b6a3-cae8071f3462)

### After
![After preview image](https://github.com/flutter/flutter/assets/48603081/9f1dc48a-622f-4402-8d5e-8e6e3e150165)

c8e42b47

Process only specific labels. (#129475) · bac05895
godofredoc authored Jun 26, 2023
```
To avoid trying to process all the open bugs in flutter/flutter.
```
bac05895

Roll Packages from d041934b296d to 6b70804799a9 (7 revisions) (#129559) · 4871391d

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/packages/compare/d041934b296d...6b70804799a9

2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227)
2023-06-23 stuartmorgan@google.com [image_picker] Update to 1.0 (flutter/packages#4285)
2023-06-23 stuartmorgan@google.com [tool] Consider comment-only changes to be dev-only (flutter/packages#4279)
2023-06-23 stuartmorgan@google.com [ci] Switch to LUCI for Android build-all (flutter/packages#4274)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value (flutter/packages#4222)
2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value - implementations (flutter/packages#4273)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4871391d

Make bug templates more consistent (#129460) · a20db068

Ian Hickson authored Jun 26, 2023

* remove trailing periods in template titles
* tweak the design doc template a little based on testing it out

a20db068

Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (#129544) · da2b8723

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/be46101e952d...debee7cece49

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 5ea08db08587 to 6d89bc1acb7e (2 revisions) (flutter/engine#43194)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

da2b8723

Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (#129540) · fde39063

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/88ff46e1efc1...be46101e952d

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from a20d58872fbe to 5ea08db08587 (1 revision) (flutter/engine#43193)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XnZWRj5iNXgOHlVNi... to 3Y8TbEFhQUKOJBLQ4... (flutter/engine#43192)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from XnZWRj5iNXgO to 3Y8TbEFhQUKO

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde39063

Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (#129534) · c7f82a1c

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/317673b3278a...88ff46e1efc1

2023-06-26 robert.ancell@canonical.com Allow event channels to reuse names (flutter/engine#41837)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7f82a1c

Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (#129531) · 8b6e1fde

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/593e1d9a9cf5...317673b3278a

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uh5om9qyypCToIllT... to GkEyRw1Q2qLZWxitD... (flutter/engine#43190)
2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 7866f2c6ba52 to a20d58872fbe (1 revision) (flutter/engine#43191)
2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from w-DJY4dBZWS7lxsxE... to XnZWRj5iNXgOHlVNi... (flutter/engine#43188)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from w-DJY4dBZWS7 to XnZWRj5iNXgO
fuchsia/sdk/core/mac-amd64 from uh5om9qyypCT to GkEyRw1Q2qLZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b6e1fde

25 Jun, 2023 4 commits

Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (#129514) · b2e95013

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5178e8ab7764...593e1d9a9cf5

2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 18a947ed2253 to 7866f2c6ba52 (1 revision) (flutter/engine#43187)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2e95013

Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (#129508) · 42d2c2d5

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/100f6fc854b4...5178e8ab7764

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N0MQ5J5y_hQoiOYs9... to uh5om9qyypCToIllT... (flutter/engine#43185)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N0MQ5J5y_hQo to uh5om9qyypCT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42d2c2d5

Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (#129498) · 176f7e63

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/a9f446e25f0c...100f6fc854b4

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bjQLnDu32Oj0KUbrW... to w-DJY4dBZWS7lxsxE... (flutter/engine#43184)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bjQLnDu32Oj0 to w-DJY4dBZWS7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

176f7e63

Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (#129495) · c0f76fc9

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5b1b98305768...a9f446e25f0c

2023-06-24 bdero@google.com [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0f76fc9

24 Jun, 2023 8 commits

Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (#129493) · c442c6d4

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/72c902ce3b81...5b1b98305768

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JF0sJRpJH8KiyyqrR... to N0MQ5J5y_hQoiOYs9... (flutter/engine#43180)
2023-06-24 bdero@google.com [Impeller] Disable blending for Source blend mode (flutter/engine#43162)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JF0sJRpJH8Ki to N0MQ5J5y_hQo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c442c6d4

Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (#129489) · 96a9773d

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/f2976add9414...72c902ce3b81

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96a9773d

Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (#129487) · 6855b527

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/76a5e971dc09...f2976add9414

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from b5PDBUm8Hfx- to bjQLnDu32Oj0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6855b527

Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (#129483) · fd9d13c2

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/79fd6beea087...76a5e971dc09

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd9d13c2

Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (#129479) · afa4cf7e

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/30ac9107f2f9...79fd6beea087

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from w-tUP3Ia2kfAaFNW1... to JF0sJRpJH8KiyyqrR... (flutter/engine#43174)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from w-tUP3Ia2kfA to JF0sJRpJH8Ki

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afa4cf7e

Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (#129476) · cc76ed95

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/ee65380bf3fd...30ac9107f2f9

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc76ed95

Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (#129474) · a8c68425

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/240a86f40781...ee65380bf3fd

2023-06-24 skia-flutter-autoroll@skia.org Roll ANGLE from f834ba7fdab9 to 7169dc5fe003 (1 revision) (flutter/engine#43169)
2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8c68425

Fix issues with no response bot. (#129470) · 0f006ea0
godofredoc authored Jun 24, 2023
```
This is also increasing the number of items to be evaluated on each iteration.
```
0f006ea0