1. 29 Jan, 2016 1 commit
  2. 27 Jan, 2016 2 commits
    • Hixie's avatar
      Semantics · 28a17883
      Hixie authored
      28a17883
    • Adam Barth's avatar
      updateChildren() needs to walk the list forward · 05839e51
      Adam Barth authored
      This patch changes the framework to walk the child list forwards so that build
      functions with global side effects do sensible things. Specifically, if you
      have a number of autofocusable children, the first one the list will acquire
      the focus because it gets built first now.
      
      Fixes #182
      05839e51
  3. 18 Jan, 2016 1 commit
    • Ian Hickson's avatar
      Fix some intrinsic constraints contract violations. · 60d9ab7e
      Ian Hickson authored
      RenderBlock wasn't constraining the results.
      RenderPadding wasn't constraining the results (which matters
      especially when the constraints can't fit the padding in the first
      place).
      RenderViewport wasn't constraining the results.
      
      Add a test for the block case.
      
      To catch this kind of thing in the future, add some asserts to
      debugDoesMeetConstraints() that all four intrinsic functions return
      values that are within the constraints.
      
      RenderBlockViewport doesn't support returning intrinsics, so turn off
      the "no intrinsic support" asserts (and return zero) when we're doing
      this new assert.
      
      This new assert screwed up the custom layout classes' tests, so adjust
      those tests to ignore the callbacks invoked from these asserts.
      
      Add to the _debugReportException() method a short summary of the
      descendants of this node. It's important to have this information when
      debugging errors like these intrinsic constraints contract violations
      because often nodes just pass the values through to their child so you
      have to go several steps down to find the actual problem.
      
      Fixes https://github.com/flutter/flutter/issues/1210
      60d9ab7e
  4. 12 Jan, 2016 4 commits
  5. 11 Jan, 2016 3 commits
  6. 08 Jan, 2016 2 commits
    • Ian Hickson's avatar
    • Adam Barth's avatar
      Optimize repainting in Scaffold · ee88a685
      Adam Barth authored
      Previously, we triggered a layout (and hence a repaint) when sliding the
      draw because we gave the draw loose constraints. The drawer uses an
      Align to move itself to the proper side of the screen, so it can have
      tight constraints, which makes it a layout boundary.
      
      Also, don't trigger a layout just because the Scaffold rebuilds. There
      isn't any state in the scaffold custom layout, so it doesn't need to
      repaint just because we created a new instance of the delegate.
      
      Finally, add the debugging infrastructure I used to find these issues.
      ee88a685
  7. 07 Jan, 2016 2 commits
  8. 02 Jan, 2016 1 commit
    • Adam Barth's avatar
      ScrollbarPainter exception when scrolling MaterialList · 94843700
      Adam Barth authored
      When assigning a new overlayPainter, we were detaching the old overlay
      painter even if the render object itself wasn't attached. Now we only
      twiddle the attach/detach state of the overlay painter when we're
      attached ourselves.
      
      Fixes #1047
      94843700
  9. 17 Dec, 2015 1 commit
    • Hixie's avatar
      Less tree walking for compositing bits updates. · ab01c7bf
      Hixie authored
      Use the same technique for updating compositing bits as layout and
      painting. This avoids walking the entire rendering tree when all you
      need to update is a small subtree.
      ab01c7bf
  10. 16 Dec, 2015 1 commit
  11. 14 Dec, 2015 1 commit
  12. 11 Dec, 2015 1 commit
    • Ian Hickson's avatar
      applyPaintTransform() improvements · d1364643
      Ian Hickson authored
      Previously, applyPaintTransform() had to know how it was positioned in
      its parent, even though that's really the parent's responsibility.
      
      Now, applyPaintTransform() is given a child and applies the transform
      that it would give the child during paint.
      
      This makes it possible for applyPaintTransform() to work across
      coordinate system boundaries (e.g. box to sector, or view to box --
      previously, view to box only worked because we explicitly skipped that
      step -- since view doesn't actually apply a transform, it doesn't
      really matter).
      d1364643
  13. 10 Dec, 2015 1 commit
  14. 09 Dec, 2015 1 commit
    • Ian Hickson's avatar
      Catch un-normalized BoxConstraints · 1a049c14
      Ian Hickson authored
      Add BoxConstraints.isNormalized feature.
      
      Use this feature in asserts in all the intrinsic dimension methods, in
      various relevant BoxConstraints methods, and in layout().
      
      Wrap the _DebugSize logic in BoxConstraints.constrain() in an assert
      block to avoid a branch in release mode.
      
      Remove the logic in BoxConstraints.isSatisfiedBy() that dealt with
      non-normalized values.
      
      Add BoxConstraints.normalize().
      
      Make RenderCustomOneChildLayoutBox.performLayout() only set
      parentUsesSize on the child if the constraints aren't tight.
      1a049c14
  15. 08 Dec, 2015 1 commit
  16. 05 Dec, 2015 2 commits
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556
    • Adam Barth's avatar
      Remove PaintingCanvas · abf03595
      Adam Barth authored
      We can just use Canvas now.  The two are the same thing.
      abf03595
  17. 02 Dec, 2015 1 commit
  18. 01 Dec, 2015 1 commit
    • Ian Hickson's avatar
      Remove the assert when opening popup menus. · fbd612e6
      Ian Hickson authored
      Some paint bounds are in fact empty, e.g. at the start of a growing
      animation if there's also a fade, the initial 0x0 box will also be
      opacity:0, and might get a dedicated layer and PaintingContext.
      fbd612e6
  19. 26 Nov, 2015 1 commit
  20. 25 Nov, 2015 1 commit
  21. 19 Nov, 2015 5 commits
    • Adam Barth's avatar
      Add a repaint rainbow to help debug repaint issues · 8fa223ff
      Adam Barth authored
      The repaint raindbow tints each recording with a rotating set of colors so you
      can see which pixels are repainting each frame.
      8fa223ff
    • Adam Barth's avatar
      Add debugDumpLayerTree to dump the layer tree · dfbd8c6a
      Adam Barth authored
      To help debugging issues with the layer tree.
      dfbd8c6a
    • Adam Barth's avatar
      Re-enable support for debugPaintLayerBordersEnabled · 2232ee56
      Adam Barth authored
      We lost this feature at some point. This patch brings it back.
      2232ee56
    • Adam Barth's avatar
      Some paint functions were using canvas.save/restore around children · d689362d
      Adam Barth authored
      This pattern breaks when using compositing because we need to lift those
      operations into the compositing tree. This patch removes all the ones I could
      find and adds an assert to help prevent more from getting introduced.
      
      Fixes #191
      d689362d
    • Adam Barth's avatar
      Refactor PaintingContext · fc576814
      Adam Barth authored
      This patch simplifies PaintingContext with several goals:
      
      1) We now call a callback instead of assuming the caller has a single child to
         paint. This change will let us handle render objects that wish to paint more
         than one child.
      2) We now avoid creating lots of empty picture layers because we don't eagerly
         start recording pictures. Instead, we wait for the first caller to touch the
         canvas before creating the picture recorder.
      3) We now are more consistent about which values have incorporated the painting
         offset.
      fc576814
  22. 18 Nov, 2015 1 commit
  23. 13 Nov, 2015 1 commit
  24. 10 Nov, 2015 2 commits
    • Adam Barth's avatar
      Make layout_bench.dart 19% faster · 1d7cd6b7
      Adam Barth authored
      Previously we would walk from every node in layout to the root to mark the root
      as needing paint. Now we leave dirty bits throughout the tree so that we can
      cut off the walk as soon as we find a dirty node.
      1d7cd6b7
    • Florian Loitsch's avatar
      Minor doc fixes. · c5427fb9
      Florian Loitsch authored
      c5427fb9
  25. 04 Nov, 2015 2 commits
    • Hixie's avatar
      Get more debug info into the rendering layer · 6d389722
      Hixie authored
      - change how we expose settings at the RenderObject layer so that it's
        easier to maintain.
      - expose the Widget owner chain in the RenderObject layer debug output
      - add debug info to RenderOpacity, RenderIgnorePointer, RenderListener
      - make the output for text nodes prettier
      6d389722
    • Adam Barth's avatar
      Always reset parentData when dropping children · c44dd17d
      Adam Barth authored
      Previously, we'd leave the old values in the parent data if the types matches,
      but not all render objects would reset these values during layout. For example,
      RenderProxyBox doesn't set the position field because it doesn't read the
      position field. However, leaving the old data there violates the invariants of
      the box protocol and can cause trouble (e.g., localToGlobal giving the wrong
      result).
      
      Fixes #1939
      c44dd17d